https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Blocks||30915
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Fridolin Somers changed:
What|Removed |Added
Blocks||29283
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Bug 23166 depends on bug 23084, which changed state.
Bug 23084 Summary: Replace grep {^$var$} with grep {$var eq $_}
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Blocks||26365
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_20_11_target, |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #60 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #59 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #57)
> I've decided to fix it here, it should not hurt.
Ok, I added my SO for it in case you didn't push yet.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Attachment #109058|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #57 from Jonathan Druart
---
(In reply to Joonas Kylmälä from comment #38)
> There seems to be nothing wrong with the code, it is just that the QA tool
> doesn't add the "orders" object because this is not being
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #56 from Jonathan Druart
---
Created attachment 109058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109058=edit
Bug 23166: Early return if no set
It prevents valid_template check to raise
Can't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #55 from Katrin Fischer ---
Sounds good and I can stop to stare at this because I am getting nowhere
tonight :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #54 from Joonas Kylmälä ---
(In reply to Katrin Fischer from comment #39)
> we usually don't remove the sign-off lines - that's one reason we prefer
> follow-ups - because it allows to see the changes, but also because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #52 from Joonas Kylmälä ---
Created attachment 109049
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109049=edit
Bug 23166: Call the methods from the .inc
We do not longer need the order variables to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #53 from Joonas Kylmälä ---
Created attachment 109050
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109050=edit
Bug 23166: (QA follow-up) Add POD text
Signed-off-by: Nick Clemens
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #49 from Joonas Kylmälä ---
Created attachment 109046
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109046=edit
Bug 23166: Replace the count of orders with Koha::Acq::Orders
Signed-off-by: Nick
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #50 from Joonas Kylmälä ---
Created attachment 109047
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109047=edit
Bug 23166: Remove filtering from controllers
Signed-off-by: Nick Clemens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #51 from Joonas Kylmälä ---
Created attachment 109048
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109048=edit
Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Attachment #109037|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #48 from Joonas Kylmälä ---
Created attachment 109045
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109045=edit
Bug 23166: Remove baskets_deletedorders code
This is never used.
Signed-off-by: Nick
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109025|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109023|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109026|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109024|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109022|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109020|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #109021|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #39 from Katrin Fischer ---
(In reply to Joonas Kylmälä from comment #37)
> I attached a follow-up for the POD and removed the sign-offs given the other
> issue Nick pointed out still remains:
>
> > FAIL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #38 from Joonas Kylmälä ---
There seems to be nothing wrong with the code, it is just that the QA tool
doesn't add the "orders" object because this is not being executed from the
real .pl script, so therefore the $set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #37 from Joonas Kylmälä ---
I attached a follow-up for the POD and removed the sign-offs given the other
issue Nick pointed out still remains:
> FAIL koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc
> FAIL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #36 from Joonas Kylmälä ---
Created attachment 109026
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109026=edit
Bug 23166: (QA follow-up) Add POD text
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #35 from Joonas Kylmälä ---
Created attachment 109025
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109025=edit
Bug 23166: Call the methods from the .inc
We do not longer need the order variables to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #34 from Joonas Kylmälä ---
Created attachment 109024
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109024=edit
Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #33 from Joonas Kylmälä ---
Created attachment 109023
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109023=edit
Bug 23166: Remove filtering from controllers
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #32 from Joonas Kylmälä ---
Created attachment 109022
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109022=edit
Bug 23166: Replace the count of orders with Koha::Acq::Orders
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #31 from Joonas Kylmälä ---
Created attachment 109021
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109021=edit
Bug 23166: Remove baskets_deletedorders code
This is never used.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Attachment #108997|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #29 from Joonas Kylmälä ---
Created attachment 109019
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109019=edit
Bug 23166: (QA follow-up) Add POD text
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #26 from Joonas Kylmälä ---
Created attachment 109001
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109001=edit
Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #24 from Joonas Kylmälä ---
Created attachment 108999
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108999=edit
Bug 23166: Replace the count of orders with Koha::Acq::Orders
Signed-off-by: Joonas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #27 from Joonas Kylmälä ---
Created attachment 109002
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109002=edit
Bug 23166: Call the methods from the .inc
We do not longer need the order variables to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #25 from Joonas Kylmälä ---
Created attachment 109000
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109000=edit
Bug 23166: Remove filtering from controllers
Signed-off-by: Joonas Kylmälä
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Joonas Kylmälä changed:
What|Removed |Added
Attachment #108991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #23 from Joonas Kylmälä ---
Created attachment 108998
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108998=edit
Bug 23166: Remove baskets_deletedorders code
This is never used.
Signed-off-by: Joonas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #104370|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #104369|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #104368|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #104365|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #104366|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Nick Clemens changed:
What|Removed |Added
Attachment #104367|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Blocks||26139
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Blocks|26139 |
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Blocks||26139
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #13 from Jonathan Druart
---
Test plan:
Create several orders (on at least 2 bibliographic records)
Cancel some
Try to delete the bibliographic records
=> You should the JS alert about existing orders
The delete button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #11 from Jonathan Druart
---
Created attachment 104369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104369=edit
Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #12 from Jonathan Druart
---
Created attachment 104370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104370=edit
Bug 23166: Call the methods from the .inc
We do not longer need the order variables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #10 from Jonathan Druart
---
Created attachment 104368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104368=edit
Bug 23166: Remove filtering from controllers
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #9 from Jonathan Druart
---
Created attachment 104367
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104367=edit
Bug 23166: Replace the count of orders with Koha::Acq::Orders
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Attachment #90826|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #8 from Jonathan Druart
---
Created attachment 104366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104366=edit
Bug 23166: Remove baskets_deletedorders code
This is never used.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_11_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #4 from Jonathan Druart
---
Created attachment 90827
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90827=edit
Bug 23166: Remove baskets_deletedorders code
This is never used.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #5 from Jonathan Druart
---
Created attachment 90828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90828=edit
Bug 23166: Replace the count of orders with Koha::Acq::Orders
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Attachment #90825|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Attachment #90824|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #1 from Jonathan Druart
---
Created attachment 90824
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90824=edit
Bug 23166: Replace the count of orders with Koha::Acq::Orders
--
You are receiving this
77 matches
Mail list logo