https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Rebecca Coert changed:
What|Removed |Added
CC||rco...@arlingtonva.us
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #65 from Martin Renvoize ---
Kyle.. do you think you might have a chance to get back to this.. I'm not sure
I will any time soon.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #66 from Jonathan Druart ---
Wasn't this a "have to" for 20.11.01?...
Looks like we completely forgot about it.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #67 from Kyle M Hall ---
(In reply to Martin Renvoize from comment #64)
> Work to date uploaded.. still needs more followups but I wanted to make sure
> BZ was in sync with my gitlab before stepping away again
What is st
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #68 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #67)
> (In reply to Martin Renvoize from comment #64)
> > Work to date uploaded.. still needs more followups but I wanted to make sure
> > BZ was in sync
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Kyle M Hall changed:
What|Removed |Added
Attachment #115193|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #70 from Kyle M Hall ---
Created attachment 122449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122449&action=edit
Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl
Signed-off-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #71 from Kyle M Hall ---
Created attachment 122450
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122450&action=edit
Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
Signed-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #72 from Kyle M Hall ---
Created attachment 122451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122451&action=edit
Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #73 from Kyle M Hall ---
Created attachment 122452
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122452&action=edit
Bug 26282: (QA follow-up) Update POD
Signed-off-by: Martin Renvoize
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #74 from Kyle M Hall ---
Created attachment 122453
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122453&action=edit
Bug 26282: (QA follow-up) Unit tests
This patch adds tests for the behaviour change.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #75 from Kyle M Hall ---
Created attachment 122454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122454&action=edit
Bug 26282: (QA follow-up) Update test
Signed-off-by: Josef Moravec
Signed-off-by: M
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #76 from Kyle M Hall ---
Created attachment 122455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122455&action=edit
Bug 26282: (QA follow-up) Restore default notice
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #77 from Kyle M Hall ---
Created attachment 122456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122456&action=edit
Bug 26282: Show reason only if notice exists
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Kyle M Hall changed:
What|Removed |Added
Status|ASSIGNED|Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #78 from Kyle M Hall ---
Created attachment 122550
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122550&action=edit
Bug 26282: Update Holds to pull
--
You are receiving this mail because:
You are wat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@iki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #1 from Kyle M Hall ---
Created attachment 109286
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109286&action=edit
Bug 26282: Allow staff to decide if a hold cancellation notice will be sent
when cance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Jonathan Druart changed:
What|Removed |Added
Severity|enhancement |normal
--- Comment #3 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Jonathan Druart changed:
What|Removed |Added
Severity|normal |major
--- Comment #4 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #5 from Kyle M Hall ---
Created attachment 113960
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113960&action=edit
Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #6 from Victor Grousset/tuxayo ---
Potential issue found: "No reason given" => no notification sent
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #7 from Kyle M Hall ---
Created attachment 113991
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113991&action=edit
Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #8 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #7)
> Created attachment 113991 [details] [review]
> Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
I am not sure we want t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #9 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Kyle M Hall from comment #7)
> > Created attachment 113991 [details] [review] [review]
> > Bug 26282: (QA follow-up) Always notify patro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #10 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Kyle M Hall from comment #7)
> > Created attachment 113991 [details] [review] [review]
> > Bug 26282: (QA follow-up) Always notif
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #11 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > (In reply to Kyle M Hall from comment #7)
> > > Created attachment 113991 [details] [review] [rev
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Depends on||12656
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #13 from Martin Renvoize ---
This will also need some handling added to
misc/cronjobs/holds/cancel_expired_holds.pl to re-enable the option to send
notices when holds are automatically cancelled on expiration as per bug 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #109286|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #113960|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #113991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #17 from Martin Renvoize ---
Created attachment 114010
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114010&action=edit
Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds
Signed-off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #18 from Martin Renvoize ---
As this is an entirely new notice this cycle, I'd be tempted to update the
default to check for the presence of 'reason' and give a slightly different
form if it is not present as a side n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #19 from Jonathan Druart
---
We are D-1 before the release, I'd like a patch as small as possible. And I
won't have time to test it...
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114008|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114009|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114010|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114007|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #20 from Tomás Cohen Arazi ---
Created attachment 114011
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114011&action=edit
Bug 26282: Unit tests
This patch adds tests for the behaviour change. It tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #21 from Tomás Cohen Arazi ---
Created attachment 114012
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114012&action=edit
Bug 26282: Allow staff to decide if a hold cancellation notice will be sent
whe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #22 from Tomás Cohen Arazi ---
Created attachment 114013
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114013&action=edit
Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl
Signe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #23 from Tomás Cohen Arazi ---
Created attachment 114014
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114014&action=edit
Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #24 from Tomás Cohen Arazi ---
Created attachment 114015
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114015&action=edit
Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds
Signed-o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #25 from Tomás Cohen Arazi ---
Created attachment 114016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114016&action=edit
Bug 26282: (QA follow-up) Update POD
Signed-off-by: Tomas Cohen Arazi
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #26
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #27 from Jonathan Druart
---
So, to resume a private discussion.
We are trying to modify a behaviour that is not advertise in comment 0, neither
on bug 25534 and so it's not the point of this bug report.
I still don't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Jonathan Druart changed:
What|Removed |Added
Attachment #114014|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #29 from Jonathan Druart
---
I am really happy to have to deal with a checkbox on release day!
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec changed:
What|Removed |Added
Attachment #114011|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec changed:
What|Removed |Added
Attachment #114012|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec changed:
What|Removed |Added
Attachment #114013|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec changed:
What|Removed |Added
Attachment #114028|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #34 from Josef Moravec ---
Created attachment 114034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114034&action=edit
Bug 26282: (QA follow-up) Update test
Signed-off-by: Josef Moravec
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #35 from Jonathan Druart
---
Hi Josef, I was in a chat with Martin.
We were actually thinking about removing the notice template HOLD_CANCELLATION
from the DB, for 20.11.00.
That will disable the feature and let people c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #36 from Martin Renvoize ---
Created attachment 114035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114035&action=edit
Bug 26282: (ALTERNATIVE) Remove HOLD_CANCELLATION notice
We are really close to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #37 from Martin Renvoize ---
I think this final alternative is the best approach given the release timing...
If we all agree, I will happily transplant the other patches here to a new bug
for 20.11.01 and go back and upd
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #38 from Josef Moravec ---
(In reply to Martin Renvoize from comment #37)
> I think this final alternative is the best approach given the release
> timing...
>
> If we all agree, I will happily transplant the other patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114035|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |ASSIGNED
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Assignee|k...@bywatersolutions.com |martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Depends on|12656, 25534|
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Depends on||27103
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_11_target|
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114016|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114033|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114015|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114031|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114032|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #41 from Martin Renvoize ---
Created attachment 114249
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114249&action=edit
Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
Sig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114015|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114016|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #44 from Martin Renvoize ---
Created attachment 114252
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114252&action=edit
Bug 26282: (QA follow-up) Unit tests
This patch adds tests for the behaviour cha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114034|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114030|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #46 from Martin Renvoize ---
Created attachment 114254
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114254&action=edit
Button approach
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #47 from Martin Renvoize ---
Created attachment 114255
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114255&action=edit
Checkbox aproach
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #48 from Martin Renvoize ---
Two more followups to come.. one to restore the notices we nuked with bug 27103
and one to convert from a checkbox to a button.
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #49 from Martin Renvoize ---
Created attachment 114259
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114259&action=edit
Bug 26282: (QA follow-up) Restore default notice
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_11_candidate
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #51 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #50)
> OK, I don't think I'll manage to get to switching the checkbox
> implementation to a double button one..
>
> Perhaps we can do that in a dist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Blocks||27262
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114254|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Martin Renvoize changed:
What|Removed |Added
Attachment #114255|0 |1
is obsolete|
1 - 100 of 144 matches
Mail list logo
