[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Rasa Satinskiene changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Rasa Satinskiene changed: What|Removed |Added Documentation||Rasa Satinskiene

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting -- You

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #83 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Bug 29822 depends on bug 34256, which changed state. Bug 34256 Summary: Patron search: search for borrowernumber starts with fails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 What|Removed

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What|Removed |Added Blocks||33428 Referenced Bugs:

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #82 from Nick Clemens --- Created attachment 154366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154366=edit Bug 29822: (QA follow-up) Use pipe for all field separators - Tidy atomic update

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #81 from Nick Clemens --- Created attachment 154365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154365=edit Bug 29822: Update unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #80 from Nick Clemens --- Created attachment 154364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154364=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #79 from Nick Clemens --- Created attachment 154363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154363=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #78 from Nick Clemens --- Created attachment 154362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154362=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What|Removed |Added Attachment #153442|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #76 from Nick Clemens --- This and 33428 are going to clash, happy to rebase mine on top of this Would it be better to leave the fields from the pref as pipe, and just move the other fields 'full_address', 'all_emails'

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Depends on|34092 |34256 Referenced Bugs:

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153384|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153383|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153382|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153381|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153380|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153379|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153378|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153377|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153376|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153375|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153374|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #153373|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #63 from Martin Renvoize --- Unit tests failing with rebase.. resetting to Failed whilst I work on that -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Depends on||34092 Referenced Bugs:

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #62 from Martin Renvoize --- OK.. rebased.. but waiting for my ktd to startup so I can re-run the tests. Patches uploaded just in case someone is already available ;P -- You are receiving this mail because: You are

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #151238|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #151237|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #151236|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #151235|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #151234|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #151233|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #55 from Martin Renvoize --- Bugger.. I thought this was part of that dependency tree already :(. Looking at the rebase now. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Attachment #151064|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Attachment #151062|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Attachment #151061|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Attachment #151060|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Attachment #151059|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Attachment #151058|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #46 from Jonathan Druart --- Created attachment 151064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151064=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #149894|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #149893|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #149892|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #149891|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #149890|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff ---

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #147437|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #147436|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #147435|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #147434|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #147433|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Sally changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff ---

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #146492|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #146491|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #146490|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #146489|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #146488|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #23 from Martin Renvoize --- Created attachment 146492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146492=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are the

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #22 from Martin Renvoize --- Created attachment 146491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146491=edit Bug 29822: Database and Preference description updates -- You are receiving this mail

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #21 from Martin Renvoize --- Created attachment 146490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146490=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #146445|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Attachment #144831|0 |1 is obsolete|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #18 from Martin Renvoize --- (In reply to Katrin Fischer from comment #7) > it would also simplify your patch :) Not in the slightest.. it makes it significantly more involved and has a much higher risk of regression.

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #17 from Martin Renvoize --- Created attachment 146445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146445=edit Bug 29822: Use the modal This looks silly to me... and it still requires changes to

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #16 from Martin Renvoize --- This preference does not affect the attributes in any way.. I've varified that in the code. Attributes are handled as their own case in the main patron search page.. always searched. --

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #15 from Katrin Fischer --- (In reply to Martin Renvoize from comment #14) > Can we deal with patron attributes as it's own bug please.. this is rapidly > going from a small improvement to a large and difficult

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #14 from Martin Renvoize --- Can we deal with patron attributes as it's own bug please.. this is rapidly going from a small improvement to a large and difficult development. -- You are receiving this mail because: You

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #13 from Katrin Fischer --- (In reply to Martin Renvoize from comment #11) > The excludes just get greyed out rather than removed as far as I can tell. Maybe we could rethink that? I still think having more ways to do a

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #12 from Katrin Fischer --- I'd include the note fields OPAC and circulation. Wondering: how do we handle additional patron attributes here? Are they always searchable automatically or not searchable at all? -- You

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #11 from Martin Renvoize --- The excludes just get greyed out rather than removed as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #10 from Katrin Fischer --- You can still use the modal and exclude those fields easily in the yaml file. That way we still have a consistent display/one place of code to change things and it's reduced to the more

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Status|Failed QA |In Discussion -- You

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #9 from Martin Renvoize --- Created attachment 146430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146430=edit Modal highlighting why I think it's a bad idea I've attached a mock of the modal.. all

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #8 from Martin Renvoize --- (In reply to Katrin Fischer from comment #7) > > 1) I believe the list is now too limited. This is also likely to cause > issues for libraries that have added fields not in your list. I think

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7

[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #6 from Martin Renvoize --- Thanks for testing David, always great to get your feedback. I should have said somewhere I. The bug, the list of fields I picked is entirely arbitrarily picked at the moment.. I picked what

  1   2   >