[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #55 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #54 from Joonas Kylmälä --- Passing QA. Added one more patch, the last one, to remove an unused variable in the opac-reserve.pl file. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #53 from Joonas Kylmälä --- Created attachment 139923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139923=edit Bug 30847: Remove unused variable Signed-off-by: Joonas Kylmälä -- You are receiving

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #52 from Joonas Kylmälä --- Created attachment 139922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139922=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #51 from Joonas Kylmälä --- Created attachment 139921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139921=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #50 from Joonas Kylmälä --- Created attachment 139920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139920=edit Bug 30847: Don't declare undef variable for assignment New holds have found set to

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #49 from Joonas Kylmälä --- Created attachment 139919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139919=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #48 from Joonas Kylmälä --- Created attachment 139918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139918=edit Bug 30847: Don't fetch patron twice Signed-off-by: Owen Leonard Rebased-by: Victor

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #47 from Joonas Kylmälä --- Created attachment 139917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139917=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #46 from Joonas Kylmälä --- Created attachment 139916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139916=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added Attachment #139628|0 |1 is obsolete|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Signed Off ---

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138941|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138940|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138939|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138938|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138937|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138936|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138935|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138934|0 |1 is

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #34 from Owen Leonard --- Created attachment 138941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138941=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #33 from Owen Leonard --- Created attachment 138940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138940=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #32 from Owen Leonard --- Created attachment 138939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138939=edit Bug 30847: Don't declare undef variable for assignment New holds have found set to undef

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #31 from Owen Leonard --- Created attachment 138938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138938=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #30 from Owen Leonard --- Created attachment 138937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138937=edit Bug 30847: Don't fetch patron twice Signed-off-by: Owen Leonard -- You are receiving

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #29 from Owen Leonard --- Created attachment 138936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138936=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #28 from Owen Leonard --- Created attachment 138935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138935=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 -

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Owen Leonard changed: What|Removed |Added Attachment #137668|0 |1 is obsolete|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Depends on|31307 | Referenced Bugs:

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Depends on||31314 Referenced Bugs:

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Depends on|27272 |31307

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Attachment #137675|0 |1 is obsolete|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Attachment #137674|0 |1 is obsolete|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Assignee|n...@bywatersolutions.com

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #23 from Nick Clemens --- (In reply to Jonathan Druart from comment #22) > Hi Nick, I have rebased your patches on top of bug 27272, hope you don't > mind! > I can also mark myself as assignee of the patches and continue

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Depends on||27272 --- Comment #22

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #21 from Jonathan Druart --- Created attachment 137675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137675=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #20 from Jonathan Druart --- Created attachment 137674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137674=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #19 from Jonathan Druart --- Created attachment 137673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137673=edit Bug 30847: Don't declrae undef variable for assignment New holds have found set to

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #18 from Jonathan Druart --- Created attachment 137672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137672=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #17 from Jonathan Druart --- Created attachment 137671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137671=edit Bug 30847: Don't fetch patron twice -- You are receiving this mail because: You are

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #16 from Jonathan Druart --- Created attachment 137670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137670=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #15 from Jonathan Druart --- Created attachment 137669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137669=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test:

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added Attachment #135340|0 |1 is obsolete|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #13 from Caroline Cyr La Rose --- (In reply to Caroline Cyr La Rose from comment #12) > Is this still to be tested or is it a duplicate or bug 27272? *of -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Caroline Cyr La Rose changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #10 from Nick Clemens --- Largely these changes should be small enough to read code for approval To test: 1 - Apply patch 2 - Confirm placing holds on OPAC works 3 - Confirm patron blocked when: marked 'gone no

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #9 from Nick Clemens --- Created attachment 135348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135348=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #8 from Nick Clemens --- Created attachment 135347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135347=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #7 from Nick Clemens --- Created attachment 135346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135346=edit Bug 30847: Don't declrae undef variable for assignment New holds have found set to undef -

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #6 from Nick Clemens --- Created attachment 135345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135345=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to the

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #5 from Nick Clemens --- Created attachment 135344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135344=edit Bug 30847: Remove %itemInfoHash This is not used git grep itemInfoHash only 2 occurences

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #4 from Nick Clemens --- Created attachment 135343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135343=edit Bug 30847: Don't fetch patron twice We already have a patron objetc, no need to fetch --

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #3 from Nick Clemens --- Created attachment 135342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135342=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #2 from Nick Clemens --- Created attachment 135341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135341=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 -

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #1 from Nick Clemens --- Created attachment 135340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135340=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on

[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are