https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #32 from Pedro Amorim ---
Nice work everyone!
Pushed to 22.11.x for next release
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs maili
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Pedro Amorim changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #31 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #30 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #29 from David Gustafsson ---
Ok, good! Yes, even though highly unlikely anyone would do that by mistake or
malicious intent, but still serious issue. As wrote above get_column should be
used here instead of dynamic metho
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Blocks||33844
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #28 from Marcel de Rooy ---
(In reply to David Gustafsson from comment #17)
> I see your point, but was it not already possible to make that code crash
> (or even worse things) by for example using key values that does n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #27 from Marcel de Rooy ---
Created attachment 151732
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151732&action=edit
Bug 32478: (QA follow-up) Keep current hashref behavior
Prevent a crash on wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #26 from Marcel de Rooy ---
Created attachment 151731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151731&action=edit
Bug 32478: (QA follow-up) Shebang and chmod for Koha/Config/SysPrefs.t
Test plan:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Attachment #151136|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Attachment #150690|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Attachment #150689|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Attachment #150688|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Attachment #150687|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #20 from Marcel de Rooy ---
sub is_denied_renewal
foreach my $field (keys %$denyingrules) {
my $val = $self->$field;
This is out of scope, but there is not even a check if it is a valid field.
The method Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
David Gustafsson changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #19 from David Gustafsson ---
Created attachment 151136
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151136&action=edit
Bug 32478: Fix syspref NULL values in tests
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |In Discussion
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #17 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #15)
> We remove these lines completely now and just trust ->yaml_preference:
> -foreach my $line (@lines){
> -my ($field,$array) = split
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #16 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #14)
> (In reply to David Gustafsson from comment #13)
> > Ok! Suppose due to forgot to fix the tests that still uses the 'NULL' value,
> > will do so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #15 from Marcel de Rooy ---
We remove these lines completely now and just trust ->yaml_preference:
-foreach my $line (@lines){
-my ($field,$array) = split /:/, $line;
-next if !$array;
-$field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #14 from Marcel de Rooy ---
(In reply to David Gustafsson from comment #13)
> Ok! Suppose due to forgot to fix the tests that still uses the 'NULL' value,
> will do so. Why is it odd? null is valid json, NULL is not.
Som
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #13 from David Gustafsson ---
Ok! Suppose due to forgot to fix the tests that still uses the 'NULL' value,
will do so. Why is it odd? null is valid json, NULL is not.
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #12 from Marcel de Rooy ---
The replace NULL by null thing feels a bit odd btw..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #10 from Nick Clemens ---
Created attachment 150690
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150690&action=edit
Bug 32478: (follow-up) Tidy code
Signed-off-by: Nick Clemens
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #9 from Nick Clemens ---
Created attachment 150689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150689&action=edit
Bug 32478: (follow-up) UpdateItemLocationOnCheckin no longer needs flattening
This p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #8 from Nick Clemens ---
Created attachment 150688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150688&action=edit
Bug 32478: Fix handling of undef values in ItemsDeniedRenewal
Signed-off-by: Nick Cl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Nick Clemens changed:
What|Removed |Added
Attachment #144633|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #6 from David Gustafsson ---
(In reply to Nick Clemens from comment #4)
> (In reply to Nick Clemens from comment #3)
> > (In reply to Jonathan Druart from comment #2)
> > > I don't think the removal here is correct, the m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #5 from David Gustafsson ---
Created attachment 150685
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150685&action=edit
Bug 32478: Fix handling of undef values in ItemsDeniedRenewal
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #4 from Nick Clemens ---
(In reply to Nick Clemens from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > I don't think the removal here is correct, the method does more than
> > C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
Jonathan Druart changed:
What|Removed |Added
Depends on||15494
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
David Gustafsson changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
David Gustafsson changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
David Gustafsson changed:
What|Removed |Added
See Also||https://bugs.koha-communi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
--- Comment #1 from David Gustafsson ---
Created attachment 144633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144633&action=edit
Bug 32478: Remove Koha::Config::SysPref->find since bypasses cache
get_yaml_pref
45 matches
Mail list logo
