https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #65 from Jonathan Druart ---
use C4::Context;
use Koha::Logger;
use Koha::BackgroundJobs;
+use C4::Context;
Dup C4::Context.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Arthur Suzuki changed:
What|Removed |Added
Status|Pushed to oldstable |RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #62 from Jacob O'Mara ---
Nice work, thanks everyone!
Pushed to 22.11.x for the next release.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Jacob O'Mara changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #59 from Marcel de Rooy ---
So we need libparallel-forkmanager-perl
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Keywords||dependency
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|Pushed to master|ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #58 from Marcel de Rooy ---
Created attachment 147828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147828=edit
Bug 32558: (QA follow-up) Move ForkManager to required
Thx Martin Renvoize for noting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Martin Renvoize changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Blocks|32990 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Blocks||32990
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #56 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #146754|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #54
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #53 from Marcel de Rooy ---
Created attachment 146754
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146754=edit
Bug 32558: (QA follow-up) Leave default to 1, remove extra fork
The default of 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Attachment #146020|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #51 from Marcel de Rooy ---
Opened bug 32990 to address the deadlock.
Please signoff, Kyle !
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #50 from Marcel de Rooy ---
Refactored the code in ImportBatch, new results:
286505 at /usr/share/koha/misc/background_jobs_worker.pl line 93.
286506 90 at /usr/share/koha/misc/background_jobs_worker.pl line 136.
286507
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #49 from Marcel de Rooy ---
When I submit 4 stage marc imports with 3 processes (removing the extra fork in
process_job), I get this:
285042 at /usr/share/koha/misc/background_jobs_worker.pl line 93.
285043 82 at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #48 from Marcel de Rooy ---
Note: Kyle, you did not even respond to any of the comments !
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #47
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #46 from Kyle M Hall ---
(In reply to David Cook from comment #44)
> (In reply to Jonathan Druart from comment #43)
> > Could you remind me why we need this? Why don't you just run another worker?
> > This area has not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Emily Lamancusa changed:
What|Removed |Added
Severity|enhancement |major
--- Comment #45
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #44 from David Cook ---
(In reply to Jonathan Druart from comment #43)
> Could you remind me why we need this? Why don't you just run another worker?
> This area has not been very stable in the last releases and I am not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #43 from Jonathan Druart ---
Could you remind me why we need this? Why don't you just run another worker?
This area has not been very stable in the last releases and I am not sure we
should play with more forking and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #42 from Marcel de Rooy ---
(In reply to David Cook from comment #39)
> (In reply to Marcel de Rooy from comment #34)
> > +Max processes will be set from the command line option, the environment
> > variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #41 from Marcel de Rooy ---
(In reply to David Cook from comment #40)
> (In reply to Marcel de Rooy from comment #35)
> > Not sure (yet) but should the default not be zero? Just do not fork like we
> > currently do?
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #40 from David Cook ---
(In reply to Marcel de Rooy from comment #35)
> Not sure (yet) but should the default not be zero? Just do not fork like we
> currently do?
The job needs to run in a forked process. The memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #39 from David Cook ---
(In reply to Marcel de Rooy from comment #34)
> +Max processes will be set from the command line option, the environment
> variable MAX_PROCESSES, or the koha-conf file, in that order of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #38 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #34)
> +Max processes will be set from the command line option, the environment
> variable MAX_PROCESSES, or the koha-conf file, in that order of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #37
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #36 from Marcel de Rooy ---
Theoretical add a wait_all_children:
diff --git a/misc/background_jobs_worker.pl b/misc/background_jobs_worker.pl
index 1b2d6309d9..89f51042cf 100755
--- a/misc/background_jobs_worker.pl
+++
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #35 from Marcel de Rooy ---
Not sure (yet) but should the default not be zero? Just do not fork like we
currently do?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #34 from Marcel de Rooy ---
+Max processes will be set from the command line option, the environment
variable MAX_PROCESSES, or the koha-conf file, in that order of precedence.
+By default the script will only run one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Emily Lamancusa changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Emily Lamancusa changed:
What|Removed |Added
Attachment #145950|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #31 from Kyle M Hall ---
(In reply to Emily Lamancusa from comment #29)
> *-Step 5 should say parameter -m 3 instead of parameter -p 3
>
> Apparently I can't type it correctly either!
Thanks! I've updated the test plan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #145901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #29 from Emily Lamancusa
---
*-Step 5 should say parameter -m 3 instead of parameter -p 3
Apparently I can't type it correctly either!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #28 from Emily Lamancusa
---
Test notes:
-Step 5 should say parameter -m 3 instead of parameter -d 3
-The above should also be documented in the help section of the script
-Is the process limit still meant to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #145900|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #145067|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Emily Lamancusa changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Rebecca Coert changed:
What|Removed |Added
CC||rco...@arlingtonva.us
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #24 from David Cook ---
What happens if you have a background_jobs_worker.pl running 4 child processes,
they all ACK early, and then 1 child process crashes?
That job will be stuck as "new" or "started" until the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #23 from David Cook ---
(In reply to Kyle M Hall from comment #10)
> Would that work with the database polling method? I think that would require
> some re-engineering.
Upon review, that won't work with having multiple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #22 from David Cook ---
Was tempted to Fail QA this one, but I haven't actually tested if the current
patch won't work in practice.
But I think moving the forking up as I describe above would be a wise move.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #21 from David Cook ---
(In reply to Jonathan Druart from comment #14)
> From
> https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed
>
> "You have to ACK messages in same order as they arrive to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #144960|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Depends on||32573
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #19 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #18)
> (In reply to Jonathan Druart from comment #17)
> > This contradicts https://metacpan.org/pod/Net::Stomp#ack
> >
> > """
> > This acknowledges that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #18 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #17)
> This contradicts https://metacpan.org/pod/Net::Stomp#ack
>
> """
> This acknowledges that you have received and processed a frame and all
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #17 from Jonathan Druart ---
This contradicts https://metacpan.org/pod/Net::Stomp#ack
"""
This acknowledges that you have received and processed a frame and all frames
before it (if you are using client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #16 from Kyle M Hall ---
Created attachment 145062
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145062=edit
Bug 32558: (follow-up) Ack the stomp message before forking
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #15 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #14)
> From
> https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed
>
> "You have to ACK messages in same order as they arrive to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #14 from Jonathan Druart ---
From
https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed
"You have to ACK messages in same order as they arrive to your system"
If this is correct, forking is not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #13 from Kyle M Hall ---
Created attachment 145043
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145043=edit
Bug 32558: (follow-up) Allow configuration of max processes via env or koha
conf
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Emily Lamancusa changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #12 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #11)
> (In reply to Jonathan Druart from comment #9)
> > (In reply to Jonathan Druart from comment #8)
> > > The first argument could be the memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #11 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > The first argument could be the memory footprint, but with bug 28413 it
> > should not be a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #10 from Kyle M Hall ---
(In reply to David Cook from comment #7)
> An alternative would be to launch more background_jobs_worker.pl processes,
> although that would require updating the koha-worker script.
Would that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #8 from Jonathan Druart ---
(In reply to David Cook from comment #7)
> An alternative would be to launch more background_jobs_worker.pl processes,
> although that would require updating the koha-worker script.
Yes,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #6 from Kyle M Hall ---
Created attachment 144961
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144961=edit
Bug 32558: (follow-up) Set default max processes to 1
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #5 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #2)
> Hi Kyle, you embedded unrelated changes (sip).
> This would make sense in some cases (job types), but I think it should
> default to 1 to keep the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #144947|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Attachment #144946|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #3 from Kyle M Hall ---
Created attachment 144947
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144947=edit
Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs
simultaneously
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #2 from Jonathan Druart ---
Hi Kyle, you embedded unrelated changes (sip).
This would make sense in some cases (job types), but I think it should default
to 1 to keep the existing behaviour (we don't want 10 long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #1 from Kyle M Hall ---
Created attachment 144946
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144946=edit
Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs
simultaneously
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
90 matches
Mail list logo
