[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Blocks|36789 | Referenced Bugs: https

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #166957|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #26 from Thibaud Guillot --- I miss some js code on my last rebase (due to place_booking.js modal renaming). -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #166952|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #24 from Thibaud Guillot --- (In reply to David Nind from comment #22) > The patches now apply, however there is an error when restarting everything > - see [1]. I think I managed tow ork around this, but what I did may b

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #166932|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #22 from

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #21 from Thibaud Guillot --- Created attachment 166933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166933&action=edit Bug 36271: (follow-up) Add switch for join table according to item-level_itypes s

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #166930|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #19 from Thibaud Guillot --- Created attachment 166931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166931&action=edit Bug 36271: (follow-up) Add switch for join table according to item-level_itypes s

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #166809|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Commen

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #16 from Thibaud Guillot --- Created attachment 166907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166907&action=edit Bug 36271: (follow-up) Add switch for join table according to item-level_itypes s

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #15 from David Nind --- Dependent bug 35906 no longer applies 8-(.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-b

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #165063|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Blocks||36789 Referenced Bugs:

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #165061|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #164627|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Laurence Rault changed: What|Removed |Added CC||laurence.ra...@biblibre.com

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #163546|0 |1 is obsolete|

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #8 from Martin Renvoize --- Nice one.. I'd just started to look again at this and you posted a patch.. I'll take a look now :) -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #7 from Thibaud Guillot --- Perhaps we could change the patch title to broaden the scope of the rules if you agree -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #6 from Thibaud Guillot --- Hi ! It's a first proposal, I haven't yet written unit tests because (unless I'm mistaken) they're currently KO (Booking.t) If you'd like to give me some feedback on what's been done, I'd be

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #5 from Thibaud Guillot --- Created attachment 163546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163546&action=edit Bug 36271 : Add circulation rules for booking Welcome to 4 new circulation rules

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff Dep

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Bug 36271 depends on bug 35248, which changed state. Bug 35248 Summary: Bookings needs unit tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 What|Removed |Added

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #4 from Martin Renvoize --- Thanks everyone, this is great feedback. Really interested to see your work once there's things to look at Thibuad. I'm happy with the direction the itemtype bookable code has taken, though of

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #2 from Thibaud Guillot --- Hello :) I'm actually working on that, for now, I defined a CanItemBeBookedInAdvance function in Bookings to deal with some rules, 4 in fact : - booking_total_allowed - booking_per_item - bo

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #1 from Caroline Cyr La Rose --- Hi Martin, When I was testing bookings, I was thinking of a separate parameter for the booking period. However, using the loan length makes sense. I'm not sure about the renewals. Usually

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added CC||thibaud.guil...@biblibre.c

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added CC||caroline.cyr-la-rose@inlib

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added CC||da...@davidnind.com -- Y

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de,

[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Martin Renvoize changed: What|Removed |Added Depends on||35248 Referenced Bugs: