https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #1 from Lari Strand ---
Created attachment 167110
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167110&action=edit
Bug 36947 - Diacritics and lower case letters not taken into account when
facets are a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Lari Strand changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Lari Strand changed:
What|Removed |Added
Attachment #167110|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Nind changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |lmstr...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #4 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #5 from David Cook ---
I'm going to send a follow-up quick... and you let me know if it works for you.
I should be having lunch right now, but I find this interesting.
--
You are receiving this mail because:
You are wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #6 from David Cook ---
Created attachment 167141
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167141&action=edit
Bug 36947: Remove diacritics from decomposed strings in ES search
This patch removes t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Attachment #167125|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Attachment #167141|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #9 from David Cook ---
All right... fixed the sign off.
Lari, if you approve of my patch, sign it off, and we can move this to Signed
Off.
That was fun!
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #10 from David Cook ---
So I'm a bit confused...
On Mattermost, @paxed is saying for Finnish "it should also sort åöä to the end
of the alphabet, as per the system preference"
But Lari's patch wouldn't do that, and Lar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Lari Strand changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Lari Strand changed:
What|Removed |Added
Attachment #167142|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Lari Strand changed:
What|Removed |Added
Attachment #167143|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #13 from David Cook ---
Another idea... I wonder if we could tell Perl the locale and have it do the
heavy lifting.
Maybe the user's locale or (as Katrin suggested) the library's locale...
--
You are receiving this mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #14 from Lari Strand ---
Let's do a new bugzilla ticket about the scandic letters issue?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #15 from Katrin Fischer ---
We also figured out that the expectations might differ from language to
language (or locale) with some of us using letters that present the same way
(thinking of Ä)
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #16 from David Cook ---
(In reply to Katrin Fischer from comment #15)
> We also figured out that the expectations might differ from language to
> language (or locale) with some of us using letters that present the same wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #17 from David Cook ---
I'm going to try this out in a minute...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #18 from David Cook ---
(In reply to David Cook from comment #17)
> I'm going to try this out in a minute...
In lieu of the previous patches by myself and Lari, I've added "use locale" to
sub _convert_facets() in Koha/Se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Status|Signed Off |In Discussion
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #19 from David Cook ---
To generate a locale and Koha to use it
1. vi /etc/locale.gen
2. Uncomment the locale you want to generate (e.g. fi_FI.UTF-8 UTF-8)
3. locale-gen
4. locale-a # this will show you what locales are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #20 from David Cook ---
And sure enough...
When I just add "use locale" to sub "_convert_facets" in
Koha/SearchEngine/Elasticsearch/Search.pm and make sure the environmental
variable LANG is set to the locale I want (ie
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #21 from David Cook ---
Ok, so the issue was LC_ALL was overriding everything, as one can see by
running the "locale" command.
If you unset "LC_ALL" and set "LC_COLLATE", then you're all good.
--
But I've learned a lo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #22 from David Cook ---
Created attachment 167188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167188&action=edit
Bug 36947: [Alternate] Do a locale-based sort for ES facet names
This change causes t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Assignee|lmstr...@gmail.com |dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #24 from Lari Strand ---
We're happy with this solution. I can sign off.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #25 from Lari Strand ---
The locale based sorting is not working with this alternative commit. The perl
module is announced inside the sub. I added use locale; to the beginning of the
file and now the sorting works when F
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #27 from David Cook ---
(In reply to Lari Strand from comment #25)
> The locale based sorting is not working with this alternative commit. The
> perl module is announced inside the sub. I added use locale; to the
> beginn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #28 from David Cook ---
(In reply to Fridolin Somers from comment #26)
> +use Unicode::Normalize;
> Dont we need to choose the method ?
> +use Unicode::Normalize qw( NFKD );
Unicode::Normalize exports NFC, NFD, NFKC, and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #29 from David Cook ---
Created attachment 167198
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167198&action=edit
Bug 36947: [Alternate 2] Do a locale-based sort for ES facet names
This change uses a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #30 from David Cook ---
Of course, there's always this 3rd option of using "Unicode::Collate::Locale",
which I've called "Alternate 2".
I think that I like this option best, as it's the most configurable. You can
just fe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #31 from David Cook ---
Note that I've tried with a variety of system settings. Even if all the LC_,
LANG, and LANGUAGE environmental variables are empty, the collator will still
use a sensible default, so it's not like i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #32 from Lari Strand ---
This seems to achieve the same result as use locale (when LC_COLLATE is set to
"fi_FI"):
if( C4::Context->preference('FacetOrder') eq 'Alphabetical' ){
my $coll = Unicode::Col
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #33 from David Cook ---
(In reply to Lari Strand from comment #32)
> This seems to achieve the same result as use locale (when LC_COLLATE is set
> to "fi_FI"):
>
> if( C4::Context->preference('FacetOrder') eq 'Al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #34 from Lari Strand ---
Sorry, missed the patch :D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #35 from David Cook ---
(In reply to Lari Strand from comment #34)
> Sorry, missed the patch :D
No worries! I hope you like the patch!
Thanks for the interesting challenge.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #36 from Lari Strand ---
Found couple of bugs linking to this one. Collections get alphabetized by the
auth value code rather than the description. Will make another bugzilla ticket
for this unless I can find one. I alrea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #37 from Lari Strand ---
Added https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36982.
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #38 from David Cook ---
(In reply to Lari Strand from comment #36)
> Also languages get alpabetized based on their english descriptions instead
> of the selected intranet language. This might be more difficult to fix...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #39 from David Cook ---
For my part, I like "Bug 36947: [Alternate 2] Do a locale-based sort for ES
facet names" best.
What do others think?
I'll post this on the listserv as well to solicit opinions.
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #40 from Lari Strand ---
I like alternative 2, Do a locale-based sort for ES facet names" best as well.
We actually implemented this in our production environment with
my $coll = Unicode::Collate::Locale->new( locale =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #41 from David Cook ---
(In reply to Lari Strand from comment #40)
> I like alternative 2, Do a locale-based sort for ES facet names" best as
> well. We actually implemented this in our production environment with
I'm so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #42 from Lari Strand ---
I guess there could be cases where you want to override your env LC_COLLATE
locale with one set in koha-conf.xml or Apache. I'm not familiar on how Koha
uses localizations in other ways besides se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment #43
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Attachment #167145|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Attachment #167146|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Attachment #167188|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #44 from Katrin Fischer ---
Prices display according to the active currency and the CurrencyFormat system
preference. The Local doesn't play any role here.
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Lari Strand changed:
What|Removed |Added
Attachment #167198|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #46 from Martin Renvoize ---
Created attachment 168488
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168488&action=edit
Bug 36947: Do a locale-based sort for ES facet names
This change uses a configur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Martin Renvoize changed:
What|Removed |Added
QA Contact||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Martin Renvoize changed:
What|Removed |Added
Attachment #167880|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #47
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #48 from David Cook ---
(In reply to Martin Renvoize from comment #47)
> This is a great first pass... I'd love to see an option added to
> koha-conf.xml to allow setting at the instance level.
>
> More importantly thoug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #49 from David Cook ---
And as for the koha-conf.xml option... yeah cool. I think that makes sense for
the first implementation.
I'm so excited to explore more options in the future as well. I love languages
and UTF-8 :
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Martin Renvoize changed:
What|Removed |Added
CC|martin.renvoize@ptfs-europe |
|.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #50 from Martin Renvoize ---
Would love to see this over the finish line ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing lis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
Katrin Fischer changed:
What|Removed |Added
CC||caroline.cyr-la-rose@inlibr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #52 from David Cook ---
(In reply to Martin Renvoize from comment #50)
> Would love to see this over the finish line ;)
I'm hoping to look at this in August...
--
You are receiving this mail because:
You are watching a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #53 from David Cook ---
Staying back late on my Friday working on this one...
`locale -a` returns
C
C.utf8
en_US.utf8
fr_FR.utf8
POSIX
However, when I try to use one of the locales in Unicode::Collate::Locale, it
says i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #54 from David Cook ---
(In reply to David Cook from comment #53)
> But I'll have a go again with Finnish and have another look when it's not so
> late...
I was going to leave this for another day but I'm just too stubbo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #55 from David Cook ---
I'm hoping to revisit this soon.
We can do a unit test to verify the overall functionality, but we'll need to be
very careful unit testing other locales, because I don't think we can count on
eve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
David Cook changed:
What|Removed |Added
Attachment #168488|0 |1
is obsolete|
70 matches
Mail list logo
