http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #15952|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA |Passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #27 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I've noticed something very odd about sorting on the staff client: if I choose
to sort by title (for example), it always defaults to sorting in *descending*
order,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Good catch! This latest followup fixes that. I've also simplified some of the
presentation logic.
(In reply to comment #27)
I've noticed something very odd about sorting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
I am a little bit perplexed by this line. Why did you add the || 'title'
when $sortfield has already been set? Or, equivalently, why did you set
$sortfield previously? I
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15891
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15891action=edit
Bug 9458 - Add sorting to lists - QA Followup 3
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #24 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Comment on attachment 15675
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15675
Bug 9458 - Add sorting to lists - QA Followup
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #15363|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15675
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15675action=edit
Bug 9458 - Add sorting to lists - QA Followup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #21 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I am concerned about the way $sortfield is included directly in the query. Does
it provide an SQL injection vector?
--
You are receiving this mail because:
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15694
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15694action=edit
Bug 9458 - Add sorting to lists - QA Followup 2
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
Good catch! We cannot use a placeholder for ORDER BY fields, but we *can*
escape it using quote_identifier to ensure it cannot be used for SQL injection
attacks. I've
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15543
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15543action=edit
Bug 9458 - Add sorting to lists - QA Followup
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #15543|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #11)
3 small remarks:
- At the OPAC, the user does not know what is the default sorting. At the
intranet, same thing, maybe we would like to add the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Blocks||9661
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #14)
(In reply to comment #11)
3 small remarks:
- At the OPAC, the user does not know what is the default sorting. At the
intranet, same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #15545|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
There is an issue about arrows:
[% IF direction == 'asc' %][% direction = 'desc' %][% ELSE %][% direction =
'asc' %][% END %]
So there is an inversion on them. When
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Attachment #14792|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 15363
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15363action=edit
Bug 9458 - Add sorting to lists
Test Plan:
1) Apply patch
2)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Assignee|gmcha...@gmail.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14781
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14781action=edit
Bug 9458 - Add sorting to lists
Test Plan:
1) Apply patch
2) View
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|NEW |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Just a remark about the multiple items: See bug report 8032. The sorting on
call number works on the first item (just an arbitrary choice). But all call
numbers are listed.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Change sponsored?|---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
In the staff client:
- Sortable columns do not have a visual indicator that they are sortable.
They should have an icon like JavaScript-sorted table headers do.
- Only
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #14781|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #14790|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #14791|0 |1
38 matches
Mail list logo
