http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Fridolin SOMERS changed:
What|Removed |Added
Blocks||9654
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Galen Charlton changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #28 from mathieu saby ---
(In reply to Martin Renvoize from comment #27)
> Hi Mathieu,
>
> There were a few IRC converstaions and a thread on the mailing list about
> tidying the whole koha codebase at some point.. I thin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #27 from Martin Renvoize ---
Hi Mathieu,
There were a few IRC converstaions and a thread on the mailing list about
tidying the whole koha codebase at some point.. I think the final decision was
to just do it as we go alon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #26 from mathieu saby ---
(In reply to Martin Renvoize from comment #25)
> Passing QA for that final followup. It's a template tidy up which doesn't
> affect operation.
>
> It'll affect blame as it change whitespace (which
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #25 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Martin Renvoize changed:
What|Removed |Added
Attachment #22827|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Status|Passed QA |Needs Signoff
--- Comment #22
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #21 from mathieu saby ---
Created attachment 22827
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22827&action=edit
[PATCH 3] Bug 9807 : Reindent basketgroup template
Subject: [PATCH 3/3] reindent basketg
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Attachment #22793|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #20 from mathieu saby ---
(In reply to Kyle M Hall from comment #19)
> I would like to note that the pdf print view is a "interesting" but
> certainly no reason to not pass qa. I think a long term future goal should
> be to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #18 from Kyle M Hall ---
Created attachment 22813
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22813&action=edit
Bug 9807 : Followup fixing variable name
Fixing closedbg name in template
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Kyle M Hall changed:
What|Removed |Added
Attachment #22792|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Attachment #22782|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Attachment #22781|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #14 from mathieu saby ---
Jonathan, I will rewrite the patch without any reindenting. I think it will be
more easy to understand for QA team.
As reindenting is needed for code readabiliy, it will add a followup for it.
Ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #11 from mathieu saby ---
The closedbg variable passed to template is used to decide if the bg must be
only displayed, or make editable.
By the way, I've remarked a typo : "closedgb" for "closedbg".
I'm writing a followup.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #13 from mathieu saby ---
Created attachment 22782
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22782&action=edit
[PATCH 2] Bug 9807 : Followup fixing variable name
Fixing closedbg name in template
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Attachment #22023|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #10 from mathieu saby ---
> 2/ The view "show" is not clear in the code. Personally, I don't understand
> anything.
Could you specify what you call the view "show" ? I don't find the "show" word
in my patch.
> 3/ There
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #9 from mathieu saby ---
(In reply to Jonathan Druart from comment #8)
> I am a little bit disconcerted.
> The aqbasketgroup.tt is really dirty and it is not easy to do something in
> it.
=> so true. it's horrible. And ver
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #7 from mathieu saby ---
Thank you Pierre and Cedric!
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #22021|0 |1
is obsolete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
sandbo...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #6 from sandbo...@biblibre.com ---
Created attachment 22023
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22023&action=edit
Bug 9807 : Make possible to view a basketgroup without reopening it
This patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #4 from mathieu saby ---
(In reply to mathieu saby from comment #3)
> Next step for improving basketgroup management will be Bug 10919
>
> M. Saby
And make links from other pages (orders, baskets...) to a specific basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #3 from mathieu saby ---
Next step for improving basketgroup management will be Bug 10919
M. Saby
--
You are receiving this mail because:
You are watching all bug changes.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #2 from mathieu saby ---
Created attachment 22021
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22021&action=edit
[PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it
This patch m
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #1 from mathieu saby ---
I am working on that
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
mathieu saby changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f
36 matches
Mail list logo