Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Marc Balmer
Am 24.03.12 15:35, schrieb Robin Sheat: > Op 25-03-12 03:19, Marc Balmer schreef: >> No, it does not rewrite any reports. If users enter SQL somewhere, I >> assume they enter proper SQL for their DB server. Which leads to a > > OK, so it doesn't address this (quite minor) problem. It would mean

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Robin Sheat
Op 25-03-12 03:19, Marc Balmer schreef: > No, it does not rewrite any reports. If users enter SQL somewhere, I > assume they enter proper SQL for their DB server. Which leads to a OK, so it doesn't address this (quite minor) problem. > I am considering to write a set of compatability functions

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Marc Balmer
Am 24.03.12 15:07, schrieb Robin Sheat: > Op 25-03-12 03:01, Marc Balmer schreef: >> We adress this problem with the DBQ module, which exists to produce >> database specific SQL code when there is no standard way to express sth >> and when there is no way to get it through DBI. See the example we

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Robin Sheat
Op 25-03-12 03:01, Marc Balmer schreef: > We adress this problem with the DBQ module, which exists to produce > database specific SQL code when there is no standard way to express sth > and when there is no way to get it through DBI. See the example we > bundled with the path in bug 7365. I'm not

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Marc Balmer
Am 24.03.12 14:44, schrieb Robin Sheat: > Op 25-03-12 02:28, Jared Camins-Esakov schreef: >> MySQL supports ExtractValue too. Is there something special in the >> Postgres functionality that makes a difference for the end user? > > Actually, this is something worth considering when supporting mul

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Robin Sheat
Op 25-03-12 02:28, Jared Camins-Esakov schreef: > MySQL supports ExtractValue too. Is there something special in the > Postgres functionality that makes a difference for the end user? Actually, this is something worth considering when supporting multiple databases: some reports may require a diffe

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Jared Camins-Esakov
Tomas, > >> Are there any specific features of PostgreSQL that would lead to a > > >> beneficial new feature for library patrons? I know there is plenty of > > >> literature on it's merits over MySQL, but how do those translate to > > >> something that the users of Koha can benefit from? > > > >

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-24 Thread Tomas Cohen Arazi
El 23/03/2012 22:22, "Christopher Nighswonger" escribió: > > On Fri, Mar 23, 2012 at 5:38 PM, Marc Balmer wrote: > > Am 23.03.12 21:39, schrieb Ian Walls: > >> Marc, > > ... > > > > >> Are there any specific features of PostgreSQL that would lead to a > >> beneficial new feature for library patro

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Christopher Nighswonger
On Fri, Mar 23, 2012 at 5:38 PM, Marc Balmer wrote: > Am 23.03.12 21:39, schrieb Ian Walls: >> Marc, ... > >> Are there any specific features of PostgreSQL that would lead to a >> beneficial new feature for library patrons?  I know there is plenty of >> literature on it's merits over MySQL, but

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Marc Balmer
Am 23.03.12 21:39, schrieb Ian Walls: > Marc, > > > Without concrete examples of what RDMS-specific features would be desirable > for us, I'm more inclined to reach for compliance with standards (and thus > any standards-based RDMS) than for adding support for specific new RDMS > systems. Now, o

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Ian Walls
Marc, Without concrete examples of what RDMS-specific features would be desirable for us, I'm more inclined to reach for compliance with standards (and thus any standards-based RDMS) than for adding support for specific new RDMS systems. Now, of course every RDMS is different, and will implement

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Marc Balmer
Am 23.03.12 17:23, schrieb Ian Walls: > According to rule SQL6 of our Coding Guidelines ( > http://wiki.koha-community.org/wiki/Coding_Guidelines#Database), backquotes > are not acceptable, as they are a MySQL-ism. Part of the duty of QA is to > verify that the coding guidelines are met, so it is

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Marc Balmer
Am 23.03.12 13:27, schrieb Chris Nighswonger: > Hi Marc, > > On Fri, Mar 23, 2012 at 6:12 AM, Marc Balmer wrote: > >> Dear Koha-Devels, >> >> during the Marseille Hackfest 2012 I started together with Stephane and >> Christophe from BibLibre to add support for the PostgreSQL database. >> The ult

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Paul Poulain
Le 23/03/2012 13:27, Chris Nighswonger a écrit : > Hi Marc, Hi Chris, > Furthermore, what "will" and "will not" pass QA is subject to > the discretion of the community appointed QA manager, not other individuals. Marc comment was made after a discussion we had during the hackfest, where I said him

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Ian Walls
According to rule SQL6 of our Coding Guidelines ( http://wiki.koha-community.org/wiki/Coding_Guidelines#Database), backquotes are not acceptable, as they are a MySQL-ism. Part of the duty of QA is to verify that the coding guidelines are met, so it is reasonable to say that such markings *should*

Re: [Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Chris Nighswonger
Hi Marc, On Fri, Mar 23, 2012 at 6:12 AM, Marc Balmer wrote: > Dear Koha-Devels, > > during the Marseille Hackfest 2012 I started together with Stephane and > Christophe from BibLibre to add support for the PostgreSQL database. > The ultimate goal of this work is that Koha can run on a PostgreSQ

[Koha-devel] Adding support for PostgreSQL, no new MySQLisms, please

2012-03-23 Thread Marc Balmer
Dear Koha-Devels, during the Marseille Hackfest 2012 I started together with Stephane and Christophe from BibLibre to add support for the PostgreSQL database. The ultimate goal of this work is that Koha can run on a PostgreSQL server as as good as it does now on a MySQL server. This mostly boils