Re: [kopete-devel] [PATCH] chatwindow: Fix crashes where there are no other members in a chat

2007-02-01 Thread Martijn Klingens
On Friday 02 February 2007, Jeremy Kerr wrote: > > I'm not a history plugin guy, but my first feeling is to use the > > myself contact, since at the very least you are in the chat yourself, > > no? > > ... which brings me to the question - what's the policy on the 'members' > list for a chatsession

Re: [kopete-devel] [PATCH] chatwindow: Fix crashes where there are no other members in a chat

2007-02-01 Thread Jeremy Kerr
> I'm not a history plugin guy, but my first feeling is to use the > myself contact, since at the very least you are in the chat yourself, > no? ... which brings me to the question - what's the policy on the 'members' list for a chatsession - should it contain the myself contact ? I've seen lots

Re: [kopete-devel] [PATCH] chatwindow: Fix crashes where there are no other members in a chat

2007-02-01 Thread Martijn Klingens
On Thursday 01 February 2007, Jeremy Kerr wrote: > OK, looks like the history plugin depends on having at least one member > in the chat (eg, to figure out which file to save the history to). Any > history plugin folks here that have suggestions about what to do in > this case ? I'm not a history

Re: [kopete-devel] [PATCH] chatwindow: Fix crashes where there are no other members in a chat

2007-02-01 Thread Jeremy Kerr
> However, IANAKCWH (I am not a kopete chat window hacker) - are there > any other problems associated with having an empty chatwindow or > Kopete::ChatSession? OK, looks like the history plugin depends on having at least one member in the chat (eg, to figure out which file to save the history to

[kopete-devel] [PATCH] chatwindow: Fix crashes where there are no other members in a chat

2007-02-01 Thread Jeremy Kerr
This change is necessary to allow chatwindows/chatsessions with no other members. For example, meanwhile conferences can start with no members, as other participants can be added later. However, IANAKCWH (I am not a kopete chat window hacker) - are there any other problems associated with having a