Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-03-01 Thread Charles Connell
> On 2008-03-01 09:26:13, Matt Rogers wrote: > > Looks good now. Thanks! :) Be sure to fix the whitespace issue (marked in > > red in the diffs) before you commit > > Shipped. http://websvn.kde.org/?view=rev&revision=781052. Whitespace is fixed. I guess you have to close this page. - Charles

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-03-01 Thread Matt Rogers
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/#review225 --- Ship it! Looks good now. Thanks! :) Be sure to fix the whitespace issue (marked

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-03-01 Thread Matt Rogers
> On 2008-02-23 10:33:04, Matt Rogers wrote: > > hmm, I wonder if you could tie the resize to the layout timer instead of > > having to create a new one. That removes another option ( the one about how > > long to wait to resize ) and removes a timer. :) > > > > If you can't do it, then we'll

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-24 Thread Charles Connell
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/ --- (Updated 2008-02-24 16:48:57.846832) Review request for Kopete. Summary --- This is

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-24 Thread Charles Connell
> On 2008-02-23 10:33:04, Matt Rogers wrote: > > hmm, I wonder if you could tie the resize to the layout timer instead of > > having to create a new one. That removes another option ( the one about how > > long to wait to resize ) and removes a timer. :) > > > > If you can't do it, then we'll

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-24 Thread Charles Connell
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/ --- (Updated 2008-02-24 16:29:13.755513) Review request for Kopete. Summary --- This is

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Charles Connell
> On 2008-02-23 10:33:04, Matt Rogers wrote: > > hmm, I wonder if you could tie the resize to the layout timer instead of > > having to create a new one. That removes another option ( the one about how > > long to wait to resize ) and removes a timer. :) > > > > If you can't do it, then we'll

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Matt Rogers
> On 2008-02-23 10:33:04, Matt Rogers wrote: > > hmm, I wonder if you could tie the resize to the layout timer instead of > > having to create a new one. That removes another option ( the one about how > > long to wait to resize ) and removes a timer. :) > > > > If you can't do it, then we'll

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Charles Connell
> On 2008-02-23 10:33:04, Matt Rogers wrote: > > hmm, I wonder if you could tie the resize to the layout timer instead of > > having to create a new one. That removes another option ( the one about how > > long to wait to resize ) and removes a timer. :) > > > > If you can't do it, then we'll

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Matt Rogers
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/#review176 --- hmm, I wonder if you could tie the resize to the layout timer instead of having

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Charles Connell
> On 2008-02-20 12:25:41, Matt Rogers wrote: > > Ok, so there are a couple of problems with this. > > > > 1. It uses a timer. You don't need a timer to do this. It should happen > > only as a user goes online or offline. Have the main window listen for > > status changes and act appropriately.

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Charles Connell
> On 2008-02-20 12:25:41, Matt Rogers wrote: > > Ok, so there are a couple of problems with this. > > > > 1. It uses a timer. You don't need a timer to do this. It should happen > > only as a user goes online or offline. Have the main window listen for > > status changes and act appropriately.

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-23 Thread Charles Connell
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/ --- (Updated 2008-02-23 10:21:47.197447) Review request for Kopete. Summary --- This is

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-20 Thread Adam Russell
> On 2008-02-20 12:25:41, Matt Rogers wrote: > > Ok, so there are a couple of problems with this. > > > > 1. It uses a timer. You don't need a timer to do this. It should happen > > only as a user goes online or offline. Have the main window listen for > > status changes and act appropriately.

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-20 Thread Charles Connell
> On 2008-02-20 12:25:41, Matt Rogers wrote: > > Ok, so there are a couple of problems with this. > > > > 1. It uses a timer. You don't need a timer to do this. It should happen > > only as a user goes online or offline. Have the main window listen for > > status changes and act appropriately.

Re: [kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-20 Thread Matt Rogers
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/#review158 --- Ok, so there are a couple of problems with this. 1. It uses a timer. You don't n

[kopete-devel] Review Request: Automatically resize main window to fit contactlist

2008-02-20 Thread Charles Connell
--- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/ --- Review request for Kopete. Summary --- This is a patch that resizes the main window a