Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/ --- (Updated Oct. 5, 2017, 10:36 p.m.) Status -- This change has been ma

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103800 --- Ship it! I think it makes sense to commit this for now; t

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103767 --- Laurent, Pali, if I commit this as it is, then https://git.

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

> On June 11, 2017, 9:52 a.m., Paulo Lieuthier wrote: > > Ship It! Do you know it's not the creator of request which must click on "ship it" - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboa

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

> On June 10, 2017, 1:26 p.m., Laurent Montel wrote: > > > > Paulo Lieuthier wrote: > I had already started translating those (and all others) in my main > branch, and didn't want to mess with that here. Next review request will be > such translation, isn't that better? > > By the

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

> On June 10, 2017, 1:26 p.m., Laurent Montel wrote: > > > > Paulo Lieuthier wrote: > I had already started translating those (and all others) in my main > branch, and didn't want to mess with that here. Next review request will be > such translation, isn't that better? > > By the

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103308 --- Ship it! Ship It! - Paulo Lieuthier On June 10, 2017,

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

> On June 10, 2017, 1:26 p.m., Laurent Montel wrote: > > > > Paulo Lieuthier wrote: > I had already started translating those (and all others) in my main > branch, and didn't want to mess with that here. Next review request will be > such translation, isn't that better? > > By the

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

> On June 10, 2017, 4:26 p.m., Laurent Montel wrote: > > > > Paulo Lieuthier wrote: > I had already started translating those (and all others) in my main > branch, and didn't want to mess with that here. Next review request will be > such translation, isn't that better? > > By the

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

> On June 10, 2017, 1:26 p.m., Laurent Montel wrote: > > I had already started translating those (and all others) in my main branch, and didn't want to mess with that here. Next review request will be such translation, isn't that better? By the way, I does it mean to "`kDebug(14308)`" (there

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103302 --- plugins/history/historyguiclient.cpp (line 30)

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103301 --- Looks good for me. @Montel if you do not see any obvious err

Review Request 130154: Re-enable XML-based history plugin, fix history file saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/ --- Review request for Kopete and Pali Rohár. Repository: kopete Descriptio