Re: KVM: x86: accessors for guest registers

2008-06-29 Thread Avi Kivity
Marcelo Tosatti wrote: - svm always caches registers, and all registers are dirty, since cache/decache is cheap Accurate regs_dirty information is useful for converting the emulator, so that you can do something like: emul_register_write(ctxt, reg, val) { if (!__test_and_set_bit(re

Re: [PATCH 2/3] Fix time drift problem under high load when PIT is in use.

2008-06-29 Thread Dor Laor
On Sun, 2008-06-29 at 16:59 +0300, Gleb Natapov wrote: > Count the number of interrupts that was lost due to interrupt coalescing > and re-inject them back when possible. This fixes time drift problem when > pit is used as a time source. > > Signed-off-by: Gleb Natapov <[EMAIL PROTECTED]> > --- >

Re: KVM: x86: accessors for guest registers

2008-06-29 Thread Marcelo Tosatti
On Sun, Jun 29, 2008 at 04:14:37PM +0300, Avi Kivity wrote: > Marcelo Tosatti wrote: >> As suggested by Avi, introduce accessors to read/write guest registers. >> This simplifies the ->cache_regs/->decache_regs interface, and improves >> register caching which is important for VMX, where the cost o

[PATCH] Re: kvm: unable to handle kernel NULL pointer dereference

2008-06-29 Thread Tobias Diedrich
Tobias Diedrich wrote: > Chris Wright wrote: > > * Tobias Diedrich ([EMAIL PROTECTED]) wrote: > > > PM: Creating hibernation image: > > > PM: Need to copy 126181 pages > > > PM: Normal pages needed: 126181 + 1024 + 38, available pages: 397721 > > > x86 PAT enabled: cpu 0, old 0x7040600070406, new

Re: kvm: unable to handle kernel NULL pointer dereference

2008-06-29 Thread Tobias Diedrich
Chris Wright wrote: > * Tobias Diedrich ([EMAIL PROTECTED]) wrote: > > PM: Creating hibernation image: > > PM: Need to copy 126181 pages > > PM: Normal pages needed: 126181 + 1024 + 38, available pages: 397721 > > x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > > svm_cpu_init: s

Re: another kvm-70 compile bug with rhel/centos 5.2

2008-06-29 Thread Avi Kivity
Farkas Levente wrote: Avi Kivity wrote: Farkas Levente wrote: hi, i'm just try to recompile kvm-70 with the latest centos-5.2 (aka rhel-5.2) kernel, but i've got a new compile error: error: redefinition of typedef 'bool' Please try the attached patch, and let me know if it helps. FYI: /

Re: another kvm-70 compile bug with rhel/centos 5.2

2008-06-29 Thread Farkas Levente
Avi Kivity wrote: Farkas Levente wrote: hi, i'm just try to recompile kvm-70 with the latest centos-5.2 (aka rhel-5.2) kernel, but i've got a new compile error: error: redefinition of typedef 'bool' Please try the attached patch, and let me know if it helps. FYI: /lib/modules/2.6.18-92.1

Re: another kvm-70 compile bug with rhel/centos 5.2

2008-06-29 Thread Farkas Levente
Avi Kivity wrote: Farkas Levente wrote: hi, i'm just try to recompile kvm-70 with the latest centos-5.2 (aka rhel-5.2) kernel, but i've got a new compile error: error: redefinition of typedef 'bool' Please try the attached patch, and let me know if it helps. not working on centos-5.2: ---

[ kvm-Bugs-2005957 ] TAP networking stalls on large file transfers

2008-06-29 Thread SourceForge.net
Bugs item #2005957, was opened at 2008-06-29 19:12 Message generated for change (Comment added) made by andyz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2005957&group_id=180599 Please note that this message will contain a full copy of the comment thr

Re: another kvm-70 compile bug with rhel/centos 5.2

2008-06-29 Thread Avi Kivity
Farkas Levente wrote: hi, i'm just try to recompile kvm-70 with the latest centos-5.2 (aka rhel-5.2) kernel, but i've got a new compile error: error: redefinition of typedef 'bool' Please try the attached patch, and let me know if it helps. -- error compiling committee.c: too many arguments

[ kvm-Bugs-1872252 ] 64-bit windows no longer booting with -no-kvm

2008-06-29 Thread SourceForge.net
Bugs item #1872252, was opened at 2008-01-15 19:17 Message generated for change (Comment added) made by avik You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1872252&group_id=180599 Please note that this message will contain a full copy of the comment thre

[ kvm-Bugs-2005957 ] TAP networking stalls on large file transfers

2008-06-29 Thread SourceForge.net
Bugs item #2005957, was opened at 2008-06-29 19:12 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2005957&group_id=180599 Please note that this message will contain a full copy

[PATCH 3/3] Fix time drift problem under high load when RTC is in use.

2008-06-29 Thread Gleb Natapov
Count the number of interrupts that was lost due to interrupt coalescing and re-inject them back when possible. This fixes time drift problem when RTC is used as a time source. Signed-off-by: Gleb Natapov <[EMAIL PROTECTED]> --- hw/mc146818rtc.c | 11 +-- 1 files changed, 9 insertions(

[PATCH 1/3] Change qemu_set_irq() to return status information.

2008-06-29 Thread Gleb Natapov
The return value is less then zero if interrupt is masked, zero if it is known that interrupt is lost (due to coalescing) or greater then zero if interrupt is delivered or was successfully queued for delivery by interrupt controller. Device emulation can use this info as it pleases. Included patch

[PATCH 2/3] Fix time drift problem under high load when PIT is in use.

2008-06-29 Thread Gleb Natapov
Count the number of interrupts that was lost due to interrupt coalescing and re-inject them back when possible. This fixes time drift problem when pit is used as a time source. Signed-off-by: Gleb Natapov <[EMAIL PROTECTED]> --- hw/i8254.c | 20 +++- 1 files changed, 19 inserti

[PATCH 0/3] Fix guest time drift under heavy load.

2008-06-29 Thread Gleb Natapov
Resending one more time. There was no response last time I've sent it. Qemu device emulation for timers might be inaccurate and causes coalescing of several IRQs into one. It happens when the load on the host is high and the guest did not manage to ack the previous IRQ. The first patch in the seri

Re: [PATCH 0 of 4] [kvm-userspace][test] consolidate test libs to libcflat

2008-06-29 Thread Avi Kivity
Avi Kivity wrote: Jerone Young wrote: This set of patches are to consolidate test libraries into a single library archive. This lib archive is libcflat. This will allow common code to be shared among archs. Applied all, thanks. I squashed together 1-3 as Hollis suggested, and with git'

Re: KVM: x86: accessors for guest registers

2008-06-29 Thread Avi Kivity
Marcelo Tosatti wrote: As suggested by Avi, introduce accessors to read/write guest registers. This simplifies the ->cache_regs/->decache_regs interface, and improves register caching which is important for VMX, where the cost of vmcs_read/vmcs_write is significant. I made some changes, whic

Re: [PATCH 0/4] kvm-s390 patches for 2.6.27

2008-06-29 Thread Avi Kivity
Carsten Otte wrote: Hi Avi, now that we're moving closer to the merge window, please look at the following patches. I'd love to see them in 2.6.27. There is no need to hurry any of these into 2.6.26 because our console patches are waiting for the merge window in Rustys queue too, which makes .26

Re: [PATCH] configure: remove configure warning against not using gcc3

2008-06-29 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: On Wed, Jun 25, 2008 at 02:56:58PM +0300, Avi Kivity wrote: Carlo Marcelo Arenas Belon wrote: @@ -28,8 +28,6 @@ usage() { Any additional option is given to qemu's configure verbatim; including: - --disable-gcc-checkdon't insist on gc

Re: KVM: x86: move vapic page handling out of fast path

2008-06-29 Thread Avi Kivity
Marcelo Tosatti wrote: On Mon, Jun 23, 2008 at 05:29:34AM +0300, Avi Kivity wrote: The page can't be swapped out since its reference count is elevated indefinitely. AFAICT the page can be swapped out when the guest has exited to userspace and the only reference is the qemu userspace m

Re: [PATCH 2 of 3] Move KVM TRACE DEFINITIONS to common header

2008-06-29 Thread Avi Kivity
Jerone Young wrote: 3 files changed, 40 insertions(+), 40 deletions(-) include/asm-x86/kvm.h | 22 -- include/asm-x86/kvm_host.h | 18 -- include/linux/kvm_host.h | 40 This patch moves moves definitions requ

Re: KVM: pvmmu breakage with gcc 4.3.0

2008-06-29 Thread Avi Kivity
Christian Borntraeger wrote: Am Donnerstag, 26. Juni 2008 schrieb Avi Kivity: I don't think "p" should force the contents into memory? Perhaps "m"(*(char *)buffer)? Anthony, I don't see why a memory clobber would tell gcc that the variables is actually used. The problem is with the void

Re: [PATCH] KVM: VMX: Add ept_sync_context in flush_tlb

2008-06-29 Thread Avi Kivity
Yang, Sheng wrote: On Wednesday 25 June 2008 20:02:17 Avi Kivity wrote: Yang, Sheng wrote: From 54dc26e44f1c0aa460bef409b799f36dae56a911 Mon Sep 17 00:00:00 2001 From: Sheng Yang <[EMAIL PROTECTED]> Date: Wed, 18 Jun 2008 11:23:13 +0800 Subject: [PATCH] KVM: VMX: Add ept_sync_context in

Re: [GIT PULL] KVM fixes for 2.6.26-rc7

2008-06-29 Thread Avi Kivity
Soren Hansen wrote: On Thu, Jun 26, 2008 at 03:52:47PM +0300, Avi Kivity wrote: The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX. That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compat

Re: [PATCH] Avoid fragment virtio-blk transfers by copying

2008-06-29 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: A major source of performance loss for virtio-blk has been the fact that we split transfers into multiple requests. This is particularly harmful if you have striped storage beneath your virtual machine. This patch copies the re

Re: [PATCH] Avoid fragment virtio-blk transfers by copying

2008-06-29 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Jun 25, 2008 at 01:44:35PM +0300, Avi Kivity wrote: Anthony Liguori wrote: A major source of performance loss for virtio-blk has been the fact that we split transfers into multiple requests. This is particularly harmful if you have striped storage beneath

Re: [PATCH][REPOST]: Fake emulate Intel perfctr MSRs

2008-06-29 Thread Avi Kivity
Chris Lalancette wrote: Respin of my previous patch to fake emulate the Intel perfctr MSRs. As Sheng Yang pointed out, I didn't need an additional include, and I could use other #define's. Applied, thanks. Sorry about the delay. -- error compiling committee.c: too many arguments to funct

Re: nfsroot stays 'readonly'

2008-06-29 Thread Avi Kivity
Louis-David Mitterrand wrote: Hi, To provide an emergency off-site backup server for a client, I'm trying to use kvm on a nightly rsync'ed copy of their server. To avoid the use of a disk image I was advised to try nfsroot. This the command I am running: # kvm -nographic -hda ~/empty.qcow2

Re: another kvm-70 compile bug with rhel/centos 5.2

2008-06-29 Thread Avi Kivity
Farkas Levente wrote: anyone like to fix it? Don't worry, we'll get it fixed. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [PATCH 0 of 4] [kvm-userspace][test] consolidate test libs to libcflat

2008-06-29 Thread Avi Kivity
Jerone Young wrote: This set of patches are to consolidate test libraries into a single library archive. This lib archive is libcflat. This will allow common code to be shared among archs. Applied all, thanks. I squashed together 1-3 as Hollis suggested, and with git's rename detection,

Re: [GIT PULL] KVM fixes for 2.6.26-rc7

2008-06-29 Thread Avi Kivity
Soren Hansen wrote: On Thu, Jun 26, 2008 at 03:52:47PM +0300, Avi Kivity wrote: The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX. That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compat

Re: KVM: pvmmu breakage with gcc 4.3.0

2008-06-29 Thread Avi Kivity
Alexandre Oliva wrote: I thought a better approach was to have __pa do something along the lines of ({ char *__buf = (char*)buffer; asm ("" : : "o"(*__buf)); ... }) to make it clear that physical addresses are used. I agree, I think such a patch is important for future-proofing Linux a