Re: [PATCH 8/15 v5] PCI: add boot options to reassign resources

2008-10-22 Thread Ingo Molnar
* Yu Zhao [EMAIL PROTECTED] wrote: +static char *pci_assign_pio; +static char *pci_assign_mmio; + +static int pcibios_bus_resource_needs_fixup(struct pci_bus *bus) +{ + int i; + int type = 0; + int domain, busnr; + + if (!bus-self) + return 0; + + for

[PATCH 1/1] KVM: Use set_bit for userspace irq source init

2008-10-22 Thread Sheng Yang
Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- arch/ia64/kvm/kvm-ia64.c |2 +- arch/x86/kvm/x86.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/kvm/kvm-ia64.c b/arch/ia64/kvm/kvm-ia64.c index a40223f..c25c75b 100644 --- a/arch/ia64/kvm/kvm-ia64.c

[PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-10-22 Thread Yu Zhao
Greetings, Following patches are intended to support SR-IOV capability in the Linux kernel. With these patches, people can turn a PCI device with the capability into multiple ones from software perspective, which will benefit KVM and achieve other purposes such as QoS, security, and etc. Changes

[PATCH 14/16 v6] PCI: document for SR-IOV user and developer

2008-10-22 Thread Yu Zhao
Create HOW-TO for SR-IOV user and driver developer. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL PROTECTED] Cc:

[PATCH 4/16 v6] PCI: make pci_alloc_child_bus() be able to handle NULL bridge

2008-10-22 Thread Yu Zhao
Make pci_alloc_child_bus() be able to allocate buses without bridge devices. Some SR-IOV devices can occupy more than one bus number, but there is no explicit bridges because that have internal routing mechanism. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH

[PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-10-22 Thread Yu Zhao
Document the new PCI[x86] boot parameters. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL PROTECTED] Cc: Roland

[PATCH 9/16 v6] PCI: add boot option to align MMIO resources

2008-10-22 Thread Yu Zhao
This patch adds boot option to align MMIO resource for a device. The alignment is a bigger value between the PAGE_SIZE and the resource size. The boot option can be used as: pci=align-mmio=:01:02.3 '[:]01:02.3' is the domain, bus, device and function number of the device. Cc:

[PATCH 15/16 v6] PCI: document the SR-IOV sysfs entries

2008-10-22 Thread Yu Zhao
Document the SR-IOV sysfs entries. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL PROTECTED] Cc: Roland Dreier

[PATCH 10/16 v6] PCI: cleanup pci_bus_add_devices()

2008-10-22 Thread Yu Zhao
This cleanup makes pci_bus_add_devices() easier to read. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL

Re: [PATCH 1/1] KVM: Use set_bit for userspace irq source init

2008-10-22 Thread Avi Kivity
Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs - v2

2008-10-22 Thread Avi Kivity
Jan Kiszka wrote: [ taking Sheng's comments into account ] The logic of kvm_apic_accept_pic_intr has a minor, practically hardly relevant incorrectness: PIC interrupts are still delivered even if the APIC of VPU0 (BSP) is disabled. This does not comply with the Virtual Wire mode according to

Re: [PATCH 0/2] KVM: x86: Fix and optimize in-kernel NMI watchdog support - v2

2008-10-22 Thread Avi Kivity
Jan Kiszka wrote: This is a reworked version of the NMI watchdog fixes, taking the discussion with Sheng into account. There are two further (minor) issues I found in the APIC emulation at this chance, but those can be handled separately. Applied, thanks. -- error compiling committee.c:

Re: [PATCH 1/1] KVM: IRQ ACK notifier should be used with in-kernel irqchip

2008-10-22 Thread Avi Kivity
Sheng Yang wrote: Also remove unnecessary parameter of unregister irq ack notifier. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] x86 emulator: Add a Src2 decode set and SrcOne operand type

2008-10-22 Thread Avi Kivity
Guillaume Thouvenin wrote: Instruction like shld has three operands, so we need to add a Src2 decode set. We start with Src2None, Src2CL, and Src2Imm8 to support shld and we will expand it later. Operand type of Src2 are placed at the end of the set to avoid renumbering. For Src2CL we mask to a

Re: [PATCH] kvm: fix unifdef problem

2008-10-22 Thread Avi Kivity
Sheng Yang wrote: Reminder by Avi, unifdef need a -U parameter to deal undefined macro, other wise it can't deal with #if defined() || defined(). Also fix a historic bug on never execute unifdef... Also discard set -e before unifdef, because unifdef would return 1 if it have done something to

Re: [PATCH] kvm/ia64: Code cleanup for Linux- 2.6.28.

2008-10-22 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi Could you help to queue this patch for 2.6.28? It has no any logic changes, and just re-organizes the structure of vm data area to allow users to configure large memory and more vcpus. Since it changes many in header files, so it had better go into rc1. Thanks!

Re: [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu 0).

2008-10-22 Thread Avi Kivity
Zhang, Xiantao wrote: Before Aps going to block status, it should make sure SIGINT is masked, otherwise, it may eat SIGINT from user killing the guest, and results in Qemu hanging there, becasue main thread can't get it to free guest's resource. diff --git a/arch/ia64/kvm/kvm-ia64.c

Re: [PATCH] x86 emulator: Add decode entries for 0x04 and 0x05 opcodes

2008-10-22 Thread Avi Kivity
Guillaume Thouvenin wrote: Add decode entries for 0x04 and 0x05 (ADD) opcodes, execution is already implemented. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH] kvm testsuite: Add test for 'add imm' instruction

2008-10-22 Thread Avi Kivity
Guillaume Thouvenin wrote: Add 'add' instruction test when source operand is an immediate (opcode 0x04 and 0x05) in real mode test harness. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in

[PATCH 12/16 v6] PCI: support the SR-IOV capability

2008-10-22 Thread Yu Zhao
Support Single Root I/O Virtualization (SR-IOV) capability. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL

[PATCH 7/16 v6] PCI: cleanup pcibios_allocate_resources()

2008-10-22 Thread Yu Zhao
This cleanup makes pcibios_allocate_resources() easier to read. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL

[PATCH 8/16 v6] PCI: add boot options to reassign resources

2008-10-22 Thread Yu Zhao
This patch adds boot options so user can reassign device resources of all devices under a bus. The boot options can be used as: pci=assign-mmio=:01,assign-pio=:02 '[:]bb' is the domain and bus number. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc:

[PATCH 11/16 v6] PCI: split a new function from pci_bus_add_devices()

2008-10-22 Thread Yu Zhao
This patch splits a new function from pci_bus_add_devices(). The new function can be used to register PCI bus to the device core and create its sysfs entries. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc:

fedora's latest kernel no longer boot

2008-10-22 Thread Farkas Levente
hi, the latest fedora kernel-2.6.26.5-45.fc9.i686 no longer boot as guests ie. stops at: Loading ehci-hcd module. while if i switch back to the kernel-2.6.25.14-108.fc9.i686 it's boot without problem on an intel, rhel-5, kvm-77 host. yours. -- Levente Si vis pacem

[PATCH 13/16 v6] PCI: reserve bus range for SR-IOV device

2008-10-22 Thread Yu Zhao
Reserve bus range for SR-IOV at device scanning stage. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL PROTECTED]

[ kvm-Bugs-2171940 ] SCSI: Windows (XP) Full Format fails to complete on SCSI

2008-10-22 Thread SourceForge.net
Bugs item #2171940, was opened at 2008-10-16 16:59 Message generated for change (Comment added) made by lvivier You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2171940group_id=180599 Please note that this message will contain a full copy of the comment

Re: Handle INIT before SIPI.

2008-10-22 Thread Gleb Natapov
On Tue, Oct 21, 2008 at 10:34:12AM +0800, Xu, Dongxiao wrote: Hi, Gleb, It seems that this patch is x86 specific, and it breaks the IA-64 compilation. Do you have any good idea to solve this? Thanks! Solve this by ifdefs for now. For better solution cleanup of SMP handling is needed.

Re: [PATCH 2/16 v6] PCI: define PCI resource names in an 'enum'

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:40:41 am Yu Zhao wrote: This patch moves all definitions of the PCI resource names to an 'enum', and also replaces some hard-coded resource variables with symbol names. This change eases introduction of device specific resources. Thanks for removing a bunch of

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:45:31 am Yu Zhao wrote: Document the new PCI[x86] boot parameters. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox

Re: [PATCH 9/16 v6] PCI: add boot option to align MMIO resources

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:43:24 am Yu Zhao wrote: This patch adds boot option to align MMIO resource for a device. The alignment is a bigger value between the PAGE_SIZE and the resource size. It looks like this forces alignment on PAGE_SIZE, not a bigger value between the PAGE_SIZE and

Re: [PATCH 8/16 v6] PCI: add boot options to reassign resources

2008-10-22 Thread Yu Zhao
Bjorn Helgaas wrote: On Wednesday 22 October 2008 02:43:03 am Yu Zhao wrote: This patch adds boot options so user can reassign device resources of all devices under a bus. The boot options can be used as: pci=assign-mmio=:01,assign-pio=:02 '[:]bb' is the domain and bus

Re: [PATCH 9/16 v6] PCI: add boot option to align MMIO resources

2008-10-22 Thread Yu Zhao
Bjorn Helgaas wrote: On Wednesday 22 October 2008 02:43:24 am Yu Zhao wrote: This patch adds boot option to align MMIO resource for a device. The alignment is a bigger value between the PAGE_SIZE and the resource size. It looks like this forces alignment on PAGE_SIZE, not a bigger value

Re: [PATCH 2/16 v6] PCI: define PCI resource names in an 'enum'

2008-10-22 Thread Yu Zhao
Bjorn Helgaas wrote: On Wednesday 22 October 2008 08:44:24 am Yu Zhao wrote: Bjorn Helgaas wrote: On Wednesday 22 October 2008 02:40:41 am Yu Zhao wrote: This patch moves all definitions of the PCI resource names to an 'enum', and also replaces some hard-coded resource variables with symbol

[PATCH 3/3] virtio_net: support ethtool offload queries

2008-10-22 Thread Mark McLoughlin
Since 2.6.24, if get_tx_csum, get_sg or get_tso are NULL then the default ethtool_op_get_xxx functions are called. Before 2.6.24, however, these need to be manually hooked in. Signed-off-by: Mark McLoughlin [EMAIL PROTECTED] --- hack-module.awk |6 ++ 1 files changed, 6 insertions(+), 0

[PATCH 1/3] virtio_net: Fix leaked netdev-refcnt

2008-10-22 Thread Mark McLoughlin
If after receiving some packets and refilling the queue with buffers, we detect that more packets are available then we re-schedule the queue and process them. This re-scheduling - i.e. calling __netif_rx_schedule() - causes a netdev reference to be taken. Once we've finally run out of buffers

[PATCH 2/3] virtio_net: Make use of napi_weight module param

2008-10-22 Thread Mark McLoughlin
Currently, the napi_weight module param is ignored and we hardcode the weight to 16 since this commit: commit 85a8b9da078977c6198d434837c7d077669c9c54 Author: Anthony Liguori [EMAIL PROTECTED] Date: Sun Jan 6 21:37:01 2008 -0600 Make sure to set weight to 16 always.

[PATCH 0/3] Some kvm-guest-drivers-linux/virtio_net fixes

2008-10-22 Thread Mark McLoughlin
Hi Avi, Here's a few virtio_net fixes for kvm-guest-drivers-linux. Cheers, Mark. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs - v2

2008-10-22 Thread Jan Kiszka
Jan Kiszka wrote: Jan Kiszka wrote: Avi Kivity wrote: Jan Kiszka wrote: [ taking Sheng's comments into account ] The logic of kvm_apic_accept_pic_intr has a minor, practically hardly relevant incorrectness: PIC interrupts are still delivered even if the APIC of VPU0 (BSP) is disabled. This

Re: [PATCH] qemu: qemu_fopen_fd: differentiate between reader and writer user

2008-10-22 Thread Uri Lublin
hony Liguori wrote: Uri Lublin wrote: In the scenario above (with ACK/GO messages), SRC _does_ know that DST have failed (as it does not receive ACK). With ACK/GO messages we only need third party involvement to handle a scenario where GO does not reach DST. Without ACK/GO messages we need

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-10-22 Thread Randy Dunlap
Bjorn Helgaas wrote: On Wednesday 22 October 2008 02:45:31 am Yu Zhao wrote: Document the new PCI[x86] boot parameters. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED]

[PATCH 0/2] kvmtrace: Allow user to clean up stale trace setup

2008-10-22 Thread Eduardo Habkost
If kvmtrace crashes or gets killed while collecting trace data, stale trace setup information may be enabled on the kernel, and currently there is no way to force the previous trace setup to be overwritten or disabled. The following two patches against kvm-userspace will add a new command-line

[PATCH 1/2] Extract disable_trace() from cleanup_trace()

2008-10-22 Thread Eduardo Habkost
Extract the KVM_TRACE_DISABLE ioctl() call from cleanup_trace(), as other parts of the code will use it. Signed-off-by: Eduardo Habkost [EMAIL PROTECTED] --- user/kvmtrace.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/user/kvmtrace.c b/user/kvmtrace.c index

Re: [PATCH 0/2] kvmtrace: Allow user to clean up stale trace setup

2008-10-22 Thread Eduardo Habkost
On Wed, Oct 22, 2008 at 03:42:27PM -0200, Glauber Costa wrote: On Wed, Oct 22, 2008 at 3:35 PM, Eduardo Habkost [EMAIL PROTECTED] wrote: If kvmtrace crashes or gets killed while collecting trace data, stale trace setup information may be enabled on the kernel, and currently there is no way

[PATCH 2/2] kvmtrace: Add -f option to clean up existing trace setup

2008-10-22 Thread Eduardo Habkost
If kvmtrace crashes or gets killed while collecting trace data, stale trace setup information may be enabled, and currently there is no way to force the previous trace setup to be overwritten or disabled. The -f option will allow the user to forcibly clean up an existing trace setup before

Re: [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs - v2

2008-10-22 Thread Jan Kiszka
Jan Kiszka wrote: Jan Kiszka wrote: Jan Kiszka wrote: Avi Kivity wrote: Jan Kiszka wrote: [ taking Sheng's comments into account ] The logic of kvm_apic_accept_pic_intr has a minor, practically hardly relevant incorrectness: PIC interrupts are still delivered even if the APIC of VPU0

Re: [PATCH 0/2] kvm: disable virtualization on kdump

2008-10-22 Thread Simon Horman
On Mon, Oct 20, 2008 at 01:01:32PM -0200, Eduardo Habkost wrote: The following two patches should make kdump work when the kvm-intel module is loaded. We need to disable vmx mode before booting the kdump kernel, so I've introduced a notifier interface where KVM can hook and disable

RE: [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu 0).

2008-10-22 Thread Zhang, Xiantao
Avi Kivity wrote: Zhang, Xiantao wrote: Before Aps going to block status, it should make sure SIGINT is masked, otherwise, it may eat SIGINT from user killing the guest, and results in Qemu hanging there, becasue main thread can't get it to free guest's resource. diff --git

RE: [PATCH] kvm/ia64: Code cleanup for Linux- 2.6.28.

2008-10-22 Thread Zhang, Xiantao
Avi Kivity wrote: Zhang, Xiantao wrote: Hi, Avi Could you help to queue this patch for 2.6.28? It has no any logic changes, and just re-organizes the structure of vm data area to allow users to configure large memory and more vcpus. Since it changes many in header files, so it had better go

Re:[PATCH] kvm/ia64: Makefile fix for forcing to re-generate asm-offsets.h

2008-10-22 Thread Zhang, Xiantao
Hi, Avi Could you revert the commit d6f9e28239fd6ac6ace6e72b44c257ed3936fdd5 ? It should be an incorrect fix, and leads to fail to generate asm-offsets.h under some special configrations. It should be my fault, sorry! Please apply this one. Thanks! Xiantao From

Re: [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu 0).

2008-10-22 Thread Avi Kivity
Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Before Aps going to block status, it should make sure SIGINT is masked, otherwise, it may eat SIGINT from user killing the guest, and results in Qemu hanging there, becasue main thread can't get it to free guest's resource.