This patchset based on MSI patch which changed deliver method to irq routing.
Thanks.
--
Yang, Sheng
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Sheng Yang
---
include/linux/kvm_host.h |3 ++
virt/kvm/ioapic.c| 84 ---
virt/kvm/irq_comm.c | 89 -
3 files changed, 89 insertions(+), 87 deletions(-)
diff --git a/include/l
Prepared for reuse ioapic_redir_entry for MSI.
Signed-off-by: Sheng Yang
---
include/linux/kvm_types.h | 17 +
virt/kvm/ioapic.c |6 +++---
virt/kvm/ioapic.h | 17 +
3 files changed, 21 insertions(+), 19 deletions(-)
diff --git a/include/l
Would be used with bit ops, and would be easily extended if KVM_MAX_VCPUS is
increased.
Signed-off-by: Sheng Yang
---
arch/x86/kvm/lapic.c |8
virt/kvm/ioapic.c|4 ++--
virt/kvm/ioapic.h|4 ++--
virt/kvm/irq_comm.c |6 +++---
4 files changed, 11 insertions(+), 1
It's also convenient when we extend KVM supported vcpu number in the future.
Signed-off-by: Sheng Yang
---
arch/x86/kvm/lapic.c |7 ---
virt/kvm/ioapic.c| 24 +---
virt/kvm/irq_comm.c | 22 --
3 files changed, 29 insertions(+), 24 deletion
In order to use with bit ops.
Signed-off-by: Sheng Yang
---
virt/kvm/ioapic.c | 17 -
virt/kvm/ioapic.h |4 ++--
virt/kvm/irq_comm.c |5 +++--
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index 99d274c..6cb33
We have to handle more than one interrupt with one handler for MSI-X. So we
need a bitmap to track the triggered interrupts.
Signed-off-by: Sheng Yang
---
include/linux/kvm_host.h |5 +-
virt/kvm/kvm_main.c | 103 -
2 files changed, 103 inser
Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls.
This two ioctls are used by userspace to specific guest device MSI-X entry
number and correlate MSI-X entry with GSI during the initialization stage.
MSI-X should be well initialzed before enabling.
Don't support change MSI-X entry num
This patch finally enable MSI-X.
What we need for MSI-X:
1. Intercept one page in MMIO region of device. So that we can get guest desired
MSI-X table and set up the real one. Now this have been done by guest, and
transfer to kernel using ioctl KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY.
2. Informatio
Based on former patchset.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Sheng Yang
---
libkvm/libkvm.c | 98 ---
libkvm/libkvm.h | 22
2 files changed, 101 insertions(+), 19 deletions(-)
diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index 92ffe10..571506a 100644
--- a/libkvm/libkvm
Update using irq routing method.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Sheng Yang
---
qemu/hw/device-assignment.c | 20
1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index e6d2352..f14f971 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-as
Which is used later for capability detection.
Signed-off-by: Sheng Yang
---
qemu/Makefile.target |1 +
qemu/configure | 20
2 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/qemu/Makefile.target b/qemu/Makefile.target
index 2c7c0d5..28704ce 100644
-
This framework can be easily extended to support device capability, like
MSI/MSI-x.
Signed-off-by: Sheng Yang
---
qemu/hw/pci.c | 85 +
qemu/hw/pci.h | 30
2 files changed, 115 insertions(+), 0 deletions(-)
diff --
Try to figure out device capability in update_dev_cap(). Now we are only care
about MSI capability.
The function pci_find_cap_offset original function wrote by Allen for Xen.
Notice the function need root privilege to work. This depends on libpci to work.
Signed-off-by: Allen Kay
Signed-off-by:
Notice here is a simple solution, can be replaced later.
Signed-off-by: Sheng Yang
---
libkvm/kvm-common.h |1 +
libkvm/libkvm.c | 10 ++
libkvm/libkvm.h |8
3 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/libkvm/kvm-common.h b/libkvm/kvm-common
Signed-off-by: Sheng Yang
---
qemu/hw/device-assignment.c | 112 ---
qemu/hw/device-assignment.h |7 +++
2 files changed, 112 insertions(+), 7 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 76369ed..3ff8fde
Update from v2:
Change the interface to irq routing method.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Sheng Yang
---
qemu/hw/pci.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu/hw/pci.h b/qemu/hw/pci.h
index b6fc330..8466cf8 100644
--- a/qemu/hw/pci.h
+++ b/qemu/hw/pci.h
@@ -185,6 +185,7 @@ typedef struct PCIIORegion {
#define PCI_CAPABILITY_CONFIG
The most important part here, is we emulate a page of MMIO region using a
page of memory. That's because MSI-X table was put in the region and we have to
intercept it.
Signed-off-by: Sheng Yang
---
qemu/hw/device-assignment.c | 287 ++-
qemu/hw/device-ass
Signed-off-by: Sheng Yang
---
libkvm/libkvm.c | 25 +
libkvm/libkvm.h |7 +++
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index b4433bd..ef0066a 100644
--- a/libkvm/libkvm.c
+++ b/libkvm/libkvm.c
@@ -1342,3 +
Jamie Lokier schrieb:
> Although there are many ways to make Windows blue screen in KVM, in
> this case I've narrowed it down to the difference in
> qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83).
This must be one of SVN revisions 5003 to 5008 in upstream qemu. Can you
narrow it down to on
Bugs item #2584662, was opened at 2009-02-10 12:56
Message generated for change (Comment added) made by technologov
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2584662&group_id=180599
Please note that this message will contain a full copy of the comme
Bugs item #2545471, was opened at 2009-01-29 15:32
Message generated for change (Comment added) made by technologov
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2545471&group_id=180599
Please note that this message will contain a full copy of the comme
Kevin Wolf wrote:
> Jamie Lokier schrieb:
> > Although there are many ways to make Windows blue screen in KVM, in
> > this case I've narrowed it down to the difference in
> > qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83).
>
> This must be one of SVN revisions 5003 to 5008 in upstream qemu
Kevin Wolf wrote:
> Jamie Lokier schrieb:
> > Although there are many ways to make Windows blue screen in KVM, in
> > this case I've narrowed it down to the difference in
> > qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83).
>
> This must be one of SVN revisions 5003 to 5008 in upstream qemu
Hello,
My kvm processes are exiting on what I think are VIRTIO errors:
Guest moved used index from 24543 to 24606
1) Network specific settings:
I am required to hide the Mac address of the kvm guest, therefore I added
the following line in /etc/network/interface on the host:
up route add -ne
Jeremy Fitzhardinge wrote:
Yes. It seems however that only set_pte_at/pte_update/_defer are
used under significatly long lazy mmu sections (long as in number of
updates). Is it worthwhile to bother (and risk) batching kernel pte
updates ?
Well, that depends on how expensive each update is.
Marcelo Tosatti wrote:
This is better.
Currently, this code path is posing us big troubles,
and we won't have a decent patch in time. So, temporarily
disable it.
Applied to master and kvm-updates/2.6.29, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubs
Sheng Yang wrote:
Merge MSI userspace interface with IRQ routing table. Notice the API have been
changed, and using IRQ routing table would be the only interface kvm-userspace
supported.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from
Anthony Liguori wrote:
Yes, this would be IMHO the best overall solution. Can we take
kvm-userspace maint/2.6.29 and call it qemu-kvm-0.9.1-1? Most users
don't need newer kernel modules if they have a relatively recent distro.
Right, that's another advantage of split repos.
I wonder abo
Gleb Natapov wrote:
For STS register bit are cleared by writing 1 into it.
Applied all four, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More
Sheng Yang wrote:
Removed the unnecessary works.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kern
Han, Weidong wrote:
define KVM_CAP_DEVICE_DEASSIGNMENT and KVM_DEASSIGN_PCI_DEVICE
for device deassignment.
#ifdef KVM_CAP_IRQ_ROUTING
@@ -466,6 +469,8 @@ struct kvm_irq_routing {
#define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \
struct kvm_assigned_irq)
#define KVM_R
Jamie Lokier schrieb:
> Kevin Wolf wrote:
>> Jamie Lokier schrieb:
>>> Although there are many ways to make Windows blue screen in KVM, in
>>> this case I've narrowed it down to the difference in
>>> qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83).
>> This must be one of SVN revisions 5003 t
Sheng Yang wrote:
This patchset based on MSI patch which changed deliver method to irq routing.
Thanks.
Looks good to me, will apply if further review doesn't generate comments.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line
Sheng Yang wrote:
Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls.
This two ioctls are used by userspace to specific guest device MSI-X entry
number and correlate MSI-X entry with GSI during the initialization stage.
MSI-X should be well initialzed before enabling.
Don't support ch
Sheng Yang wrote:
This patch finally enable MSI-X.
What we need for MSI-X:
1. Intercept one page in MMIO region of device. So that we can get guest desired
MSI-X table and set up the real one. Now this have been done by guest, and
transfer to kernel using ioctl KVM_SET_MSIX_NR and KVM_SET_MSIX_E
Avi Kivity wrote:
Anthony Liguori wrote:
Yes, this would be IMHO the best overall solution. Can we take
kvm-userspace maint/2.6.29 and call it qemu-kvm-0.9.1-1? Most users
don't need newer kernel modules if they have a relatively recent distro.
Right, that's another advantage of split r
Marcelo Tosatti wrote:
On Sun, Feb 08, 2009 at 04:08:56AM -0200, Marcelo Tosatti wrote:
On Wed, Feb 04, 2009 at 05:52:04PM +0100, Gerd Hoffmann wrote:
Hi folks,
kvmclock currently falls apart on machines without constant tsc.
This patch fixes it. Changes:
* keep tsc frequency in
Anthony Liguori wrote:
I wonder about splitting the ordinary kvm-xx releases? It means
doubling the download/build/install cycle, but it will increase
similarity to the stable releases.
I was going to suggest that to but then wanted to avoid complicating
things. I think it's the right mod
Bill Davidsen wrote:
> Farkas Levente wrote:
>> hi,
>> with kvm-83 on a
>> - host:
>> - Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz
>> - Intel S3000AHV
>> - 8GB RAM
>> - CentOS-5.2
>> - kernel-2.6.18-92.1.22.el5 x86_64 64bit
>> fedora-10 i386 install hang at :
>>
This is a known issue.
See:
https://bugzilla.redhat.com/show_bug.cgi?id=475598
--
-Alexey Eromenko "Technologov"
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.h
On Tue, 2009-02-10 at 14:29 -0700, Alex Williamson wrote:
> Make use of qemu_vlan_rxfilter so that we can filter at a lower
> level. We implement callbacks for devices being added and removed
> so that we can fall back to our own filtering or make another attempt
> to push filtering off to someone
Newer gcc versions support a R"..." construct, so we can't use
"abc"R"def" constructs without any space between R and the quotes,
when using -std=gnu99 (that is used by the user/test code).
This fixes this error:
test/x86/vmexit.c:34:26: error: invalid character ' ' in raw string
delimiter
Kevin Wolf wrote:
> Besides reviewing the code over and over again, I think the only real
> chance is that you can get a non-productive copy of your image and add
> some debug code so that we can see at least which code path is causing
> problems.
I have a copy of my image to reproduce the bug, so
Avi Kivity wrote:
Jeremy Fitzhardinge wrote:
Yes. It seems however that only set_pte_at/pte_update/_defer are
used under significatly long lazy mmu sections (long as in number of
updates). Is it worthwhile to bother (and risk) batching kernel pte
updates ?
Well, that depends on how expens
Make use of qemu_vlan_rxfilter so that we can filter at a lower
level. We implement callbacks for devices being added and removed
so that we can fall back to our own filtering or make another attempt
to push filtering off to someone else.
Signed-off-by: Alex Williamson
---
Updated to address e1
On Sun, Jan 18, 2009 at 12:17:29PM +0800, Yu Zhao wrote:
> +/**
> + * pci_ats_qdep - query ATS invalidate queue depth
> + * @dev: the PCI device
> + *
> + * Returns the queue depth on success, or 0 on error.
> + */
> +int pci_ats_qdep(struct pci_dev *dev)
> +{
> + int pos;
> + u16 cap;
> +
On Tuesday, February 10, 2009 3:32 am David Woodhouse wrote:
> On Sun, 2009-01-18 at 12:17 +0800, Yu Zhao wrote:
> > The ATS spec can be found at
> > http://www.pcisig.com/specifications/iov/ats/ (it requires membership).
> >
> > Signed-off-by: Yu Zhao
>
> If I can have an ack from Jesse for the P
On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote:
> define KVM_CAP_DEVICE_DEASSIGNMENT and KVM_DEASSIGN_PCI_DEVICE
> for device deassignment.
Should add a pointer to the commit which added this ioctl:
commit 0a920356748df4fb06e86c21c23d2ed6d31d37ad
Author: Weidong Han
Date: Tue Dec
On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote:
> change from KERN_INFO to KERN_WARNING to prompt users when
> deassign an unassigned device
>
> Signed-off-by: Weidong Han
> ---
> virt/kvm/kvm_main.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/virt/kvm/
On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote:
> add this ioctl to deassign a device from guest
>
> Signed-off-by: Weidong Han
Looks fine.
Acked-by: Mark McLoughlin
Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@v
Hi Weidong,
In general, this looks like a good cleanup.
With deassign_device() fixed to only require assigned_dev_id, I would be
happy to ACK this whole patch.
However, it would be much, much easier to review the patch if you had
split it into multiple patches e.g.
1) Make init_assigned_devic
Hello,
I'd like to discuss an issue I'm having with KVM on a Windows XP guest.
The hosting system is a `x86_64 Intel(R) Core(TM)2 Duo CPU T7300 @
2.00GHz GenuineIntel' machine runing the latest (stable) kernel
release and KVM version 83.
The respecitve modules (kvm, kvm_intel) are loaded and in
Alexey Eremenko wrote:
> This is a known issue.
>
> See:
> https://bugzilla.redhat.com/show_bug.cgi?id=475598
>
thanks:-)
--
Levente "Si vis pacem para bellum!"
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord.
Hi Alex,
Just had a quick looked over these and they seem pretty good, but some
broad comments:
- The logic around "is this a NIC+TAP pair?" would be good to have a
better API around. We need this to merge virtio GSO support too.
Anthony had some ideas here.
- I think you could kee
Mark McLoughlin wrote:
Hi Alex,
Just had a quick looked over these and they seem pretty good, but some
broad comments:
- The logic around "is this a NIC+TAP pair?" would be good to have a
better API around. We need this to merge virtio GSO support too.
Anthony had some ideas here.
Bugs item #2545471, was opened at 2009-01-29 14:32
Message generated for change (Comment added) made by fadb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2545471&group_id=180599
Please note that this message will contain a full copy of the comment thre
Hi Mark,
Thanks for the comments.
On Wed, 2009-02-11 at 19:31 +, Mark McLoughlin wrote:
>
> - The logic around "is this a NIC+TAP pair?" would be good to have a
> better API around. We need this to merge virtio GSO support too.
> Anthony had some ideas here.
Ok, I'll see if I ca
* Mathieu Desnoyers wrote:
> Here is a new backtrace, taken with a huge amount of debugging active, which
> still
> points to an interrupt handler nested over kvm_mmu_pte_write as the culprit.
> It's
> weird that the kvm code gets called on my modest Pentium M laptop, which I
> think
> has
Hi,
On Wed, 2009-02-11 at 12:41 +0100, Phil Ten wrote:
> Hello,
>
> My kvm processes are exiting on what I think are VIRTIO errors:
>
> Guest moved used index from 24543 to 24606
This is very strange. The code in question is:
static int virtqueue_num_heads(VirtQueue *vq, unsigned int idx)
{
On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote:
> Marcelo Tosatti wrote:
> > This is better.
> >
> > Currently, this code path is posing us big troubles,
> > and we won't have a decent patch in time. So, temporarily
> > disable it.
> >
> >
>
> Applied to master and kvm-updates/2.6.29, th
Mathieu Desnoyers wrote:
* Ingo Molnar (mi...@elte.hu) wrote:
* Mathieu Desnoyers wrote:
Hi,
I've started experiencing freezes on my uniprocessor laptop with a
2.6.28.2/2.6.28.3 kernel with the LTTng patchset applied
(http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.
* Ingo Molnar (mi...@elte.hu) wrote:
>
> * Mathieu Desnoyers wrote:
>
> > Here is a new backtrace, taken with a huge amount of debugging active,
> > which still
> > points to an interrupt handler nested over kvm_mmu_pte_write as the
> > culprit. It's
> > weird that the kvm code gets called o
On Wed, Feb 11, 2009 at 08:50:38PM +0100, Ingo Molnar wrote:
>
> * Mathieu Desnoyers wrote:
>
> > Here is a new backtrace, taken with a huge amount of debugging active,
> > which still
> > points to an interrupt handler nested over kvm_mmu_pte_write as the
> > culprit. It's
> > weird that th
On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote:
> > - What do we need rxfilter=on|off on the command line for?
>
> Primarily because the current tun driver in Linux has a bug that it can
> drop unicast packets requested to be included in the filter if it
> overflows the exact match tab
On Wed, 2009-02-11 at 20:19 +, Mark McLoughlin wrote:
> On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote:
> > > - What do we need rxfilter=on|off on the command line for?
> >
> > Primarily because the current tun driver in Linux has a bug that it can
> > drop unicast packets requeste
On Mon, Feb 02, 2009 at 04:23:40PM +0200, Avi Kivity wrote:
> Gleb Natapov wrote:
>> On Mon, Feb 02, 2009 at 04:04:55PM +0200, Avi Kivity wrote:
>>
>>> Gleb Natapov wrote:
>>>
> Right, I was thinking about
>
> if (irq >= 0 && irq < IOAPIC_NUM_PINS) {
>
> Should return
On Wed, Feb 11, 2009 at 08:08:23PM +, Mark McLoughlin wrote:
> On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote:
> > Marcelo Tosatti wrote:
> > > This is better.
> > >
> > > Currently, this code path is posing us big troubles,
> > > and we won't have a decent patch in time. So, temporarily
>
Skip the test which checks if the PIT is properly routed when
using the IOAPIC, aimed at buggy hardware.
Signed-off-by: Marcelo Tosatti
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 478bca9..eecfc92 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -27,6 +27,7
* Gleb Natapov (g...@redhat.com) wrote:
> --- a/qemu/hw/pci.c
> +++ b/qemu/hw/pci.c
> @@ -213,7 +213,7 @@ static void pci_unregister_io_regions(PCIDevice *pci_dev)
>
> for(i = 0; i < PCI_NUM_REGIONS; i++) {
> r = &pci_dev->io_regions[i];
> -if (!r->size)
> +if (!r->s
* Mathieu Desnoyers (mathieu.desnoy...@polymtl.ca) wrote:
> * Ingo Molnar (mi...@elte.hu) wrote:
> >
> > * Mathieu Desnoyers wrote:
> >
> > > Here is a new backtrace, taken with a huge amount of debugging active,
> > > which still
> > > points to an interrupt handler nested over kvm_mmu_pte_wr
* Kevin Wolf (kw...@suse.de) wrote:
> I would suspect that simply having a 64 bit host isn't enough to trigger
> the problem. These patches were in for half a year now without anyone
> noticing such failure.
BTW, we've seen similar corruption, but not narrowed it down successfully as
it's been qui
On Wednesday 11 February 2009 20:48:55 Avi Kivity wrote:
> Sheng Yang wrote:
> > This patch finally enable MSI-X.
> >
> > What we need for MSI-X:
> > 1. Intercept one page in MMIO region of device. So that we can get guest
> > desired MSI-X table and set up the real one. Now this have been done by
On Wednesday 11 February 2009 20:44:57 Avi Kivity wrote:
> Sheng Yang wrote:
> > Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls.
> >
> > This two ioctls are used by userspace to specific guest device MSI-X
> > entry number and correlate MSI-X entry with GSI during the initialization
>
77 matches
Mail list logo
