Re: [PATCH 14/15] Move interrupt injection logic to x86.c

2009-04-14 Thread Gleb Natapov
Please use this one instead. Exactly as previous one, but with fixed checkpatch.pl problems. Signed-off-by: Gleb Natapov diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 057a612..f9eb9ac 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kv

Re: KVM crash on unusual PM->RM transition

2009-04-14 Thread Avi Kivity
H. Peter Anvin wrote: H. Peter Anvin wrote: The current test branch of Syslinux does PM->RM transition via a stub which can be located in high memory. This is correct and valid (x86 CPUs rely on this to boot): after clearing CR0.PE, CS.base retains its previous value until CS is reloaded by

AW: AW: AW: AW: KVM performance

2009-04-14 Thread BRAUN, Stefanie
Hello, the host runs on a Dual-Core AMD Opteron Processor. Does there exist a similar AMD parameter? Regard Stefanie -Ursprüngliche Nachricht- Von: Avi Kivity [mailto:a...@redhat.com] Gesendet: Samstag, 11. April 2009 18:19 An: BRAUN, Stefanie Cc: kvm@vger.kernel.org Betreff: Re: AW: AW:

Re: AW: AW: AW: AW: KVM performance

2009-04-14 Thread Avi Kivity
BRAUN, Stefanie wrote: Hello, the host runs on a Dual-Core AMD Opteron Processor. Does there exist a similar AMD parameter? You can add individual host cpu features by using '-cpu qemu64,+feature', where feature is taken from the host /proc/cpuinfo. Do you know which cpu features the prog

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread Avi Kivity
Glauber Costa wrote: we currently unblock shadow interrupt state when we skip an instruction, but failing to do so when we actually emulate one. This blocks interrupts in key instruction blocks, in particular sti; hlt; sequences If the instruction emulated is an sti, we have to block shadow inte

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread Gleb Natapov
On Mon, Apr 13, 2009 at 04:06:50PM -0400, Glauber Costa wrote: > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 3fc4623..0db1be7 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -513,6 +513,7 @@ struct kvm_x86_ops {

Re: [PATCH] Add MCE support to KVM

2009-04-14 Thread Avi Kivity
Huang Ying wrote: I'm okay with an ioctl to setup MCE, but just make sure userspace has all the information to know what the kernel can do rather than the try-and-see-if-it-works approach. We can publish this information via KVM_CAP things, or via another ioctl (see KVM_GET_SUPPORTED_CPUID2 fo

Re: kvm 84 update

2009-04-14 Thread Armindo Silva
On Tue, Apr 14, 2009 at 12:40 AM, Charles Duffy wrote: > Armindo Silva wrote: >> >> There are a few glitches/problems with this version (at least using >> win2k3 server as guest). The problems with the vnc window only >> disappear when i create a new guest, with the old ones the mouse is >> still

[ kvm-Bugs-2761920 ] 64-bit smp RHEL5.3 call trace after Live Migration

2009-04-14 Thread SourceForge.net
Bugs item #2761920, was opened at 2009-04-14 06:10 Message generated for change (Tracker Item Submitted) made by jiajun You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2761920&group_id=180599 Please note that this message will contain a full copy of the c

Biweekly KVM Test report, kernel e3dbe3... userspace ee8b55...

2009-04-14 Thread Xu, Jiajun
Hi All, This is our Weekly KVM Testing Report against lastest kvm.git e3dbe3f408a46a045012f1882e9f62b27b8a616c and kvm-userspace.git ee8b55cb06c3fa996392a69983b0fe4d77343dc3. LTP diotest is found has performance downgrade issue. And 64-bit SMP RHEL5.3 guest meets call trace after Live Migration.

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Dmitry Eremin-Solenikov
Gleb Natapov wrote: > Start to use interrupt/exception queues like VMX does. This also fix the > bug that if exit was caused by a guest internal exception access to IDT > the exception was not reinjected. This patch broke KVM for me: after it is applied (to the tip of avi's git tree), linux insid

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: > Gleb Natapov wrote: > > > Start to use interrupt/exception queues like VMX does. This also fix the > > bug that if exit was caused by a guest internal exception access to IDT > > the exception was not reinjected. > > This

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Dmitry Eremin-Solenikov
2009/4/14 Gleb Natapov : > On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: >> Gleb Natapov wrote: >> >> > Start to use interrupt/exception queues like VMX does. This also fix the >> > bug that if exit was caused by a guest internal exception access to IDT >> > the exception

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 06:32:29PM +0400, Dmitry Eremin-Solenikov wrote: > 2009/4/14 Gleb Natapov : > > On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: > >> Gleb Natapov wrote: > >> > >> > Start to use interrupt/exception queues like VMX does. This also fix the > >> > bug t

Re: [PATCH 00/15] interrupt injection rework

2009-04-14 Thread Joerg Roedel
Hi Gleb, I am just curious, have you given these patches some stress testing with all kinds of Windows guests? To my experience they break very fast if something is wrong with interrupts ;) Joerg On Mon, Apr 13, 2009 at 12:55:30PM +0300, Gleb Natapov wrote: > Hi, > > This patch series aims to c

Re: [PATCH 00/15] interrupt injection rework

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 05:33:49PM +0200, Joerg Roedel wrote: > Hi Gleb, > > I am just curious, have you given these patches some stress testing with all > kinds of Windows guests? To my experience they break very fast if something is > wrong with interrupts ;) > I tested VMX with windows XP/vist

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 05:55:36PM +0300, Gleb Natapov wrote: > > After applying the next patch (or the whole serie), I get the following > > messages > > during initramfs drivers probe: > > > > Clocksource tsc unstable (delta...) > > no cont in shutdown! > > floppy0: FDC access conflict! > > >

Re: KVM crash on unusual PM->RM transition

2009-04-14 Thread H. Peter Anvin
Avi Kivity wrote: >> >> It looks like KVM will simply crash when it runs into a real-mode state >> it can't approximate with V86 mode. I guess I had the failed notion >> that it would kick back such "impossible" states to Qemu. > > Exactly. There's the emulate_invalid_guest_state module paramete

Re: KVM crash on unusual PM->RM transition

2009-04-14 Thread Avi Kivity
H. Peter Anvin wrote: Any reason to not make use of Qemu in userspace, rather than relying on the in-kernel interpreter for these? The kernel interpreter is obviously The Right Thing to avoid frequent ping-pong into the kernel, but it seems to me that such a potential "long-term" situation might

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread H. Peter Anvin
Avi Kivity wrote: > > The comment about repeating 'mov ss' in the manual has that wonderful > word in it, May. That means we're perfectly allowed to ignore it and > just set the flag unconditionally. > Realistically, though, this should only be done for a limited number of sequential instructio

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Avi Kivity
Gleb Natapov wrote: On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: Gleb Natapov wrote: Start to use interrupt/exception queues like VMX does. This also fix the bug that if exit was caused by a guest internal exception access to IDT the exception was not reinje

Re: KVM crash on unusual PM->RM transition

2009-04-14 Thread H. Peter Anvin
Avi Kivity wrote: > > - qemu doesn't do smp. > It certainly claims to. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread Avi Kivity
H. Peter Anvin wrote: Avi Kivity wrote: The comment about repeating 'mov ss' in the manual has that wonderful word in it, May. That means we're perfectly allowed to ignore it and just set the flag unconditionally. Realistically, though, this should only be done for a limited number o

Re: KVM crash on unusual PM->RM transition

2009-04-14 Thread Avi Kivity
H. Peter Anvin wrote: Avi Kivity wrote: - qemu doesn't do smp. It certainly claims to. Sorry, not specific enough: it doesn't do real SMP. Atomic instructions are translated as multiple, non-atomic instructions, so you can't run tcg compiled code in parallel. If your host is

Re: KVM crash on unusual PM->RM transition

2009-04-14 Thread H. Peter Anvin
Avi Kivity wrote: > > Sorry, not specific enough: it doesn't do real SMP. Atomic instructions > are translated as multiple, non-atomic instructions, so you can't run > tcg compiled code in parallel. If your host is different than your > target, you have memory ordering issues as well. > > What

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 07:10:40PM +0300, Avi Kivity wrote: > Gleb Natapov wrote: >> On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: >> >>> Gleb Natapov wrote: >>> >>> Start to use interrupt/exception queues like VMX does. This also fix the bug that if exi

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread H. Peter Anvin
Avi Kivity wrote: > > Why do we care? The guest can only harm itself, and if it wants to > disable interrupts, it would be a lot easier for it to run a plain 'cli'. > > I guess it would be a problem if we emulated 'mov ss' for ordinary > userspace or vm86 mode, but we don't. > Well, the answer

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread Alan Cox
> Why? Do you see a guest filling all of memory with 'mov ss' and > expecting to break out of it via an interrupt? Well I did try mapping a page of move ss all through memory on real hardware long ago and seeing what happened on a 386 in real mode with DOSEMU. I was disappointed ;) -- To unsubs

Re: [PATCH] deal with interrupt shadow state for emulated instruction

2009-04-14 Thread H. Peter Anvin
Alan Cox wrote: Why? Do you see a guest filling all of memory with 'mov ss' and expecting to break out of it via an interrupt? Well I did try mapping a page of move ss all through memory on real hardware long ago and seeing what happened on a 386 in real mode with DOSEMU. I was disappointed ;)

RE: [patch 1/2] IA64: export smp_send_reschedule

2009-04-14 Thread Luck, Tony
I could do more than Ack it, I could apply it (since it is in arch/ia64. But "To be used by KVM" is a bit vague for a commit description. A bit more detail please. -Tony -Original Message- From: Zhang, Xiantao Sent: Monday, April 13, 2009 6:57 PM To: Marcelo Tosatti; kvm@vger.kernel.org

Re: kvm 84 update

2009-04-14 Thread Charles Duffy
Armindo Silva wrote: On Tue, Apr 14, 2009 at 12:40 AM, Charles Duffy wrote: What problems with the VNC window? The mouse is always out of sync. That's what -usbdevice tablet is for. Other problem is that all my guest lost their default network config - they all had static ips if i configur

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Dmitry Eremin-Solenikov
2009/4/14 Gleb Natapov : > On Tue, Apr 14, 2009 at 06:32:29PM +0400, Dmitry Eremin-Solenikov wrote: >> 2009/4/14 Gleb Natapov : >> > On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: >> >> Gleb Natapov wrote: >> >> >> >> > Start to use interrupt/exception queues like VMX does

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 11:29:49PM +0400, Dmitry Eremin-Solenikov wrote: > 2009/4/14 Gleb Natapov : > > On Tue, Apr 14, 2009 at 06:32:29PM +0400, Dmitry Eremin-Solenikov wrote: > >> 2009/4/14 Gleb Natapov : > >> > On Tue, Apr 14, 2009 at 02:14:04PM +, Dmitry Eremin-Solenikov wrote: > >> >> Gleb

Re: [ kvm-Bugs-2761920 ] 64-bit smp RHEL5.3 call trace after Live Migration

2009-04-14 Thread Gerrit Slomma
SourceForge.net sourceforge.net> writes: > > Bugs item #2761920, was opened at 2009-04-14 06:10 > Message generated for change (Tracker Item Submitted) made by jiajun > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2761920&; > group_id=180599 > (...

IA64: export smp_send_reschedule

2009-04-14 Thread Marcelo Tosatti
KVM will use smp_send_reschedule to force a cpu out of guest mode. Signed-off-by: Marcelo Tosatti Index: kvm/arch/ia64/kernel/smp.c === --- kvm.orig/arch/ia64/kernel/smp.c +++ kvm/arch/ia64/kernel/smp.c @@ -225,6 +225,7 @@ smp_send

Re: [PATCH 0/4] ksm - dynamic page sharing driver for linux v3

2009-04-14 Thread Andrew Morton
On Thu, 9 Apr 2009 06:58:37 +0300 Izik Eidus wrote: > KSM is a linux driver that allows dynamicly sharing identical memory > pages between one or more processes. Generally looks OK to me. But that doesn't mean much. We should rub bottles with words like "hugh" and "nick" on them to be sure.

Re: [PATCH 3/4] add replace_page(): change the page pte is pointing to.

2009-04-14 Thread Andrew Morton
On Thu, 9 Apr 2009 06:58:40 +0300 Izik Eidus wrote: > replace_page() allow changing the mapping of pte from one physical page > into diffrent physical page. At a high level, this is very similar to what page migration does. Yet this implementation shares nothing with the page migration code.

Re: [PATCH 4/4] add ksm kernel shared memory driver.

2009-04-14 Thread Andrew Morton
On Thu, 9 Apr 2009 06:58:41 +0300 Izik Eidus wrote: > Ksm is driver that allow merging identical pages between one or more > applications in way unvisible to the application that use it. > Pages that are merged are marked as readonly and are COWed when any > application try to change them. > >

[ kvm-Bugs-2763707 ] Soft lockup after migration in 64 bit SMP RHEL 5.3 guest

2009-04-14 Thread SourceForge.net
Bugs item #2763707, was opened at 2009-04-15 00:53 Message generated for change (Tracker Item Submitted) made by subhraveti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2763707&group_id=180599 Please note that this message will contain a full copy of t

Re: [ kvm-Bugs-2761920 ] 64-bit smp RHEL5.3 call trace after Live Migration

2009-04-14 Thread Dinesh Subhraveti
> I reported this issue before here: > > http://article.gmane.org/gmane.comp.emulators.kvm.devel/29833 > > and opened a bug-report here: > > https://bugzilla.redhat.com/show_bug.cgi?id=492688 > > but nobody cared up to now. > > This not only applies to a smp but also to a domain with only one

Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic.

2009-04-14 Thread Gleb Natapov
On Tue, Apr 14, 2009 at 10:41:03PM +0300, Gleb Natapov wrote: > > Guest: Debian lenny. Linux 2.6.26, Debian version (I can provide > > config or bzImage + initrd). > Yes please provide. Debian lenny (x86_64) is my default guest :) And I > just booted it fine on AMD barcelona CPU. What is you host