Hi all,
I've been working quite extensively with kvm on CentOS 5.3 lately.
If you are interested in the latest rpm of kvm-kmod-2.6.30-rc8,
qemu-kvm-0.10.5 and libvirt-0.6.4 you can temporary find them here:
http://update.nethesis.it/kvm/
I've had no problem so far using these packages.
Feedback i
Gerd Hoffmann wrote:
> On 06/09/09 16:51, Paul Brook wrote:
>> On Tuesday 09 June 2009, Han, Weidong wrote:
>>> Paul Brook wrote:
On Monday 08 June 2009, Weidong Han wrote:
> When hot remove an assigned device, segmentation fault was
> triggered by qemu_free(&pci_dev->qdev) in pci_unre
Avi Kivity wrote:
Not really. One thing, migration should transition the shadow
pagetables from large pages to small ones, maybe that bit is broken.
Maybe we're looking at a largepage spte and interpreting it as a
normal L2 spte, and interpreting a guest page as the L1 spt.
I tried to fin
Han, Weidong wrote:
-int pci_unregister_device(PCIDevice *pci_dev)
+int pci_unregister_device(PCIDevice *pci_dev, int assigned)
{
int ret = 0;
@@ -377,7 +377,11 @@ int pci_unregister_device(PCIDevice *pci_dev)
qemu_free_irqs(pci_dev->irq);
pci_irq_index--;
pci_dev->bus->
On 06/09/2009 05:44 PM, Michael Goldish wrote:
The test looks pretty nicely written. Comments:
1. Consider making all the cloned VMs use image snapshots:
curr_vm = vm1.clone()
curr_vm.get_params()["extra_params"] += " -snapshot"
I'm not sure it's a good idea to let all VMs use the same disk
On 06/09/2009 08:45 PM, Uri Lublin wrote:
On 06/09/2009 11:41 AM, Yolkfull Chow wrote:
Hi,
This test will boot VMs until one of them becomes unresponsive, and
records the maximum number of VMs successfully started.
Hello,
Some more comments (in addition to previous comments by others)
1.
Avi Kivity wrote:
> Han, Weidong wrote:
>>
>> -int pci_unregister_device(PCIDevice *pci_dev)
>> +int pci_unregister_device(PCIDevice *pci_dev, int assigned) {
>> int ret = 0;
>>
>> @@ -377,7 +377,11 @@ int pci_unregister_device(PCIDevice *pci_dev)
>> qemu_free_irqs(pci_dev->irq);
>>
Han, Weidong wrote:
I tried to find an easy and clean way to check it, but I found the members of
struct PCIDevice and DeviceState were not suitable for this checking, and qdev
is not pointer in struct PCIDevice.
Yes, of course. I applied the patch, thanks.
--
error compiling committee.c
On 06/10/09 10:31, Han, Weidong wrote:
Avi Kivity wrote:
Can you check pci_dev->qdev instead of assigned? A little less
ugly.
I tried to find an easy and clean way to check it, but I found the
members of struct PCIDevice and DeviceState were not suitable for
this checking, and qdev is not poi
Gerd Hoffmann wrote:
> On 06/10/09 10:31, Han, Weidong wrote:
>> Avi Kivity wrote:
>>> Can you check pci_dev->qdev instead of assigned? A little less
>>> ugly.
>>
>> I tried to find an easy and clean way to check it, but I found the
>> members of struct PCIDevice and DeviceState were not suitable
Huang Ying wrote:
Enclose do_machine_check with #ifdef CONFIG_X86_MCE.
Reported-by: Marcelo Tosatti
Signed-off-by: Huang Ying
Applied, thanks.
I would have preferred to select X86_MCE instead, but that doesn't do
anything (need to select X86_MCE_INTEL as well, and that becomes fragile)
On Wednesday 10 June 2009 05:30:09 Marcelo Tosatti wrote:
> >From the Intel docs:
>
> An EPT misconfiguration occurs when, in the course of translation
> a guest-physical address, the logical processor encounters an EPT
> paging-structure entry that contains an unsupported value.
>
> Handle this ev
Marcelo Tosatti wrote:
This way there is no need to add explicit checks in every
for_each_shadow_entry user.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
===
--- kvm.orig/arch/x86/kvm/mmu.c
+++ kvm/arch/x86/kvm/mmu
Marcelo Tosatti wrote:
Required by EPT misconfiguration handler.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
===
--- kvm.orig/arch/x86/kvm/mmu.c
+++ kvm/arch/x86/kvm/mmu.c
@@ -3013,6 +3013,26 @@ out:
retur
On Tue, Jun 09, 2009 at 10:51:23PM -0700, Sridhar Samudrala wrote:
>
> Unfortunately, this doesn't work for UDP without any changes.
> skb_segment() currently adds transport header to
> each segmented skb. But when we are using IP fragmentation, only the
> first fragment should include the UDP
Marcelo Tosatti wrote:
Disable usage of 2M pages if VMX_EPT_2MB_PAGE_BIT (bit 16) is clear
in MSR_IA32_VMX_EPT_VPID_CAP and EPT is enabled.
Index: kvm/virt/kvm/kvm_main.c
===
--- kvm.orig/virt/kvm/kvm_main.c
+++ kvm/virt/kvm/kvm_mai
Avi Kivity wrote:
Marcelo Tosatti wrote:
This way there is no need to add explicit checks in every
for_each_shadow_entry user.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
===
--- kvm.orig/arch/x86/kvm/mmu.c
+++ k
On Wed, Jun 10, 2009 at 12:19:42AM +0100, Paul Brook wrote:
> On Monday 25 May 2009, Michael S. Tsirkin wrote:
> > Add functions implementing MSI-X support. First user will be virtio-pci.
> > Note that platform must set a flag to declare MSI supported.
> > For PC this will be set by APIC.
>
> This
On Tue, Jun 09, 2009 at 02:11:14PM -0300, Glauber Costa wrote:
> On Fri, Jun 05, 2009 at 01:23:15PM +0300, Michael S. Tsirkin wrote:
> > Add routines to manage PCI capability list. First user will be MSI-X.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > hw/pci.c | 98
> > ++
On Tue, Jun 09, 2009 at 02:26:27PM -0300, Glauber Costa wrote:
> On Fri, Jun 05, 2009 at 01:23:31PM +0300, Michael S. Tsirkin wrote:
> > Add functions implementing MSI-X support. First user will be virtio-pci.
> > Note that platform must set a flag to declare MSI supported.
> > For PC this will be
On Tue, Jun 09, 2009 at 02:33:33PM -0300, Glauber Costa wrote:
> > env = cpu_single_env;
> > if (!env)
> > @@ -727,7 +762,6 @@ static void apic_mem_writel(void *opaque,
> > target_phys_addr_t addr, uint32_t val)
> > printf("APIC write: %08x = %08x\n", (uint32_t)addr, val);
> > #end
- "Yolkfull Chow" wrote:
> On 06/09/2009 05:44 PM, Michael Goldish wrote:
> > The test looks pretty nicely written. Comments:
> >
> > 1. Consider making all the cloned VMs use image snapshots:
> >
> > curr_vm = vm1.clone()
> > curr_vm.get_params()["extra_params"] += " -snapshot"
> >
> >
On Tue, Jun 09, 2009 at 02:36:21PM -0300, Glauber Costa wrote:
> On Fri, Jun 05, 2009 at 01:23:55PM +0300, Michael S. Tsirkin wrote:
> > Make it possible to resize PCI regions. This will be used by virtio
> > with MSI-X, where the region size depends on whether MSI-X is enabled,
> > and can change
On Tue, Jun 09, 2009 at 02:45:54PM -0300, Glauber Costa wrote:
> duplicated save config.
>
> > diff --git a/hw/virtio.h b/hw/virtio.h
> > index 04a3c3d..ce05517 100644
> > --- a/hw/virtio.h
> > +++ b/hw/virtio.h
> > @@ -72,6 +72,10 @@ typedef struct VirtQueueElement
> >
> > typedef struct {
> >
On 06/10/2009 06:03 PM, Michael Goldish wrote:
- "Yolkfull Chow" wrote:
On 06/09/2009 05:44 PM, Michael Goldish wrote:
The test looks pretty nicely written. Comments:
1. Consider making all the cloned VMs use image snapshots:
curr_vm = vm1.clone()
curr_vm.get_params()["extra_p
Just wondered... what version of qemu was this for, has it gotten anywhere, etc?
I've tried to apply these patches to 0.10.5, 0.10.0, 0.9.1 and the
current Git (as of June 10 2009) but none seem to include rombios.c or
vgabios.c :(
Thanks!
-dav7
--
To unsubscribe from this list: send the line "u
This is a package containing the kvm external module, based on the
2.6.30 series. kvm-kmod-2.6.30 contains the kvm code that is
present in Linux 2.6.30, except that it can run on older kernels.
It is a good companion to the qemu-kvm-0.10 series.
Note that performance and features will vary with
On Tue, Jun 09, 2009 at 02:36:21PM -0300, Glauber Costa wrote:
> On Fri, Jun 05, 2009 at 01:23:55PM +0300, Michael S. Tsirkin wrote:
> > Make it possible to resize PCI regions. This will be used by virtio
> > with MSI-X, where the region size depends on whether MSI-X is enabled,
> > and can change
Even better would be to use "/usr/bin/python2".
This is because future distros will include python3, which is incompatible with
python2 code.
"python" will be symlink of "python3".
-Alexey
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@v
A minor fix to the pte accessors, followed by a cosmetic fix so we don't
hit the same problem next time, followed by a cosmetic patch just because
I had my search-and-replace warmed up. Please review.
Avi Kivity (3):
KVM: MMU: Fix is_dirty_pte()
KVM: MMU: Adjust pte accessors to explicitly in
is_dirty_pte() is used on guest ptes, not shadow ptes, so it needs to avoid
shadow_dirty_mask and use PT_DIRTY_MASK instead.
Misdetecting dirty pages could lead to unnecessarily setting the dirty bit
under EPT.
Signed-off-by: Avi Kivity
---
arch/x86/kvm/mmu.c |2 +-
1 files changed, 1 inser
Since the guest and host ptes can have wildly different format, adjust
the pte accessor names to indicate on which type of pte they operate on.
No functional changes.
Signed-off-by: Avi Kivity
---
arch/x86/kvm/mmu.c | 16
arch/x86/kvm/mmu.h |2 +-
arch/x86
We use shadow_pte and spte inconsistently, switch to the shorter spelling.
Rename set_shadow_pte() to __set_spte() to avoid a conflict with the
existing set_spte(), and to indicate its lowlevelness.
Signed-off-by: Avi Kivity
---
arch/x86/kvm/mmu.c | 102 ++--
On Tue, Jun 09, 2009 at 02:45:54PM -0300, Glauber Costa wrote:
> duplicated save config.
Good catch. Fixed.
--
MST
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
Should work, we use KVM and openVZ in Proxmox VE.
Best Regards,
Martin Maurer
mar...@proxmox.com
http://pve.proxmox.com
> -Original Message-
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On
> Behalf Of Ajay EP
> Sent: Dienstag, 09. Juni 2009 15:37
> To: kvm@vger.k
- "Yolkfull Chow" wrote:
> On 06/10/2009 06:03 PM, Michael Goldish wrote:
> > - "Yolkfull Chow" wrote:
> >
> >
> >> On 06/09/2009 05:44 PM, Michael Goldish wrote:
> >>
> >>> The test looks pretty nicely written. Comments:
> >>>
> >>> 1. Consider making all the cloned VMs use i
RFC: move the dirty page tracking to use dirty bit
Well, i was bored this morning and had this idea for a while, didnt test it to
much..., first i want to hear what ppl think?
Thanks.
Izik Eidus (2):
kvm: fix dirty bit tracking for slots with large pages
kvm: change the dirty page tracking t
When slot is already allocted and being asked to be tracked we need to break the
large pages.
This code flush the mmu when someone ask a slot to start dirty bit tracking.
Signed-off-by: Izik Eidus
---
virt/kvm/kvm_main.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/
right now the dirty page tracking work with the help of page faults, when we
want to track a page for being dirty, we write protect it and we mark it dirty
when we have write page fault, this code move into looking at the dirty bit
of the spte.
Signed-off-by: Izik Eidus
---
arch/ia64/kvm/kvm-ia6
Izik Eidus wrote:
When slot is already allocted and being asked to be tracked we need to break the
large pages.
This code flush the mmu when someone ask a slot to start dirty bit tracking.
Signed-off-by: Izik Eidus
---
virt/kvm/kvm_main.c |2 ++
1 files changed, 2 insertions(+), 0 deletio
Few quick thoughts:
+void kvm_arch_get_dirty_log(struct kvm *kvm, struct kvm_memory_slot *memslot)
+{
+}
+
long kvm_arch_vm_ioctl(struct file *filp,
unsigned int ioctl, unsigned long arg)
{
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
Avi Kivity wrote:
Izik Eidus wrote:
When slot is already allocted and being asked to be tracked we need
to break the
large pages.
This code flush the mmu when someone ask a slot to start dirty bit
tracking.
Signed-off-by: Izik Eidus
---
virt/kvm/kvm_main.c |2 ++
1 files changed, 2 in
On Wed, Jun 10, 2009 at 11:08:14AM +0300, Avi Kivity wrote:
> Avi Kivity wrote:
>>
>> Not really. One thing, migration should transition the shadow
>> pagetables from large pages to small ones, maybe that bit is broken.
>>
>> Maybe we're looking at a largepage spte and interpreting it as a
>>
On Wed, Jun 10, 2009 at 12:17:09PM +0300, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>> Required by EPT misconfiguration handler.
>>
>> Signed-off-by: Marcelo Tosatti
>>
>> Index: kvm/arch/x86/kvm/mmu.c
>> ===
>> --- kvm.orig/arch/x86
Looks fine to me.
BTW, I think debug_print() should be prefixed by a single underscore, not two.
A double underscore should be used only when name mangling is required -- at
least that's what I understood from PEP 8.
Let me know what you think.
Thanks,
Michael
- Original Message -
From:
Marcelo Tosatti wrote:
Isn't it simpler to invoke for_each_shadow_entry(), instead of defining
a callback and calling it?
We had those callbacks once, then switched to for_each.
The point is its exported to use in a external module (kvm-intel.ko),
so you hide the details (such as lockin
Beth Kon wrote:
This patch is based on the recent patch from Vincent Minet. I split Vincent's
changes into 2 patches (to separate MADT and RSDT table cleanup, as suggested by
Marcelo) and added a bit to them.
There has been much ado over the acpi_bios_init function recently. I had actually
done
Looks fine to me.
- Original Message -
From: "Lucas Meneghel Rodrigues"
To: autot...@test.kernel.org
Cc: kvm@vger.kernel.org
Sent: Tuesday, June 9, 2009 7:33:29 PM (GMT+0200) Auto-Detected
Subject: [Autotest] [KVM-AUTOTEST PATCH 4/4] Fix bad logging calls
During the conversion of kvm aut
Here is the port of MSI-X support patches to upstream qemu.
Please comment or commit.
This patchset adds generic support for MSI-X, adds implementation in
APIC, and uses MSI-X in virtio-net.
Changelog:
- since v3
call to resize_region on load
split patches a bit differently to address style c
Change much of hw/pci to use symbolic constants and a table-driven
design: add a mask table with writable bits set and readonly bits unset.
Detect change by comparing original and new registers.
This makes it easy to support capabilities where read-only/writeable
bit layout differs between devices
Add support for capability bits in save/restore for pci.
These will be used for MSI, where the capability might
be present or not as requested by user, which does not
map well into a single version number.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.c | 17 ++---
hw/pci.h |4 +
Add routines to manage PCI capability list. First user will be MSI-X.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.c | 79 ++
hw/pci.h | 18 +-
2 files changed, 96 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/h
Add inline routines for convenient access to pci devices
with correct (little) endianness. Will be used by MSI-X support.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.h | 30 +++---
1 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
inde
Add functions implementing MSI-X support. First user will be virtio-pci.
Note that platform must set a flag to declare MSI supported: this
is a safety measure to avoid breaking platforms which should support
MSI-X but currently lack this in the interrupt controller emulation.
For PC this will be se
Add global flag to disable MSI-X by default. This is useful primarily
to make images loadable by older qemu (without msix). Even when MSI-X
is disabled by flag, you can still load images that have MSI-X enabled.
Signed-off-by: Michael S. Tsirkin
---
hw/msix.c |3 +++
qemu-options.hx
Implement MSI support in APIC. Note that MSI and MMIO APIC registers
are at the same memory location, but actually not on the global bus: MSI
is on PCI bus, APIC is connected directly to the CPU. We map them on the
global bus at the same address which happens to work because MSI
registers are reser
Make it possible to resize PCI regions. This will be used by virtio
with MSI-X, where the region size depends on whether MSI-X is enabled,
and can change across load/save.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.c | 54 --
hw/pci.h |
Extend virtio to support many interrupt vectors, and rearrange code in
preparation for multi-vector support (mostly move reset out to bindings,
because we will have to reset the vectors in transport-specific code).
Actual bindings in pci, and use in net, to follow.
Load and save are not connected t
This enables actual support for MSI-X in virtio PCI.
First user will be virtio-net.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio-pci.c | 152 --
1 files changed, 112 insertions(+), 40 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-p
Looks fine to me.
- Original Message -
From: "Lucas Meneghel Rodrigues"
To: autot...@test.kernel.org
Cc: kvm@vger.kernel.org, "Lucas Meneghel Rodrigues"
Sent: Tuesday, June 9, 2009 7:33:28 PM (GMT+0200) Auto-Detected
Subject: [KVM-AUTOTEST PATCH 3/4] Fix bad line breaks
During the conve
Request up to 3 vectors in virtio-net. Actual bindings might supply
less.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio-net.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 60aa6da..6118fe3 100644
--- a/hw/virtio-net.c
+++ b/hw/
Implement bindings for virtio save/load. Use them in virtio pci.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio-pci.c | 50 +-
hw/virtio.c | 33 -
hw/virtio.h |4
3 files changed, 69 insertions(
Add pci_get/set_byte to keep *_word and *_long access functions company.
They are unused for now.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.h | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
index 9455e4c..07404c5 100644
--- a/hw/pci.h
+
One more thing: maybe we shouldn't test if the file exists and raise IOError
ourselves --
python does this automatically anyway when we call open() for a file that
doesn't exist.
- Original Message -
From: "Michael Goldish"
To: "Lucas Meneghel Rodrigues"
Cc: kvm@vger.kernel.org, autot.
On Wed, Jun 10, 2009 at 02:28:19PM +0300, Avi Kivity wrote:
> A minor fix to the pte accessors, followed by a cosmetic fix so we don't
> hit the same problem next time, followed by a cosmetic patch just because
> I had my search-and-replace warmed up. Please review.
Looks good.
--
To unsubscribe
Marcelo Tosatti wrote:
On Wed, Jun 10, 2009 at 02:28:19PM +0300, Avi Kivity wrote:
A minor fix to the pte accessors, followed by a cosmetic fix so we don't
hit the same problem next time, followed by a cosmetic patch just because
I had my search-and-replace warmed up. Please review.
L
On Wed, Jun 10, 2009 at 03:23:47PM +0300, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>>> Isn't it simpler to invoke for_each_shadow_entry(), instead of
>>> defining a callback and calling it?
>>>
>>> We had those callbacks once, then switched to for_each.
>>>
>>
>> The point is its exported
On Tuesday 09 June 2009, Fischer, Anna wrote:
> I have tried using virtio and using the emulated QEMU virtual NICs.
> It does not make a difference. It seems as if there is an overflow somewhere
> when QEMU/virtio cannot cope with the network load any more, and then the
> virtual interfaces don't
> Subject: Re: Network throughput limits for local VM <-> VM
> communication
>
> On Tuesday 09 June 2009, Fischer, Anna wrote:
>
> > I have tried using virtio and using the emulated QEMU virtual NICs.
> > It does not make a difference. It seems as if there is an overflow
> somewhere
> > when QEMU
> > > Note that platform must set a flag to declare MSI supported.
> > > For PC this will be set by APIC.
> >
> > This sounds wrong. The device shouldn't know or care whether the system
> > has a MSI capable interrupt controller. That's for the guest OS to figure
> > out.
>
> You are right of cours
On Wed, Jun 10, 2009 at 4:01 AM, Alexey Eromenko wrote:
>
> Even better would be to use "/usr/bin/python2".
That doesn't seem to exist, on Ubuntu at least.
> This is because future distros will include python3, which is incompatible
> with python2 code.
>
> "python" will be symlink of "python3".
On Wed, Jun 10, 2009 at 03:07:34PM +0100, Paul Brook wrote:
> > > > Note that platform must set a flag to declare MSI supported.
> > > > For PC this will be set by APIC.
> > >
> > > This sounds wrong. The device shouldn't know or care whether the system
> > > has a MSI capable interrupt controller.
> > If we really need to avoid MSI-X capable devices then that should be done
> > explicity per-device. i.e. you have a different virtio-net device that
> > does not use MSI-X.
> >
> > Paul
>
> Why should it be done per-device?
Because otherwise you end up with the horrible hacks that you're curr
On Wed, 10 Jun 2009 03:56:31 pm Dor Laor wrote:
> Rusty Russell wrote:
> > The current theoretical hole is that the host suppresses notifications
> > using the VIRTIO_AVAIL_F_NO_NOTIFY flag, but we can get a number of
> > notifications in before it gets to that suppression. You can use a
> > count
On Wed, Jun 10, 2009 at 03:39:05PM +0100, Paul Brook wrote:
> > > If we really need to avoid MSI-X capable devices then that should be done
> > > explicity per-device. i.e. you have a different virtio-net device that
> > > does not use MSI-X.
> > >
> > > Paul
> >
> > Why should it be done per-devic
On Wed, Jun 10, 2009 at 12:54:15PM +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 09, 2009 at 02:11:14PM -0300, Glauber Costa wrote:
> > On Fri, Jun 05, 2009 at 01:23:15PM +0300, Michael S. Tsirkin wrote:
> > > Add routines to manage PCI capability list. First user will be MSI-X.
> > >
> > > Signe
On Thu, Jun 11, 2009 at 12:09:33AM +0930, Rusty Russell wrote:
> On Wed, 10 Jun 2009 03:56:31 pm Dor Laor wrote:
> > Rusty Russell wrote:
> > > The current theoretical hole is that the host suppresses notifications
> > > using the VIRTIO_AVAIL_F_NO_NOTIFY flag, but we can get a number of
> > > noti
Hi,
Per Avi's request, here's a patch which moves the current _PR section
from the DSDT table into a new SSDT table.
The long term idea is to be able to have multiple different SSDTs for
different sized systems, and in particular allow to keep the legacy one
for supporting legacy operating syste
On Wed, Jun 10, 2009 at 11:55:40AM -0300, Glauber Costa wrote:
> On Wed, Jun 10, 2009 at 12:54:15PM +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 09, 2009 at 02:11:14PM -0300, Glauber Costa wrote:
> > > On Fri, Jun 05, 2009 at 01:23:15PM +0300, Michael S. Tsirkin wrote:
> > > > Add routines to m
Looks good.
On Tue, Jun 9, 2009 at 5:57 PM, Lucas Meneghel Rodrigues wrote:
> All kvm modules that can be used as stand alone programs were
> updated to use #!/usr/bin/python instead of #!/usr/bin/env python,
> complying with the rest of the autotest code base. As suggested
> by Martin, common.py
On Wed, Jun 10, 2009 at 05:01:18PM +0200, Jes Sorensen wrote:
> Index: qemu-kvm/kvm/bios/acpi-ssdt.dsl
> ===
> --- /dev/null
> +++ qemu-kvm/kvm/bios/acpi-ssdt.dsl
> @@ -0,0 +1,140 @@
> +/*
> + * Bochs/QEMU ACPI SSDT ASL definition
> +
> > That's seems just plain wrong to me.
> > Loading a VM shouldn't not
> > do anything that can't happen during normal operation.
>
> At least wrt pci, we are very far from this state: load just overwrites
> all registers, readonly or not, which can never happen during normal
> operation.
IMO tha
On Wed, 10 Jun 2009, Federico Simoncelli wrote:
I've been working quite extensively with kvm on CentOS 5.3 lately.
If you are interested in the latest rpm of kvm-kmod-2.6.30-rc8,
qemu-kvm-0.10.5 and libvirt-0.6.4 you can temporary find them here:
http://update.nethesis.it/kvm/
I've had no prob
Michael S. Tsirkin wrote:
But I don't understand how aio will make implementing it easier -
or are you merely saying that it will make it worthwhile?
If you have aio, the the NIC and the guest proceed in parallel. If the
guest is faster (likely), then when it sends the next packet it will
Marcelo Tosatti wrote:
Ah, you're right.
I don't think it's worthwhile to add all this just for debugging. You
can add a function that dumps the spte chain as well as the features
MSR, and we can decode it by hand when we see it. Disadvantage is more
work for us when we hit the bug,
> > caps can be anywhere, but we don't expect it to change during machine
> > execution lifetime.
> >
> > Or I am just confused by the name "pci_device_load" ?
>
> Right. So I want to load an image and it has capability X at offset Y.
> wmask has to match. I don't want to assume that we never chang
On 06/10/2009 05:13 PM, Gleb Natapov wrote:
+ * Bochs/QEMU ACPI SSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
I am not sure that there is even one bit of code below written by Fabrice.
Well better safe than sorry, since I copied over a bunch of stuff,
I figured it was simpler
Make the audit code aware of largepages.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
===
--- kvm.orig/arch/x86/kvm/mmu.c
+++ kvm/arch/x86/kvm/mmu.c
@@ -3033,12 +3033,11 @@ static void __mmu_spte_walk(struct kvm *
- Fail early in case gfn_to_pfn returns is_error_pfn.
- For the pre pte write case, avoid spurious "gva is valid but spte is notrap"
messages (the emulation code does the guest write first, so this particular
case is OK).
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
- Unsync pages contain writable sptes in the rmap.
- rmaps do not exclusively contain writable sptes anymore.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
===
--- kvm.orig/arch/x86/kvm/mmu.c
+++ kvm/arch/x86/kvm/mmu.
Addressing comments, introducing a new helper, handling largepages.
--
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Under testing, count_writable_mappings returns a value that is 2 integers
larger than what count_rmaps returns.
Suspicion is that either of the two functions is counting a duplicate (either
positively or negatively).
Modifying check_writable_mappings_rmap to check for rmap existance on
all prese
Hiding some of the last largepage / level interaction (which is useful
for gbpages and for zero based levels).
Also merge the PT_PAGE_TABLE_LEVEL clearing loop in unlink_children.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
==
It is valid to set non leaf sptes as notrap.
Signed-off-by: Marcelo Tosatti
Index: kvm/arch/x86/kvm/mmu.c
===
--- kvm.orig/arch/x86/kvm/mmu.c
+++ kvm/arch/x86/kvm/mmu.c
@@ -3084,12 +3084,7 @@ static void audit_mappings_page(struct k
Gleb Natapov wrote:
Currently vcpu_id is used as an index into vcpus array and as apic id
on x86. This is incorrect since apic ids not have to be continuous
(they can also encode cpu hierarchy information) and may have values
bigger then vcpu array in case of x2apic. This series removes use of
v
On Wed, Jun 10, 2009 at 04:24:28PM +0100, Paul Brook wrote:
> > > caps can be anywhere, but we don't expect it to change during machine
> > > execution lifetime.
> > >
> > > Or I am just confused by the name "pci_device_load" ?
> >
> > Right. So I want to load an image and it has capability X at of
On Wed, Jun 10, 2009 at 06:18:01PM +0300, Avi Kivity wrote:
> Michael S. Tsirkin wrote:
>> But I don't understand how aio will make implementing it easier -
>> or are you merely saying that it will make it worthwhile?
>>
>
> If you have aio, the the NIC and the guest proceed in parallel. If the
On Wed, Jun 10, 2009 at 04:15:04PM +0100, Paul Brook wrote:
> > > That's seems just plain wrong to me.
> > > Loading a VM shouldn't not
> > > do anything that can't happen during normal operation.
> >
> > At least wrt pci, we are very far from this state: load just overwrites
> > all registers, rea
On Wednesday 10 June 2009, Michael S. Tsirkin wrote:
> On Wed, Jun 10, 2009 at 04:15:04PM +0100, Paul Brook wrote:
> > > > That's seems just plain wrong to me.
> > > > Loading a VM shouldn't not
> > > > do anything that can't happen during normal operation.
> > >
> > > At least wrt pci, we are very
Michael S. Tsirkin wrote:
On Wed, Jun 10, 2009 at 06:18:01PM +0300, Avi Kivity wrote:
Michael S. Tsirkin wrote:
But I don't understand how aio will make implementing it easier -
or are you merely saying that it will make it worthwhile?
If you have aio, the the NIC and the gues
1 - 100 of 139 matches
Mail list logo