[no subject]

2010-11-18 Thread satimis
http://maralemprendimientos.com/important.php -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ppc32 build failed

2010-11-18 Thread Takuya Yoshikawa
Aren't you using upstream qemu? IIRC, ppc kvm needs to use upstream qemu. I use qemu-kvm git version. Do you means qemu instead of qemu-kvm? Hi, qemu 0.13.0 build passed Yes, that what I meant! Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a messag

Re: ppc32 build failed

2010-11-18 Thread Yang Rui Rui
On 11/19/2010 02:37 PM, Yang Ruirui R wrote: On 11/19/2010 02:24 PM, Takuya Yoshikawa wrote: (2010/11/19 15:01), Yang Rui Rui wrote: Hi, I searched the archive found some discutions about this, not fixed yet? could someone tell, is g4 kvm available now? Hi, (added kvm-ppc to Cc) I'm using g

Re: ppc32 build failed

2010-11-18 Thread Yang Rui Rui
On 11/19/2010 02:24 PM, Takuya Yoshikawa wrote: (2010/11/19 15:01), Yang Rui Rui wrote: Hi, I searched the archive found some discutions about this, not fixed yet? could someone tell, is g4 kvm available now? Hi, (added kvm-ppc to Cc) I'm using g4 (Mac mini box) to run KVM. - though not

Re: ppc32 build failed

2010-11-18 Thread Takuya Yoshikawa
(2010/11/19 15:01), Yang Rui Rui wrote: Hi, I searched the archive found some discutions about this, not fixed yet? could someone tell, is g4 kvm available now? Hi, (added kvm-ppc to Cc) I'm using g4 (Mac mini box) to run KVM. - though not tried 2.6.37-rc2 yet. Aren't you using upstream qe

ppc32 build failed

2010-11-18 Thread Yang Rui Rui
Hi, I searched the archive found some discutions about this, not fixed yet? could someone tell, is g4 kvm available now? powerpc g4 build failed (host kernel 2.6.37-rc2): CCppc-softmmu/kvm.o /home/dave/qemu-kvm/target-ppc/kvm.c: In function 'kvm_arch_init_vcpu': /home/dave/qemu-kvm/target

[PATCH v3 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Alex Williamson
Register the actual VM RAM using the new API Signed-off-by: Alex Williamson --- hw/pc.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 69b13bf..fb7ee21 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -912,14 +912,11 @@ void pc_memory_init(ram_addr

[PATCH v3 1/2] Minimal RAM API support

2010-11-18 Thread Alex Williamson
This adds a minimum chunk of Anthony's RAM API support so that we can identify actual VM RAM versus all the other things that make use of qemu_ram_alloc. Signed-off-by: Alex Williamson --- Makefile.objs |1 + cpu-common.h |2 + memory.c | 97 +

[PATCH v3 0/2] Minimal RAM API support

2010-11-18 Thread Alex Williamson
v3: - Address review comments - pc registers all memory below 4G in one chunk Let me know if there are any further issues. Thanks, Alex v2: - Move to Makefile.objs - Move structures to memory.c and create a callback function - Fix memory leak I haven't moved to the state parameter becau

Re: HAL type for Win2003 Server on recent KVM versions?

2010-11-18 Thread Kenni Lund
2010/11/18 Cole Robinson : > On 11/18/2010 09:05 AM, Kenni Lund wrote: >> I'm curious why the RHEL 6 documentation claims that you actively need >> to select the "Standard PC" HAL on installation, if it's not even the >> recommended/preferred HAL...(?): >> "Windows 2003 requires a specific computer

[PATCH] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
Store irq routing table pointer in the irqfd object, and use that to inject MSI directly without bouncing out to a kernel thread. While we touch this structure, rearrange irqfd fields to make fastpath better packed for better cache utilization. This also adds some comments about locking rules and

Re: [PATCH v2 2/6] KVM: MMU: don't drop spte if overwrite it from W to RO

2010-11-18 Thread Avi Kivity
On 11/18/2010 05:32 PM, Marcelo Tosatti wrote: > >> There is no need to flush on sync_page path since the guest is > >> responsible for it. > >> > > > > If we don't, the next rmap_write_protect() will incorrectly decide that > > there's no need to flush tlbs. > > > > Maybe it's not a

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 06:18:06PM +0200, Avi Kivity wrote: > >But for PV devices, we can be loose in how we define the way the > >devices interact with the rest of the system. For instance, we > >can say that virtio-pci devices are directly connected to RAM and > >do not go through the memory con

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Avi Kivity
On 11/18/2010 06:09 PM, Anthony Liguori wrote: That's what "two memory maps" mean. If you have one cpu in SMM and another outside SMM, then those two maps are active simultaneously. I'm not sure if more modern memory controllers do special things here, but for the i440fx, if any CPU asserts

Re: [PATCH v2 5/6] KVM: MMU: remove 'clear_unsync' parameter

2010-11-18 Thread Marcelo Tosatti
On Thu, Nov 18, 2010 at 03:42:01PM +0800, Xiao Guangrong wrote: > On 11/18/2010 12:49 AM, Marcelo Tosatti wrote: > bool clear_unsync) > >> +static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page > >> *sp) > >> { > >>int i, offset, nr_present; > >>

Re: [PATCH v2 2/6] KVM: MMU: don't drop spte if overwrite it from W to RO

2010-11-18 Thread Marcelo Tosatti
On Thu, Nov 18, 2010 at 03:12:56PM +0800, Xiao Guangrong wrote: > On 11/17/2010 11:57 PM, Avi Kivity wrote: > > >>> set_pte: > >>> update_spte(sptep, spte); > >>> +/* > >>> + * If we overwrite a writable spte with a read-only one we > >>> + * should flush remote TLBs. Otherwise

Re: [PATCH 0/2] KVM: fix and cleanup: kvm_lock and hardware_disable

2010-11-18 Thread Marcelo Tosatti
On Tue, Nov 16, 2010 at 05:32:44PM +0900, Takuya Yoshikawa wrote: > Hello! > > During investigating kvm's mutual exclusions, starting from checking > kvm's srcu grace periods, I could not understand some of the locking rules. > > This one is an example which I doubt. > But I'm not so sure. Please

Re: [PATCH 0/2] Minor emulator cleanups

2010-11-18 Thread Marcelo Tosatti
On Wed, Nov 17, 2010 at 01:40:49PM +0200, Avi Kivity wrote: > A couple of trivial patches that clean up a bit of cruft from the emulator. > > Avi Kivity (2): > KVM: x86 emulator: drop unused #ifndef __KERNEL__ > KVM: x86 emulator: drop DPRINTF() > > arch/x86/kvm/emulate.c | 14 +---

Re: [PATCH 0/2] Introduce segmented addresses to the emulator

2010-11-18 Thread Marcelo Tosatti
On Wed, Nov 17, 2010 at 01:40:58PM +0200, Avi Kivity wrote: > Currently we lose segment information associated with memory operands. This > prevents us from doing proper segment checks. > > This patchset prepares the way by remembering which segment is associated > with a memory operand. > > Avi

Re: [PATCH]KVM: VMX: Inform user about INTEL_TXT dependency

2010-11-18 Thread Marcelo Tosatti
On Wed, Nov 17, 2010 at 11:40:17AM +0800, Shane Wang wrote: > Inform user to either disable TXT in the BIOS or do TXT launch with tboot > before enabling KVM since some BIOSes do not set > FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX bit when TXT is enabled. > > Signed-off-by: Shane Wang > --- >

Re: [PATCH v2 0/2] Introduce segmented addresses to the emulator

2010-11-18 Thread Marcelo Tosatti
On Wed, Nov 17, 2010 at 03:28:20PM +0200, Avi Kivity wrote: > Currently we lose segment information associated with memory operands. This > prevents us from doing proper segment checks. > > This patchset prepares the way by remembering which segment is associated > with a memory operand. > > Avi

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:57 AM, Avi Kivity wrote: On 11/18/2010 05:46 PM, Anthony Liguori wrote: On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable segment

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Avi Kivity
On 11/18/2010 05:46 PM, Anthony Liguori wrote: On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable segments the i440fx can toggle are 12 fixed 16k se

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Gleb Natapov
On Wed, Nov 17, 2010 at 05:42:28PM -0600, Anthony Liguori wrote: > >For my purpose in using this to program the IOMMU with guest physical to > >host virtual addresses for device assignment, it doesn't really matter > >since there should never be a DMA in this range of memory. But for a > >general

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable segments the i440fx can toggle are 12 fixed 16k segments from 0xc to 0xe and a single 64k

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Avi Kivity
On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable segments the i440fx can toggle are 12 fixed 16k segments from 0xc to 0xe and a single 64k segment from 0xf to 0xf. There are

Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

2010-11-18 Thread Avi Kivity
On 11/18/2010 05:00 PM, Andi Kleen wrote: On 11/18/2010 3:32 PM, Avi Kivity wrote: On 11/18/2010 03:48 PM, Andi Kleen wrote: On 11/18/2010 1:17 PM, Avi Kivity wrote: cea15c2 ("KVM: Move KVM context switch into own function") split vmx_vcpu_run() to prevent multiple copies of the context switch

Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

2010-11-18 Thread Andi Kleen
On 11/18/2010 3:32 PM, Avi Kivity wrote: On 11/18/2010 03:48 PM, Andi Kleen wrote: On 11/18/2010 1:17 PM, Avi Kivity wrote: cea15c2 ("KVM: Move KVM context switch into own function") split vmx_vcpu_run() to prevent multiple copies of the context switch from being generated (causing problems du

[GIT PULL] KVM updates for 2.6.37-rc2

2010-11-18 Thread Marcelo Tosatti
Linus, please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/2.6.37 To receive the following updates: Avi Kivity (2): KVM: Correct ordering of ldt reload wrt fs/gs reload KVM: VMX: Fix host userspace gsbase corruption arch/x86/kvm/svm.c |2 +- arch/x86

Re: [PATCH] KVM test: unattended installation cleanup

2010-11-18 Thread Lucas Meneghel Rodrigues
On Thu, 2010-11-18 at 12:44 -0200, Lucas Meneghel Rodrigues wrote: > From: Jason Wang > > This patch does the following things: > > - Drop the built-in tftp/dhcp based unatteded installation for the > following reason: > > 1 It's based on slirp and was not supported by major > distributions

Re: HAL type for Win2003 Server on recent KVM versions?

2010-11-18 Thread Cole Robinson
On 11/18/2010 09:05 AM, Kenni Lund wrote: > 2010/11/18 Avi Kivity : >> On 11/18/2010 12:58 AM, Kenni Lund wrote: >>> >>> Hi >>> >>> I'm about to move a couple of virtual machines from a Fedora 11 system >>> to a new server with a more recent operating system and newer version >>> of KVM, etc. >>> >

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 03:48:43PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 03:35:01PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 03:20:27PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 03:14:53PM +0200, Gleb Natapov wrote: > > > > On Thu, Nov 18, 201

Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

2010-11-18 Thread Avi Kivity
On 11/18/2010 03:48 PM, Andi Kleen wrote: On 11/18/2010 1:17 PM, Avi Kivity wrote: cea15c2 ("KVM: Move KVM context switch into own function") split vmx_vcpu_run() to prevent multiple copies of the context switch from being generated (causing problems due to a label). This patch folds them back

Re: HAL type for Win2003 Server on recent KVM versions?

2010-11-18 Thread Kenni Lund
2010/11/18 Avi Kivity : > On 11/18/2010 12:58 AM, Kenni Lund wrote: >> >> Hi >> >> I'm about to move a couple of virtual machines from a Fedora 11 system >> to a new server with a more recent operating system and newer version >> of KVM, etc. >> >> One of the guests is a Windows Server 2003 Standar

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 03:35:01PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 03:20:27PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 03:14:53PM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 03:03:37PM +0200, Michael S. Tsirkin wrote: > > > > > >+static inline v

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 03:39:15PM +0200, Avi Kivity wrote: > On 11/18/2010 03:35 PM, Gleb Natapov wrote: > >> > >> or something like this. > >Ah so you want to do it only for MSI? For MSI it makes sense. Remember > >though that sometimes destination depend on message itself (specifically > >on de

Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

2010-11-18 Thread Andi Kleen
On 11/18/2010 1:17 PM, Avi Kivity wrote: cea15c2 ("KVM: Move KVM context switch into own function") split vmx_vcpu_run() to prevent multiple copies of the context switch from being generated (causing problems due to a label). This patch folds them back together again and adds the __noclone attri

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Avi Kivity
On 11/18/2010 03:35 PM, Gleb Natapov wrote: > > or something like this. Ah so you want to do it only for MSI? For MSI it makes sense. Remember though that sometimes destination depend on message itself (specifically on delivery mode). Yes, broadcast or multicast or lowest priority wouldn't get

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 03:20:27PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 03:14:53PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 03:03:37PM +0200, Michael S. Tsirkin wrote: > > > > >+static inline void kvm_irq_routing_update(struct kvm *kvm, > > > > >+

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 03:14:53PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 03:03:37PM +0200, Michael S. Tsirkin wrote: > > > >+static inline void kvm_irq_routing_update(struct kvm *kvm, > > > >+ struct kvm_irq_routing_table > > > >*irq_rt) > >

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Avi Kivity
On 11/18/2010 03:14 PM, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 03:03:37PM +0200, Michael S. Tsirkin wrote: > > >+static inline void kvm_irq_routing_update(struct kvm *kvm, > > >+ struct kvm_irq_routing_table *irq_rt) > > >+{ > > >+ rcu_a

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 03:12:02PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 02:37:08PM +0200, Gleb Natapov wrote: > > > So that's unavoidable if we think paths are correct. > > > But if we know they are wrong, we are better off > > > correcting them first IMO. > > > > > They are

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 03:03:37PM +0200, Michael S. Tsirkin wrote: > > >+static inline void kvm_irq_routing_update(struct kvm *kvm, > > >+struct kvm_irq_routing_table *irq_rt) > > >+{ > > >+ rcu_assign_pointer(kvm->irq_routing, irq_rt); > > >+} > > >+ > > > st

Re: [RFC PATCH 1/2] KVM: count the number of dirty bits for each memslot

2010-11-18 Thread Avi Kivity
On 11/18/2010 03:10 PM, Jan Kiszka wrote: Am 18.11.2010 13:54, Avi Kivity wrote: > On 11/18/2010 07:14 AM, Takuya Yoshikawa wrote: >> This patch introduces the counter to hold the number of dirty bits in >> each >> memslot. We will use this to optimize dirty logging later. >> >> >> @@ -3217,

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 02:37:08PM +0200, Gleb Natapov wrote: > > So that's unavoidable if we think paths are correct. > > But if we know they are wrong, we are better off > > correcting them first IMO. > > > They are correct for x86. My patch set does not even tries to cover all > HW. If sparc wa

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Philipp Hahn
Hello, Am Donnerstag 18 November 2010 10:05:59 schrieb Hidetoshi Seto: > > Your have to be careful about compile-time-detection and > > runtime-detection: ... > -#ifdef CONFIG_UTIMENSAT > -return utimensat(dirfd, path, times, flags); > -#else > +{ > +int ret = utimensat(dirfd, path

Re: [RFC PATCH 1/2] KVM: count the number of dirty bits for each memslot

2010-11-18 Thread Jan Kiszka
Am 18.11.2010 13:54, Avi Kivity wrote: > On 11/18/2010 07:14 AM, Takuya Yoshikawa wrote: >> This patch introduces the counter to hold the number of dirty bits in >> each >> memslot. We will use this to optimize dirty logging later. >> >> >> @@ -3217,11 +3216,8 @@ int kvm_vm_ioctl_get_dirty_log(stru

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Avi Kivity
On 11/18/2010 03:03 PM, Michael S. Tsirkin wrote: > > int kvm_set_irq(struct kvm *kvm, int irq_source_id, u32 irq, int level); > >+int kvm_set_msi(struct kvm_kernel_irq_routing_entry *irq_entry, struct kvm *kvm, > >+ int irq_source_id, int level); > > No point in the level argu

Re: [RFC PATCH 2/2] KVM: selective write protection using dirty bitmap

2010-11-18 Thread Avi Kivity
On 11/18/2010 07:15 AM, Takuya Yoshikawa wrote: Lai Jiangshan once tried to rewrite kvm_mmu_slot_remove_write_access() using rmap: "kvm: rework remove-write-access for a slot" http://www.spinics.net/lists/kvm/msg35871.html One problem pointed out there was that this approach might hurt ca

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 02:29:11PM +0200, Avi Kivity wrote: > On 11/18/2010 01:10 PM, Michael S. Tsirkin wrote: > >> I guess I should create an empty Documentation/kvm/locking.txt and > >> force everyone else to update it. > > > >Comments near the relevant fields not better? > > > > Not an eithe

Re: [RFC PATCH 1/2] KVM: count the number of dirty bits for each memslot

2010-11-18 Thread Avi Kivity
On 11/18/2010 07:14 AM, Takuya Yoshikawa wrote: This patch introduces the counter to hold the number of dirty bits in each memslot. We will use this to optimize dirty logging later. @@ -3217,11 +3216,8 @@ int kvm_vm_ioctl_get_dirty_log(struct kvm *kvm, n = kvm_dirty_bitmap_bytes(memslo

Re: [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func

2010-11-18 Thread Sheng Yang
On Thu, Nov 18, 2010 at 8:33 PM, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 07:59:10PM +0800, Sheng Yang wrote: >> On Thu, Nov 18, 2010 at 5:41 PM, Michael S. Tsirkin wrote: >> > On Thu, Nov 18, 2010 at 11:30:47AM +0200, Avi Kivity wrote: >> >> >> >> >> >>  *entry may be stale after rcu_

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 02:23:20PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 02:16:05PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > > > > On Thu, Nov 18, 201

Re: [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 07:59:10PM +0800, Sheng Yang wrote: > On Thu, Nov 18, 2010 at 5:41 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 11:30:47AM +0200, Avi Kivity wrote: > >> >> > >> >>  *entry may be stale after rcu_read_unlock().  Is this a problem? > >> > > >> >I suppose not. All

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Avi Kivity
On 11/18/2010 01:10 PM, Michael S. Tsirkin wrote: > I guess I should create an empty Documentation/kvm/locking.txt and > force everyone else to update it. Comments near the relevant fields not better? Not an either/or. You can't understand the system from random source comments. diff -

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 02:16:05PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 18, 201

[PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

2010-11-18 Thread Avi Kivity
cea15c2 ("KVM: Move KVM context switch into own function") split vmx_vcpu_run() to prevent multiple copies of the context switch from being generated (causing problems due to a label). This patch folds them back together again and adds the __noclone attribute to prevent the label from being duplic

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > > > > On Wed, Nov 17, 201

Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support

2010-11-18 Thread Sheng Yang
On Thu, Nov 18, 2010 at 5:28 PM, Avi Kivity wrote: > On 11/18/2010 03:58 AM, Sheng Yang wrote: >> >> On Wednesday 17 November 2010 21:58:00 Avi Kivity wrote: >> >  On 11/15/2010 11:15 AM, Sheng Yang wrote: >> >  >  This patch enable per-vector mask for assigned devices using MSI-X. >> >  > >> >  >

Re: [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func

2010-11-18 Thread Sheng Yang
On Thu, Nov 18, 2010 at 5:41 PM, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 11:30:47AM +0200, Avi Kivity wrote: >> >> >> >>  *entry may be stale after rcu_read_unlock().  Is this a problem? >> > >> >I suppose not. All MSI-X MMIO accessing would be executed without delay, so >> >no re- >>

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > > > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > > > > 2010/11/16 Gleb Natapov : >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > > > 2010/11/16 Gleb Natapov : > > > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > > 2010/11/16 Gleb Natapov : > > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > > >> >> Perhaps the FW path should use device class names if no name is > >

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 01:03:44PM +0200, Avi Kivity wrote: > On 11/18/2010 12:57 PM, Michael S. Tsirkin wrote: > >So the following on top will fix it all. > >Any more comments befpre I bundle it up, > >test and report? > > > > Nope (not that I can comment on an incremental). Here it is rolled up

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Avi Kivity
On 11/18/2010 12:57 PM, Michael S. Tsirkin wrote: So the following on top will fix it all. Any more comments befpre I bundle it up, test and report? Nope (not that I can comment on an incremental). I guess I should create an empty Documentation/kvm/locking.txt and force everyone else to upda

[ kvm-Bugs-1998355 ] IO Performance

2010-11-18 Thread SourceForge.net
Bugs item #1998355, was opened at 2008-06-20 02:11 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1998355&group_id=180599 Please note that this message will contain a full copy of the comme

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
So the following on top will fix it all. Any more comments befpre I bundle it up, test and report? kvm: fix up msi fastpath This will be folded into the msi fastpath patch. Changes: - simplify irq_entry/irq_routing update rules: simply to it all under irqfds.lock - document locking for rcu upd

Re: HAL type for Win2003 Server on recent KVM versions?

2010-11-18 Thread Avi Kivity
On 11/18/2010 12:58 AM, Kenni Lund wrote: Hi I'm about to move a couple of virtual machines from a Fedora 11 system to a new server with a more recent operating system and newer version of KVM, etc. One of the guests is a Windows Server 2003 Standard SP2, which is currently running with the "AC

Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-18 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ kvm-Bugs-1841658 ] OpenSolaris 64bit panic with kvm-54

2010-11-18 Thread SourceForge.net
Bugs item #1841658, was opened at 2007-11-30 13:11 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1841658&group_id=180599 Please note that this message will contain a full copy of the comme

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-18 Thread Gleb Natapov
On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > 2010/11/16 Gleb Natapov : > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > >> >> Perhaps the FW path should use device class names if no name is > >> >> specified. > >> > What do you mean by "device class name". We can

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 11:34:26AM +0200, Michael S. Tsirkin wrote: > > > @@ -125,10 +129,18 @@ irqfd_wakeup(wait_queue_t *wait, unsigned mode, int > > > sync, void *key) > > > { > > > struct _irqfd *irqfd = container_of(wait, struct _irqfd, wait); > > > unsigned long flags = (unsigned long)k

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/01/2010 10:14 AM, Alex Williamson wrote: Register the actual VM RAM using the new API Signed-off-by: Alex Williamson --- hw/pc.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 69b13bf..0ea6d10 100644 --- a/hw/pc.c +++ b/hw/pc

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Avi Kivity
On 11/18/2010 12:12 AM, Michael S. Tsirkin wrote: Store irq routing table pointer in the irqfd object, and use that to inject MSI directly without bouncing out to a kernel thread. While we touch this structure, rearrange irqfd fields to make fastpath better packed for better cache utilization.

Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support

2010-11-18 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 09:29:22AM +0800, Sheng Yang wrote: > > > +#define KVM_MSIX_TYPE_ASSIGNED_DEV 1 > > > + > > > +#define KVM_MSIX_FLAG_MASKBIT(1 << 0) > > > +#define KVM_MSIX_FLAG_QUERY_MASKBIT (1 << 0) > > > + > > > +struct kvm_msix_entry { > > > + __u32 id; > > > + __

Re: [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 11:30:47AM +0200, Avi Kivity wrote: > >> > >> *entry may be stale after rcu_read_unlock(). Is this a problem? > > > >I suppose not. All MSI-X MMIO accessing would be executed without delay, so > >no re- > >order issue would happen. If the guest is reading and writing the

Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 11:28:02AM +0200, Avi Kivity wrote: > On 11/18/2010 03:58 AM, Sheng Yang wrote: > >On Wednesday 17 November 2010 21:58:00 Avi Kivity wrote: > >> On 11/15/2010 11:15 AM, Sheng Yang wrote: > >> > This patch enable per-vector mask for assigned devices using MSI-X. > >> > >

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 11:05:22AM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 12:12:54AM +0200, Michael S. Tsirkin wrote: > > Store irq routing table pointer in the irqfd object, > > and use that to inject MSI directly without bouncing out to > > a kernel thread. > > > > While we touch t

Re: [PATCH v2 1/6] KVM: MMU: fix forgot flush vcpu tlbs

2010-11-18 Thread Avi Kivity
On 11/18/2010 09:17 AM, Xiao Guangrong wrote: On 11/18/2010 01:36 AM, Marcelo Tosatti wrote: >> I don't think we need to flush immediately; set a "tlb dirty" bit >> somewhere that is cleareded when we flush the tlb. >> kvm_mmu_notifier_invalidate_page() can consult the bit and force a >> flu

Re: [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func

2010-11-18 Thread Avi Kivity
On 11/18/2010 04:22 AM, Sheng Yang wrote: On Wednesday 17 November 2010 22:01:41 Avi Kivity wrote: > On 11/15/2010 11:15 AM, Sheng Yang wrote: > > We need to query the entry later. > > > > +int kvm_get_irq_routing_entry(struct kvm *kvm, int gsi, > > + struct kvm_kernel_irq_routi

Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support

2010-11-18 Thread Avi Kivity
On 11/18/2010 03:58 AM, Sheng Yang wrote: On Wednesday 17 November 2010 21:58:00 Avi Kivity wrote: > On 11/15/2010 11:15 AM, Sheng Yang wrote: > > This patch enable per-vector mask for assigned devices using MSI-X. > > > > This patch provided two new APIs: one is for guest to specific devic

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 11:16:02AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 11:05:22AM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 12:12:54AM +0200, Michael S. Tsirkin wrote: > > > Store irq routing table pointer in the irqfd object, > > > and use that to inject MSI dir

Re: 2.6.37-rc2 after KVM shutdown - unregister_netdevice: waiting for vmtst01eth0 to become free. Usage count = 1

2010-11-18 Thread Eric Dumazet
Le jeudi 18 novembre 2010 à 07:28 +0100, Nikola Ciprich a écrit : > > Yep, this is a known problem, thanks ! > > > > fix is there : > > > > http://patchwork.ozlabs.org/patch/71354/ > Thanks Eric, this indeed fixes the problem.. > I noticed the fix didn't make it to 2.6.37-rc2-git3 though, > mayb

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 11:05:22AM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 12:12:54AM +0200, Michael S. Tsirkin wrote: > > Store irq routing table pointer in the irqfd object, > > and use that to inject MSI directly without bouncing out to > > a kernel thread. > > > > While we touch t

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Jes Sorensen
On 11/18/10 09:48, Hidetoshi Seto wrote: > (2010/11/18 17:02), Jes Sorensen wrote: >> Hi Hidetoshi, >> >> I think the idea of the patch is good, but please move qemu_utimensat() >> to oslib-posix.c and provide a wrapper for oslib-win32.c. It is >> emulation for a system library function, so it does

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Hidetoshi Seto
(2010/11/18 17:28), Philipp Hahn wrote: > Hello, > > Am Donnerstag 18 November 2010 01:41:39 schrieb Hidetoshi Seto: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: > >> +#ifdef CONFIG_UTIMENSAT >> +

Re: [PATCH RFC] kvm: fast-path msi injection with irqfd

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 12:12:54AM +0200, Michael S. Tsirkin wrote: > Store irq routing table pointer in the irqfd object, > and use that to inject MSI directly without bouncing out to > a kernel thread. > > While we touch this structure, rearrange irqfd fields to make fastpath > better packed for

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Hidetoshi Seto
(2010/11/18 17:02), Jes Sorensen wrote: > On 11/18/10 01:41, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virti

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Philipp Hahn
Hello, Am Donnerstag 18 November 2010 01:41:39 schrieb Hidetoshi Seto: > This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > +#ifdef CONFIG_UTIMENSAT > +return utimensat(dirfd, path, times, flags); > +

Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-18 Thread Takuya Yoshikawa
(2010/11/18 14:45), Zachary Amsden wrote: No, I believe your patch is correct and the lock should be there. Did you test with spinlock debugging just to be sure? Sorry but no. I have no experience with cpu hotplug. So I thought it would take too much time to do real test by myself and repo

[PATCH] kvm: clear vapic after reset

2010-11-18 Thread Avi Kivity
Clear the vapic address immediately after reset. This allows dual-boot guests to work efficiently, and more importantly, works around the bios using 'rep insb' to read in the option rom and confusing the vapic machinery. Signed-off-by: Avi Kivity --- target-i386/kvm.c | 12 1 fil

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Jes Sorensen
On 11/18/10 01:41, Hidetoshi Seto wrote: > This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > > hw/virtio-9p-local.c: In function 'local_utimensat': > hw/virtio-9p-local.c:479: warning: implicit declaratio