Bug in KVM clock backwards compensation

2011-04-28 Thread Zachary Amsden
So I've been going over the new code changes to the TSC related code and I don't like one particular set of changes. In particular, here: kvm_x86_ops-vcpu_load(vcpu, cpu); if (unlikely(vcpu-cpu != cpu) || check_tsc_unstable()) { /* Make sure TSC doesn't go

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Jan Kiszka
On 2011-04-28 08:59, Zachary Amsden wrote: So I've been going over the new code changes to the TSC related code and I don't like one particular set of changes. In particular, here: kvm_x86_ops-vcpu_load(vcpu, cpu); if (unlikely(vcpu-cpu != cpu) || check_tsc_unstable()) {

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Roedel, Joerg
On Thu, Apr 28, 2011 at 02:59:57AM -0400, Zachary Amsden wrote: So I've been going over the new code changes to the TSC related code and I don't like one particular set of changes. In particular, here: kvm_x86_ops-vcpu_load(vcpu, cpu); if (unlikely(vcpu-cpu != cpu) ||

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Roedel, Joerg
On Thu, Apr 28, 2011 at 03:06:01AM -0400, Jan Kiszka wrote: And /me still wonders (like I did when this first popped up) if the proper place of determining TSC stability really have to be KVM. If the Linux core fails to detect some instability and KVM has to jump in, shouldn't we better

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Simon Grinberg
- Original Message - From: Emmanuel Noobadmin centos.ad...@gmail.com To: CentOS mailing list cen...@centos.org, kvm kvm@vger.kernel.org Sent: Tuesday, April 26, 2011 11:57:18 PM Subject: Re: [CentOS] Install CentOS as KVM guest Unfortunately, things still don't work. rant It's

Re: performance of virtual functions compared to virtio

2011-04-28 Thread Avi Kivity
On 04/28/2011 12:13 AM, David Ahern wrote: Is the following depict where copies are done for virtio-net? Yes. You should have been an artist. snip still life of a networked guest -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line

Re: faking vendor-id to guest for driver-install-triggering?

2011-04-28 Thread Avi Kivity
On 04/27/2011 04:15 PM, Oliver Rath wrote: Hi there, is it possible to announce the kvm-guest (i.e. winxp) some arbitrary vendor-id's in a way, that the win-client starts to install the driver for this card? I.e. the RTL8111/8168B PCI Express Gigabit Ethernet Card has the vendor-id 10ec:8168

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Emmanuel Noobadmin
On 4/28/11, Simon Grinberg si...@redhat.com wrote: What version of VMWare are you using? Currently, I'm not using VMWare yet on this new server as I really do hope to be able to use an unified solution. But so far, it's just one brickwall after another. I've given myself until this weekend to

[PATCH 0/5] qemu-kvm: pci-assign: Some more cleanups

2011-04-28 Thread Jan Kiszka
I found these patches in my shared-INTx queue. They do not depend on that topic (which is on my to do list, not on the top, but close), so I decided to repost them. Jan Kiszka (5): pci-assign: Clean up assigned_dev_pci_read/write_config pci-assign: Move merge_bits pci-assign: Fix dword

[PATCH 4/5] pci-assign: Remove suspicious hunk from assigned_dev_pci_read_config

2011-04-28 Thread Jan Kiszka
No one can remember where this came from, and it looks very hacky anyway (we return 0 for config space address 0xfc of _every_ assigned device, not only vga as the comment claims). So better remove it and wait for the underlying issue to reappear. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

[PATCH 2/5] pci-assign: Move merge_bits

2011-04-28 Thread Jan Kiszka
We will need it earlier in the file, so move it unmodified to the top. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/device-assignment.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/hw/device-assignment.c

[PATCH 3/5] pci-assign: Fix dword read at PCI_COMMAND

2011-04-28 Thread Jan Kiszka
If we emulate the command register, we must only read its content from the shadow config space. For dword read of both PCI_COMMAND and PCI_STATUS, at least the latter must be read from the device. For simplicity reasons and as the code path is not considered performance critical for the affected

[PATCH 5/5] pci-assign: Convert need_emulate_cmd into a bitmask

2011-04-28 Thread Jan Kiszka
Define a mask of PCI command register bits that need to be emulated, i.e. read back from their shadow state. We will need this for selectively emulating the INTx mask bit. Note: No initialization of emulate_cmd_mask to zero needed, the device state is already zero-initialized. Signed-off-by: Jan

[PATCH 1/5] pci-assign: Clean up assigned_dev_pci_read/write_config

2011-04-28 Thread Jan Kiszka
Use rages_overlap and proper constants to match the access range against regions that need special handling. This also fixes yet uncaught high-byte write access to the command register. Moreover, use more constants instead of magic numbers. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

[PATCH 0/2] Segment cleanups and optimizations

2011-04-28 Thread Avi Kivity
The first patch in this segment-themed patchset cleans up segment handling in the emulator; while the second patch undoes some of the performance hit taken by the emulator segment limit checks. Avi Kivity (2): KVM: x86 emulator: consolidate segment accessors KVM: VMX: Cache vmcs segment

[PATCH 1/2] KVM: x86 emulator: consolidate segment accessors

2011-04-28 Thread Avi Kivity
Instead of separate accessors for the segment selector and cached descriptor, use one accessor for both. This simplifies the code somewhat. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/include/asm/kvm_emulate.h | 13 +--- arch/x86/kvm/emulate.c | 122

[PATCH 2/2] KVM: VMX: Cache vmcs segment fields

2011-04-28 Thread Avi Kivity
Since the emulator now checks segment limits and access rights, it generates a lot more accesses to the vmcs segment fields. Undo some of the performance hit by cacheing those fields in a read-only cache (the entire cache is invalidated on any write, or on guest exit). Signed-off-by: Avi Kivity

Re: [PATCH 0/5] qemu-kvm: pci-assign: Some more cleanups

2011-04-28 Thread Avi Kivity
On 04/28/2011 11:59 AM, Jan Kiszka wrote: I found these patches in my shared-INTx queue. They do not depend on that topic (which is on my to do list, not on the top, but close), so I decided to repost them. Looks good, will apply after Alex reviews. -- error compiling committee.c: too many

[PATCH 1/2] rcu: export rcu_note_context_switch() function

2011-04-28 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- include/linux/rcutiny.h |6 +- kernel/rcutiny.c|7 +++ kernel/rcutree.c|1 + 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h index 30ebd7c..8e5f7cf

[PATCH 2/2] KVM: make guest mode entry to be rcu quiescent state

2011-04-28 Thread Gleb Natapov
KVM does not hold any references to rcu protected data when it switches CPU into a guest mode. In fact switching to a guest mode is very similar to exiting to userspase from rcu point of view. In addition CPU may stay in a guest mode for quite a long time (up to one time slice). Lets treat guest

[PATCH 0/2] make kvm guest mode to be rcu quiescent state

2011-04-28 Thread Gleb Natapov
CPU may spend a lot of time in a guest mode while other CPUs wait for rcu grace period to elapse. This patch series makes guest mode into quiescent state to shorten wait time. Gleb Natapov (2): rcu: export rcu_note_context_switch() function KVM: make guest mode entry to be rcu quiescent state

Re: nmi is broken?

2011-04-28 Thread Avi Kivity
On 04/28/2011 04:28 AM, OGAWA Hirofumi wrote: Avi Kivitya...@redhat.com writes: On 04/24/2011 03:24 PM, Jan Kiszka wrote: This would cause IRQs to be delivered even if the PIT is masked, no? I checked the patch and our code again: NMI watchdog masking is managed via

Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function

2011-04-28 Thread Avi Kivity
On 04/28/2011 12:52 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapovg...@redhat.com @@ -93,11 +93,7 @@ static inline int rcu_needs_cpu(int cpu) #endif /* #else #ifdef CONFIG_TINY_RCU */ -static inline void rcu_note_context_switch(int cpu) -{ - rcu_sched_qs(cpu); -

Re: [PATCH 1/1] KVM: MMU: Fix 64-bit paging breakage on x86_32

2011-04-28 Thread Avi Kivity
On 04/28/2011 01:08 AM, Takuya Yoshikawa wrote: From: Takuya Yoshikawayoshikawa.tak...@oss.ntt.co.jp Fix regression introduced by commit e30d2a170506830d5eef5e9d7990c5aedf1b0a51 KVM: MMU: Optimize guest page table walk On x86_32, get_user() does not support 64-bit values and we fail to

[ kvm-Bugs-2998292 ] XP Guest Crash on Ubuntu 10.04

2011-04-28 Thread SourceForge.net
Bugs item #2998292, was opened at 2010-05-08 01:28 Message generated for change (Comment added) made by epipe You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2998292group_id=180599 Please note that this message will contain a full copy of the comment

Re: [PATCH] KVM: SVM: Make dump_vmcb static, reduce text

2011-04-28 Thread Avi Kivity
On 04/25/2011 08:00 AM, Joe Perches wrote: dump_vmcb isn't used outside this module, make it static. Shrink text and object by ~1% by standardizing formats. $ size arch/x86/kvm/svm.o* text data bss dec hex filename 52910580 10072 63562f84a

Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function

2011-04-28 Thread Gleb Natapov
On Thu, Apr 28, 2011 at 01:01:04PM +0300, Avi Kivity wrote: On 04/28/2011 12:52 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapovg...@redhat.com @@ -93,11 +93,7 @@ static inline int rcu_needs_cpu(int cpu) #endif /* #else #ifdef CONFIG_TINY_RCU */ -static inline void

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Gleb Natapov
On Wed, Apr 27, 2011 at 04:57:18AM +0800, Emmanuel Noobadmin wrote: Unfortunately, things still don't work. rant It's just ridiculous that the installer under KVM does not detect the cdrom drive it was booted from. Trying to do a net-install doesn't work, maybe I messed up the networking

[ kvm-Bugs-2998292 ] XP Guest Crash on Ubuntu 10.04

2011-04-28 Thread SourceForge.net
Bugs item #2998292, was opened at 2010-05-07 20:28 Message generated for change (Settings changed) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2998292group_id=180599 Please note that this message will contain a full copy of the

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Emmanuel Noobadmin
On 4/28/11, Gleb Natapov g...@redhat.com wrote: So why don't you use virt-manager? The original intention was to run the host without any graphical desktop or anything not necessary to host the guests. That was based on reading and such which recommends not having anything beyond the necessary

Re: [PATCH -v3] Monitor command: x-gpa2hva, translate guest physical address to host virtual address

2011-04-28 Thread Marcelo Tosatti
On Fri, Nov 19, 2010 at 04:17:35PM +0800, Huang Ying wrote: On Tue, 2010-11-16 at 10:23 +0800, Huang Ying wrote: Author: Max Asbock masb...@linux.vnet.ibm.com Add command x-gpa2hva to translate guest physical address to host virtual address. Because gpa to hva translation is not

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Gleb Natapov
On Thu, Apr 28, 2011 at 07:46:28PM +0800, Emmanuel Noobadmin wrote: On 4/28/11, Gleb Natapov g...@redhat.com wrote: So why don't you use virt-manager? The original intention was to run the host without any graphical desktop or anything not necessary to host the guests. That was based on

Re: [PATCH -v3] Monitor command: x-gpa2hva, translate guest physical address to host virtual address

2011-04-28 Thread Anthony Liguori
On 04/27/2011 06:06 PM, Marcelo Tosatti wrote: On Fri, Nov 19, 2010 at 04:17:35PM +0800, Huang Ying wrote: On Tue, 2010-11-16 at 10:23 +0800, Huang Ying wrote: Author: Max Asbockmasb...@linux.vnet.ibm.com Add command x-gpa2hva to translate guest physical address to host virtual address.

[PATCH] KVM: VMX: Avoid reading %rip unnecessarily when handling exceptions

2011-04-28 Thread Avi Kivity
Avoids a VMREAD. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/vmx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 3f6e9bf..139a5cb 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3170,7 +3170,6

[PATCH 1/6] kvm tools: Prevent duplicate definitions of ALIGN

2011-04-28 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/kvm/bios.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/kvm/include/kvm/bios.h b/tools/kvm/include/kvm/bios.h index dd70c44..914720b 100644 --- a/tools/kvm/include/kvm/bios.h +++

[PATCH 4/6] kvm tools: Use threadpool for virtio-blk

2011-04-28 Thread Sasha Levin
virtio-blk has been converted to use the threadpool. All the threading code has been removed, which left only simple callback handling code. New threadpool job types are created within VIRTIO_PCI_QUEUE_PFN for every queue (just one in the case of virtio-blk). The module signals for work after

[PATCH 5/6] kvm tools: Use threadpool for virtio-console.

2011-04-28 Thread Sasha Levin
This is very similar to the change done in virtio-net. Notice that one signal here comes from outside the module (actual terminal) while the other one is generated by the virtio module. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/virtio-console.c | 40

[PATCH 2/6] kvm tools: Add kernel headers required for using list

2011-04-28 Thread Sasha Levin
Adds kernel headers so that linux/list.h (and others) could be included directly. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/linux/kernel.h | 26 ++ tools/kvm/include/linux/prefetch.h |6 ++ tools/kvm/include/linux/types.h|

[PATCH 3/6] kvm tools: Introduce generic IO threadpool

2011-04-28 Thread Sasha Levin
This patch adds a generic pool to create a common interface for working with threads within the kvm tool. Main idea here is using this threadpool for all I/O threads instead of having every I/O module write it's own thread code. The process of working with the thread pool is supposed to be very

[PATCH 6/6] kvm tools: Use threadpool for virtio-net

2011-04-28 Thread Sasha Levin
virtio-net has been converted to use the threadpool. This is very similar to the change done in virtio-blk, only here we had 2 queues to handle. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/virtio-net.c | 101 1 files

Re: nmi is broken?

2011-04-28 Thread OGAWA Hirofumi
Avi Kivity a...@redhat.com writes: This seems to be complex stuff depending on hardware configurations. I'm not fully understanding though, current state of it is, Yes, PIC is in AEOI mode if linux is using IO-APIC. Um.., kvm says irq == 0 is mp_INT mode in MADT, not mp_ExtINT. That is

Re: nmi is broken?

2011-04-28 Thread OGAWA Hirofumi
OGAWA Hirofumi hirof...@mail.parknet.co.jp writes: Avi Kivity a...@redhat.com writes: This seems to be complex stuff depending on hardware configurations. I'm not fully understanding though, current state of it is, Yes, PIC is in AEOI mode if linux is using IO-APIC. Um.., kvm says irq == 0

[PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-04-28 Thread Ulrich Obergfell
Loss of periodic timer interrupts caused by delayed callbacks and by interrupt coalescing is compensated by gradually injecting additional interrupts during subsequent timer intervals, starting at a rate of one additional interrupt per interval. The injection of additional interrupts is based on a

[PATCH v3 0/5] hpet 'driftfix': alleviate time drift with HPET periodic timers

2011-04-28 Thread Ulrich Obergfell
Hi, This is version 3 of a series of patches that I originally posted in: http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01989.html http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01992.html http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01991.html

[PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Ulrich Obergfell
'target_get_irq_delivered' and 'target_reset_irq_delivered' contain entry addresses of functions that are utilized by update_irq() to detect coalesced interrupts. apic code loads these pointers during initialization. This change can be replaced if a generic feedback infrastructure to track

[PATCH v3 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-28 Thread Ulrich Obergfell
The new fields in HPETTimer are covered by a separate VMStateDescription which is a subsection of 'vmstate_hpet_timer'. They are only migrated if -global hpet.driftfix=on Signed-off-by: Ulrich Obergfell uober...@redhat.com --- hw/hpet.c | 33 + 1 files

[PATCH v3 4/5] hpet 'driftfix': add code in update_irq() to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Ulrich Obergfell
update_irq() uses a similar method as in 'rtc_td_hack' to detect coalesced interrupts. The function entry addresses are retrieved from 'target_get_irq_delivered' and 'target_reset_irq_delivered'. This change can be replaced if a generic feedback infrastructure to track coalesced IRQs for

[PATCH v3 2/5] hpet 'driftfix': add driftfix property to HPETState and DeviceInfo

2011-04-28 Thread Ulrich Obergfell
driftfix is a 'bit type' property. Compensation of delayed callbacks and coalesced interrupts can be enabled with the command line option -global hpet.driftfix=on driftfix is 'off' (disabled) by default. Signed-off-by: Ulrich Obergfell uober...@redhat.com --- hw/hpet.c |3 +++ 1 files

Re: [PATCH 1/5] pci-assign: Clean up assigned_dev_pci_read/write_config

2011-04-28 Thread Alex Williamson
On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: Use rages_overlap and proper constants to match the access range against ^ typo - only if you resend regions that need special handling. This also fixes yet uncaught high-byte write access to the command register. Moreover, use

Re: [PATCH 1/5] pci-assign: Clean up assigned_dev_pci_read/write_config

2011-04-28 Thread Jan Kiszka
On 2011-04-28 16:29, Alex Williamson wrote: On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: Use rages_overlap and proper constants to match the access range against ^ typo - only if you resend regions that need special handling. This also fixes yet uncaught high-byte write

Re: [PATCH 3/5] pci-assign: Fix dword read at PCI_COMMAND

2011-04-28 Thread Alex Williamson
On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: If we emulate the command register, we must only read its content from the shadow config space. For dword read of both PCI_COMMAND and PCI_STATUS, at least the latter must be read from the device. For simplicity reasons and as the code

Re: [PATCH 1/5] pci-assign: Clean up assigned_dev_pci_read/write_config

2011-04-28 Thread Alex Williamson
On Thu, 2011-04-28 at 16:46 +0200, Jan Kiszka wrote: On 2011-04-28 16:29, Alex Williamson wrote: On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: Use rages_overlap and proper constants to match the access range against ^ typo - only if you resend regions that need special

Re: [PATCH -v3] Monitor command: x-gpa2hva, translate guest physical address to host virtual address

2011-04-28 Thread Marcelo Tosatti
On Thu, Apr 28, 2011 at 08:00:19AM -0500, Anthony Liguori wrote: On 04/27/2011 06:06 PM, Marcelo Tosatti wrote: On Fri, Nov 19, 2010 at 04:17:35PM +0800, Huang Ying wrote: On Tue, 2010-11-16 at 10:23 +0800, Huang Ying wrote: Author: Max Asbockmasb...@linux.vnet.ibm.com Add command x-gpa2hva

Re: [PATCH 1/5] pci-assign: Clean up assigned_dev_pci_read/write_config

2011-04-28 Thread Jan Kiszka
On 2011-04-28 16:54, Alex Williamson wrote: On Thu, 2011-04-28 at 16:46 +0200, Jan Kiszka wrote: On 2011-04-28 16:29, Alex Williamson wrote: On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: Use rages_overlap and proper constants to match the access range against ^ typo - only if

Virtualize BTS?

2011-04-28 Thread Jun Koi
hi, i am wondering if current KVM version virtualizes the BTS (Branch Trace Store) facility? do we have this facility inside VM? thanks, Jun -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 3/5] pci-assign: Fix dword read at PCI_COMMAND

2011-04-28 Thread Jan Kiszka
On 2011-04-28 16:51, Alex Williamson wrote: On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: If we emulate the command register, we must only read its content from the shadow config space. For dword read of both PCI_COMMAND and PCI_STATUS, at least the latter must be read from the device.

Re: [PATCH 1/5] pci-assign: Clean up assigned_dev_pci_read/write_config

2011-04-28 Thread Jan Kiszka
On 2011-04-28 16:54, Alex Williamson wrote: On Thu, 2011-04-28 at 16:46 +0200, Jan Kiszka wrote: On 2011-04-28 16:29, Alex Williamson wrote: On Thu, 2011-04-28 at 10:59 +0200, Jan Kiszka wrote: Use rages_overlap and proper constants to match the access range against ^ typo - only if

Re: Virtualize BTS?

2011-04-28 Thread Avi Kivity
On 04/28/2011 06:03 PM, Jun Koi wrote: hi, i am wondering if current KVM version virtualizes the BTS (Branch Trace Store) facility? do we have this facility inside VM? No. On AMD we do virtualize a similar feature (LBR). -- error compiling committee.c: too many arguments to function -- To

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Emmanuel Noobadmin
On 4/28/11, Gleb Natapov g...@redhat.com wrote: Qemu is not intended to be used directly by end user. It is too complex as you already found out. VMware don't even give you access to such low parts of virt stack. You should use libvirt or virt-manager instead. Especially if you are concerned

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Zachary Amsden
On 04/28/2011 12:06 AM, Jan Kiszka wrote: On 2011-04-28 08:59, Zachary Amsden wrote: So I've been going over the new code changes to the TSC related code and I don't like one particular set of changes. In particular, here: kvm_x86_ops-vcpu_load(vcpu, cpu); if

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Zachary Amsden
On 04/28/2011 12:13 AM, Roedel, Joerg wrote: On Thu, Apr 28, 2011 at 02:59:57AM -0400, Zachary Amsden wrote: So I've been going over the new code changes to the TSC related code and I don't like one particular set of changes. In particular, here: kvm_x86_ops-vcpu_load(vcpu,

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Blue Swirl
On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell uober...@redhat.com wrote: 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain entry addresses of functions that are utilized by update_irq() to detect coalesced interrupts. apic code loads these pointers during initialization.

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Zachary Amsden
On 04/28/2011 12:22 AM, Roedel, Joerg wrote: On Thu, Apr 28, 2011 at 03:06:01AM -0400, Jan Kiszka wrote: And /me still wonders (like I did when this first popped up) if the proper place of determining TSC stability really have to be KVM. If the Linux core fails to detect some instability

[PATCH 0/3] Fix HTML report generation

2011-04-28 Thread Lucas Meneghel Rodrigues
Made HTML report generation generic and useable by any autotest client job, fixed up some bugs in HTML report code. Now it'll be easier to browse and visualize results without the autotest web interface. Lucas Meneghel Rodrigues (3): tools/html_report: Make html report generation autotest

[PATCH 2/3] virt.virt_utils: Get rid of create_report function

2011-04-28 Thread Lucas Meneghel Rodrigues
As it has been transfered to the html_report module itself. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/virt/virt_utils.py | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/client/virt/virt_utils.py b/client/virt/virt_utils.py index

[PATCH 1/3] tools/html_report: Make html report generation autotest generic

2011-04-28 Thread Lucas Meneghel Rodrigues
The html report tool was a bit too tied to KVM autotest, and that was not necessary. Turn it into a generic module that can be used by any autotest job, encapsulate the main worker function into autotest API so we don't need to exec it in a subshell, fix naming of the report and CSS details.

[PATCH 3/3] KVM test: control: Replace create_report function call

2011-04-28 Thread Lucas Meneghel Rodrigues
Following up with the previous changes. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/control |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/control b/client/tests/kvm/control index 6437d88..eb95a33 100644 ---

[PATCH] kvm tools: Emulate RTC to fix system time in guests

2011-04-28 Thread Pekka Enberg
This patch fixes system time in guests by implementing proper CMOS RTC clock support. # Before: sh-2.05b# date Fri Aug 7 04:02:01 UTC 2009 # After: sh-2.05b# date Thu Apr 28 19:12:21 UTC 2011 Cc: Asias He asias.he...@gmail.com Cc: Cyrill Gorcunov gorcu...@gmail.com Cc: Ingo

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Joerg Roedel
On Thu, Apr 28, 2011 at 11:34:44AM -0700, Zachary Amsden wrote: On 04/28/2011 12:13 AM, Roedel, Joerg wrote: I see it different. This code wants to check if the _guest_ tsc moves forwared (or at least not backwards). So it is fully legitimate to just do this by reading the guest-tsc and

Re: [PATCH] kvm tools: Emulate RTC to fix system time in guests

2011-04-28 Thread Ingo Molnar
* Pekka Enberg penb...@kernel.org wrote: This patch fixes system time in guests by implementing proper CMOS RTC clock support. # Before: sh-2.05b# date Fri Aug 7 04:02:01 UTC 2009 # After: sh-2.05b# date Thu Apr 28 19:12:21 UTC 2011 Very nice! Ingo -- To

Re: [CentOS] Install CentOS as KVM guest

2011-04-28 Thread Emmanuel Noobadmin
On 4/28/11, Gleb Natapov g...@redhat.com wrote: of virt stack. You should use libvirt or virt-manager instead. Especially if you are concerned about security. I think libvirt can start guest on headless server. If this still fails for you you need to complain to libvirt developers (not in a

Re: [Qemu-devel] KVM call minutes for Apr 26

2011-04-28 Thread Lucas Meneghel Rodrigues
On Tue, 2011-04-26 at 16:29 -0500, Anthony Liguori wrote: On 04/26/2011 11:47 AM, Lucas Meneghel Rodrigues wrote: On Tue, 2011-04-26 at 17:58 +0300, Avi Kivity wrote: On 04/26/2011 05:41 PM, Chris Wright wrote: - having basic common config could be useful Hi Lucas, Could you send your

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Jan Kiszka
On 2011-04-28 21:06, Zachary Amsden wrote: On 04/28/2011 12:22 AM, Roedel, Joerg wrote: On Thu, Apr 28, 2011 at 03:06:01AM -0400, Jan Kiszka wrote: And /me still wonders (like I did when this first popped up) if the proper place of determining TSC stability really have to be KVM. If the

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Jan Kiszka
On 2011-04-28 20:51, Blue Swirl wrote: On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell uober...@redhat.com wrote: 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain entry addresses of functions that are utilized by update_irq() to detect coalesced interrupts. apic code loads

Re: Guest virtual CPUs limited to only 50% of host CPU

2011-04-28 Thread Drew Johnson
Thanks for the reply. Turns out it was htop reporting it wrong. The utime in /proc/stat already includes guest time. On Tue, Apr 5, 2011 at 2:03 AM, Avi Kivity a...@redhat.com wrote: On 03/31/2011 11:03 PM, Drew Johnson wrote: Hi, I am using Qemu-KVM-0.12.5 This is somewhat old.  Try

Re: [PATCH -v3] Monitor command: x-gpa2hva, translate guest physical address to host virtual address

2011-04-28 Thread Huang Ying
On 04/28/2011 10:04 PM, Marcelo Tosatti wrote: On Thu, Apr 28, 2011 at 08:00:19AM -0500, Anthony Liguori wrote: On 04/27/2011 06:06 PM, Marcelo Tosatti wrote: On Fri, Nov 19, 2010 at 04:17:35PM +0800, Huang Ying wrote: On Tue, 2010-11-16 at 10:23 +0800, Huang Ying wrote: Author: Max

Re: [RFC PATCH 3/3] KVM: MMU: Optimize guest page table walk

2011-04-28 Thread Andi Kleen
Avi Kivity a...@redhat.com writes: Good optimization. copy_from_user() really isn't optimized for short buffers, I expect much of the improvement comes from that. Actually it is equivalent to get_user for the lenghts supported by get_user, assuming you pass in a constant length. You probably

Re: Bug in KVM clock backwards compensation

2011-04-28 Thread Zachary Amsden
On 04/28/2011 01:20 PM, Joerg Roedel wrote: On Thu, Apr 28, 2011 at 11:34:44AM -0700, Zachary Amsden wrote: On 04/28/2011 12:13 AM, Roedel, Joerg wrote: I see it different. This code wants to check if the _guest_ tsc moves forwared (or at least not backwards). So it is fully

[PATCH 0/4] Fix HTML report generation v2

2011-04-28 Thread Lucas Meneghel Rodrigues
Made HTML report generation generic and useable by any autotest client job, fixed up some bugs in HTML report code. Now it'll be easier to browse and visualize results without the autotest web interface. Lucas Meneghel Rodrigues (4): tools/html_report: Make html report generation autotest

[PATCH 1/4] tools/html_report: Make html report generation autotest generic

2011-04-28 Thread Lucas Meneghel Rodrigues
The html report tool was a bit too tied to KVM autotest, and that was not necessary. Turn it into a generic module that can be used by any autotest job, encapsulate the main worker function into autotest API so we don't need to exec it in a subshell, fix naming of the report and CSS details.

[PATCH 2/4] job: Write a job HTML report for every autotest client job

2011-04-28 Thread Lucas Meneghel Rodrigues
We have a tool that can generate such a file and it makes it easier for people who don't have access to the autotest web interface to analyze job results. With this, all client jobs write such a file, so test writers don't have to worry about it. This change does not regress the job unittests.

[PATCH 4/4] KVM test: control: Get rid of report generation code

2011-04-28 Thread Lucas Meneghel Rodrigues
As this is now handled by autotest and control file writers don't have to worry about it anymore. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/control |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/control

[PATCH 3/4] virt.virt_utils: Get rid of create_report function

2011-04-28 Thread Lucas Meneghel Rodrigues
As it has been transfered to the html_report module itself. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/virt/virt_utils.py | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/client/virt/virt_utils.py b/client/virt/virt_utils.py index

[PATCH] KVM test: Fix problem when unexpected strings appear on SSH prompt

2011-04-28 Thread Lucas Meneghel Rodrigues
In some conditions, ssh may respond things like: Warning: Permanently added localhost' (RSA) to the list of known hosts. Take that into account on the remote login function. Signed-off-by: Jason D. Gaston jason.d.gas...@intel.com --- client/virt/virt_utils.py |7 +-- 1 files changed, 5

Re: [Autotest] [Autotest PATCH] KVM-test: Check if guest bootable after reseting several times

2011-04-28 Thread Lucas Meneghel Rodrigues
On Thu, Apr 21, 2011 at 3:47 AM, Amos Kong ak...@redhat.com wrote: This test comes from a regression bug: Guest can not found bootable device after reseting several times by monitor command. Can you point out the bug number? I really don't expect that we keep integrity of the disk after

Re: [Autotest] [Autotest PATCH] KVM-test: Simple stop/continue test

2011-04-28 Thread Lucas Meneghel Rodrigues
On Thu, Apr 21, 2011 at 3:21 AM, Amos Kong ak...@redhat.com wrote: Change guest state by monitor cmd, verify guest status, and try to login guest by network. I don't like the way you're handling human monitor and QMP monitors in this tests... comments below: Signed-off-by: Jason Wang

Re: [RFC PATCH 3/3] KVM: MMU: Optimize guest page table walk

2011-04-28 Thread Takuya Yoshikawa
On Thu, 28 Apr 2011 19:46:00 -0700 Andi Kleen a...@firstfloor.org wrote: Avi Kivity a...@redhat.com writes: Good optimization. copy_from_user() really isn't optimized for short buffers, I expect much of the improvement comes from that. Actually it is equivalent to get_user for the

Re: [Autotest] [Autotest PATCH] KVM-test: TSC drift test

2011-04-28 Thread Lucas Meneghel Rodrigues
On Thu, Apr 21, 2011 at 4:33 AM, Amos Kong ak...@redhat.com wrote: This case is used to test the drift between host and guest. Use taskset to make tsc program execute in a single cpu. If the drift ratio bigger than 10%, then fail this case. The calculations of the tsc frequency looks wrong...

Re: [PATCH v2 2/2] KVM: PPC: booke: add sregs support

2011-04-28 Thread Alexander Graf
Both patches look good to me. I'll apply them to my tree. Alex On 28.04.2011, at 00:24, Scott Wood scottw...@freescale.com wrote: Signed-off-by: Scott Wood scottw...@freescale.com --- v2: reject KVM_SET_SREGS that tries to change PVR, as requested Documentation/kvm/api.txt |