Re: [PATCH 02/11] kvm tools: Hold a copy of ops struct inside disk_image

2011-10-31 Thread Pekka Enberg
On Sun, Oct 30, 2011 at 7:35 PM, Sasha Levin wrote: > This makes passing different ops structures easier since you don't have > to keep them somewhere else after initializing disk_image. > > Signed-off-by: Sasha Levin Why do we want to do this? Why would you ever want to allocate ops via malloc(

[PATCH] KVM test: nic_hotplug: Use -f on mv commands

2011-10-31 Thread Lucas Meneghel Rodrigues
A given sequence of nic_hotplug iterations might leave the system in a state that mv might overwrite a file. If the -f flag is not passed to the mv command, the system will go to interactive mode, which is clearly not desirable. So, introduce a mimic of the os.path.exists() API to verify the presen

Re: [PATCHv4] virtio-blk: use ida to allocate disk index

2011-10-31 Thread Rusty Russell
On Mon, 31 Oct 2011 08:05:55 +0100, Jens Axboe wrote: > On 2011-10-30 20:29, Michael S. Tsirkin wrote: > > Based on a patch by Mark Wu > > > > Current index allocation in virtio-blk is based on a monotonically > > increasing variable "index". This means we'll run out of numbers > > after a while

Re: [PATCH 08/14] Revert "KVM: PPC: Add support for explicit HIOR setting"

2011-10-31 Thread Alexander Graf
On 31.10.2011, at 06:30, Avi Kivity wrote: > On 10/31/2011 09:53 AM, Alexander Graf wrote: >> This reverts commit 11d7596e18a712dc3bc29d45662ec111fd65946b. It exceeded >> the padding on the SREGS struct, rendering the ABI backwards-incompatible. > > Can't find the commit hash. Please use hashe

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-10-31 Thread Scott Wood
On 10/31/2011 08:24 AM, Avi Kivity wrote: > On 10/31/2011 09:53 AM, Alexander Graf wrote: >> From: Scott Wood >> >> This implements a shared-memory API for giving host userspace access to >> the guest's TLB. >> >> >> diff --git a/Documentation/virtual/kvm/api.txt >> b/Documentation/virtual/kvm/ap

[PATCH 5/6 V2] Add check for suspended vm in softlockup detector

2011-10-31 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. Signed-off-by: Eric B Munson --- kernel/watchdog.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff

[PATCH 4/6 V2] Add generic stubs for kvm stop check functions

2011-10-31 Thread Eric B Munson
Signed-off-by: Eric B Munson --- include/asm-generic/pvclock.h | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 include/asm-generic/pvclock.h diff --git a/include/asm-generic/pvclock.h b/include/asm-generic/pvclock.h new file mode 100644 index 000

[PATCH 6/6 V2] Add age out of guest paused flag

2011-10-31 Thread Eric B Munson
The KVM_GUEST_PAUSED flag will prevent a guest from compaining about a soft lockup but it can mask real soft lockups if the flag isn't cleared when it is no longer relevant. This patch adds a kvm ioctl that the hypervisor will use when it resumes a guest to start a timer for aging out the flag. T

[PATCH 3/6 V2] Add ioctl for KVM_GUEST_STOPPED

2011-10-31 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson --- Changes from V1: Add kvm_set_host_stopped to arch/x86/jvm/x86.c instead of kvmclock.c Rename KVM_PAUSE_GUEST to KVM_GUEST_PAUSED ar

[PATCH 1/6 V2] Add flag to indicate that a vm was stopped by the host

2011-10-31 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock-abi.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include/a

[PATCH 2/6 V2] Add functions to check if the host has stopped the vm

2011-10-31 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |2 ++ arch/x86/kernel/kvmclock.c | 19 +

[PATCH 0/6 V2] Avoid soft lockup message when KVM is stopped by host

2011-10-31 Thread Eric B Munson
Changes from V1: (Thanks Marcelo) Host code has all been moved to arch/x86/kvm/x86.c KVM_PAUSE_GUEST was renamed to KVM_GUEST_PAUSED When a guest kernel is stopped by the host hypervisor it can look like a soft lockup to the guest kernel. This false warning can mask later soft lockup warnings whi

KVM call agenda for November 1st

2011-10-31 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

KVM call agenda for November 1st

2011-10-31 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan. PD. Tomorrow is a Spanish holiday, so I would not attend the call. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH 01/14] KVM: PPC: e500: don't translate gfn to pfn with preemption disabled

2011-10-31 Thread Scott Wood
On 10/31/2011 07:50 AM, Avi Kivity wrote: > On 10/31/2011 09:53 AM, Alexander Graf wrote: >> +/* sesel is index into the set, not the whole array */ >> +static void write_stlbe(struct kvmppc_vcpu_e500 *vcpu_e500, >> +struct tlbe *gtlbe, >> +struct tlbe *stlbe

RE: [net-next-2.6 PATCH 0/6 RFC v3] macvlan: MAC Address filtering support for passthru mode

2011-10-31 Thread Rose, Gregory V
> -Original Message- > From: Roopa Prabhu [mailto:ropra...@cisco.com] > Sent: Monday, October 31, 2011 10:09 AM > To: Rose, Gregory V; net...@vger.kernel.org > Cc: s...@us.ibm.com; dragos.tatu...@gmail.com; kvm@vger.kernel.org; > a...@arndb.de; m...@redhat.com; da...@davemloft.net; mc...@br

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-10-31 Thread Jan Kiszka
On 2011-10-31 14:36, Avi Kivity wrote: > On 10/31/2011 09:53 AM, Alexander Graf wrote: >> Right now we transfer a static struct every time we want to get or set >> registers. Unfortunately, over time we realize that there are more of >> these than we thought of before and the extensibility and flex

Re: [net-next-2.6 PATCH 0/6 RFC v3] macvlan: MAC Address filtering support for passthru mode

2011-10-31 Thread Roopa Prabhu
On 10/31/11 9:38 AM, "Rose, Gregory V" wrote: >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Roopa Prabhu >> Sent: Friday, October 28, 2011 7:34 PM >> To: net...@vger.kernel.org >> Cc: s...@us.ibm.com; dragos.tatu...@gm

Re: [Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

2011-10-31 Thread Anthony Liguori
On 10/27/2011 07:10 AM, Marcelo Tosatti wrote: The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at: git://github.co

RE: [net-next-2.6 PATCH 0/6 RFC v3] macvlan: MAC Address filtering support for passthru mode

2011-10-31 Thread Rose, Gregory V
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Roopa Prabhu > Sent: Friday, October 28, 2011 7:34 PM > To: net...@vger.kernel.org > Cc: s...@us.ibm.com; dragos.tatu...@gmail.com; kvm@vger.kernel.org; > a...@arndb.de; m...@redha

Re: 1.0 Hard Freeze Logistics

2011-10-31 Thread Anthony Liguori
On 10/31/2011 08:28 AM, Anthony Liguori wrote: Hi, Here are the logistics for the upcoming 1.0 hard freeze. All dates are reflected in the wiki[1]. If you're a contributor and you've sent a series before the soft freeze deadline, you've already done everything you need to do so sit back and enj

[PATCH 5/5] kvm tools: Remove dead code virt_queue__trigger_irq()

2011-10-31 Thread Asias He
This function is not used anymore. Instead, We are using virtio_pci__signal_vq() to trigger interrupt right now. Signed-off-by: Asias He --- tools/kvm/include/kvm/virtio.h |3 --- tools/kvm/virtio/core.c| 12 2 files changed, 0 insertions(+), 15 deletions(-) diff --gi

[PATCH 4/5] kvm tools: Fix ndev mutex and condition variable initialization

2011-10-31 Thread Asias He
This patch fixes the initialization of the following variables: ndev->io_tx_lock ndev->io_rx_lock ndev->io_tx_cond ndev->io_rx_cond Signed-off-by: Asias He --- tools/kvm/virtio/net.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/kvm/virtio/net.c

[PATCH 3/5] kvm tools: Fix a vertical indentation for net/uip/udp.c

2011-10-31 Thread Asias He
Signed-off-by: Asias He --- tools/kvm/net/uip/udp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/kvm/net/uip/udp.c b/tools/kvm/net/uip/udp.c index 39c2b57..d4518b2 100644 --- a/tools/kvm/net/uip/udp.c +++ b/tools/kvm/net/uip/udp.c @@ -182,7 +182,7 @@ static void

[PATCH 2/5] kvm tools: Use macro in uip_tx_do_ipv4()

2011-10-31 Thread Asias He
Use marcro instead of magic number in uip_tx_do_ipv4() Signed-off-by: Asias He --- tools/kvm/include/kvm/uip.h |1 + tools/kvm/net/uip/ipv4.c|6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/kvm/include/kvm/uip.h b/tools/kvm/include/kvm/uip.h index bded9

[PATCH 1/5] kvm tools: Drop unused variable in struct uip_buf

2011-10-31 Thread Asias He
'u32 payload' is not used, so drop it. Signed-off-by: Asias He --- tools/kvm/include/kvm/uip.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/tools/kvm/include/kvm/uip.h b/tools/kvm/include/kvm/uip.h index 3501d36..bded986 100644 --- a/tools/kvm/include/kvm/uip.h +++ b/

Re: 1.0 Hard Freeze Logistics

2011-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2011 at 1:28 PM, Anthony Liguori wrote: > To make the Test Day more successful, please sign up to test a specific area > on the Test[3] wiki page. [...] > [3] http://wiki.qemu.org/Planning/1.0/Testing I just signed up for several block and tracing tests and encourage everyone to g

Re: [PATCH 13/14] KVM: PPC: E500: Support hugetlbfs

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > With hugetlbfs support emerging on e500, we should also support KVM > backing its guest memory by it. > > This patch adds support for hugetlbfs into the e500 shadow mmu code. > > > @@ -673,12 +674,31 @@ static inline void kvmppc_e500_shadow_map(struct

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > Right now we transfer a static struct every time we want to get or set > registers. Unfortunately, over time we realize that there are more of > these than we thought of before and the extensibility and flexibility of > transferring a full struct ever

1.0 Hard Freeze Logistics

2011-10-31 Thread Anthony Liguori
Hi, Here are the logistics for the upcoming 1.0 hard freeze. All dates are reflected in the wiki[1]. If you're a contributor and you've sent a series before the soft freeze deadline, you've already done everything you need to do so sit back and enjoy gorge yourself on Halloween candy. If

Re: [PATCH 08/14] Revert "KVM: PPC: Add support for explicit HIOR setting"

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > This reverts commit 11d7596e18a712dc3bc29d45662ec111fd65946b. It exceeded > the padding on the SREGS struct, rendering the ABI backwards-incompatible. Can't find the commit hash. Please use hashes from the Linus tree when possible. This needs to be

Re: [PATCH 06/14] KVM: PPC: e500: Don't hardcode PIR=0

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > From: Scott Wood > > The hardcoded behavior prevents proper SMP support. > > QEMU shall specify the vcpu's PIR as the vcpu id. > > Could also be kvm tool - we generally use the code name 'userspace' to refer to qemu (but don't rewrite the patch on t

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > From: Scott Wood > > This implements a shared-memory API for giving host userspace access to > the guest's TLB. > > > diff --git a/Documentation/virtual/kvm/api.txt > b/Documentation/virtual/kvm/api.txt > index 7945b0b..ab1136f 100644 > --- a/Docume

Re: [PATCH 01/14] KVM: PPC: e500: don't translate gfn to pfn with preemption disabled

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > From: Scott Wood > > Delay allocation of the shadow pid until we're ready to disable > preemption and write the entry. > > @@ -507,21 +507,16 @@ static inline void kvmppc_e500_deliver_tlb_miss(struct > kvm_vcpu *vcpu, > vcpu_e500->mas7 = 0; >

Re: [PATCH 08/11] kvm tools: Split io request from completion

2011-10-31 Thread Asias He
On 10/31/2011 01:35 AM, Sasha Levin wrote: > This patch splits IO request processing from completion notification. > > Signed-off-by: Sasha Levin > --- > tools/kvm/disk/core.c |6 +- > tools/kvm/include/kvm/disk-image.h |4 +- > tools/kvm/include/kvm/virtio-blk.h |1 + >

Re: kernel BUG at include/linux/kvm_host.h:603!

2011-10-31 Thread Jörg Sommer
Hi Alexander, Alexander Graf hat am Mon 10. Oct, 10:09 (+0200) geschrieben: > On 07.10.2011, at 23:10, Jörg Sommer wrote: > > > Hi, > > > > I've got this backtrace: > > > > [130902.709711] [ cut here ] > > [130902.709747] kernel BUG at include/linux/kvm_host.h:603! > >

Re: [PATCH 0/1] virtio: console: fix for early console

2011-10-31 Thread Amit Shah
On (Thu) 22 Sep 2011 [23:44:22], Amit Shah wrote: > Hi Rusty, > > This is a fix from Christian for early console handling with multiport > support. Please apply. > > Christian, I've made some changes to the patch as noted in the commit > message. Nothing major, but an ACK would be nice. > > Th

[PATCH] [kvm-autotest] tests.cgroup: Add TestFreezer

2011-10-31 Thread Lukas Doktor
This subtest tests the 'freezer.state' cgroup functionality. It assignes the virtual machine into freezer cgroup, schedule cpu-intensive work and verifies the correct function in both states (frozen/thawed) during long and short period of time. * Adds TestFreezer (freezer) test * Adds assign_vm_

[kvm-autotest] tests.cgroup: Add TestFreezer

2011-10-31 Thread Lukas Doktor
This subtest tests the 'freezer.state' cgroup functionality. It assignes the virtual machine into freezer cgroup, schedule cpu-intensive work and verifies the correct function in both states (frozen/thawed) during long and short period of time. * Adds TestFreezer (freezer) test * Adds assign_vm_

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-31 Thread Kenji Kaneshige
(2011/10/28 21:48), Jun Koi wrote: 2011/10/28 Kenji Kaneshige: Avi, Jan, Could you comment on these patches? Inject-NMI doesn't work on Windows guest without these patches. sorry but i am really curious here: why Windows still works well even if it desnt see the inject-NMI? or there are stil

[PATCH 01/14] KVM: PPC: e500: don't translate gfn to pfn with preemption disabled

2011-10-31 Thread Alexander Graf
From: Scott Wood Delay allocation of the shadow pid until we're ready to disable preemption and write the entry. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- arch/powerpc/kvm/e500_tlb.c | 36 +++- 1 files changed, 23 insertions(+), 13 deletions

[PATCH 06/14] KVM: PPC: e500: Don't hardcode PIR=0

2011-10-31 Thread Alexander Graf
From: Scott Wood The hardcoded behavior prevents proper SMP support. QEMU shall specify the vcpu's PIR as the vcpu id. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- arch/powerpc/kvm/booke.c |4 ++-- arch/powerpc/kvm/e500.c |3 --- 2 files changed, 2 insertions(+), 5 de

[PATCH 10/14] KVM: PPC: Add support for explicit HIOR setting

2011-10-31 Thread Alexander Graf
Until now, we always set HIOR based on the PVR, but this is just wrong. Instead, we should be setting HIOR explicitly, so user space can decide what the initial HIOR value is - just like on real hardware. We keep the old PVR based way around for backwards compatibility, but once user space uses th

[PATCH 08/14] Revert "KVM: PPC: Add support for explicit HIOR setting"

2011-10-31 Thread Alexander Graf
This reverts commit 11d7596e18a712dc3bc29d45662ec111fd65946b. It exceeded the padding on the SREGS struct, rendering the ABI backwards-incompatible. Signed-off-by: Alexander Graf --- arch/powerpc/include/asm/kvm.h|8 arch/powerpc/include/asm/kvm_book3s.h |2 -- arch/powe

[PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-10-31 Thread Alexander Graf
Right now we transfer a static struct every time we want to get or set registers. Unfortunately, over time we realize that there are more of these than we thought of before and the extensibility and flexibility of transferring a full struct every time is limited. So this is a new approach to the p

[PATCH 11/14] KVM: PPC: Whitespace fix for kvm.h

2011-10-31 Thread Alexander Graf
kvm.h had sparse whitespace at the end of the line. Clean it up so syncing with QEMU gets easier. Signed-off-by: Alexander Graf --- arch/powerpc/include/asm/kvm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/kvm.h b/arch/powerpc/include/asm

[PATCH 03/14] KVM: PPC: e500: clear up confusion between host and guest entries

2011-10-31 Thread Alexander Graf
From: Scott Wood Split out the portions of tlbe_priv that should be associated with host entries into tlbe_ref. Base victim selection on the number of hardware entries, not guest entries. For TLB1, where one guest entry can be mapped by multiple host entries, we use the host tlbe_ref for tracki

[PATCH 02/14] KVM: PPC: e500: Eliminate preempt_disable in local_sid_destroy_all

2011-10-31 Thread Alexander Graf
From: Scott Wood The only place it makes sense to call this function already needs to have preemption disabled. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- arch/powerpc/kvm/e500_tlb.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kvm/

[PATCH 13/14] KVM: PPC: E500: Support hugetlbfs

2011-10-31 Thread Alexander Graf
With hugetlbfs support emerging on e500, we should also support KVM backing its guest memory by it. This patch adds support for hugetlbfs into the e500 shadow mmu code. Signed-off-by: Alexander Graf Acked-by: Scott Wood --- v1 -> v2: - address scott's comments --- arch/powerpc/kvm/e500_tl

[PATCH 04/14] KVM: PPC: e500: MMU API

2011-10-31 Thread Alexander Graf
From: Scott Wood This implements a shared-memory API for giving host userspace access to the guest's TLB. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- Documentation/virtual/kvm/api.txt | 74 +++ arch/powerpc/include/asm/kvm.h | 35 +++ arch/powerpc/include/asm/kv

[PATCH 12/14] KVM: Fix whitespace in kvm_para.h

2011-10-31 Thread Alexander Graf
When syncing KVM headers with QEMU I (or whoever applies the diff) end up automatically fixing whitespaces. One of them is in kvm_para.h. It's a lot more consistent for people who don't do the whitespace fixups automatically to already have fixed headers in Linux. So remove the sparse empty line a

[PATCH 14/14] PPC: Fix race in mtmsr paravirt implementation

2011-10-31 Thread Alexander Graf
From: Bharat Bhushan The current implementation of mtmsr and mtmsrd are racy in that it does: * check (int_pending == 0) ---> host sets int_pending = 1 <--- * write shared page * done while instead we should check for int_pending after the shared page is written. Signed-off-by: Bharat

[PATCH 05/14] KVM: PPC: e500: tlbsx: fix tlb0 esel

2011-10-31 Thread Alexander Graf
From: Scott Wood It should contain the way, not the absolute TLB0 index. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- arch/powerpc/kvm/e500_tlb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch/powerpc/kvm/e500_tlb.c

[PULL 00/14] ppc patch queue 2011-10-31

2011-10-31 Thread Alexander Graf
Hi Avi / Marcelo, This is my current patch queue for ppc. Please pull. Alex The following changes since commit b796a09c5d808f4013f27ad45953db604dac18fd: Marcelo Tosatti (1): Merge remote-tracking branch 'upstream/master' into kvm-devel are available in the git repository at: git:/

[PATCH 07/14] KVM: PPC: Fix build failure with HV KVM and CBE

2011-10-31 Thread Alexander Graf
When running with HV KVM and CBE config options enabled, I get build failures like the following: arch/powerpc/kernel/head_64.o: In function `cbe_system_error_hv': (.text+0x1228): undefined reference to `do_kvm_0x1202' arch/powerpc/kernel/head_64.o: In function `cbe_maintenance_hv': (.text

Re: [PATCHv4] virtio-blk: use ida to allocate disk index

2011-10-31 Thread Jens Axboe
On 2011-10-30 20:29, Michael S. Tsirkin wrote: > Based on a patch by Mark Wu > > Current index allocation in virtio-blk is based on a monotonically > increasing variable "index". This means we'll run out of numbers > after a while. It also could cause confusion about the disk > name in the case