[PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org --- hw/spapr_vscsi.c |4 +++- 1 file changed, 3

Re: [PATCH v2 1/7] KVM Guest: Add VCPU running/pre-empted state for guest

2012-06-19 Thread Nikunj A Dadhania
On Tue, 12 Jun 2012 19:43:10 -0300, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Jun 04, 2012 at 10:36:05AM +0530, Nikunj A. Dadhania wrote: The patch adds guest code for msr between guest and hypervisor. The msr will export the vcpu running/pre-empted information to the guest from

Re: [PATCH v2 3/7] KVM: Add paravirt kvm_flush_tlb_others

2012-06-19 Thread Nikunj A Dadhania
Hi Marcelo, Thanks for the review. On Tue, 12 Jun 2012 20:02:18 -0300, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Jun 04, 2012 at 10:37:24AM +0530, Nikunj A. Dadhania wrote: flush_tlb_others_ipi depends on lot of statics in tlb.c. Replicated the flush_tlb_others_ipi as

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-06-19 Thread Dor Laor
On 06/19/2012 05:51 AM, Asias He wrote: On 06/18/2012 07:39 PM, Sasha Levin wrote: On Mon, 2012-06-18 at 14:14 +0300, Dor Laor wrote: On 06/18/2012 01:05 PM, Rusty Russell wrote: On Mon, 18 Jun 2012 16:03:23 +0800, Asias Heas...@redhat.com wrote: On 06/18/2012 03:46 PM, Rusty Russell wrote:

[PATCH v3] spapr: Add memop hypercall

2012-06-19 Thread Benjamin Herrenschmidt
This adds a qemu-specific hypervisor call to the pseries machine which allows to do what amounts to memmove, memcpy and xor over regions of physical memory such as the framebuffer. This is the simplest way to get usable framebuffer speed from SLOF since the framebuffer isn't mapped in the VRMA

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-19 Thread Emmanuel Noobadmin
On 6/18/12, Stefan Hajnoczi stefa...@gmail.com wrote: off. The code suggests that QEMU also logs an error message (USBDEVFS_REAPURBNDELAY: Inappropriate ioctl for device) when this happens. If you want, check the libvirt log file for this guest - it probably has tons of these messages in it.

Re: [PATCH v3 6/6] KVM: introduce readonly memslot

2012-06-19 Thread Gleb Natapov
On Mon, Jun 18, 2012 at 05:25:05PM -0300, Marcelo Tosatti wrote: On Mon, Jun 18, 2012 at 12:50:10PM +0300, Avi Kivity wrote: On 06/16/2012 05:11 AM, Marcelo Tosatti wrote: Can you introduce a separate exit reason, say KVM_EXIT_READ_FAULT, with information about the fault? I think

Re: [PATCH v3 6/6] KVM: introduce readonly memslot

2012-06-19 Thread Avi Kivity
On 06/18/2012 11:25 PM, Marcelo Tosatti wrote: On Mon, Jun 18, 2012 at 12:50:10PM +0300, Avi Kivity wrote: On 06/16/2012 05:11 AM, Marcelo Tosatti wrote: Can you introduce a separate exit reason, say KVM_EXIT_READ_FAULT, with information about the fault? I think you mean WRITE_FAULT.

RE: [PATCH v4] KVM: x86: Implement PCID/INVPCID for guests with EPT

2012-06-19 Thread Mao, Junjie
Hi, Avi Any comments for the patch? Best Regards Junjie Mao -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Saturday, June 16, 2012 10:32 AM To: Mao, Junjie Cc: 'kvm@vger.kernel.org'; Avi Kivity Subject: Re: [PATCH v4] KVM: x86: Implement PCID/INVPCID

Re: [PATCH v8 04/15] KVM: Guard mmu_notifier specific code with CONFIG_MMU_NOTIFIER

2012-06-19 Thread Avi Kivity
On 06/18/2012 08:47 PM, Christoffer Dall wrote: On Mon, Jun 18, 2012 at 9:08 AM, Avi Kivity a...@redhat.com wrote: On 06/15/2012 10:07 PM, Christoffer Dall wrote: From: Marc Zyngier marc.zyng...@arm.com In order to avoid compilation failure when KVM is not compiled in, guard the mmu_notifier

Re: [PATCH v8 06/15] ARM: KVM: Hypervisor identity mapping

2012-06-19 Thread Avi Kivity
On 06/18/2012 08:55 PM, Christoffer Dall wrote: On Mon, Jun 18, 2012 at 9:12 AM, Avi Kivity a...@redhat.com wrote: On 06/15/2012 10:07 PM, Christoffer Dall wrote: Adds support in the identity mapping feature that allows KVM to setup identity mapping for the Hyp mode with the AP[1] bit set as

Re: [PATCH v8 10/15] ARM: KVM: Inject IRQs and FIQs from userspace

2012-06-19 Thread Avi Kivity
On 06/18/2012 11:56 PM, Christoffer Dall wrote: On Mon, Jun 18, 2012 at 9:32 AM, Avi Kivity a...@redhat.com wrote: On 06/15/2012 10:08 PM, Christoffer Dall wrote: From: Christoffer Dall cd...@cs.columbia.edu Userspace can inject IRQs and FIQs through the KVM_IRQ_LINE VM ioctl. This ioctl is

Re: [PATCH v8 11/15] ARM: KVM: World-switch implementation

2012-06-19 Thread Avi Kivity
On 06/19/2012 01:05 AM, Christoffer Dall wrote: Premature, but this is sad. I suggest you split vmid generation from next available vmid. This allows you to make the generation counter atomic so it may be read outside the lock. You can do if (likely(kvm-arch.vmd_gen) ==

Re: SOLVED: RE: Garbled audio - Windows 7 64 bit guest on Debian

2012-06-19 Thread Avi Kivity
On 06/18/2012 10:32 PM, Jimmy Crossley wrote: I have mostly solved this issue. The sound works much, much, better, but is still not as good as on my host machine. I installed PulseAudio and used it instead of ALSA. In order to get kvm to use it, I set the environment variable

Re: [PATCH v8 13/15] ARM: KVM: Handle guest faults in KVM

2012-06-19 Thread Avi Kivity
On 06/19/2012 01:20 AM, Christoffer Dall wrote: On Mon, Jun 18, 2012 at 9:45 AM, Avi Kivity a...@redhat.com wrote: On 06/15/2012 10:09 PM, Christoffer Dall wrote: From: Christoffer Dall cd...@cs.columbia.edu Handles the guest faults in KVM by mapping in corresponding user pages in the 2nd

Re: [PATCH v2 0/3] Improve virtio-blk performance

2012-06-19 Thread Stefan Hajnoczi
On Tue, Jun 19, 2012 at 5:24 AM, Asias He as...@redhat.com wrote: On 06/18/2012 06:58 PM, Stefan Hajnoczi wrote: As long as the latency is decreasing that's good.  But It's worth keeping in mind that these percentages are probably wildly different on real storage devices and/or qemu-kvm.  

Re: [PATCH v8 13/15] ARM: KVM: Handle guest faults in KVM

2012-06-19 Thread Andrea Arcangeli
On Tue, Jun 19, 2012 at 12:32:06PM +0300, Avi Kivity wrote: On 06/19/2012 01:20 AM, Christoffer Dall wrote: On Mon, Jun 18, 2012 at 9:45 AM, Avi Kivity a...@redhat.com wrote: On 06/15/2012 10:09 PM, Christoffer Dall wrote: From: Christoffer Dall cd...@cs.columbia.edu Handles the guest

Re: [PATCH] KVM: PPC: Book3S HV: Drop locks around call to kvmppc_pin_guest_page

2012-06-19 Thread Alexander Graf
On 06.06.2012, at 17:52, Alexander Graf wrote: On 06/06/2012 02:28 PM, Avi Kivity wrote: On 06/01/2012 01:20 PM, Paul Mackerras wrote: At the moment we call kvmppc_pin_guest_page() in kvmppc_update_vpa() with two spinlocks held: the vcore lock and the vcpu-vpa_update_lock. This is not good,

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Andreas Färber
Am 19.06.2012 08:02, schrieb Benjamin Herrenschmidt: We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt

Re: [PATCH] KVM: PPC: Book3S HV: Drop locks around call to kvmppc_pin_guest_page

2012-06-19 Thread Avi Kivity
On 06/19/2012 01:50 PM, Alexander Graf wrote: On 06.06.2012, at 17:52, Alexander Graf wrote: On 06/06/2012 02:28 PM, Avi Kivity wrote: On 06/01/2012 01:20 PM, Paul Mackerras wrote: At the moment we call kvmppc_pin_guest_page() in kvmppc_update_vpa() with two spinlocks held: the vcore lock

[FIX PATCH] KVM: Use kvm_kvfree() to free memory allocated by kvm_kvzalloc()

2012-06-19 Thread Takuya Yoshikawa
From: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp The following commit did not care about the error handling path: commit c1a7b32a14138f908df52d7c53b5ce3415ec6b50 KVM: Avoid wasting pages for small lpage_info arrays If memory allocation fails, vfree() will be called with the address

Re: [FIX PATCH] KVM: Use kvm_kvfree() to free memory allocated by kvm_kvzalloc()

2012-06-19 Thread Avi Kivity
On 06/19/2012 04:04 PM, Takuya Yoshikawa wrote: From: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp The following commit did not care about the error handling path: commit c1a7b32a14138f908df52d7c53b5ce3415ec6b50 KVM: Avoid wasting pages for small lpage_info arrays If memory

Re: [PATCH 3/4] KVM: MMU: Make kvm_handle_hva() handle range of addresses

2012-06-19 Thread Takuya Yoshikawa
On Mon, 18 Jun 2012 15:11:42 +0300 Avi Kivity a...@redhat.com wrote: Potential for improvement: don't do 512 iterations on same large page. Something like if ((gfn ^ prev_gfn) mask(level)) ret |= handler(...) with clever selection of the first prev_gfn so it always matches

RE: SOLVED: RE: Garbled audio - Windows 7 64 bit guest on Debian

2012-06-19 Thread Jimmy Crossley
Thanks for that reminder, Avi. You are right - it would be best to not be running kvm as root or with any special capabilities. I mainly wanted to report back that I got the sound working by switching to PulseAudio. I made the other changes so I would not have to run kvm as root and it would

Re: KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. Anthony suggested for last week: - multithreading vhost (and general vhost improvements) I suggest: - status of migration: post-copy, IDL, XBRLE, huge memory, ... Will send an

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Anthony Liguori
On 06/19/2012 08:54 AM, Juan Quintela wrote: Juan Quintelaquint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. Anthony suggested for last week: - multithreading vhost (and general vhost improvements) I suggest: - status of migration: post-copy, IDL,

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Takuya Yoshikawa
On Tue, 19 Jun 2012 09:01:36 -0500 Anthony Liguori anth...@codemonkey.ws wrote: I'm not at all convinced that postcopy is a good idea. There needs a clear expression of what the value proposition is that's backed by benchmarks. Those benchmarks need to include latency measurements of

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Chegu Vinod
Hello, Wanted to share some preliminary data from live migration experiments on a setup that is perhaps one of the larger ones. We used Juan's huge_memory patches (without the separate migration thread) and measured the total migration time and the time taken for stage 3 (downtime). Note:

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Michael Roth
On Tue, Jun 19, 2012 at 03:54:23PM +0200, Juan Quintela wrote: Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. Anthony suggested for last week: - multithreading vhost (and general vhost improvements) I suggest: - status

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Michael Roth
On Tue, Jun 19, 2012 at 11:34:42PM +0900, Takuya Yoshikawa wrote: On Tue, 19 Jun 2012 09:01:36 -0500 Anthony Liguori anth...@codemonkey.ws wrote: I'm not at all convinced that postcopy is a good idea. There needs a clear expression of what the value proposition is that's backed by

Re: [PATCH 1/3] block: Introduce __blk_segment_map_sg() helper

2012-06-19 Thread Tejun Heo
Hello, On Mon, Jun 18, 2012 at 7:02 PM, Asias He as...@redhat.com wrote: I *hope* this is a bit prettier.  e.g. Do we really need to pass in @sglist and keep using goto new_segment? I think this deserves another patch on top of this splitting one. I'd like to clean this up later. Yeap,

Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-19 Thread Sam Ravnborg
I just noticed include/asm-generic/Kbuild.asm already had ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \                  $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),) header-y  += kvm_para.h endif but this doesn't seem to work. Kbuild people: which

Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-19 Thread Sam Ravnborg
On Tue, Jun 19, 2012 at 08:48:03PM +0200, Sam Ravnborg wrote: I just noticed include/asm-generic/Kbuild.asm already had ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \                  $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),) header-y  += kvm_para.h

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: Tab alert. :) Argh :-) Gotta get an emacs config for use with qemu :-) Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 22:18, Benjamin Herrenschmidt wrote: On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: Tab alert. :) Argh :-) Gotta get an emacs config for use with qemu :-) So do you want to resend? I can just fix it on the fly too. Alex -- To unsubscribe from this list: send

Regarding improving ple handler (vcpu_on_spin)

2012-06-19 Thread Raghavendra K T
In ple handler code, last_boosted_vcpu (lbv) variable is serving as reference point to start when we enter. lbv = kvm-lbv; for each vcpu i of kvm if i is eligible if yield_to(i) is success lbv = i currently this variable is per VM and it is set after we do

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 22:20 +0200, Alexander Graf wrote: So do you want to resend? I can just fix it on the fly too. If you can then sure, please do :-) Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

[PATCH] kvm: handle last_boosted_vcpu = 0 case

2012-06-19 Thread Rik van Riel
On Wed, 20 Jun 2012 01:50:50 +0530 Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: In ple handler code, last_boosted_vcpu (lbv) variable is serving as reference point to start when we enter. Also statistical analysis (below) is showing lbv is not very well distributed with current

Re: [PATCH v3] spapr: Add memop hypercall

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:21, Benjamin Herrenschmidt wrote: This adds a qemu-specific hypervisor call to the pseries machine which allows to do what amounts to memmove, memcpy and xor over regions of physical memory such as the framebuffer. This is the simplest way to get usable framebuffer

Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 07:56, Benjamin Herrenschmidt wrote: More recent Power server chips (i.e. based on the 64 bit hash MMU) support more than just the traditional 4k and 16M page sizes. This can get quite complicated, because which page sizes are supported, which combinations are supported

Re: [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:02, Benjamin Herrenschmidt wrote: We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt

[PATCH v2] Fixes related to processing of qemu's -numa option

2012-06-19 Thread Chegu Vinod
From: root r...@hydra11.kio Changes since v1: - Use bitmap functions that are already in qemu (instead of cpu_set_t macro's) - Added a check for endvalue = max_cpus. - Fix to address the round-robbing assignment (for the case when cpu's are not explicitly specified)

how to map a host virtual address (hva) to guest address space (gva/gpa/gfn)

2012-06-19 Thread sheng qiu
Hi all, is there any existing function in KVM that can map a host virtual address (hva) to the guest address space. So that the guest VM can access it. i.e. translate hva to a gpa or gva or gfn, so the guest VM can use that converted address to access? Thanks, Sheng -- To unsubscribe from this

VMM OSX port

2012-06-19 Thread Gene Crucean
Hey everyone, I just subscribed to this list so please forgive me if I goof something up. I was looking into the possibility of porting VMM to OSX. Is this on the todo list already? Or something that anyone else is hoping for? Since it's all written in Python (with GTK for the UI), it doesn't

Re: how to map a host virtual address (hva) to guest address space (gva/gpa/gfn)

2012-06-19 Thread Mehul Chadha
On Tue, Jun 19, 2012 at 6:09 PM, sheng qiu herbert1984...@gmail.com wrote: Hi all, is there any existing function in KVM that can map a host virtual address (hva) to the guest address space. So that the guest VM can access it. i.e. translate hva to a gpa or gva or gfn, so the guest VM can

Re: [PATCH v8 10/15] ARM: KVM: Inject IRQs and FIQs from userspace

2012-06-19 Thread Christoffer Dall
On Tue, Jun 19, 2012 at 4:49 AM, Avi Kivity a...@redhat.com wrote: On 06/18/2012 11:56 PM, Christoffer Dall wrote: On Mon, Jun 18, 2012 at 9:32 AM, Avi Kivity a...@redhat.com wrote: On 06/15/2012 10:08 PM, Christoffer Dall wrote: From: Christoffer Dall cd...@cs.columbia.edu Userspace can

Re: [PATCH v8 11/15] ARM: KVM: World-switch implementation

2012-06-19 Thread Christoffer Dall
On Tue, Jun 19, 2012 at 5:16 AM, Avi Kivity a...@redhat.com wrote: On 06/19/2012 01:05 AM, Christoffer Dall wrote: Premature, but this is sad.  I suggest you split vmid generation from next available vmid.  This allows you to make the generation counter atomic so it may be read outside the

Re: [PATCH v8 11/15] ARM: KVM: World-switch implementation

2012-06-19 Thread Christoffer Dall
On Tue, Jun 19, 2012 at 11:27 PM, Christoffer Dall c.d...@virtualopensystems.com wrote: On Tue, Jun 19, 2012 at 5:16 AM, Avi Kivity a...@redhat.com wrote: On 06/19/2012 01:05 AM, Christoffer Dall wrote: Premature, but this is sad.  I suggest you split vmid generation from next available vmid.  

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-06-19 Thread Asias He
On 06/19/2012 02:21 PM, Dor Laor wrote: On 06/19/2012 05:51 AM, Asias He wrote: On 06/18/2012 07:39 PM, Sasha Levin wrote: On Mon, 2012-06-18 at 14:14 +0300, Dor Laor wrote: On 06/18/2012 01:05 PM, Rusty Russell wrote: On Mon, 18 Jun 2012 16:03:23 +0800, Asias Heas...@redhat.com wrote: On

Implementing a Virtio host module for 802.11 media

2012-06-19 Thread Song Gao
Greetings! I want to develop a Virtio host module to emulate 802.11 wireless networks. Here's the motivation: I am a PhD student working in wireless networks. I've been using a cluster of 32 KVM guest nodes to emulate wireless nodes and testing mobile Ad-hoc routing protocols. I use iptables

[PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org --- hw/spapr_vscsi.c |4 +++- 1 file changed, 3

[PATCH v3] spapr: Add memop hypercall

2012-06-19 Thread Benjamin Herrenschmidt
This adds a qemu-specific hypervisor call to the pseries machine which allows to do what amounts to memmove, memcpy and xor over regions of physical memory such as the framebuffer. This is the simplest way to get usable framebuffer speed from SLOF since the framebuffer isn't mapped in the VRMA

Re: [PATCH] KVM: PPC: Book3S HV: Drop locks around call to kvmppc_pin_guest_page

2012-06-19 Thread Alexander Graf
On 06.06.2012, at 17:52, Alexander Graf wrote: On 06/06/2012 02:28 PM, Avi Kivity wrote: On 06/01/2012 01:20 PM, Paul Mackerras wrote: At the moment we call kvmppc_pin_guest_page() in kvmppc_update_vpa() with two spinlocks held: the vcore lock and the vcpu-vpa_update_lock. This is not good,

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Andreas Färber
Am 19.06.2012 08:02, schrieb Benjamin Herrenschmidt: We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt

Re: [PATCH] KVM: PPC: Book3S HV: Drop locks around call to kvmppc_pin_guest_page

2012-06-19 Thread Avi Kivity
On 06/19/2012 01:50 PM, Alexander Graf wrote: On 06.06.2012, at 17:52, Alexander Graf wrote: On 06/06/2012 02:28 PM, Avi Kivity wrote: On 06/01/2012 01:20 PM, Paul Mackerras wrote: At the moment we call kvmppc_pin_guest_page() in kvmppc_update_vpa() with two spinlocks held: the vcore lock

Re: [PATCH 3/4] KVM: MMU: Make kvm_handle_hva() handle range of addresses

2012-06-19 Thread Takuya Yoshikawa
On Mon, 18 Jun 2012 15:11:42 +0300 Avi Kivity a...@redhat.com wrote: Potential for improvement: don't do 512 iterations on same large page. Something like if ((gfn ^ prev_gfn) mask(level)) ret |= handler(...) with clever selection of the first prev_gfn so it always matches

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: Tab alert. :) Argh :-) Gotta get an emacs config for use with qemu :-) Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 22:18, Benjamin Herrenschmidt wrote: On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: Tab alert. :) Argh :-) Gotta get an emacs config for use with qemu :-) So do you want to resend? I can just fix it on the fly too. Alex -- To unsubscribe from this list: send

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 22:20 +0200, Alexander Graf wrote: So do you want to resend? I can just fix it on the fly too. If you can then sure, please do :-) Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3] spapr: Add memop hypercall

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:21, Benjamin Herrenschmidt wrote: This adds a qemu-specific hypervisor call to the pseries machine which allows to do what amounts to memmove, memcpy and xor over regions of physical memory such as the framebuffer. This is the simplest way to get usable framebuffer

Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 07:56, Benjamin Herrenschmidt wrote: More recent Power server chips (i.e. based on the 64 bit hash MMU) support more than just the traditional 4k and 16M page sizes. This can get quite complicated, because which page sizes are supported, which combinations are supported

Re: [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:02, Benjamin Herrenschmidt wrote: We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt