Re: [PATCH 2/2] add initial kvm dev passhtrough support

2013-06-11 Thread Mario Smarduch
Resending, initial email from my exchange client got rejected due to HTML content On 6/12/2013 8:45 AM, Mario Smarduch wrote: > > Hi Antonios, thanks for your feedback, initially we’ll work with static binding gain performance data given latency/throughput is key, later add dynamic

Re: [PATCH 0/4 v3] KVM: PPC: IOMMU in-kernel handling

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 16:11 +1000, Alexey Kardashevskiy wrote: > Ben, ping! :) > > This series has tiny fixes (capability and ioctl numbers, > changed documentation, compile errors in some configuration). > More details are in the commit messages. > Rebased on v3.10-rc4. Alex, I assume you'll mer

Re: [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found

2013-06-11 Thread Greg Kroah-Hartman
On Wed, Jun 12, 2013 at 09:39:50AM +0800, wenchao wrote: > cc to Greg for 3.9. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. -- To unsubscribe from this list: send the line

KVM: x86: handle idiv overflow at kvm_write_tsc

2013-06-11 Thread Marcelo Tosatti
Its possible that idivl overflows (due to large delta stored in usdiff, valid scenario). Create an exception handler to catch the overflow exception (division by zero is protected by vcpu->arch.virtual_tsc_khz check), and interpret it accordingly (delta is larger than USEC_PER_SEC). Fixes https:

Re: [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found

2013-06-11 Thread wenchao
cc to Greg for 3.9. On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia wrote: ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget to set it correctly in configfs, make user confused. Actually it fail to find a matching one, so change the error value. Signed-off-by: Wen

Re: KVM call agenda for 2013-06-11

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 01:38:11PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Jun 04, 2013 at 04:24:31PM +0300, Michael S. Tsirkin wrote: > >> Juan is not available now, and Anthony asked for > >> agenda to be sent early. > >> So here comes: > >> > >> Agenda for t

Re: KVM call agenda for 2013-06-11

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 08:06:15PM +0200, Laszlo Ersek wrote: > On 06/11/13 17:45, Michael S. Tsirkin wrote: > > > To summarize, there's a concensus now that generating ACPI > > tables in QEMU is a good idea. > > > > Two issues that need to be addressed: > > - original patches break cross-version

Re: KVM call agenda for 2013-06-11

2013-06-11 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Tue, Jun 04, 2013 at 04:24:31PM +0300, Michael S. Tsirkin wrote: >> Juan is not available now, and Anthony asked for >> agenda to be sent early. >> So here comes: >> >> Agenda for the meeting Tue, June 11: >> >> - Generating acpi tables, redux > > Not so much

Re: [Qemu-devel] KVM call agenda for 2013-06-25

2013-06-11 Thread Alexander Graf
On 11.06.2013, at 17:52, Juan Quintela wrote: > > Hi > > Now we have moved to one call each other week. > Please, send any topic that you are interested in covering. VFIO for device tree based platforms Alex > > Thanks, Juan. > > PD. If you want to attend and you don't have the call deta

Re: KVM call agenda for 2013-06-11

2013-06-11 Thread Laszlo Ersek
On 06/11/13 17:45, Michael S. Tsirkin wrote: > To summarize, there's a concensus now that generating ACPI > tables in QEMU is a good idea. > > Two issues that need to be addressed: > - original patches break cross-version migration. Need to fix that. > > - Anthony requested that patchset is merg

Re: [Qemu-devel] KVM call agenda for 2013-06-25

2013-06-11 Thread Michael R. Hines
I don't think my presence on the call is necessary, but I would appreciate it you put RDMA on the agenda. The patches have been thoroughly bug-tested and reviewed. - Michael On 06/11/2013 11:52 AM, Juan Quintela wrote: Hi Now we have moved to one call each other week. Please, send any topic

[PATCH v2] kvm/ppc/booke: Delay kvmppc_lazy_ee_enable

2013-06-11 Thread Scott Wood
kwmppc_lazy_ee_enable() should be called as late as possible, or else we get things like WARN_ON(preemptible()) in enable_kernel_fp() in configurations where preemptible() works. Note that book3s_pr already waits until just before __kvmppc_vcpu_run to call kvmppc_lazy_ee_enable(). Signed-off-by:

[Bug 59521] KVM linux guest reads uninitialized pvclock values before executing rdmsr MSR_KVM_WALL_CLOCK

2013-06-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59521 --- Comment #1 from Eugene Batalov 2013-06-11 16:03:55 --- I have reconstructed the uninitialized pvclock read backtrace. References to file lines are for Ubuntu-raring kernel git://kernel.ubuntu.com/ubuntu/ubuntu-raring.git tag is Ubuntu-3.

[PATCH 0/3] vfio: fixup notifiers and avoid possible deadlock

2013-06-11 Thread Alex Williamson
Cleanup a couple of the notifier paths to remove bogus WARN_ON calls. One is pretty easy to hit and neither really signifies a problems. Fix remove path to avoid potential deadlock with other device_lock holders. Thanks, Alex --- Alex Williamson (3): vfio: Don't overreact to DEL_DEVICE

[PATCH 2/3] vfio: Ignore sprurious notifies

2013-06-11 Thread Alex Williamson
Remove debugging WARN_ON if we get a spurious notify for a group that no longer exists. No reports of anyone hitting this, but it would likely be a race and not a bug if they did. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c |8 +++- 1 file changed, 3 insertions(+), 5 deletion

[PATCH 1/3] vfio: Don't overreact to DEL_DEVICE

2013-06-11 Thread Alex Williamson
BUS_NOTIFY_DEL_DEVICE triggers IOMMU drivers to remove devices from their iommu group, but there's really nothing we can do about it at this point. If the device is in use, then the vfio sub-driver will block the device_del from completing until it's released. If the device is not in use or not o

[PATCH 3/3] vfio-pci: Avoid deadlock on remove

2013-06-11 Thread Alex Williamson
If an attempt is made to unbind a device from vfio-pci while that device is in use, the request is blocked until the device becomes unused. Unfortunately, that unbind path still grabs the device_lock, which certain things like __pci_reset_function() also want to take. This means we need to try to

KVM call agenda for 2013-06-25

2013-06-11 Thread Juan Quintela
Hi Now we have moved to one call each other week. Please, send any topic that you are interested in covering. Thanks, Juan. PD. If you want to attend and you don't have the call details, contact me. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a messag

Re: KVM call agenda for 2013-06-11

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 04:24:31PM +0300, Michael S. Tsirkin wrote: > Juan is not available now, and Anthony asked for > agenda to be sent early. > So here comes: > > Agenda for the meeting Tue, June 11: > > - Generating acpi tables, redux Not so much notes as a quick summary of the call: Ther

Re: [PATCH 1/2] add irq priodrop support

2013-06-11 Thread Mario Smarduch
Hi Grant, appreciate the strong feedback, I agree with all the coding observations will make the changes. I have few inline responses. >> +static u32 gic_irq_prio_drop[DIV_ROUND_UP(1020, 32)] __read_mostly; > > I believe it is possible to have more than one GIC in a

Re: [PATCH 2/2] add initial kvm dev passhtrough support

2013-06-11 Thread Mario Smarduch
I know Antonios very well. Yes our intent is definitely to use VFIO. - Mario On 6/11/2013 4:52 PM, Alex Williamson wrote: > On Tue, 2013-06-11 at 16:13 +0200, Mario Smarduch wrote: >> On 6/11/2013 10:28 AM, Alexander Graf wrote: >> >>> >>> Is there any particular reason you're not going down th

Re: [PATCH 2/2] add initial kvm dev passhtrough support

2013-06-11 Thread Alex Williamson
On Tue, 2013-06-11 at 16:13 +0200, Mario Smarduch wrote: > On 6/11/2013 10:28 AM, Alexander Graf wrote: > > > > > Is there any particular reason you're not going down that path for your ARM > > implementation? > > We see this as a good starting point to build on, we need baseline numbers > for

KVM minutes for 2013-06-11

2013-06-11 Thread Juan Quintela
2013-06-11 -- - move ACPI table generation to QEMU - code sharing with SEABIOS - easier to generate there Anthony: it is the same put in QEMU or SEABIOS Michael: there are some information not easily available in seabios (hot plug) Anthony: transfer QOM tree to SEA

Re: [PATCH 2/2] add initial kvm dev passhtrough support

2013-06-11 Thread Mario Smarduch
On 6/11/2013 10:28 AM, Alexander Graf wrote: > > Is there any particular reason you're not going down that path for your ARM > implementation? We see this as a good starting point to build on, we need baseline numbers for performance, latency, interrupt throughput on real hardware ASAP to buil

Re: [PATCH 1/2] add irq priodrop support

2013-06-11 Thread Grant Likely
On Tue, 11 Jun 2013 09:37:24 +0200, Mario Smarduch wrote: > This is the same Interrupt Priority Drop/Deactivation patch > emailed some time back (except for 3.10-rc4) used by the initial > device pass-through support. > > When enabled all IRQs on host write to distributor EOIR and > DIR reg

[GIT PULL] KVM fixes for 3.10-rc5

2013-06-11 Thread Gleb Natapov
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git fixes To receive the following KVM bug fixes. There is one more fix for MIPS KVM ABI here, MIPS and PPC build breakage fixes and a couple of PPC bug fixes. David Daney (2): kvm: Add definition of KVM_REG_MIPS mi

Re: [PATCH v3 03/13] nEPT: Add EPT tables support to paging_tmpl.h

2013-06-11 Thread Gleb Natapov
On Tue, May 21, 2013 at 03:52:12PM +0800, Xiao Guangrong wrote: > On 05/19/2013 12:52 PM, Jun Nakajima wrote: > > From: Nadav Har'El > > > > This is the first patch in a series which adds nested EPT support to KVM's > > nested VMX. Nested EPT means emulating EPT for an L1 guest so that L1 can >

Re: [PATCH net 2/2] vhost: fix ubuf_info cleanup

2013-06-11 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 6 Jun 2013 15:20:46 +0300 > vhost_net_clear_ubuf_info didn't clear ubuf_info > after kfree, this could trigger double free. > Fix this and simplify this code to make it more robust: make sure > ubuf info is always freed through vhost_net_clear_ubuf_info. > >

Re: [PATCH net 1/2] vhost: check owner before we overwrite ubuf_info

2013-06-11 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 6 Jun 2013 15:20:39 +0300 > If device has an owner, we shouldn't touch ubuf_info > since it might be in use. > > Signed-off-by: Michael S. Tsirkin Applied. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord

Re: [PATCH v3 3/6] KVM: MMU: make return value of mmio page fault handler more readable

2013-06-11 Thread Gleb Natapov
On Mon, Jun 10, 2013 at 10:16:04PM +0900, Takuya Yoshikawa wrote: > On Mon, 10 Jun 2013 10:57:50 +0300 > Gleb Natapov wrote: > > > On Fri, Jun 07, 2013 at 04:51:25PM +0800, Xiao Guangrong wrote: > > > > + > > > +/* > > > + * Return values of handle_mmio_page_fault_common: > > > + * RET_MMIO_PF_E

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Gleb Natapov
On Tue, Jun 11, 2013 at 11:30:11AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2013 at 11:22:37AM +0300, Gleb Natapov wrote: > > On Tue, Jun 11, 2013 at 11:19:46AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 11, 2013 at 11:03:50AM +0300, Gleb Natapov wrote: > > > > On Tue, Jun 11, 201

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 11:22:37AM +0300, Gleb Natapov wrote: > On Tue, Jun 11, 2013 at 11:19:46AM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2013 at 11:03:50AM +0300, Gleb Natapov wrote: > > > On Tue, Jun 11, 2013 at 11:02:26AM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 11, 201

Re: [PATCH 2/2] add initial kvm dev passhtrough support

2013-06-11 Thread Alexander Graf
Am 11.06.2013 um 09:43 schrieb Mario Smarduch : > > This is the initial device pass through support. > At this time host == guest only is supported. > Basic Operation: > > - QEMU parameters: -device kvm-device-assign,host= > for example - kvm-device-assign,host='arm-sp804'. Essentially > any

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Gleb Natapov
On Tue, Jun 11, 2013 at 11:19:46AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2013 at 11:03:50AM +0300, Gleb Natapov wrote: > > On Tue, Jun 11, 2013 at 11:02:26AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 11, 2013 at 10:53:48AM +0300, Gleb Natapov wrote: > > > > On Tue, Jun 11, 201

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 11:03:50AM +0300, Gleb Natapov wrote: > On Tue, Jun 11, 2013 at 11:02:26AM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2013 at 10:53:48AM +0300, Gleb Natapov wrote: > > > On Tue, Jun 11, 2013 at 10:10:47AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Jun 06, 201

Dev Passthrough QEMU patch

2013-06-11 Thread Mario Smarduch
This patch is for testing only and goes along with other two patches for priodrop and dev passthrough, it should apply against 1.4.5. diff --git a/cpus.c b/cpus.c index c15ff6c..0c19214 100644 --- a/cpus.c +++ b/cpus.c @@ -737,6 +737,26 @@ static void *qemu_kvm_cpu_thread_fn(void *arg) CPU

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 11:02:26AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2013 at 10:53:48AM +0300, Gleb Natapov wrote: > > On Tue, Jun 11, 2013 at 10:10:47AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Jun 06, 2013 at 10:02:14AM -0500, Anthony Liguori wrote: > > > > Gleb Natapov wr

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Gleb Natapov
On Tue, Jun 11, 2013 at 11:02:26AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2013 at 10:53:48AM +0300, Gleb Natapov wrote: > > On Tue, Jun 11, 2013 at 10:10:47AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Jun 06, 2013 at 10:02:14AM -0500, Anthony Liguori wrote: > > > > Gleb Natapov wr

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 10:53:48AM +0300, Gleb Natapov wrote: > On Tue, Jun 11, 2013 at 10:10:47AM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 06, 2013 at 10:02:14AM -0500, Anthony Liguori wrote: > > > Gleb Natapov writes: > > > > > > > On Wed, Jun 05, 2013 at 07:41:17PM -0500, Anthony Liguo

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Gleb Natapov
On Tue, Jun 11, 2013 at 10:10:47AM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 06, 2013 at 10:02:14AM -0500, Anthony Liguori wrote: > > Gleb Natapov writes: > > > > > On Wed, Jun 05, 2013 at 07:41:17PM -0500, Anthony Liguori wrote: > > >> "H. Peter Anvin" writes: > > >> > > >> > On 06/05/201

[PATCH 2/2] add initial kvm dev passhtrough support

2013-06-11 Thread Mario Smarduch
This is the initial device pass through support. At this time host == guest only is supported. Basic Operation: - QEMU parameters: -device kvm-device-assign,host= for example - kvm-device-assign,host='arm-sp804'. Essentially any device that does PIO should be supported. - Host DTS contains th

[PATCH 1/2] add irq priodrop support

2013-06-11 Thread Mario Smarduch
This is the same Interrupt Priority Drop/Deactivation patch emailed some time back (except for 3.10-rc4) used by the initial device pass-through support. When enabled all IRQs on host write to distributor EOIR and DIR reg to dr-prioritize/de-activate an interrupt. For device that's passed thr

Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR

2013-06-11 Thread Michael S. Tsirkin
On Thu, Jun 06, 2013 at 10:02:14AM -0500, Anthony Liguori wrote: > Gleb Natapov writes: > > > On Wed, Jun 05, 2013 at 07:41:17PM -0500, Anthony Liguori wrote: > >> "H. Peter Anvin" writes: > >> > >> > On 06/05/2013 03:08 PM, Anthony Liguori wrote: > >> >>> > >> >>> Definitely an option. Howeve