Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization

2015-06-10 Thread Andrew Morton
e GCC bug #10676, see > > >> <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676> > > >> Says it was fixed in 4.6, but I believe the kernel supports GCCs much > > >> older > > >> than that (back to 3.2). I personally hit it on 4.4.7, the version >

Re: [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic

2015-05-22 Thread Andrew Morton
There's a more serious failure with i386 allmodconfig: fs/userfaultfd.c:145:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(sizeof(struct uffd_msg) != 32); I'm surprised the feature is even reachable on i386 builds? -- To unsubscribe from this list: send the line "unsubscribe kvm" i

Re: [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic

2015-05-22 Thread Andrew Morton
On Thu, 14 May 2015 19:31:19 +0200 Andrea Arcangeli wrote: > If the rwsem starves writers it wasn't strictly a bug but lockdep > doesn't like it and this avoids depending on lowlevel implementation > details of the lock. > > ... > > @@ -229,13 +246,33 @@ static __always_inline ssize_t __mcopy_at

Re: [PATCH 2/4] mm: introduce mm_forbids_zeropage function

2014-10-22 Thread Andrew Morton
On Wed, 22 Oct 2014 21:45:52 +0200 Dominik Dingel wrote: > > > +#ifndef mm_forbids_zeropage > > > +#define mm_forbids_zeropage(X) (0) > > > +#endif > > > > Can we document this please? What it does, why it does it. We should > > also specify precisely which arch header file is responsible fo

Re: [PATCH 2/4] mm: introduce mm_forbids_zeropage function

2014-10-22 Thread Andrew Morton
On Wed, 22 Oct 2014 13:09:28 +0200 Dominik Dingel wrote: > Add a new function stub to allow architectures to disable for > an mm_structthe backing of non-present, anonymous pages with > read-only empty zero pages. > > ... > > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -56,6 +56,10

Re: [PATCH v2] kvm: Faults which trigger IO release the mmap_sem

2014-09-22 Thread Andrew Morton
On Mon, 22 Sep 2014 23:32:36 +0200 Paolo Bonzini wrote: > Il 22/09/2014 22:49, Andres Lagar-Cavilla ha scritto: > >>> > > Paolo, should I recut including the recent Reviewed-by's? > >> > > >> > No, I'll add them myself. > > Paolo, is this patch waiting for something? Is Gleb's Reviewed-by enough?

Re: [PATCH] mm: export symbol dependencies of is_zero_pfn()

2014-09-12 Thread Andrew Morton
On Fri, 12 Sep 2014 22:17:23 +0200 Ard Biesheuvel wrote: > In order to make the static inline function is_zero_pfn() callable by > modules, export its symbol dependencies 'zero_pfn' and (for s390 and > mips) 'zero_page_mask'. So hexagon and score get the export if/when needed. > We need this f

Re: [PATCH] CMA: generalize CMA reserved area management functionality (fixup)

2014-07-17 Thread Andrew Morton
MA is disabled, CONFIG_CMA_AREAS isn't defined so compile error happens. To fix it, define MAX_CMA_AREAS if CONFIG_CMA_AREAS isn't defined. Signed-off-by: Joonsoo Kim Reported-by: Stephen Rothwell Signed-off-by: Andrew Morton --- include/linux/cma.h |6 ++ 1 file changed, 6 inse

Re: [PATCH v3 -next 0/9] CMA: generalize CMA reserved area management code

2014-06-25 Thread Andrew Morton
On Wed, 25 Jun 2014 14:33:56 +0200 Marek Szyprowski wrote: > > That's probably easier. Marek, I'll merge these into -mm (and hence > > -next and git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git) > > and shall hold them pending you review/ack/test/etc, OK? > > Ok. I've tested them an

Re: [PATCH v3 -next 0/9] CMA: generalize CMA reserved area management code

2014-06-18 Thread Andrew Morton
On Tue, 17 Jun 2014 10:25:07 +0900 Joonsoo Kim wrote: > > >v2: > > > - Although this patchset looks very different with v1, the end result, > > > that is, mm/cma.c is same with v1's one. So I carry Ack to patch 6-7. > > > > > >This patchset is based on linux-next 20140610. > > > > Thanks for

Re: [PATCH v3 -next 4/9] DMA, CMA: support arbitrary bitmap granularity

2014-06-18 Thread Andrew Morton
On Mon, 16 Jun 2014 14:40:46 +0900 Joonsoo Kim wrote: > PPC KVM's CMA area management requires arbitrary bitmap granularity, > since they want to reserve very large memory and manage this region > with bitmap that one bit for several pages to reduce management overheads. > So support arbitrary bi

Re: [PATCH -mm 0/3] fix numa vs kvm scalability issue

2014-02-19 Thread Andrew Morton
On Wed, 19 Feb 2014 09:59:17 +0100 Peter Zijlstra wrote: > On Tue, Feb 18, 2014 at 05:12:43PM -0500, r...@redhat.com wrote: > > The NUMA scanning code can end up iterating over many gigabytes > > of unpopulated memory, especially in the case of a freshly started > > KVM guest with lots of memory.

Re: [PATCH 01/14] asmlinkage, kvm: Make kvm_rebooting visible

2014-02-10 Thread Andrew Morton
On Sat, 8 Feb 2014 08:51:57 +0100 Andi Kleen wrote: > kvm_rebooting is referenced from assembler code, thus > needs to be visible. So I read the gcc page and looked at the __visible definition but I still don't really get it. What goes wrong if the __visible isn't present on these referenced-f

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:23:58 -0700 Kent Overstreet wrote: > > I found things to be quite the opposite - it took 5 minutes of staring, > > head-scratching, double-checking and penny-dropping before I was > > confident that the newly-added code actually has nothing at all to do > > with the current

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:12:17 -0700 Kent Overstreet wrote: > How's this look? > > diff --git a/lib/idr.c b/lib/idr.c > index 15c021c..a3f8e9a 100644 > --- a/lib/idr.c > +++ b/lib/idr.c > @@ -1288,6 +1288,11 @@ static inline unsigned alloc_local_tag(struct > percpu_ida *pool, > * Safe to be cal

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:00:10 -0700 Kent Overstreet wrote: > On Wed, Aug 28, 2013 at 01:25:50PM -0700, Andrew Morton wrote: > > On Wed, 28 Aug 2013 12:55:17 -0700 Kent Overstreet > > wrote: > > > > > Fixup patch, addressing Andrew's review feedback: > &g

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 13:44:54 -0700 Kent Overstreet wrote: > > > > What guarantees that this wait will terminate? > > > > > > It seems fairly clear to me from the break statement a couple lines up; > > > if we were passed __GFP_WAIT we terminate iff we succesfully allocated a > > > tag. If we wer

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 12:55:17 -0700 Kent Overstreet wrote: > Fixup patch, addressing Andrew's review feedback: Looks reasonable. > lib/idr.c | 38 +- I still don't think it should be in this file. You say that some as-yet-unmerged patches will tie

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 12:53:17 -0700 Kent Overstreet wrote: > > > + while (1) { > > > + spin_lock(&pool->lock); > > > + > > > + /* > > > + * prepare_to_wait() must come before steal_tags(), in case > > > + * percpu_ida_free() on another cpu flips a bit in > > > +

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-20 Thread Andrew Morton
On Fri, 16 Aug 2013 23:09:06 + "Nicholas A. Bellinger" wrote: > From: Kent Overstreet > > Percpu frontend for allocating ids. With percpu allocation (that works), > it's impossible to guarantee it will always be possible to allocate all > nr_tags - typically, some will be stuck on a remote

Re: [PATCH 1/2] mm: add support for discard of unused ptes

2013-07-30 Thread Andrew Morton
On Thu, 25 Jul 2013 10:54:20 +0200 Martin Schwidefsky wrote: > From: Konstantin Weitz > > In a virtualized environment and given an appropriate interface the guest > can mark pages as unused while they are free (for the s390 implementation > see git commit 45e576b1c3d00206 "guest page hinting

Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap

2013-07-24 Thread Andrew Morton
On Tue, 23 Jul 2013 12:22:59 +1000 Alexey Kardashevskiy wrote: > Ping, anyone, please? ew, you top-posted. > Ben needs ack from any of MM people before proceeding with this patch. Thanks! For what? The three lines of comment in page-flags.h? ack :) Manipulating page->_count directly is con

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-25 Thread Andrew Morton
On Tue, 25 Sep 2012 17:13:27 +0900 Minchan Kim wrote: > I see. To me, your saying is better than current comment. > I hope comment could be more explicit. > > diff --git a/mm/compaction.c b/mm/compaction.c > index df01b4e..f1d2cc7 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -542,

Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

2012-09-25 Thread Andrew Morton
On Tue, 25 Sep 2012 10:12:07 +0100 Mel Gorman wrote: > First, we'd introduce a variant of get_pageblock_migratetype() that returns > all the bits for the pageblock flags and then helpers to extract either the > migratetype or the PG_migrate_skip. We already are incurring the cost of > get_pageblo

Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

2012-09-24 Thread Andrew Morton
On Mon, 24 Sep 2012 10:39:38 +0100 Mel Gorman wrote: > On Fri, Sep 21, 2012 at 02:36:56PM -0700, Andrew Morton wrote: > > > Also, what has to be done to avoid the polling altogether? eg/ie, zap > > a pageblock's PB_migrate_skip synchronously, when something was done to &

Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

2012-09-21 Thread Andrew Morton
On Fri, 21 Sep 2012 11:46:22 +0100 Mel Gorman wrote: > When compaction was implemented it was known that scanning could potentially > be excessive. The ideal was that a counter be maintained for each pageblock > but maintaining this information would incur a severe penalty due to a > shared writa

Re: [PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible

2012-09-21 Thread Andrew Morton
On Fri, 21 Sep 2012 11:46:20 +0100 Mel Gorman wrote: > Compactions free scanner acquires the zone->lock when checking for PageBuddy > pages and isolating them. It does this even if there are no PageBuddy pages > in the range. > > This patch defers acquiring the zone lock for as long as possible.

Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long

2012-09-21 Thread Andrew Morton
On Fri, 21 Sep 2012 11:46:18 +0100 Mel Gorman wrote: > Changelog since V2 > o Fix BUG_ON triggered due to pages left on cc.migratepages > o Make compact_zone_order() require non-NULL arg `contended' > > Changelog since V1 > o only abort the compaction if lock is contended or run too long > o Rea

Re: qemu-kvm loops after kernel udpate

2012-09-18 Thread Andrew Morton
On Wed, 19 Sep 2012 10:00:34 +1000 Stephen Rothwell wrote: > Hi Andrew, > > On Tue, 18 Sep 2012 12:46:46 -0700 Andrew Morton > wrote: > > > > hm, thanks. This will probably take some time to resolve so I think > > I'll drop > > > > mm-move-

Re: qemu-kvm loops after kernel udpate

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 21:40:31 +0200 Jiri Slaby wrote: > On 09/13/2012 11:59 AM, Avi Kivity wrote: > > On 09/12/2012 09:11 PM, Jiri Slaby wrote: > >> On 09/12/2012 10:18 AM, Avi Kivity wrote: > >>> On 09/12/2012 11:13 AM, Jiri Slaby wrote: > > > Please provide the output of vmxcap >

Re: [PATCH] mm: mmu_notifier: fix inconsistent memory between secondary MMU and host

2012-08-22 Thread Andrew Morton
On Wed, 22 Aug 2012 21:50:43 +0200 Andrea Arcangeli wrote: > Hi Andrew, > > On Wed, Aug 22, 2012 at 12:15:35PM -0700, Andrew Morton wrote: > > On Wed, 22 Aug 2012 18:29:55 +0200 > > Andrea Arcangeli wrote: > > > > > On Wed, Aug 22, 2012 at 02:03:41PM +0800,

Re: [PATCH] mm: mmu_notifier: fix inconsistent memory between secondary MMU and host

2012-08-22 Thread Andrew Morton
On Wed, 22 Aug 2012 18:29:55 +0200 Andrea Arcangeli wrote: > On Wed, Aug 22, 2012 at 02:03:41PM +0800, Xiao Guangrong wrote: > > On 08/21/2012 11:06 PM, Andrea Arcangeli wrote: > > > CPU0 CPU1 > > > oldpage[1] == 0 (both guest & host) > > > o

Re: [PATCH] KVM: Avoid wasting pages for small lpage_info arrays

2012-05-15 Thread Andrew Morton
On Tue, 15 May 2012 11:02:17 +0300 Avi Kivity wrote: > On 05/14/2012 04:29 PM, Takuya Yoshikawa wrote: > > On Sun, 13 May 2012 13:20:46 +0300 > > Avi Kivity wrote: > > > > > I don't feel that the savings is worth the extra complication. We save > > > two pages per memslot here. > > > > Using a

Re: [PATCH] bitops: add _local bitops

2012-05-09 Thread Andrew Morton
On Wed, 9 May 2012 16:45:29 +0300 "Michael S. Tsirkin" wrote: > kvm needs to update some hypervisor variables atomically > in a sense that the operation can't be interrupted > in the middle. However the hypervisor always runs > on the same CPU so it does not need any memory > barrier or lock pref

Re: [PATCH] kvm: don't call mmu_shrinker w/o used_mmu_pages

2012-04-20 Thread Andrew Morton
On Fri, 13 Apr 2012 15:38:41 -0700 Ying Han wrote: > The mmu_shrink() is heavy by itself by iterating all kvms and holding > the kvm_lock. spotted the code w/ Rik during LSF, and it turns out we > don't need to call the shrinker if nothing to shrink. > We should probably tell the kvm maintainer

Re: [PATCH 0/3] Unmapped page cache control (v5)

2011-03-30 Thread Andrew Morton
On Thu, 31 Mar 2011 10:57:03 +0530 Balbir Singh wrote: > * Andrew Morton [2011-03-30 16:36:07]: > > > On Wed, 30 Mar 2011 11:00:26 +0530 > > Balbir Singh wrote: > > > > > Data from the previous patchsets can be found at > > > https://lkml.org/lkml/

Re: [PATCH 0/3] Unmapped page cache control (v5)

2011-03-30 Thread Andrew Morton
On Wed, 30 Mar 2011 11:00:26 +0530 Balbir Singh wrote: > Data from the previous patchsets can be found at > https://lkml.org/lkml/2010/11/30/79 It would be nice if the data for the current patchset was present in the current patchset's changelog! -- To unsubscribe from this list: send the line

Re: [PATCH 3/3] Provide control over unmapped pages (v5)

2011-03-30 Thread Andrew Morton
On Wed, 30 Mar 2011 11:02:38 +0530 Balbir Singh wrote: > Changelog v4 > 1. Added documentation for max_unmapped_pages > 2. Better #ifdef'ing of max_unmapped_pages and min_unmapped_pages > > Changelog v2 > 1. Use a config option to enable the code (Andrew Morton) > 2.

Re: [RFC PATCH 1/3] Weight-balanced tree

2011-02-24 Thread Andrew Morton
On Tue, 22 Feb 2011 11:55:05 -0700 Alex Williamson wrote: > Signed-off-by: Alex Williamson > --- > > include/linux/wbtree.h | 55 > lib/Makefile |3 + > lib/wbtree.c | 170 > > 3 files changed, 227 in

Re: [PATCH 3/3][RESEND] Provide control over unmapped pages (v4)

2011-02-08 Thread Andrew Morton
On Tue, 01 Feb 2011 22:25:45 +0530 Balbir Singh wrote: > Changelog v4 > 1. Add max_unmapped_ratio and use that as the upper limit > to check when to shrink the unmapped page cache (Christoph > Lameter) > > Changelog v2 > 1. Use a config option to enable the code (Andrew Mor

Re: [PATCH 1/2] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally

2011-01-27 Thread Andrew Morton
On Fri, 28 Jan 2011 01:57:11 +0100 Andi Kleen wrote: > I personally would consider it cleaner to have clearly > defined wrappers instead of complicted flags in the caller. > > > The number of args to these functions is getting nutty - you'll > > probably find that it is beneficial to inline thes

Re: [PATCH 1/2] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally

2011-01-27 Thread Andrew Morton
> > > get_user_pages_hwpoison is added as a variant of get_user_pages > > > > > > that > > > > > > > can return -EHWPOISON for HWPOISON page. > > > > > > > > > > > > > > This feature is needed by KVM, w

Re: [RFC 1/3] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally

2010-12-22 Thread Andrew Morton
On Thu, 23 Dec 2010 08:39:59 +0800 Huang Ying wrote: > > > --- a/mm/memory.c > > > +++ b/mm/memory.c > > > @@ -1449,9 +1449,16 @@ int __get_user_pages(struct task_struct > > > if (ret & VM_FAULT_ERROR) { > > > if (ret & VM_FAULT_OOM) > >

Re: [RFC 1/3] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally

2010-12-22 Thread Andrew Morton
HWPOISON page, while instruction emulation and MMIO will be > tried for general FAULT page. > > The idea comes from Andrew Morton. hm, I don't remember that. I suspect it came from someone else? > Signed-off-by: Huang Ying > Cc: Andrew Morton > --- > include/asm-gen

Re: [PATCH 3/3] Provide control over unmapped pages

2010-11-30 Thread Andrew Morton
On Tue, 30 Nov 2010 15:46:31 +0530 Balbir Singh wrote: > Provide control using zone_reclaim() and a boot parameter. The > code reuses functionality from zone_reclaim() to isolate unmapped > pages and reclaim them as a priority, ahead of other mapped pages. > > Signed-off-by: Balbir Singh > ---

Re: [PATCH 1/3] Move zone_reclaim() outside of CONFIG_NUMA

2010-11-30 Thread Andrew Morton
On Tue, 30 Nov 2010 15:45:12 +0530 Balbir Singh wrote: > This patch moves zone_reclaim and associated helpers > outside CONFIG_NUMA. This infrastructure is reused > in the patches for page cache control that follow. > Thereby adding a nice dollop of bloat to everyone's kernel. I don't think th

Re: [PATCH 1/2] Add vzalloc shortcut

2010-10-18 Thread Andrew Morton
On Tue, 19 Oct 2010 09:55:17 +0800 Dave Young wrote: > On Tue, Oct 19, 2010 at 9:27 AM, Dave Young wrote: > > On Tue, Oct 19, 2010 at 7:46 AM, Andrew Morton > >> > >> Also, a slightly better implementation would be > >> > >> static inline void *

Re: [PATCH 1/2] Add vzalloc shortcut

2010-10-18 Thread Andrew Morton
On Sat, 16 Oct 2010 12:33:31 +0800 Dave Young wrote: > Add vzalloc for convinience of vmalloc-then-memset-zero case > > Use __GFP_ZERO in vzalloc to zero fill the allocated memory. > > Signed-off-by: Dave Young > --- > include/linux/vmalloc.h |1 + > mm/vmalloc.c| 13 ++

Re: [PATCH] cgroups: fix API thinko

2010-08-25 Thread Andrew Morton
On Fri, 06 Aug 2010 10:38:24 -0600 Alex Williamson wrote: > On Fri, 2010-08-06 at 09:34 -0700, Sridhar Samudrala wrote: > > On 8/5/2010 3:59 PM, Michael S. Tsirkin wrote: > > > cgroup_attach_task_current_cg API that have upstream is backwards: we > > > really need an API to attach to the cgroups

Re: + kvm-ia64-dereference-of-null-pointer-in-set_pal_result.patch added to -mm tree

2010-01-13 Thread Andrew Morton
On Wed, 13 Jan 2010 11:22:39 +0200 Avi Kivity wrote: > On 01/13/2010 12:11 AM, a...@linux-foundation.org wrote: > > Subject: kvm/ia64: dereference of NULL pointer in set_pal_result() > > From: Roel Kluin > > > > Do not dereference a NULL pointer > > > > diff -puN > > arch/ia64/kvm/kvm_fw.c~kvm-i

Re: vga_arb warning [was: mmotm 2009-11-01-10-01 uploaded]

2009-11-03 Thread Andrew Morton
Please cc me on mmotm bug reports! On Sun, 01 Nov 2009 22:47:05 +0100 Jiri Slaby wrote: > On 11/01/2009 07:07 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2009-11-01-10-01 has been uploaded to > > Hi, I got the following warning while booting an image in qemu-kvm: >

Re: [was: mmotm 2009-10-09-01-07 uploaded]

2009-10-09 Thread Andrew Morton
On Fri, 9 Oct 2009 08:30:28 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > When CONFIG_CPU_FREQ is disabled, cpufreq_get() needs a stub. > Used by kvm (although it looks like a bit of the kvm code could > be omitted when CONFIG_CPU_FREQ is disabled). > > arch/x86/built-in.o: In function `k

Re: [PATCHv2 1/2] mm: export use_mm/unuse_mm to modules

2009-09-16 Thread Andrew Morton
On Thu, 17 Sep 2009 08:38:18 +0300 "Michael S. Tsirkin" wrote: > Hi Andrew, > On Tue, Aug 11, 2009 at 03:10:10PM -0700, Andrew Morton wrote: > > On Wed, 12 Aug 2009 00:27:52 +0300 > > "Michael S. Tsirkin" wrote: > > > > > vhost net modu

Re: [PATCHv2 1/2] mm: export use_mm/unuse_mm to modules

2009-08-11 Thread Andrew Morton
On Wed, 12 Aug 2009 00:27:52 +0300 "Michael S. Tsirkin" wrote: > vhost net module wants to do copy to/from user from a kernel thread, > which needs use_mm (like what fs/aio has). Move that into mm/ and > export to modules. OK by me. Please include this change in the virtio patchset. Which I s

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Andrew Morton
On Wed, 24 Jun 2009 16:52:06 -0700 (PDT) Davide Libenzi wrote: > > umm, yes please, I believe the patches should be split. And I'm still > > not seeing the justification for forcing CONFIG_EVENTFD onto all > > CONFIG_AIO users! > > Eventfd notifications became part of the AIO API (it's not even

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Andrew Morton
On Wed, 24 Jun 2009 15:47:47 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > Maybe there is such a reason, and it hasn't yet been beaten into my > > skull. But I still think it should be done in a separate patch. One > > which

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 15:49:53 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > On Tue, 23 Jun 2009 14:25:05 -0700 (PDT) > > Davide Libenzi wrote: > > > > > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > > >

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 14:48:51 -0700 (PDT) Davide Libenzi wrote: > > > This becomes pretty painful when the function calls other functions, for > > > which just relays the error code. > > > Should we be just documenting the error codes introduced by the function > > > code, and say that the funct

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 14:34:50 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > > Should functions be describing all the returned error codes, ala man > > > pages? > > > > > > > I think so. > > This b

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 14:25:05 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > That isn't for us to decide. Entire syscalls can be disabled in config. > > That is not a well defined separate syscall though. It's a member/feature &

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 14:03:22 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > On Tue, 23 Jun 2009 12:25:36 -0700 (PDT) > > Davide Libenzi wrote: > > > > > The following patch changes the eventfd interface to de-couple the &g

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 13:59:07 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > On Tue, 23 Jun 2009 12:25:36 -0700 (PDT) > > Davide Libenzi wrote: > > > > > Another cleanup this patch does, is making AIO select EVENTFD, in

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 12:25:36 -0700 (PDT) Davide Libenzi wrote: > The following patch changes the eventfd interface to de-couple the eventfd > memory context, from the file pointer instance. > Without such change, there is no clean way to racely free handle the > POLLHUP event sent when the last

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 12:25:36 -0700 (PDT) Davide Libenzi wrote: > Another cleanup this patch does, is making AIO select EVENTFD, instead of > adding a bunch of empty function stubs inside eventfd.h in order to > handle the (AIO && !EVENTFD) case. Given that we're trying to squeak this patch int

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-23 Thread Andrew Morton
On Tue, 23 Jun 2009 12:25:36 -0700 (PDT) Davide Libenzi wrote: > The following patch changes the eventfd interface to de-couple the eventfd > memory context, from the file pointer instance. > Without such change, there is no clean way to racely free handle the > POLLHUP event sent when the last

Re: [PATCH 5/5] add ksm kernel shared memory driver.

2009-05-13 Thread Andrew Morton
On Mon, 20 Apr 2009 04:36:06 +0300 Izik Eidus wrote: > Ksm is driver that allow merging identical pages between one or more > applications in way unvisible to the application that use it. > Pages that are merged are marked as readonly and are COWed when any > application try to change them. > >

Re: [PATCH 5/5] add ksm kernel shared memory driver.

2009-04-30 Thread Andrew Morton
On Thu, 30 Apr 2009 20:46:24 +0300 Izik Eidus wrote: > Following patchs change the api to be more robust, the result change of > the api came after conversation i had with Andrea and Chris about how > to make the api as stable as we can, > > In addition i hope this patchset fix the cross compila

Re: [KVM PATCH v3 0/2] irqfd

2009-04-28 Thread Andrew Morton
On Mon, 27 Apr 2009 14:33:24 -0400 Gregory Haskins wrote: > (Applies to kvm.git 41b76d8d0487c26d6d4d3fe53c1ff59b3236f096) > > This series implements a mechanism called "irqfd". It lets you create > an eventfd based file-desriptor to inject interrupts to a kvm guest. We > associate one gsi per

Re: [PATCH 5/5] add ksm kernel shared memory driver.

2009-04-27 Thread Andrew Morton
On Mon, 20 Apr 2009 04:36:06 +0300 Izik Eidus wrote: > Ksm is driver that allow merging identical pages between one or more > applications in way unvisible to the application that use it. > Pages that are merged are marked as readonly and are COWed when any > application try to change them. Brea

Re: [PATCH 4/4] add ksm kernel shared memory driver.

2009-04-15 Thread Andrew Morton
On Thu, 16 Apr 2009 01:37:25 +0300 Izik Eidus wrote: > Andrew Morton wrote: > > On Thu, 9 Apr 2009 06:58:41 +0300 > > Izik Eidus wrote: > > > > > > > > Confused. In the covering email you indicated that v2 of the patchset > > had abandone

Re: [PATCH 4/4] add ksm kernel shared memory driver.

2009-04-14 Thread Andrew Morton
On Thu, 9 Apr 2009 06:58:41 +0300 Izik Eidus wrote: > Ksm is driver that allow merging identical pages between one or more > applications in way unvisible to the application that use it. > Pages that are merged are marked as readonly and are COWed when any > application try to change them. > >

Re: [PATCH 3/4] add replace_page(): change the page pte is pointing to.

2009-04-14 Thread Andrew Morton
On Thu, 9 Apr 2009 06:58:40 +0300 Izik Eidus wrote: > replace_page() allow changing the mapping of pte from one physical page > into diffrent physical page. At a high level, this is very similar to what page migration does. Yet this implementation shares nothing with the page migration code.

Re: [PATCH 0/4] ksm - dynamic page sharing driver for linux v3

2009-04-14 Thread Andrew Morton
On Thu, 9 Apr 2009 06:58:37 +0300 Izik Eidus wrote: > KSM is a linux driver that allows dynamicly sharing identical memory > pages between one or more processes. Generally looks OK to me. But that doesn't mean much. We should rub bottles with words like "hugh" and "nick" on them to be sure.

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-18 Thread Andrew Morton
On Wed, 18 Mar 2009 17:40:47 -0700 Alexander Duyck wrote: > Andrew Morton wrote: > > On Wed, 18 Mar 2009 08:22:46 -0700 Alexander Duyck > > wrote: > > > >>>>>> +static int igbvf_set_ringparam(struct net_device *netdev, > >>>>>>

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-18 Thread Andrew Morton
On Wed, 18 Mar 2009 08:22:46 -0700 Alexander Duyck wrote: > +static int igbvf_set_ringparam(struct net_device *netdev, > + struct ethtool_ringparam *ring) > +{ > + struct igbvf_adapter *adapter = netdev_priv(netdev); > + struct igbvf

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-17 Thread Andrew Morton
t; I have added my comments inline below. > > Thanks, > > Alex > > Andrew Morton wrote: > > On Tue, 10 Mar 2009 19:09:28 -0700 Jeff Kirsher > > wrote: > > > >> From: Alexander Duyck > >> > >> This adds an igbvf driver to handle v

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-10 Thread Andrew Morton
On Tue, 10 Mar 2009 19:09:28 -0700 Jeff Kirsher wrote: > From: Alexander Duyck > > This adds an igbvf driver to handle virtual functions provided > by the igb driver. The drive-by reader is now wondering what a "virtual function" is. > > ... > > +#define IGBVF_STAT(m, b) sizeof(((struct igb

Re: linux-next: Tree for January 23 (kvm)

2009-01-28 Thread Andrew Morton
(cc mailing lists) On Wed, 28 Jan 2009 12:26:16 -0200 Marcelo Tosatti wrote: > On Wed, Jan 28, 2009 at 11:20:16AM +0100, Alexander Graf wrote: > > > > On 28.01.2009, at 10:51, Andrew Morton wrote: > > > >> On Fri, 23 Jan 2009 12:34:24 -0800 Randy Dunlap > >&

Re: [PATCH 1/4] rmap: add page_wrprotect() function,

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 21:38:06 +0100 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > > > + * set all the ptes pointed to a page as read only, > > > + * odirect_sync is set to 0 in case we cannot protect against race with > > > odirect > > > + * return the number of ptes that were set as read only > >

Re: [PATCH 3/4] add ksm kernel shared memory driver

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 15:21:40 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > From: Izik Eidus <[EMAIL PROTECTED]> > > ksm is driver that allow merging identical pages between one or more > applications in way unvisible to the application that use it. > pages that are merged are marked as readonly a

Re: [PATCH 2/4] Add replace_page(), change the mapping of pte from one page into another

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 15:21:39 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > From: Izik Eidus <[EMAIL PROTECTED]> > > this function is needed in cases you want to change the userspace > virtual mapping into diffrent physical page, Not sure that I understand that description. We want to replace a

Re: [PATCH 1/4] rmap: add page_wrprotect() function,

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 15:21:38 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > From: Izik Eidus <[EMAIL PROTECTED]> > > this function is useful for cases you want to compare page and know > that its value wont change during you compare it. > > this function is working by walking over the whole rmap

Re: [PATCH 0/4] ksm - dynamic page sharing driver for linux

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 21:18:23 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > > hm. > > > > There has been the occasional discussion about idenfifying all-zeroes > > pages and scavenging them, repointing them at the zero page. Could > > this infrastructure be used for that? (And how much would we g

Re: [PATCH 0/4] ksm - dynamic page sharing driver for linux

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 21:07:10 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > we have used KSM in production for about half year and the numbers that > came from our QA is: > using KSM for desktop (KSM was tested just for windows desktop workload) > you can run as many as > 52 windows xp with 1 gig

Re: [PATCH 0/4] ksm - dynamic page sharing driver for linux

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 20:48:16 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > The whole approach seems wrong to me. The kernel lost track of these > > pages and then we run around post-facto trying to fix that up again. > > Please explain (for th

Re: [PATCH 0/4] ksm - dynamic page sharing driver for linux

2008-11-11 Thread Andrew Morton
On Tue, 11 Nov 2008 15:21:37 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > KSM is a linux driver that allows dynamicly sharing identical memory pages > between one or more processes. > > unlike tradtional page sharing that is made at the allocation of the > memory, ksm do it dynamicly after the m

Re: mmotm 2008-09-22-01-36 uploaded (kvm)

2008-09-22 Thread Andrew Morton
On Mon, 22 Sep 2008 14:58:52 -0700 Jesse Barnes <[EMAIL PROTECTED]> wrote: > On Monday, September 22, 2008 12:52 pm Andrew Morton wrote: > > On Mon, 22 Sep 2008 11:19:47 -0700 > > > > Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > On Mon, 22 Sep 2

Re: mmotm 2008-09-22-01-36 uploaded (kvm)

2008-09-22 Thread Andrew Morton
On Mon, 22 Sep 2008 11:19:47 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Mon, 22 Sep 2008 01:38:58 -0700 [EMAIL PROTECTED] wrote: > > > The mm-of-the-moment snapshot 2008-09-22-01-36 has been uploaded to > > > >http://userweb.kernel.org/~akpm/mmotm/ > > > > It contains the following

linux-next: ia64 allmodconfig

2008-07-30 Thread Andrew Morton
arch/ia64/kvm/../../../virt/kvm/ioapic.c:42:17: irq.h: No such file or directory arch/ia64/kvm/../../../virt/kvm/ioapic.c: In function `__kvm_ioapic_update_eoi': arch/ia64/kvm/../../../virt/kvm/ioapic.c:296: error: implicit declaration of function `kvm_notify_acked_irq' arch/ia64/kvm/../../../virt

Re: [PATCH 0 of 3] mmu notifier v18 for -mm

2008-07-02 Thread Andrew Morton
I merged the mmu-notifers patches ahead of these: # # gup # x86-implement-pte_special.patch mm-introduce-get_user_pages_fast.patch mm-introduce-get_user_pages_fast-fix.patch mm-introduce-get_user_pages_fast-checkpatch-fixes.patch x86-lockless-get_user_pages_fast.patch x86-lockless-get_user_pages_

Re: [PATCH 0 of 3] mmu notifier v18 for -mm

2008-07-01 Thread Andrew Morton
On Thu, 26 Jun 2008 02:26:56 +0200 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > Hello, > > Christoph suggested me to repost v18 for merging in -mm, to give it more > exposure before the .27 merge window opens. There's no code change compared to > the previous v18 submission (the only change is t