On Mon, Dec 30, 2013 at 08:22:21PM -0500, Zhihui Zhang wrote:
This is the right place to set the function pointer. In addition, change
function name
from translate_nested_gpa() to translate_gpa_nested() to match the naming
convention of
other functions (e.g., paging64_gva_to_gpa_nested()).
On Thu, Jan 02, 2014 at 05:14:11PM +0800, Chen Fan wrote:
fix the 'vcpi' typos when apic_debug is enabled.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
arch/x86/kvm/lapic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
To unsubscribe from
On Tue, Jan 07, 2014 at 07:48:41PM +0100, Guido Winkelmann wrote:
Hi,
When trying to boot a Windows 7 install from a local virtual disks, qemu
stops
with the messages:
KVM internal error. Suberror: 1
emulation failure
Can you please enable the following tracepoints via the
# cd
On Wed, Jan 08, 2014 at 06:14:15PM -0500, Hu Yaohui wrote:
Hi guys,
I think you should be pretty familiar with lapic. I would really
appreciate it if someone could shed some lights on my problem
regarding Guest TLB flush IPI.
Supposed we get two vcpus 0 and 1.
When vcpu#0 wants to invalidate
Limit PIT timer frequency similarly to the limit applied by
LAPIC timer.
Cc: sta...@kernel.org
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
index 412a5aa..518d864 100644
--- a/arch/x86/kvm/i8254.c
+++ b/arch/x86/kvm/i8254.c
.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: linux-2.6.git/arch/x86/kvm/x86.c
===
--- linux-2.6.git.orig/arch/x86/kvm/x86.c
+++ linux-2.6.git/arch/x86/kvm/x86.c
@@ -1484,7 +1484,7 @@ static int kvm_guest_time_update(struct
Am i missing something, or should nested_free_all_saved_vmcss not
call
if (vmx-loaded_vmcs != vmx-vmcs01)
free_loaded_vmcs(vmx-vmcs01);
?
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More
-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index da7837e..2efa33f0 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -7332,8 +7332,8 @@ static void vmx_free_vcpu(struct kvm_vcpu *vcpu)
struct vcpu_vmx *vmx = to_vmx(vcpu
Rom Freiman r...@stratoscale.com notes other code paths vulnerable to
bug fixed by 989c6b34f6a9480e397b.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 31a5702..e50425d 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
On Fri, Jan 03, 2014 at 08:27:07PM +0100, Jan Kiszka wrote:
On 2014-01-03 20:00, Marcelo Tosatti wrote:
After free_loaded_vmcs executes, the loaded_vmcs structure
is kfreed, and now vmx-loaded_vmcs points to a kfreed area.
Subsequent free_loaded_vmcs then attempts to manipulate
vmx
On Sat, Dec 28, 2013 at 04:31:52PM +0100, Jan Kiszka wrote:
Three reasons for doing this: 1. arch.walk_mmu points to arch.mmu anyway
in case nested EPT wasn't in use. 2. this aligns VMX with SVM. But 3. is
most important: nested_cpu_has_ept(vmcs12) queries the VMCS page, and if
one guest VCPU
On Sat, Dec 28, 2013 at 11:15:32AM +, Marc Zyngier wrote:
Hi Marcelo,
Could you please pull the following tag into kvm/next?
It contains the long overdue GIC+timer save/restore interface for
KVM/arm, and a couple of other less important changes for KVM/arm64.
Thanks,
M.
On Thu, Jan 02, 2014 at 02:15:48PM +0100, Peter Lieven wrote:
Am 11.12.2013 19:53, schrieb Marcelo Tosatti:
On Sun, Dec 08, 2013 at 10:33:38PM +1100, Vadim Rozenfeld wrote:
Signed-off: Peter Lieven p...@dlh.net
Signed-off: Gleb Natapov g...@redhat.com
Signed-off: Vadim Rozenfeld vroze
On Thu, Jan 02, 2014 at 05:08:07PM +0100, Peter Lieven wrote:
Not using irq disable/enable pairs. The subtraction is not dependant on
any particular time.
local_irq_disable();
now_ns = get_kernel_ns();
local_irq_enable();
Linus,
Please pull from
git://git.kernel.org/pub/scm/virt/kvm/kvm.git master
To receive the following KVM bug fixes
Jan Kiszka (2):
KVM: x86: Fix APIC map calculation after re-enabling
KVM: nVMX: Unconditionally uninit the MMU on nested vmexit
arch/x86/kvm/lapic.c |8
On Tue, Dec 31, 2013 at 08:06:51PM +0800, Xiao Guangrong wrote:
On Dec 31, 2013, at 4:23 AM, Marcelo Tosatti mtosa...@redhat.com wrote:
On Tue, Dec 17, 2013 at 01:59:04PM +0800, Xiao Guangrong wrote:
CCed KVM guys.
On 05/10/2013 01:11 PM, Stefan Hajnoczi wrote:
On Fri, May 10
On Mon, Dec 16, 2013 at 10:32:34AM +0100, Jan Kiszka wrote:
As long as we do not expose all the VMX related states to user space,
there is no way to properly reset a VCPU when VMX is enabled. Emulate
this for now by catching host-side clearings of the feature control MSR.
This allows to reboot
On Mon, Dec 30, 2013 at 06:02:17PM -0200, Marcelo Tosatti wrote:
On Mon, Dec 16, 2013 at 10:32:34AM +0100, Jan Kiszka wrote:
As long as we do not expose all the VMX related states to user space,
there is no way to properly reset a VCPU when VMX is enabled. Emulate
this for now by catching
On Mon, Dec 16, 2013 at 10:32:34AM +0100, Jan Kiszka wrote:
As long as we do not expose all the VMX related states to user space,
there is no way to properly reset a VCPU when VMX is enabled. Emulate
this for now by catching host-side clearings of the feature control MSR.
This allows to reboot
On Tue, Dec 17, 2013 at 01:59:04PM +0800, Xiao Guangrong wrote:
CCed KVM guys.
On 05/10/2013 01:11 PM, Stefan Hajnoczi wrote:
On Fri, May 10, 2013 at 4:28 AM, wenchao wenchaoli...@gmail.com wrote:
于 2013-5-9 22:13, Mel Gorman 写道:
On Thu, May 09, 2013 at 05:50:05PM +0800,
On Sat, Dec 21, 2013 at 10:14:09AM -0800, Randy Dunlap wrote:
On 12/21/13 08:21, Masanari Iida wrote:
Correct spelling typo in Documentations/virtual/kvm
Signed-off-by: Masanari Iida standby2...@gmail.com
Acked-by: Randy Dunlap rdun...@infradead.org
Thanks.
Applied, thanks.
--
To
On Sun, Dec 29, 2013 at 02:29:30AM +0100, Jan Kiszka wrote:
From: Jan Kiszka jan.kis...@siemens.com
Update arch.apic_base before triggering recalculate_apic_map. Otherwise
the recalculation will work against the previous state of the APIC and
will fail to build the correct map when an APIC
On Thu, Dec 19, 2013 at 02:24:59PM +0100, Jan Kiszka wrote:
In contrast to VMX, SVM dose not automatically transfer DR6 into the
VCPU's arch.dr6. So if we face a DR6 read, we must consult a new vendor
hook to obtain the current value.
Fixes a regression of 020df0794f.
Signed-off-by: Jan
On Sun, Dec 22, 2013 at 12:56:49PM -0200, Marcelo Tosatti wrote:
On Sun, Dec 22, 2013 at 11:17:21AM +0200, Rom Freiman wrote:
Hello everyone,
I've been chasing this bug for a while.
According to my research, this bug fix is works fine for
3.11.9-200.fc19.x86_64 kernel version (and I
On Sun, Dec 22, 2013 at 11:17:21AM +0200, Rom Freiman wrote:
Hello everyone,
I've been chasing this bug for a while.
According to my research, this bug fix is works fine for
3.11.9-200.fc19.x86_64 kernel version (and I also came to almost similar
solution and really solved the crash).
On Fri, Dec 20, 2013 at 05:15:02PM +0800, Xiao Guangrong wrote:
On 12/20/2013 01:28 AM, Marcelo Tosatti wrote:
It is possible for __direct_map to be called on invalid root_hpa
(-1), two examples:
1) try_async_pf - can_do_async_pf
- vmx_interrupt_allowed - nested_vmx_vmexit
2
for this possibility, let fault exception be regenerated.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=924916
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 40772ef..31a5702 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
Fix off-by-one error (noticed by Andrea Arcangeli).
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/exec.c b/exec.c
index f4b9ef2..1be5252 100644
--- a/exec.c
+++ b/exec.c
@@ -1000,7 +1000,7 @@ static void *file_ram_alloc(RAMBlock *block,
}
/* MAP_POPULATE
On Wed, Dec 11, 2013 at 04:53:05PM -0200, Marcelo Tosatti wrote:
On Sun, Dec 08, 2013 at 10:33:38PM +1100, Vadim Rozenfeld wrote:
Signed-off: Peter Lieven p...@dlh.net
Signed-off: Gleb Natapov g...@redhat.com
Signed-off: Vadim Rozenfeld vroze...@redhat.com
v1 - v2
1. mark TSC page
On Tue, Dec 10, 2013 at 10:23:17PM +1100, Vadim Rozenfeld wrote:
On Mon, 2013-12-09 at 15:32 +0100, Paolo Bonzini wrote:
Il 08/12/2013 12:33, Vadim Rozenfeld ha scritto:
+ tsc_ref.tsc_sequence =
+ boot_cpu_has(X86_FEATURE_CONSTANT_TSC) ? 1 : 0;
+
On Sun, Dec 08, 2013 at 10:33:38PM +1100, Vadim Rozenfeld wrote:
Signed-off: Peter Lieven p...@dlh.net
Signed-off: Gleb Natapov g...@redhat.com
Signed-off: Vadim Rozenfeld vroze...@redhat.com
v1 - v2
1. mark TSC page dirty as suggested by
Eric Northup digitale...@google.com and Gleb
On Sun, Dec 08, 2013 at 10:33:39PM +1100, Vadim Rozenfeld wrote:
The following patch allows to activate a partition reference
time enlightenment that is based on the host platform's support
for an Invariant Time Stamp Counter (iTSC).
v2 - v3
Handle TSC sequence, scale, and offest changing
On Fri, Dec 06, 2013 at 05:24:18PM +0900, Fernando Luis Vázquez Cao wrote:
On 12/06/2013 01:38 AM, Paolo Bonzini wrote:
Il 05/12/2013 17:17, Marcelo Tosatti ha scritto:
I agree it is a bit ugly, but in my testing QEMU seemed to loop over all
the VCPUS fast enough for the kernel side
GOn Tue, Dec 03, 2013 at 03:10:48PM +0800, Xiao Guangrong wrote:
On 11/28/2013 04:53 PM, Xiao Guangrong wrote:
On 11/27/2013 03:31 AM, Marcelo Tosatti wrote:
On Tue, Nov 26, 2013 at 11:21:37AM +0800, Xiao Guangrong wrote:
On 11/26/2013 02:12 AM, Marcelo Tosatti wrote:
On Mon, Nov 25, 2013
reset.
Cc: sta...@vger.kernel.org
Cc: Will Auld will.a...@intel.com
Cc: Marcelo Tosatti mtosa...@redhat.com
Signed-off-by: Fernando Luis Vazquez Cao ferna...@oss.ntt.co.jp
I agree that the bug is in QEMU. One small nit in your patch is that
you should reset env-tsc_adjust and env-tsc
On Fri, Dec 06, 2013 at 12:42:44AM +0900, Fernando Luis Vazquez Cao wrote:
(2013/12/05 22:53), Paolo Bonzini wrote:
Il 05/12/2013 14:15, Fernando Luis Vazquez Cao ha scritto:
/*
* KVM is yet unable to synchronize TSC values of multiple VCPUs
on
* writeback.
On Thu, Dec 05, 2013 at 05:02:02PM +0100, Paolo Bonzini wrote:
Il 05/12/2013 16:42, Fernando Luis Vazquez Cao ha scritto:
(2013/12/05 22:53), Paolo Bonzini wrote:
Il 05/12/2013 14:15, Fernando Luis Vazquez Cao ha scritto:
/*
* KVM is yet unable to synchronize TSC values
On Thu, Dec 05, 2013 at 02:40:00PM -0200, Marcelo Tosatti wrote:
On Thu, Dec 05, 2013 at 05:02:02PM +0100, Paolo Bonzini wrote:
Il 05/12/2013 16:42, Fernando Luis Vazquez Cao ha scritto:
(2013/12/05 22:53), Paolo Bonzini wrote:
Il 05/12/2013 14:15, Fernando Luis Vazquez Cao ha scritto
On Thu, Dec 05, 2013 at 11:30:27PM +0800, Xiao Guangrong wrote:
Is it not the case that simply moving to the slow path once a maximum of
rewalks has been reached enough? (looks a like a good solution).
In some cases, the lockless walker will do endless-walking on desc and
without rewalk,
On Thu, Dec 05, 2013 at 11:30:27PM +0800, Xiao Guangrong wrote:
In some cases, the lockless walker will do endless-walking on desc and
without rewalk, consider this case:
there are two descs: desc1 and desc2 who is pointed by desc1-next：
desc1-next = desc2.
CPU 0
On Tue, Nov 26, 2013 at 06:24:13PM +0200, Michael S. Tsirkin wrote:
On Wed, Sep 12, 2012 at 08:13:54AM -0700, Paul E. McKenney wrote:
On Wed, Sep 12, 2012 at 03:44:26PM +0300, Gleb Natapov wrote:
On Wed, Sep 12, 2012 at 03:36:57PM +0300, Avi Kivity wrote:
On 09/12/2012 03:34 PM, Gleb
On Tue, Nov 26, 2013 at 11:10:19AM +0800, Xiao Guangrong wrote:
On 11/25/2013 10:23 PM, Marcelo Tosatti wrote:
On Mon, Nov 25, 2013 at 02:48:37PM +0200, Avi Kivity wrote:
On Mon, Nov 25, 2013 at 8:11 AM, Xiao Guangrong
xiaoguangr...@linux.vnet.ibm.com wrote:
On Nov 23, 2013, at 3:14 AM
On Tue, Nov 26, 2013 at 11:21:37AM +0800, Xiao Guangrong wrote:
On 11/26/2013 02:12 AM, Marcelo Tosatti wrote:
On Mon, Nov 25, 2013 at 02:29:03PM +0800, Xiao Guangrong wrote:
Also, there is no guarantee of termination (as long as sptes are
deleted with the correct timing). BTW, can't see
On Mon, Nov 25, 2013 at 02:48:37PM +0200, Avi Kivity wrote:
On Mon, Nov 25, 2013 at 8:11 AM, Xiao Guangrong
xiaoguangr...@linux.vnet.ibm.com wrote:
On Nov 23, 2013, at 3:14 AM, Marcelo Tosatti mtosa...@redhat.com wrote:
snip complicated stuff about parent_pte
I'm not really following
On Mon, Nov 25, 2013 at 02:11:31PM +0800, Xiao Guangrong wrote:
On Nov 23, 2013, at 3:14 AM, Marcelo Tosatti mtosa...@redhat.com wrote:
On Wed, Oct 23, 2013 at 09:29:25PM +0800, Xiao Guangrong wrote:
It likes nulls list and we use the pte-list as the nulls which can help us
to
detect
GOn Mon, Nov 25, 2013 at 04:29:28PM +0200, Gleb Natapov wrote:
On Mon, Nov 25, 2013 at 12:23:51PM -0200, Marcelo Tosatti wrote:
On Mon, Nov 25, 2013 at 02:48:37PM +0200, Avi Kivity wrote:
On Mon, Nov 25, 2013 at 8:11 AM, Xiao Guangrong
xiaoguangr...@linux.vnet.ibm.com wrote
On Mon, Nov 25, 2013 at 02:29:03PM +0800, Xiao Guangrong wrote:
Also, there is no guarantee of termination (as long as sptes are
deleted with the correct timing). BTW, can't see any guarantee of
termination for rculist nulls either (a writer can race with a lockless
reader indefinately,
On Wed, Oct 23, 2013 at 09:29:25PM +0800, Xiao Guangrong wrote:
It likes nulls list and we use the pte-list as the nulls which can help us to
detect whether the desc is moved to anther rmap then we can re-walk the rmap
if that happened
kvm-slots_lock is held when we do lockless walking that
On Wed, Nov 20, 2013 at 10:20:09PM +0800, Xiao Guangrong wrote:
But what guarantee does userspace require, from GET_DIRTY_LOG, while vcpus
are
executing?
Aha. Single calling GET_DIRTY_LOG is useless since new dirty page can be
generated
when GET_DIRTY_LOG is being returned. If user
On Wed, Aug 07, 2013 at 12:06:49PM +0800, Xiao Guangrong wrote:
On 08/07/2013 09:48 AM, Marcelo Tosatti wrote:
On Tue, Jul 30, 2013 at 09:02:02PM +0800, Xiao Guangrong wrote:
Make sure we can see the writable spte before the dirt bitmap is visible
We do
On Tue, Nov 19, 2013 at 10:29:20PM -0200, Marcelo Tosatti wrote:
A call to GET_DIRTY_LOG guarantees to return correct information about
dirty pages before invocation of the previous GET_DIRTY_LOG call.
Can you explain why it is OK to relax this rule?
That is, this might be OK, but better
On Fri, Nov 15, 2013 at 03:09:13PM +0800, Xiao Guangrong wrote:
On 11/15/2013 02:39 AM, Marcelo Tosatti wrote:
On Thu, Nov 14, 2013 at 01:15:24PM +0800, Xiao Guangrong wrote:
Hi Marcelo,
On 11/14/2013 08:36 AM, Marcelo Tosatti wrote:
Any code location which reads the writable bit
to that position
Both of these also can reduce cache miss
Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com
Reviewed-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
deletions(-)
Reviewed-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 14, 2013 at 01:15:24PM +0800, Xiao Guangrong wrote:
Hi Marcelo,
On 11/14/2013 08:36 AM, Marcelo Tosatti wrote:
Any code location which reads the writable bit in the spte and assumes if
its not
set, that the translation which the spte refers to is not cached
On Wed, Oct 23, 2013 at 09:29:22PM +0800, Xiao Guangrong wrote:
Now we can flush all the TLBs out of the mmu lock without TLB corruption when
write-proect the sptes, it is because:
- we have marked large sptes readonly instead of dropping them that means we
just change the spte from writable
be
writable due to the corrupt tlb entry
Flush all TLB
Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com
Reviewed-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More
Guangrong xiaoguangr...@linux.vnet.ibm.com
Reviewed-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
:
trace_fast_page_fault(vcpu, gva, error_code, iterator.sptep,
spte, ret);
--
1.8.1.4
Reviewed-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Mon, Nov 04, 2013 at 10:07:54AM -0700, Greg Edwards wrote:
On Fri, Nov 01, 2013 at 06:45:12PM -0700, Marcelo Tosatti wrote:
intel_iommu_iova_to_phys returns incorrect physical address
when iova is translated by large pte.
Fill in bits from iova when creating the physical address
))
+ page_size = 1;
+
/*
* Pin all pages we are about to map in memory. This is
* important because we unmap and unpin in 4kb steps later.
--
1.8.3.2
Reviewed-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send
On Tue, Oct 29, 2013 at 05:19:43PM -0600, Greg Edwards wrote:
On Mon, Oct 28, 2013 at 12:37:56PM -0700, Greg Edwards wrote:
Using KVM PCI assignment with 1 GiB huge pages trips a BUG in 3.12.0-rc7,
e.g.
# qemu-system-x86_64 \
-m 8192 \
-mem-path
On Fri, Nov 01, 2013 at 10:08:55AM -0600, Greg Edwards wrote:
When determining the page size we could use to map with the IOMMU, the
page size should be aligned with the hva, not the gfn. The gfn may not
reflect the real alignment within the hugetlbfs file.
Most of the time, this works
On Fri, Nov 01, 2013 at 12:01:26PM -0600, Greg Edwards wrote:
Is it expected the same pages might be mapped in multiple memslots? I
noticed the gfn overlap check in __kvm_set_memory_region().
It appears pfn_to_dma_pte() is behaving as expected, given half the huge
page is still mapped.
intel_iommu_iova_to_phys returns incorrect physical address
when iova is translated by large pte.
Fill in bits from iova when creating the physical address.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 15e9b57
On Thu, Oct 17, 2013 at 04:50:47PM +0200, Paolo Bonzini wrote:
The loop was always using 0 as the index. This means that
any rubbish after the first element of the array went undetected.
It seems reasonable to assume that no KVM userspace did that.
It is not a typo, look at __kvm_set_xcr when
On Wed, Oct 16, 2013 at 12:12:11PM +0300, Gleb Natapov wrote:
On Tue, Oct 15, 2013 at 07:21:19PM -0300, Marcelo Tosatti wrote:
On Tue, Oct 15, 2013 at 06:57:05AM +0300, Gleb Natapov wrote:
Why is it safe to allow access, by the lockless page write protect
side, to spt pointer
On Wed, Oct 16, 2013 at 02:25:00PM -0400, Don Zickus wrote:
On Fri, Oct 11, 2013 at 09:39:24PM -0300, Marcelo Tosatti wrote:
v2:
- do not create hung_task.h, move defines to sched.h (Don Zickus)
- switch patch order (Paolo)
As long as it solves kvm's problems, I am ok with it.
Marcelo
On Tue, Oct 15, 2013 at 06:57:05AM +0300, Gleb Natapov wrote:
Why is it safe to allow access, by the lockless page write protect
side, to spt pointer for shadow page A that can change to a shadow page
pointer of shadow page B?
Write protect spte of any page at will? Or verify that
On Sat, Oct 12, 2013 at 08:53:56AM +0300, Gleb Natapov wrote:
On Fri, Oct 11, 2013 at 05:30:17PM -0300, Marcelo Tosatti wrote:
On Fri, Oct 11, 2013 at 08:38:31AM +0300, Gleb Natapov wrote:
n_max_mmu_pages is not a suitable limit to throttle freeing of pages via
RCU (its too large
On Fri, Oct 11, 2013 at 08:38:31AM +0300, Gleb Natapov wrote:
n_max_mmu_pages is not a suitable limit to throttle freeing of pages via
RCU (its too large). If the free memory watermarks are smaller than
n_max_mmu_pages for all guests, OOM is possible.
Ah, yes. I am not saying
Implement reset of kernel watchdogs at pvclock read time. This avoids
adding special code to every watchdog.
This is possible for watchdogs which measure time based on sched_clock() or
ktime_get() variants.
Suggested by Don Zickus.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: kvm
In certain occasions it is possible for a hung task detector
positive to be false: continuation from a paused VM, for example.
Add a method to reset detection, similar as is done
with other kernel watchdogs.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: kvm/kernel/hung_task.c
v2:
- do not create hung_task.h, move defines to sched.h (Don Zickus)
- switch patch order (Paolo)
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 10, 2013 at 03:08:45PM +0300, Gleb Natapov wrote:
On Wed, Oct 09, 2013 at 10:47:10PM -0300, Marcelo Tosatti wrote:
Gleb has a idea that uses RCU_DESTORY to protect the shadow page table
and encodes the page-level into the spte (since we need to check if
the spte
On Thu, Oct 10, 2013 at 10:16:46PM +0300, Gleb Natapov wrote:
On Thu, Oct 10, 2013 at 01:42:22PM -0300, Marcelo Tosatti wrote:
On Thu, Oct 10, 2013 at 03:08:45PM +0300, Gleb Natapov wrote:
On Wed, Oct 09, 2013 at 10:47:10PM -0300, Marcelo Tosatti wrote:
Gleb has a idea that uses
On Wed, Oct 09, 2013 at 09:55:19AM -0400, Don Zickus wrote:
On Tue, Oct 08, 2013 at 07:08:11PM -0300, Marcelo Tosatti wrote:
On Tue, Oct 08, 2013 at 09:37:05AM -0400, Don Zickus wrote:
On Mon, Oct 07, 2013 at 10:05:17PM -0300, Marcelo Tosatti wrote:
Implement reset of kernel watchdogs
On Wed, Oct 09, 2013 at 06:45:47PM +0800, Xiao Guangrong wrote:
On 10/09/2013 09:56 AM, Marcelo Tosatti wrote:
On Tue, Oct 08, 2013 at 12:02:32PM +0800, Xiao Guangrong wrote:
Hi Marcelo,
On Oct 8, 2013, at 9:23 AM, Marcelo Tosatti mtosa...@redhat.com wrote:
+if (kvm
On Tue, Oct 08, 2013 at 09:37:05AM -0400, Don Zickus wrote:
On Mon, Oct 07, 2013 at 10:05:17PM -0300, Marcelo Tosatti wrote:
Implement reset of kernel watchdogs at pvclock read time. This avoids
adding special code to every watchdog.
This is possible for watchdogs which measure time
On Tue, Oct 08, 2013 at 12:02:32PM +0800, Xiao Guangrong wrote:
Hi Marcelo,
On Oct 8, 2013, at 9:23 AM, Marcelo Tosatti mtosa...@redhat.com wrote:
+ if (kvm-arch.rcu_free_shadow_page) {
+ kvm_mmu_isolate_pages(invalid_list);
+ sp = list_first_entry(invalid_list
On Tue, Oct 08, 2013 at 11:58:10AM +0200, Paolo Bonzini wrote:
Il 08/10/2013 03:05, Marcelo Tosatti ha scritto:
+void pvclock_touch_watchdogs(void)
+{
+ touch_softlockup_watchdog_sync();
+ clocksource_touch_watchdog();
+ rcu_cpu_stall_reset();
+ reset_hung_task_detector
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please ignore patch 3/3 - there is none.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
In certain occasions it is possible for a hung task detector
positive to be false: continuation from a paused VM, for example.
Add a method to reset detection, similar as is done
with other kernel watchdogs.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: kvm/kernel/hung_task.c
Implement reset of kernel watchdogs at pvclock read time. This avoids
adding special code to every watchdog.
This is possible for watchdogs which measure time based on sched_clock() or
ktime_get() variants.
Suggested by Don Zickus.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: kvm
See individual patches for details.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 05, 2013 at 06:29:15PM +0800, Xiao Guangrong wrote:
It is easy if the handler is in the vcpu context, in that case we can use
walk_shadow_page_lockless_begin() and walk_shadow_page_lockless_end() that
disable interrupt to stop shadow page being freed. But we are on the ioctl
On Thu, Sep 05, 2013 at 06:29:05PM +0800, Xiao Guangrong wrote:
Using sp-role.level instead of @level since @level is not got from the
page table hierarchy
There is no issue in current code since the fast page fault currently only
fixes the fault caused by dirty-log that is always on the
On Thu, Sep 05, 2013 at 06:29:06PM +0800, Xiao Guangrong wrote:
Currently, kvm zaps the large spte if write-protected is needed, the later
read can fault on that spte. Actually, we can make the large spte readonly
instead of making them un-present, the page fault caused by read access can
be
On Thu, Sep 05, 2013 at 06:29:08PM +0800, Xiao Guangrong wrote:
Now we can flush all the TLBs out of the mmu lock without TLB corruption when
write-proect the sptes, it is because:
- we have marked large sptes readonly instead of dropping them that means we
just change the spte from writable
On Tue, Sep 03, 2013 at 12:42:40PM +0200, Paolo Bonzini wrote:
Il 03/09/2013 05:03, Marcelo Tosatti ha scritto:
Here is the code I was thinking of:
spin_lock(ka-pvclock_gtod_sync_lock);
make_all_cpus_request(kvm, KVM_REQ_CLOCK_UPDATE);
/*
* No guest entries from
Convert steal time MSR vmsd callback pointer to proper X86CPU type.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/target-i386/machine.c b/target-i386/machine.c
index dc81cde..e568da2 100644
--- a/target-i386/machine.c
+++ b/target-i386/machine.c
@@ -330,9 +330,9 @@ static bool
On Wed, Aug 28, 2013 at 02:37:20PM +0200, Paolo Bonzini wrote:
Il 28/08/2013 04:52, Marcelo Tosatti ha scritto:
On Thu, Aug 22, 2013 at 07:05:20PM +0200, Paolo Bonzini wrote:
Il 20/08/2013 20:20, Marcelo Tosatti ha scritto:
The offset to add to the hosts monotonic time, kvmclock_offset
On Fri, Aug 23, 2013 at 03:24:37PM +0200, Andrew Jones wrote:
The comment in kvm_max_vcpus() states that it's using the recommended
procedure from the kernel API documentation to get the max number
of vcpus that kvm supports. It is, but by always returning the
maximum number supported. The
On Fri, Aug 23, 2013 at 12:00:46PM +0200, Paolo Bonzini wrote:
Il 22/08/2013 19:05, Paolo Bonzini ha scritto:
Il 20/08/2013 20:20, Marcelo Tosatti ha scritto:
The offset to add to the hosts monotonic time, kvmclock_offset, is
calculated against the monotonic time at KVM_SET_CLOCK ioctl
On Thu, Aug 22, 2013 at 07:05:20PM +0200, Paolo Bonzini wrote:
Il 20/08/2013 20:20, Marcelo Tosatti ha scritto:
The offset to add to the hosts monotonic time, kvmclock_offset, is
calculated against the monotonic time at KVM_SET_CLOCK ioctl time.
Request a master clock update
to calculate kvmclock_offset.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index d21bce5..0a93354 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1457,6 +1457,29 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm)
#endif
to calculate kvmclock_offset.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: linux-2.6-kvmclock-fixes/arch/x86/kvm/x86.c
===
--- linux-2.6-kvmclock-fixes.orig/arch/x86/kvm/x86.c
+++ linux-2.6-kvmclock-fixes/arch/x86/kvm/x86.c
The configuration of the timer represented by MSR_IA32_TSCDEADLINE depends on:
- APIC LVT Timer register.
- TSC value.
Change the order to respect the dependency.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 376fc70..d04c6ae
On Mon, Aug 19, 2013 at 08:57:58PM +0200, Paolo Bonzini wrote:
Il 19/08/2013 19:13, Marcelo Tosatti ha scritto:
The configuration of the timer represented by MSR_IA32_TSCDEADLINE depends
on:
- APIC LVT Timer register.
- TSC value.
Change the order to respect the dependency
401 - 500 of 4400 matches
Mail list logo
