Re: [Bug] Real mode guests never wake up after an HLT instruction

2008-07-05 Thread Avi Kivity
Mohammed Gamal wrote: Sorry for the scrambled message. Here is the patch +static inline void kvm_inject_db(struct kvm_vcpu *vcpu, u32 error_code) +{ + kvm_queue_exception_e(vcpu, DB_VECTOR, error_code); +} IIRC debug exceptions don't push an error code. -- I have a truly

Re: [Bug] Real mode guests never wake up after an HLT instruction

2008-07-03 Thread Mohammed Gamal
It is not, since it also happens with -no-kvm-irqchip, that does not exercise this path. I looked into it today, will look further, but my current impression is that hlt is working fine. It might be the case that the problem lies in any kind of interrupt injection that were supposed to wake

Re: [Bug] Real mode guests never wake up after an HLT instruction

2008-07-03 Thread Mohammed Gamal
Sorry for the scrambled message. Here is the patch diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index dd4efe1..8643ee5 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kvm/x86_emulate.c @@ -294,6 +294,7 @@ static u16 group2_table[] = { /* EFLAGS bit definitions. */

Re: [Bug] Real mode guests never wake up after an HLT instruction

2008-07-02 Thread Glauber Costa
On Sun, Jun 22, 2008 at 3:34 PM, Mohammed Gamal [EMAIL PROTECTED] wrote: On Sun, Jun 22, 2008 at 10:15 AM, Avi Kivity [EMAIL PROTECTED] wrote: Mohammed Gamal wrote: CPU Model: Intel(R) Core(TM)2 Duo CPU T7250 @ 2.00GHz KVM version: kvm-69-1687-gd660add Host Kernel: 2.6.26-rc5 (x86_64)

Re: [Bug] Real mode guests never wake up after an HLT instruction

2008-06-22 Thread Avi Kivity
Mohammed Gamal wrote: CPU Model: Intel(R) Core(TM)2 Duo CPU T7250 @ 2.00GHz KVM version: kvm-69-1687-gd660add Host Kernel: 2.6.26-rc5 (x86_64) Guests: FreeDOS and Minix 3.1.2 32-bit Command: qemu-system-x86_64 -hda /media/sda6/dos or minix image Real mode guests (namely Minix 3 and FreeDOS

Re: [Bug] Real mode guests never wake up after an HLT instruction

2008-06-22 Thread Mohammed Gamal
On Sun, Jun 22, 2008 at 10:15 AM, Avi Kivity [EMAIL PROTECTED] wrote: Mohammed Gamal wrote: CPU Model: Intel(R) Core(TM)2 Duo CPU T7250 @ 2.00GHz KVM version: kvm-69-1687-gd660add Host Kernel: 2.6.26-rc5 (x86_64) Guests: FreeDOS and Minix 3.1.2 32-bit Command: qemu-system-x86_64 -hda

[Bug] Real mode guests never wake up after an HLT instruction

2008-06-17 Thread Mohammed Gamal
CPU Model: Intel(R) Core(TM)2 Duo CPU T7250 @ 2.00GHz KVM version: kvm-69-1687-gd660add Host Kernel: 2.6.26-rc5 (x86_64) Guests: FreeDOS and Minix 3.1.2 32-bit Command: qemu-system-x86_64 -hda /media/sda6/dos or minix image Real mode guests (namely Minix 3 and FreeDOS with HIMEM XMS driver)