[PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-13 Thread Mark McLoughlin
Currently we only include $(KERNELDIR)/include in CFLAGS, but we also have $(KERNELDIR)/arch/$(arch)/include or else we'll get mis-matched headers. Signed-off-by: Mark McLoughlin --- kvm/user/config-i386.mak |1 - kvm/user/config-ia64.mak |1 + kvm/user/config-powerpc.mak

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-13 Thread Arnd Bergmann
On Wednesday 13 May 2009 08:32:21 Mark McLoughlin wrote: > Currently we only include $(KERNELDIR)/include in CFLAGS, > but we also have $(KERNELDIR)/arch/$(arch)/include or else > we'll get mis-matched headers. > I think this is fundamentally wrong. User files should never directly access kernel

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-14 Thread Mark McLoughlin
On Wed, 2009-05-13 at 21:57 +, Arnd Bergmann wrote: > On Wednesday 13 May 2009 08:32:21 Mark McLoughlin wrote: > > Currently we only include $(KERNELDIR)/include in CFLAGS, > > but we also have $(KERNELDIR)/arch/$(arch)/include or else > > we'll get mis-matched headers. > > > > I think this i

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-14 Thread Avi Kivity
Arnd Bergmann wrote: On Wednesday 13 May 2009 08:32:21 Mark McLoughlin wrote: Currently we only include $(KERNELDIR)/include in CFLAGS, but we also have $(KERNELDIR)/arch/$(arch)/include or else we'll get mis-matched headers. I think this is fundamentally wrong. User files should neve

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-14 Thread Arnd Bergmann
On Thursday 14 May 2009, Avi Kivity wrote: > > There aren't the real kernel headers, just cheap copies carried in > qemu-kvm.git which have been appropriately postprocessed.  We do this > since the kvm external module can run on a much older kernel, so there > is no natural place to find it hea

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-14 Thread Avi Kivity
Arnd Bergmann wrote: On Thursday 14 May 2009, Avi Kivity wrote: There aren't the real kernel headers, just cheap copies carried in qemu-kvm.git which have been appropriately postprocessed. We do this since the kvm external module can run on a much older kernel, so there is no natural place

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-14 Thread Arnd Bergmann
On Thursday 14 May 2009, Avi Kivity wrote: > I usually add a readlink -f in there due to my innate fear of relative > directories and cd. There is one already in the only place where this gets used: KERNELDIR=$(readlink -f $kerneldir) It also gets shown in the configure --help output, but I sup

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-17 Thread Avi Kivity
Mark McLoughlin wrote: Currently we only include $(KERNELDIR)/include in CFLAGS, but we also have $(KERNELDIR)/arch/$(arch)/include or else we'll get mis-matched headers. Signed-off-by: Mark McLoughlin --- kvm/user/config-i386.mak |1 - kvm/user/config-ia64.mak |1 + kvm/us