Re: [PATCH] kvm-userspace: Cleanup user space NMI injection

2008-11-26 Thread Avi Kivity
Jan Kiszka wrote: Hm. For interrupts we need to check, since the interrupt might be deasserted or masked while the window is closed. Is there no way that this can happen for NMIs? In our emulation, but I also think in real life, there is no way to deassert an NMI. Therefore, our user spa

Re: [PATCH] kvm-userspace: Cleanup user space NMI injection

2008-11-26 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >> Cleanup redundant check for an open NMI window before injecting. This >> will no longer be supported by the kernel, and it was broken by design >> anyway. >> >> This change still allows to run the user space against older kernel >> modules. >> >> > > Hm.

Re: [PATCH] kvm-userspace: Cleanup user space NMI injection

2008-11-26 Thread Avi Kivity
Jan Kiszka wrote: Cleanup redundant check for an open NMI window before injecting. This will no longer be supported by the kernel, and it was broken by design anyway. This change still allows to run the user space against older kernel modules. Hm. For interrupts we need to check, since th

[PATCH] kvm-userspace: Cleanup user space NMI injection

2008-11-24 Thread Jan Kiszka
Cleanup redundant check for an open NMI window before injecting. This will no longer be supported by the kernel, and it was broken by design anyway. This change still allows to run the user space against older kernel modules. Signed-off-by: Jan Kiszka <[EMAIL PROTECTED]> --- libkvm/libkvm.c