Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-16 Thread Avi Kivity
On 03/16/2010 09:33 PM, Marcelo Tosatti wrote: How relevant is this for -stable? Races don't sound good to me :) The race mentioned above is not existant on -stable since prefetch is disabled for invlpg. The atomic fixes seem like a candidate, since lack of them can trigger pagetable co

Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-16 Thread Marcelo Tosatti
On Tue, Mar 16, 2010 at 07:22:55PM +0100, Alexander Graf wrote: > > On 16.03.2010, at 17:36, Marcelo Tosatti wrote: > > > On Mon, Mar 15, 2010 at 01:59:52PM +0200, Avi Kivity wrote: > >> Currently when we emulate a locked operation into a shadowed guest page > >> table, we perform a write rather

Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-16 Thread Alexander Graf
On 16.03.2010, at 17:36, Marcelo Tosatti wrote: > On Mon, Mar 15, 2010 at 01:59:52PM +0200, Avi Kivity wrote: >> Currently when we emulate a locked operation into a shadowed guest page >> table, we perform a write rather than a true atomic. This is indicated >> by the "emulating exchange as writ

Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-16 Thread Marcelo Tosatti
On Mon, Mar 15, 2010 at 01:59:52PM +0200, Avi Kivity wrote: > Currently when we emulate a locked operation into a shadowed guest page > table, we perform a write rather than a true atomic. This is indicated > by the "emulating exchange as write" message that shows up in dmesg. > > In addition, th

[PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-15 Thread Avi Kivity
Currently when we emulate a locked operation into a shadowed guest page table, we perform a write rather than a true atomic. This is indicated by the "emulating exchange as write" message that shows up in dmesg. In addition, the pte prefetch operation during invlpg suffered from a race. This was

Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-15 Thread Avi Kivity
On 03/15/2010 12:16 PM, Marcelo Tosatti wrote: On Sun, Mar 14, 2010 at 09:03:47AM +0200, Avi Kivity wrote: On 03/10/2010 04:50 PM, Avi Kivity wrote: Currently when we emulate a locked operation into a shadowed guest page table, we perform a write rather than a true atomic. This is in

Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-15 Thread Marcelo Tosatti
On Sun, Mar 14, 2010 at 09:03:47AM +0200, Avi Kivity wrote: > On 03/10/2010 04:50 PM, Avi Kivity wrote: > >Currently when we emulate a locked operation into a shadowed guest page > >table, we perform a write rather than a true atomic. This is indicated > >by the "emulating exchange as write" messa

Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-13 Thread Avi Kivity
On 03/10/2010 04:50 PM, Avi Kivity wrote: Currently when we emulate a locked operation into a shadowed guest page table, we perform a write rather than a true atomic. This is indicated by the "emulating exchange as write" message that shows up in dmesg. In addition, the pte prefetch operation d

[PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

2010-03-10 Thread Avi Kivity
Currently when we emulate a locked operation into a shadowed guest page table, we perform a write rather than a true atomic. This is indicated by the "emulating exchange as write" message that shows up in dmesg. In addition, the pte prefetch operation during invlpg suffered from a race. This was