Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-23 Thread Andreas Herrmann
On Wed, May 21, 2014 at 02:39:00PM +0100, James Hogan wrote: On 20/05/14 15:47, Andreas Herrmann wrote: diff --git a/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h b/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h new file mode 100644 index 000..c812efa ---

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-23 Thread Andreas Herrmann
On Wed, May 21, 2014 at 09:31:02AM -0700, David Daney wrote: On 05/21/2014 06:39 AM, James Hogan wrote: [...] diff --git a/arch/mips/paravirt/paravirt-irq.c b/arch/mips/paravirt/paravirt-irq.c new file mode 100644 index 000..e1603dd --- /dev/null +++

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-23 Thread Ralf Baechle
On Fri, May 23, 2014 at 10:28:55PM +0200, Andreas Herrmann wrote: + wmb(); Wouldn't smp_wmb() be more accurate? ... use smp_wmb there ... A few years ago I reviewed the use of mb()/rmb()/wmb() as opposed to smp_mb()/smp_rmb()/smp_wmb() throughout the kernel. Every single use was a

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-22 Thread Andreas Herrmann
On Wed, May 21, 2014 at 02:39:00PM +0100, James Hogan wrote: On 20/05/14 15:47, Andreas Herrmann wrote: -- 8 -- diff --git a/arch/mips/paravirt/paravirt-irq.c b/arch/mips/paravirt/paravirt-irq.c new file mode 100644 index 000..e1603dd --- /dev/null +++

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-21 Thread James Hogan
On 20/05/14 15:47, Andreas Herrmann wrote: diff --git a/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h b/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h new file mode 100644 index 000..c812efa --- /dev/null +++ b/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-21 Thread David Daney
On 05/21/2014 06:39 AM, James Hogan wrote: [...] diff --git a/arch/mips/paravirt/paravirt-irq.c b/arch/mips/paravirt/paravirt-irq.c new file mode 100644 index 000..e1603dd --- /dev/null +++ b/arch/mips/paravirt/paravirt-irq.c [...] +static void irq_core_set_enable_local(void *arg) +{ +

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-21 Thread James Hogan
On 21/05/14 17:31, David Daney wrote: +paravirt_smp_sp[cpu] = __KSTK_TOS(idle); +mb(); is this barrier necessary? Really it is just make_writes_visible_asap(), but for OCTEON mb() or smp_wmb() is the closest that the kernel has. It may not be necessary, but it doesn't really

[PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-20 Thread Andreas Herrmann
From: David Daney david.da...@cavium.com For para-virtualized guests running under KVM or other equivalent hypervisor. Signed-off-by: David Daney david.da...@cavium.com Signed-off-by: Andreas Herrmann andreas.herrm...@caviumnetworks.com --- .../asm/mach-paravirt/cpu-feature-overrides.h |