Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-31 Thread Avi Kivity
Amit Shah wrote: 'opaque' fields can be later made to point to other structures without changing the structure itself. This is an advantage. Will the kvm_pic struct be needed to change in the future? Very unlikely. So we can rename it to struct kvm *, however, that gives us no real benefit as

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Yang, Sheng
On Tuesday 29 July 2008 00:26:25 Ben-Ami Yassour wrote: FROM: Avi Kivity [EMAIL PROTECTED] This can be used by kvm subsystems that are interested in when interrupts are acked, for example time drift compenstation. [Ben: add notification call to the pic and ioapic] Signed-off-by: Avi

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Amit Shah
* On Tuesday 29 Jul 2008 12:44:17 Yang, Sheng wrote: On Tuesday 29 July 2008 00:26:25 Ben-Ami Yassour wrote: FROM: Avi Kivity [EMAIL PROTECTED] This can be used by kvm subsystems that are interested in when interrupts are acked, for example time drift compenstation. [Ben: add

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Yang, Sheng
On Tuesday 29 July 2008 17:34:47 Amit Shah wrote: * On Tuesday 29 Jul 2008 12:44:17 Yang, Sheng wrote: On Tuesday 29 July 2008 00:26:25 Ben-Ami Yassour wrote: FROM: Avi Kivity [EMAIL PROTECTED] This can be used by kvm subsystems that are interested in when interrupts are acked,

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Amit Shah
* On Tuesday 29 July 2008 15:26:45 Yang, Sheng wrote: On Tuesday 29 July 2008 17:34:47 Amit Shah wrote: rename irq_request_opaque to struct* kvm in struct kvm_pic, and modify all irq_request() calling(three of them in all) with (void *)kvm. 'opaque' fields can be later made to point