Re: [PATCH 4/7] KVM: s390/CPACF: Choose crypto control block format

2015-02-04 Thread Christian Borntraeger
Am 04.02.2015 um 14:48 schrieb Paolo Bonzini: > > > On 04/02/2015 14:05, Christian Borntraeger wrote: Could this also be part of the "things" that KVM can choose to enable, even though it's not a facility? >> Can you re-ask that question? Not sure what you want to know. >> >> This

Re: [PATCH 4/7] KVM: s390/CPACF: Choose crypto control block format

2015-02-04 Thread Paolo Bonzini
On 04/02/2015 14:05, Christian Borntraeger wrote: >> > >> > Could this also be part of the "things" that KVM can choose to enable, >> > even though it's not a facility? > Can you re-ask that question? Not sure what you want to know. > > This is mostly a fixup for z13, which wants to have a big

Re: [PATCH 4/7] KVM: s390/CPACF: Choose crypto control block format

2015-02-04 Thread Christian Borntraeger
Am 04.02.2015 um 14:00 schrieb Paolo Bonzini: > > > On 04/02/2015 10:44, Christian Borntraeger wrote: >> +static void kvm_s390_set_crycb_format(struct kvm *kvm) >> +{ >> +kvm->arch.crypto.crycbd = (__u32)(unsigned long) kvm->arch.crypto.crycb; >> + >> +if (kvm_s390_apxa_installed()) >> +

Re: [PATCH 4/7] KVM: s390/CPACF: Choose crypto control block format

2015-02-04 Thread Paolo Bonzini
On 04/02/2015 10:44, Christian Borntraeger wrote: > +static void kvm_s390_set_crycb_format(struct kvm *kvm) > +{ > + kvm->arch.crypto.crycbd = (__u32)(unsigned long) kvm->arch.crypto.crycb; > + > + if (kvm_s390_apxa_installed()) > + kvm->arch.crypto.crycbd |= CRYCB_FORMAT2; >

[PATCH 4/7] KVM: s390/CPACF: Choose crypto control block format

2015-02-04 Thread Christian Borntraeger
From: Tony Krowiak We need to specify a different format for the crypto control block depending on whether the APXA facility is installed or not. Let's test for it by executing the PQAP(QCI) function and use either a format-1 or a format-2 crypto control block accordingly. Signed-off-by: Tony Kr