Re: [PATCH 6/6 v3] PCI: document the change

2008-11-15 Thread Yu Zhao
Matthew Wilcox wrote: On Sat, Sep 27, 2008 at 04:28:45PM +0800, Zhao, Yu wrote: +To register SR-IOV service, Physical Function device driver needs to call: + int pci_iov_register(struct pci_dev *dev, + int (*notify)(struct pci_dev *, u32), char **entries) I think a better

RE: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Dong, Eddie
Matthew Wilcox wrote: Wouldn't it be more useful to have the iov/N directories be a symlink to the actual pci_dev used by the virtual function? The main concern here is that a VF may be disabed such as when PF enter D3 state or undergo an reset and thus be plug-off, but user won't

Re: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Matthew Wilcox
On Tue, Oct 14, 2008 at 08:23:34AM +0800, Dong, Eddie wrote: Matthew Wilcox wrote: Wouldn't it be more useful to have the iov/N directories be a symlink to the actual pci_dev used by the virtual function? The main concern here is that a VF may be disabed such as when PF enter D3 state

RE: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Dong, Eddie
Matthew Wilcox wrote: On Tue, Oct 14, 2008 at 08:23:34AM +0800, Dong, Eddie wrote: Matthew Wilcox wrote: Wouldn't it be more useful to have the iov/N directories be a symlink to the actual pci_dev used by the virtual function? The main concern here is that a VF may be disabed such as

Re: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Yu Zhao
On Tue, Oct 14, 2008 at 10:31:03AM +0800, Dong, Eddie wrote: Matthew Wilcox wrote: On Tue, Oct 14, 2008 at 08:23:34AM +0800, Dong, Eddie wrote: Matthew Wilcox wrote: Wouldn't it be more useful to have the iov/N directories be a symlink to the actual pci_dev used by the virtual

Re: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Matthew Wilcox
On Tue, Oct 14, 2008 at 10:14:35AM +0800, Yu Zhao wrote: BTW, the SR-IOV patch is not only for network, some other devices such as IDE will use same code base as well and we image it could have other parameter to set such as starting LBA of a IDE VF. As Eddie said, we have two problems

RE: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Dong, Eddie
Matthew Wilcox wrote: On Tue, Oct 14, 2008 at 10:14:35AM +0800, Yu Zhao wrote: BTW, the SR-IOV patch is not only for network, some other devices such as IDE will use same code base as well and we image it could have other parameter to set such as starting LBA of a IDE VF. As Eddie said,

Re: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Matthew Wilcox
On Tue, Oct 14, 2008 at 12:18:40PM +0800, Dong, Eddie wrote: Matthew Wilcox wrote: On Tue, Oct 14, 2008 at 10:14:35AM +0800, Yu Zhao wrote: As Eddie said, we have two problems here: 1) User has to set device specific parameters of a VF when he wants to use this VF with KVM (assign this

Re: [PATCH 6/6 v3] PCI: document the change

2008-10-13 Thread Yu Zhao
On Tue, Oct 14, 2008 at 12:01:05PM +0800, Matthew Wilcox wrote: On Tue, Oct 14, 2008 at 10:14:35AM +0800, Yu Zhao wrote: BTW, the SR-IOV patch is not only for network, some other devices such as IDE will use same code base as well and we image it could have other parameter to set such

Re: [PATCH 6/6 v3] PCI: document the change

2008-10-01 Thread Matthew Wilcox
On Sat, Sep 27, 2008 at 04:28:45PM +0800, Zhao, Yu wrote: +++ b/Documentation/DocBook/kernel-api.tmpl @@ -239,6 +239,7 @@ X!Ekernel/module.c /sect1 sect1titlePCI Support Library/title +!Iinclude/linux/pci.h Why do you need to do this? Thus far, all the documentation has been