Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 01:57 PM, Alexander Graf wrote: Some archs need to ensure that their icache is flushed when mapping a new page. Add a callback to the generic code for an arch to implement any cache flush logic it may need. Signed-off-by: Alexander Graf ag...@suse.de --- virt/kvm/kvm_main.c

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 15:32, Avi Kivity a...@redhat.com wrote: On 08/07/2012 01:57 PM, Alexander Graf wrote: Some archs need to ensure that their icache is flushed when mapping a new page. Add a callback to the generic code for an arch to implement any cache flush logic it may need.

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? I don't think anyone is. However, we need the struct page, and all the generic kvm mm code tries hard to hide it from its users. The alternative would be

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? I don't think anyone is. However, we need the struct page, and all the generic kvm mm code

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? I don't think anyone is. However, we need the

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 16:10, Avi Kivity a...@redhat.com wrote: On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 05:14 PM, Alexander Graf wrote: On 07.08.2012, at 16:10, Avi Kivity a...@redhat.com wrote: On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 16:20, Avi Kivity a...@redhat.com wrote: On 08/07/2012 05:14 PM, Alexander Graf wrote: On 07.08.2012, at 16:10, Avi Kivity a...@redhat.com wrote: On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 05:24 PM, Alexander Graf wrote: Pre-map? How? In arch code before you install the page in a pte/tlbe. So how do I get to the struct page in there? pfn_to_page() -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the

[PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
Some archs need to ensure that their icache is flushed when mapping a new page. Add a callback to the generic code for an arch to implement any cache flush logic it may need. Signed-off-by: Alexander Graf ag...@suse.de --- virt/kvm/kvm_main.c |6 +- 1 files changed, 5 insertions(+), 1

[PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
Some archs need to ensure that their icache is flushed when mapping a new page. Add a callback to the generic code for an arch to implement any cache flush logic it may need. Signed-off-by: Alexander Graf ag...@suse.de --- virt/kvm/kvm_main.c |6 +- 1 files changed, 5 insertions(+), 1

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 01:57 PM, Alexander Graf wrote: Some archs need to ensure that their icache is flushed when mapping a new page. Add a callback to the generic code for an arch to implement any cache flush logic it may need. Signed-off-by: Alexander Graf ag...@suse.de --- virt/kvm/kvm_main.c

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 15:32, Avi Kivity a...@redhat.com wrote: On 08/07/2012 01:57 PM, Alexander Graf wrote: Some archs need to ensure that their icache is flushed when mapping a new page. Add a callback to the generic code for an arch to implement any cache flush logic it may need.

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? I don't think anyone is. However, we need the struct page, and all the generic kvm mm code tries hard to hide it from its users. The alternative would be

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? I don't think anyone is. However, we need the struct page, and all the generic kvm mm code

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? I don't think anyone is. However, we need the

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 16:10, Avi Kivity a...@redhat.com wrote: On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct place? Who says the caller of hva_to_pfn() is

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 05:14 PM, Alexander Graf wrote: On 07.08.2012, at 16:10, Avi Kivity a...@redhat.com wrote: On 08/07/2012 05:08 PM, Alexander Graf wrote: On 07.08.2012, at 15:58, Avi Kivity a...@redhat.com wrote: On 08/07/2012 04:44 PM, Alexander Graf wrote: Is this the correct

Re: [PATCH 7/8] KVM: Add page map arch callback

2012-08-07 Thread Avi Kivity
On 08/07/2012 05:24 PM, Alexander Graf wrote: Pre-map? How? In arch code before you install the page in a pte/tlbe. So how do I get to the struct page in there? pfn_to_page() -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the