Re: [PATCH v2] KVM MMU: check reserved bits only when CR4.PSE=1 or CR4.PAE=1

2010-03-18 Thread Xiao Guangrong
Hi Marcelo, Thanks for your review. Marcelo Tosatti wrote: > On Wed, Mar 17, 2010 at 11:43:06AM +0800, Xiao Guangrong wrote: >> - The RSV bit is possibility set in error code when #PF occurred >> only if CR4.PSE=1 or CR4.PAE=1 >> >> - context->rsvd_bits_mask[1][0] is always 0 >> >> Changlog:

Re: [PATCH v2] KVM MMU: check reserved bits only when CR4.PSE=1 or CR4.PAE=1

2010-03-17 Thread Marcelo Tosatti
On Wed, Mar 17, 2010 at 11:43:06AM +0800, Xiao Guangrong wrote: > - The RSV bit is possibility set in error code when #PF occurred > only if CR4.PSE=1 or CR4.PAE=1 > > - context->rsvd_bits_mask[1][0] is always 0 > > Changlog: > Move this operation to reset_rsvds_bits_mask() address Avi Kivity

[PATCH v2] KVM MMU: check reserved bits only when CR4.PSE=1 or CR4.PAE=1

2010-03-16 Thread Xiao Guangrong
- The RSV bit is possibility set in error code when #PF occurred only if CR4.PSE=1 or CR4.PAE=1 - context->rsvd_bits_mask[1][0] is always 0 Changlog: Move this operation to reset_rsvds_bits_mask() address Avi Kivity's suggestion Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c | 12 +