Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-26 Thread Scott Wood
On 07/25/2013 03:50:42 AM, Gleb Natapov wrote: Why ppc uses page_is_ram() for mmap? How should I know? But looking at the function it does it only as a fallback if ppc_md.phys_mem_access_prot() is not provided. Making access to MMIO noncached as a safe fallback makes sense. There's only one cur

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-25 Thread Gleb Natapov
On Thu, Jul 25, 2013 at 06:07:55PM +0200, Alexander Graf wrote: > > On 25.07.2013, at 10:50, Gleb Natapov wrote: > > > On Wed, Jul 24, 2013 at 03:32:49PM -0500, Scott Wood wrote: > >> On 07/24/2013 04:39:59 AM, Alexander Graf wrote: > >>> > >>> On 24.07.2013, at 11:35, Gleb Natapov wrote: > >>>

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-25 Thread Alexander Graf
On 25.07.2013, at 10:50, Gleb Natapov wrote: > On Wed, Jul 24, 2013 at 03:32:49PM -0500, Scott Wood wrote: >> On 07/24/2013 04:39:59 AM, Alexander Graf wrote: >>> >>> On 24.07.2013, at 11:35, Gleb Natapov wrote: >>> On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: >> Are

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-25 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 03:32:49PM -0500, Scott Wood wrote: > On 07/24/2013 04:39:59 AM, Alexander Graf wrote: > > > >On 24.07.2013, at 11:35, Gleb Natapov wrote: > > > >> On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: > Are not we going to use page_is_ram() from > >e500_shado

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Andrea Arcangeli
Hi! On Wed, Jul 24, 2013 at 01:30:12PM +0300, Gleb Natapov wrote: > On Wed, Jul 24, 2013 at 12:25:18PM +0200, Alexander Graf wrote: > > > > On 24.07.2013, at 12:19, Gleb Natapov wrote: > > > > > On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: > > >> > > >> On 24.07.2013, at 12:0

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Scott Wood
On 07/24/2013 04:39:59 AM, Alexander Graf wrote: On 24.07.2013, at 11:35, Gleb Natapov wrote: > On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: >>> Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as Scott commented? >> >> rWhy aren't we using page_is_ram

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 12:25:18PM +0200, Alexander Graf wrote: > > On 24.07.2013, at 12:19, Gleb Natapov wrote: > > > On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: > >> > >> On 24.07.2013, at 12:01, Gleb Natapov wrote: > >> > >>> Copying Andrea for him to verify that I am not

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 12:19, Gleb Natapov wrote: > On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: >> >> On 24.07.2013, at 12:01, Gleb Natapov wrote: >> >>> Copying Andrea for him to verify that I am not talking nonsense :) >>> >>> On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexande

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: > > On 24.07.2013, at 12:01, Gleb Natapov wrote: > > > Copying Andrea for him to verify that I am not talking nonsense :) > > > > On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: > >>> diff --git a/virt/kvm/kvm_main.c

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 12:01, Gleb Natapov wrote: > Copying Andrea for him to verify that I am not talking nonsense :) > > On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: >>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >>> index 1580dd4..5e8635b 100644 >>> --- a/virt/kvm/kv

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 1580dd4..5e8635b 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -102,6

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 11:35, Gleb Natapov wrote: > On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: >>> Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as >>> Scott commented? >> >> rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()? >> >> > Because it is

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: > > Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as > > Scott commented? > > rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()? > > Because it is much slower and, IIRC, actually used to build pfn map

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
l.org; kvm@vger.kernel.org list; >> Wood Scott-B07421; Gleb Natapov; Paolo Bonzini >> Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel >> managed pages >> >> >> On 24.07.2013, at 04:26, “tiejun.chen” wrote: >> >>> On 0

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Bhushan Bharat-R65777
>>>>> On 18.07.2013, at 10:25, Bhushan Bharat-R65777 wrote: > >>>>>> > >>>>>>> > >>>>>>> > >>>>>>>> -----Original Message----- > >>>>>>>> From: Bhushan Bhar

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
>> >>>>>>>> -Original Message- >>>>>>>> From: Bhushan Bharat-R65777 >>>>>>>> Sent: Thursday, July 18, 2013 1:53 PM >>>>>>>> To: '"�tiejun.chen�"' >>>>>>>>

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-23 Thread “tiejun.chen”
: -Original Message- From: Bhushan Bharat-R65777 Sent: Thursday, July 18, 2013 1:53 PM To: '"�tiejun.chen�"' Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- B07421 Subject: RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Scott Wood
On 07/18/2013 05:00:42 AM, Alexander Graf wrote: Now why is setting invalid flags a problem? If I understand Scott correctly, it can break the host if you access certain host devices with caching enabled. But to be sure I'd say we ask him directly :). The architecture makes it illegal to mix

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Alexander Graf
;> kernel >>>>>> managed pages >>>>>> >>>>>> >>>>>> >>>>>>> -Original Message- >>>>>>> From: "�tiejun.chen�" [mailto:tiejun.c...@windriver.com] >>>

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
To: '"�tiejun.chen�"' Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- B07421 Subject: RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages -Original Message- From: "�tiejun.chen�" [mailto:tiejun.c...

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
-R65777 Sent: Thursday, July 18, 2013 1:53 PM To: '"�tiejun.chen�"' Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- B07421 Subject: RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages -Original Message-

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Alexander Graf
harat-R65777 >>>> Sent: Thursday, July 18, 2013 1:53 PM >>>> To: '"�tiejun.chen�"' >>>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood >>>> Scott- >>>> B07421 >>>> Subject: RE: [P

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
@suse.de; Wood Scott- B07421 Subject: RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages -Original Message- From: "�tiejun.chen�" [mailto:tiejun.c...@windriver.com] Sent: Thursday, July 18, 2013 1:52 PM To: Bhushan Bharat-R65777 Cc: kvm-...@vger.k

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Alexander Graf
>> -Original Message- >>>>> From: Bhushan Bharat-R65777 >>>>> Sent: Thursday, July 18, 2013 1:53 PM >>>>> To: '"�tiejun.chen�"' >>>>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- B07421 Subject: RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages -Original Message- From: "�tiejun.chen�" [mailto:tiejun.c...@windriver.com] Sent: Thursday, July 18, 2013 1:52 P

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Bhushan Bharat-R65777
el.org; Wood Scott- > B07421 > Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel > managed pages > > > On 18.07.2013, at 10:25, Bhushan Bharat-R65777 wrote: > > > > > > >> -Original Message- > >> From: Bhushan B

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Alexander Graf
driver.com] >>> Sent: Thursday, July 18, 2013 1:52 PM >>> To: Bhushan Bharat-R65777 >>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood >>> Scott- >>> B07421 >>> Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Alexander Graf
n”"' >>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- >>> B07421 >>> Subject: RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel >>> managed pages >>> >>> >>> >>&g

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
t; Sent: Thursday, July 18, 2013 1:01 PM To: Bhushan Bharat-R65777 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- B07421 Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages On 07/18/2013 03:12 PM, Bhushan Bharat-R65777 wr

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Bhushan Bharat-R65777
t; > >> -Original Message- > > >> From: kvm-ppc-ow...@vger.kernel.org > > >> [mailto:kvm-ppc-ow...@vger.kernel.org] On Behalf Of "“tiejun.chen”" > > >> Sent: Thursday, July 18, 2013 1:01 PM > > >> To: Bhushan Bharat-R657

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
On 07/18/2013 02:04 PM, Bharat Bhushan wrote: If there is a struct page for the requested mapping then it's normal DDR and the mapping sets "M" bit (coherent, cacheable) else this is treated as I/O and we set "I + G" (cache inhibited, guarded) This helps setting proper TLB mapping for direct a

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Bhushan Bharat-R65777
el.org] On Behalf Of "“tiejun.chen”" > >> Sent: Thursday, July 18, 2013 1:01 PM > >> To: Bhushan Bharat-R65777 > >> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Wood > >> Scott- > >> B07421 > >> Subject: Re:

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
l.org; kvm@vger.kernel.org; ag...@suse.de; Wood Scott- B07421 Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages On 07/18/2013 03:12 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: "“tiejun.chen”" [mailto:tiejun.c...@windriver.com] Sent: Thu

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Bhushan Bharat-R65777
use.de; Wood Scott- > B07421 > Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel > managed pages > > On 07/18/2013 03:12 PM, Bhushan Bharat-R65777 wrote: > > > > > >> -Original Message- > >> From: "“tiejun.chen”&q

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread “tiejun.chen”
tt- B07421; Bhushan Bharat-R65777 Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages On 07/18/2013 02:04 PM, Bharat Bhushan wrote: If there is a struct page for the requested mapping then it's normal DDR and the mapping sets "M" bit (coherent, cacheable

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-18 Thread Bhushan Bharat-R65777
77 > Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel > managed pages > > On 07/18/2013 02:04 PM, Bharat Bhushan wrote: > > If there is a struct page for the requested mapping then it's normal > > DDR and the mapping sets "M" bit (cohe

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-17 Thread “tiejun.chen”
On 07/18/2013 02:04 PM, Bharat Bhushan wrote: If there is a struct page for the requested mapping then it's normal DDR and the mapping sets "M" bit (coherent, cacheable) else this is treated as I/O and we set "I + G" (cache inhibited, guarded) This helps setting proper TLB mapping for direct a