Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-26 Thread Amos Kong
On Wed, Oct 21, 2009 at 06:37:56PM +0800, Amos Kong wrote: On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: See comments below. Hi all, Thanks for your reply. . Agree with you. When I test this case, the original get_command_status() always cause special read

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-21 Thread Amos Kong
On Mon, Oct 19, 2009 at 10:22:21AM +0200, Dor Laor wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test communication by ping using hard-coded ip address

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-21 Thread Amos Kong
On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: See comments below. Hi all, Thanks for your reply. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2)

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-21 Thread Michael Goldish
- Amos Kong ak...@redhat.com wrote: On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: See comments below. Hi all, Thanks for your reply. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-21 Thread Uri Lublin
On 10/21/2009 12:37 PM, Amos Kong wrote: On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: - Dor Laordl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: For the sake of safety maybe we should start both VMs with -snapshot. Dor, what do you think? Is it safe

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-21 Thread Dor Laor
On 10/21/2009 03:46 PM, Uri Lublin wrote: On 10/21/2009 12:37 PM, Amos Kong wrote: On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: - Dor Laordl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: For the sake of safety maybe we should start both VMs with

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-20 Thread Michael Goldish
See comments below. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test communication by ping using hard-coded ip

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-20 Thread Lucas Meneghel Rodrigues
On Tue, Oct 20, 2009 at 11:19 AM, Michael Goldish mgold...@redhat.com wrote: See comments below. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command.    1) Create two VMs    2) Setup guests in different

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-19 Thread Dor Laor
On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test communication by ping using hard-coded ip address 3) Setup guests in same vlan and test communication by ping

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-14 Thread Lucas Meneghel Rodrigues
Hi Amos, thanks for the patch, here are my comments (pretty much concerning only coding style): On Wed, Sep 23, 2009 at 8:19 AM, Amos Kong ak...@redhat.com wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test