Re: [PATCH] kvm: x86: emulate monitor and mwait instructions as nop

2014-05-07 Thread Paolo Bonzini
Il 07/05/2014 20:10, Gabriel L. Somlo ha scritto: 1. I can't test svm.c (on AMD). As such, I'm not sure the skip_emulated_instruction() call in my own version of nop_interception() is necessary. If not, I could probably just call the already existing nop_on_interception() (line 1

Re: [PATCH] kvm: x86: emulate monitor and mwait instructions as nop

2014-05-07 Thread Alexander Graf
On 05/07/2014 08:15 PM, Michael S. Tsirkin wrote: On Wed, May 07, 2014 at 02:10:59PM -0400, Gabriel L. Somlo wrote: Treat monitor and mwait instructions as nop, which is architecturally correct (but inefficient) behavior. We do this to prevent misbehaving guests (e.g. OS X <= 10.7) from receivin

Re: [PATCH] kvm: x86: emulate monitor and mwait instructions as nop

2014-05-07 Thread Michael S. Tsirkin
On Wed, May 07, 2014 at 02:10:59PM -0400, Gabriel L. Somlo wrote: > Treat monitor and mwait instructions as nop, which is architecturally > correct (but inefficient) behavior. We do this to prevent misbehaving > guests (e.g. OS X <= 10.7) from receiving invalid opcode faults after > failing to chec