On Tue, Nov 25, 2008 at 04:49:49PM +0200, Avi Kivity wrote:
> Avi Kivity wrote:
>>> (In fact, PCI spec defined message data length is u64, but as you
>>> see, now msi_msg for whole Linux only have u32...)
>>>
>>
>> Well in that case please define data as __u64, so we don't have
>> surprises
Avi Kivity wrote:
(In fact, PCI spec defined message data length is u64, but as you
see, now msi_msg for whole Linux only have u32...)
Well in that case please define data as __u64, so we don't have
surprises later on.
btw, if you agree with this, don't resend; I'll edit the patch.
--
Sheng Yang wrote:
union {
+ struct {
+ __u32 addr_lo;
+ __u32 addr_hi;
__u64 addr;
?
Here I followed the spec that distinguish the "Message Address" and "Message
Upper address". And the native Linux structure:
st
On Sunday 23 November 2008 18:10:47 Avi Kivity wrote:
> Sheng Yang wrote:
> > Prepared for kvm_arch_assigned_device_msi_dispatch().
> >
> > @@ -507,10 +507,17 @@ struct kvm_assigned_irq {
> > __u32 guest_irq;
> > __u32 flags;
> > union {
> > + struct {
> > +
Sheng Yang wrote:
Prepared for kvm_arch_assigned_device_msi_dispatch().
@@ -507,10 +507,17 @@ struct kvm_assigned_irq {
__u32 guest_irq;
__u32 flags;
union {
+ struct {
+ __u32 addr_lo;
+ __u32 addr_hi;
__u64
