On 02/03/12 18:41, Daniel P. Berrange wrote:
On Fri, Mar 02, 2012 at 02:25:36PM +0400, Michael Tokarev wrote:
Not a reply to the patch but a general observation.
I noticed that the tcp migration uses gethostname
(or getaddrinfo after this patch) from the main
thread - is it really the way to
This is quite ugly. Two threads, one running main_loop_wait and
one running qemu_aio_wait, can race with each other on running the
same iohandler. The result is that an iohandler could run while the
underlying socket is not readable or writable, with possibly ill effects.
This shows as a
Am 02.03.2012 20:54, schrieb Laine Stump:
On 03/02/2012 05:35 AM, Kevin Wolf wrote:
Am 02.03.2012 10:58, schrieb Amos Kong:
On 02/03/12 11:38, Amos Kong wrote:
--- a/net.c
+++ b/net.c
@@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size,
const char **pp, int sep)
const
- Original Message -
Am 02.03.2012 20:54, schrieb Laine Stump:
On 03/02/2012 05:35 AM, Kevin Wolf wrote:
Am 02.03.2012 10:58, schrieb Amos Kong:
On 02/03/12 11:38, Amos Kong wrote:
--- a/net.c
+++ b/net.c
@@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int
buf_size,
Am 05.03.2012 09:59, schrieb Amos Kong:
- Original Message -
Am 02.03.2012 20:54, schrieb Laine Stump:
On 03/02/2012 05:35 AM, Kevin Wolf wrote:
Am 02.03.2012 10:58, schrieb Amos Kong:
On 02/03/12 11:38, Amos Kong wrote:
--- a/net.c
+++ b/net.c
@@ -84,7 +84,7 @@ static int
On 2012-03-05 09:34, Paolo Bonzini wrote:
This is quite ugly. Two threads, one running main_loop_wait and
one running qemu_aio_wait, can race with each other on running the
same iohandler. The result is that an iohandler could run while the
underlying socket is not readable or writable, with
Il 05/03/2012 10:07, Jan Kiszka ha scritto:
This is quite ugly. Two threads, one running main_loop_wait and
one running qemu_aio_wait, can race with each other on running the
same iohandler. The result is that an iohandler could run while the
underlying socket is not readable or
+/*
+ * Host interrupt handlers may have clobbered these guest-readable
+ * SPRGs, so we need to reload them here with the guest's values.
+ */
+lwz r3, VCPU_VRSAVE(r4)
+lwz r5, VCPU_SHARED_SPRG4(r11)
+mtspr SPRN_VRSAVE, r3
+lwz r6,
---
drivers/pci/pci.h|1 +
drivers/pci/quirks.c | 33 +++--
include/linux/pci.h |1 +
3 files changed, 29 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 1009a5e..4d10479 100644
--- a/drivers/pci/pci.h
+++
Hi,
I have a use case where I need to cleanup resource allocated for Virtual
Functions after a guest OS that used it crashed. This cleanup needs to
be done before the VF is being FLRed. The only possible way to do this
seems to be by using pci_dev_specific_reset() function. Unfortunately
this
Those patches make migration of IPv6 address work, old code
only support to parse IPv4 address/port, use getaddrinfo()
to get socket addresses infomation.
Last two patches are about spliting IPv6 host/port.
Changes from v1:
- split different changes to small patches, it will be
easier to
Introduce tcp_server_start() by moving original code in
tcp_start_incoming_migration().
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c | 27 +++
qemu_socket.h |2 ++
2 files changed, 29 insertions(+), 0 deletions(-)
diff --git a/net.c b/net.c
index
Use tcp_server_start in those two functions:
tcp_start_incoming_migration()
net_socket_listen_init()
Signed-off-by: Amos Kong ak...@redhat.com
---
migration-tcp.c | 21 +
net/socket.c| 23 +++
2 files changed, 8 insertions(+), 36 deletions(-)
Introduce tcp_client_start() by moving original code in
tcp_start_outgoing_migration().
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c | 39 +++
qemu_socket.h |1 +
2 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/net.c
Use tcp_client_start() in those two functions:
tcp_start_outgoing_migration()
net_socket_connect_init()
Signed-off-by: Amos Kong ak...@redhat.com
---
migration-tcp.c | 41 +
net/socket.c| 41 +++--
2 files
There are some repeated code for tcp_server_start()
and tcp_client_start().
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c | 82 -
1 files changed, 46 insertions(+), 36 deletions(-)
diff --git a/net.c b/net.c
index
Migrating with IPv6 address exists problem, gethostbyname()/inet_aton()
could not translate IPv6 address/port simply, so use getaddrinfo()
in tcp_start_common to translate network address and service.
We can get an address list by getaddrinfo().
Userlevel IPv6 Programming Introduction:
int parse_host_port(struct sockaddr_in *saddr, const char *str)
Parsed address info will be restored into 'saddr', it only support ipv4.
This function is used by net_socket_mcast_init() and net_socket_udp_init().
int parse_host_port_info(struct addrinfo *result, const char *str)
Parsed address
IPv6 address contains colons, parse will be wrong.
[2312::8274]:5200
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net.c b/net.c
index 2518e5f..d6ce1fa 100644
--- a/net.c
+++ b/net.c
@@ -84,7 +84,7 @@ static int
That method of representing an IPv6 address with a port is
discouraged because of its ambiguity. Referencing to RFC5952,
the recommended format is:
[2312::8274]:5200
For IPv6 brackets must be mandatory if you require a port.
test status: Successed
listen side: qemu-kvm -incoming
Hi
Please send in any agenda items you are interested in covering.
Cheers, Juan.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
No instruction which can change Condition Register (CR) should be executed
after Guest CR is loaded. So the guest CR is restored after the Exit Timing in
lightweight_exit executes cmpw, which can clobber CR.
Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com
---
This patch is against
If some vcpus are created before KVM_CREATE_IRQCHIP, then
irqchip_in_kernel() and vcpu-arch.apic will be inconsistent, leading
to potential NULL pointer dereferences.
Fix by:
- ensuring that no vcpus are installed when KVM_CREATE_IRQCHIP is called
- ensuring that a vcpu has an apic if it is
On 03/05/2012 12:03 PM, Amos Kong wrote:
Introduce tcp_server_start() by moving original code in
tcp_start_incoming_migration().
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c | 27 +++
qemu_socket.h |2 ++
2 files changed, 29 insertions(+), 0
On 03/05/2012 12:03 PM, Amos Kong wrote:
Introduce tcp_client_start() by moving original code in
tcp_start_outgoing_migration().
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c | 39 +++
qemu_socket.h |1 +
2 files changed, 40
On 03/05/2012 12:03 PM, Amos Kong wrote:
Use tcp_server_start in those two functions:
tcp_start_incoming_migration()
net_socket_listen_init()
Signed-off-by: Amos Kong ak...@redhat.com
---
migration-tcp.c | 21 +
net/socket.c| 23 +++
2
On 03/05/2012 12:03 PM, Amos Kong wrote:
Introduce tcp_client_start() by moving original code in
tcp_start_outgoing_migration().
Signed-off-by: Amos Kong ak...@redhat.com
---
net.c | 39 +++
qemu_socket.h |1 +
2 files changed, 40
On 02/21/2012 07:33 PM, Peter Maydell wrote:
On 9 February 2012 22:23, Peter Maydellpeter.mayd...@linaro.org wrote:
Ping re the VMState and variable sized arrays issue. I don't
see any consensus in this discussion for a different approach,
so should we just commit Mitsyanko's patchset?
From
On 03/05/2012 12:03 PM, Amos Kong wrote:
Use tcp_client_start() in those two functions:
tcp_start_outgoing_migration()
net_socket_connect_init()
Signed-off-by: Amos Kong ak...@redhat.com
---
migration-tcp.c | 41 +
net/socket.c| 41
On 05/03/12 21:27, Orit Wasserman wrote:
On 03/05/2012 12:03 PM, Amos Kong wrote:
Use tcp_server_start in those two functions:
tcp_start_incoming_migration()
net_socket_listen_init()
Signed-off-by: Amos Kongak...@redhat.com
---
migration-tcp.c | 21 +
net/socket.c
On 05/03/12 21:25, Orit Wasserman wrote:
On 03/05/2012 12:03 PM, Amos Kong wrote:
Introduce tcp_server_start() by moving original code in
tcp_start_incoming_migration().
Signed-off-by: Amos Kongak...@redhat.com
---
net.c | 27 +++
qemu_socket.h |2 ++
On 03/05/2012 03:38 PM, Igor Mitsyanko wrote:
Short summary:
* switch wp groups to bitfield rather than int array
* convert sd.c to use memory_region_init_ram() to allocate the wp
groups
(being careful to use memory_region_set_dirty() when we touch them)
* we don't need variable-length
On 02/26/2012 04:55 PM, Gleb Natapov wrote:
Gleb Natapov (3):
KVM: x86 emulator: warn when pin control is set in eventsel msr
KVM: x86 emulator: Fix raw event check
KVM: x86 emulator: add proper support for fixed counter 2
Thanks, applied (s/emulator/pmu/...)
--
error compiling
On 02/26/2012 05:20 PM, Gleb Natapov wrote:
Add unit test to test architectural PMU emulation in kvm.
Thanks, applied.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to
On 03/05/2012 11:07 AM, Jan Kiszka wrote:
On 2012-03-05 09:34, Paolo Bonzini wrote:
This is quite ugly. Two threads, one running main_loop_wait and
one running qemu_aio_wait, can race with each other on running the
same iohandler. The result is that an iohandler could run while the
Il 05/03/2012 15:24, Avi Kivity ha scritto:
On 03/05/2012 11:07 AM, Jan Kiszka wrote:
On 2012-03-05 09:34, Paolo Bonzini wrote:
This is quite ugly. Two threads, one running main_loop_wait and
one running qemu_aio_wait, can race with each other on running the
same iohandler. The result is
On 2012-03-05 15:24, Avi Kivity wrote:
Long-term, I'd like to cut out certain file descriptors from the main
loop and process them completely in separate threads (for separate
locking, prioritization etc.). Dunno how NBD works, but maybe it should
be reworked like this already.
Ideally
On 03/05/2012 06:13 PM, Avi Kivity wrote:
On 03/05/2012 03:38 PM, Igor Mitsyanko wrote:
Short summary:
* switch wp groups to bitfield rather than int array
* convert sd.c to use memory_region_init_ram() to allocate the wp
groups
(being careful to use memory_region_set_dirty() when we
On Mon, Mar 05, 2012 at 04:18:21PM +0200, Avi Kivity wrote:
On 02/26/2012 04:55 PM, Gleb Natapov wrote:
Gleb Natapov (3):
KVM: x86 emulator: warn when pin control is set in eventsel msr
KVM: x86 emulator: Fix raw event check
KVM: x86 emulator: add proper support for fixed counter 2
On 03/05/2012 04:37 PM, Igor Mitsyanko wrote:
Well, can't you make sd.c target dependent? It's not so nice, but it
does solve the problem.
OK, but it will turn qemu from it's long term path to suppress *all*
target specific code :)
The other alternative is to
On 03/05/2012 04:30 PM, Paolo Bonzini wrote:
Il 05/03/2012 15:24, Avi Kivity ha scritto:
On 03/05/2012 11:07 AM, Jan Kiszka wrote:
On 2012-03-05 09:34, Paolo Bonzini wrote:
This is quite ugly. Two threads, one running main_loop_wait and
one running qemu_aio_wait, can race with each other
On 03/05/2012 09:10 AM, Avi Kivity wrote:
On 03/05/2012 04:37 PM, Igor Mitsyanko wrote:
Well, can't you make sd.c target dependent? It's not so nice, but it
does solve the problem.
OK, but it will turn qemu from it's long term path to suppress *all*
target specific code :)
The other
On 03/05/2012 05:15 PM, Anthony Liguori wrote:
The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory
API. I think 32-on-32 is quite rare these days, so it wouldn't be much
of a performance issue.
I think this makes sense independent of other discussions regarding
fixing
On 5 March 2012 15:10, Avi Kivity a...@redhat.com wrote:
I think 32-on-32 is quite rare these days, so it wouldn't be much
of a performance issue.
32-on-32 will be the standard case for KVM on ARM I think...
-- PMM
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of
On 03/05/2012 05:20 PM, Peter Maydell wrote:
On 5 March 2012 15:10, Avi Kivity a...@redhat.com wrote:
I think 32-on-32 is quite rare these days, so it wouldn't be much
of a performance issue.
32-on-32 will be the standard case for KVM on ARM I think...
Won't we be virtualizing LPAE per
On 5 March 2012 15:21, Avi Kivity a...@redhat.com wrote:
On 03/05/2012 05:20 PM, Peter Maydell wrote:
On 5 March 2012 15:10, Avi Kivity a...@redhat.com wrote:
I think 32-on-32 is quite rare these days, so it wouldn't be much
of a performance issue.
32-on-32 will be the standard case for
Am 05.03.2012 16:10, schrieb Avi Kivity:
On 03/05/2012 04:37 PM, Igor Mitsyanko wrote:
Well, can't you make sd.c target dependent? It's not so nice, but it
does solve the problem.
OK, but it will turn qemu from it's long term path to suppress *all*
target specific code :)
The other
On 03/05/2012 05:43 PM, Andreas Färber wrote:
Am 05.03.2012 16:10, schrieb Avi Kivity:
On 03/05/2012 04:37 PM, Igor Mitsyanko wrote:
Well, can't you make sd.c target dependent? It's not so nice, but it
does solve the problem.
OK, but it will turn qemu from it's long term path to
On 5 March 2012 15:43, Andreas Färber afaer...@suse.de wrote:
Mid-term also depends on how me want to proceed with LPAE softmmu-wise
(bump arm to 64-bit target_phys_addr_t, or do LPAE and AArch64 in a
new arm64).
For LPAE I would have thought we want to make arm go to a 64 bit
From: Davidlohr Bueso d...@gnu.org
The reset_rsvds_bits_mask() function can use the guest walker's root level
number
instead of using a separate 'level' variable.
Signed-off-by: Davidlohr Bueso d...@gnu.org
---
arch/x86/kvm/mmu.c | 31 +++
1 files changed, 15
On PPC, CR2-CR4 are nonvolatile, thus have to be saved across function calls.
We didn't respect that for any architecture until Paul spotted it in his
patch for Book3S-HV. This patch saves/restores CR for all KVM capable PPC hosts.
Signed-off-by: Alexander Graf ag...@suse.de
---
Am 10.02.2012 15:36, schrieb Dongsu Park:
Recently I observed performance regression regarding virtio-blk,
especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0.
So I want to share the benchmark results, and ask you what the reason
would be.
Hi,
I think I found the problem, there
Il 05/03/2012 16:14, Avi Kivity ha scritto:
Hmm, I don't think so. It would need to protect execution of the
iohandlers too, and pretty much everything can happen there including a
nested loop. Of course recursive mutexes exist, but it sounds like too
big an axe.
The I/O handlers would
Hi ,
We have been using qemu/kvm 0.12.5 (unchanged with stock kernel 2.6.32).
I just upgraded to qemu/kvm-1.0 and see noticable difference in packet I/O.
I want to understand the enhancements in 1.0 that leads to better performance.
Can you give me some pointers?
Off the bat I see new event
Side note: I am not using vhost-net yet. I am reading from the blogs
that vhost-net gives much better performance.
I am putting another system up with vhost-net support to measure this.
Appreciate the pointers for previous question.
/a
On Mon, Mar 5, 2012 at 11:17 AM, Al Patel
On Mon, Mar 5, 2012 at 4:13 PM, Martin Mailand mar...@tuxadero.com wrote:
Am 10.02.2012 15:36, schrieb Dongsu Park:
Recently I observed performance regression regarding virtio-blk,
especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0.
So I want to share the benchmark results,
On Tue, Feb 14, 2012 at 04:17:20PM -0500, Eric B Munson wrote:
On Tue, 14 Feb 2012, Marcelo Tosatti wrote:
On Tue, Feb 14, 2012 at 10:50:13AM -0500, Eric B Munson wrote:
On Tue, 14 Feb 2012, Marcelo Tosatti wrote:
On Tue, Feb 14, 2012 at 10:29:31AM -0500, Eric B Munson wrote:
Am 05.03.2012 17:35, schrieb Stefan Hajnoczi:
1. Test on i7 Laptop with Cpu governor ondemand.
v0.14.1
bw=63492KB/s iops=15873
bw=63221KB/s iops=15805
v1.0
bw=36696KB/s iops=9173
bw=37404KB/s iops=9350
master
bw=36396KB/s iops=9099
bw=34182KB/s iops=8545
Change the Cpu
On Mon, Mar 05, 2012 at 10:00:49AM +, Tadeusz Struk wrote:
---
drivers/pci/pci.h|1 +
drivers/pci/quirks.c | 33 +++--
include/linux/pci.h |1 +
3 files changed, 29 insertions(+), 6 deletions(-)
Please read Documentation/SubmittingPatches for
On Tue, Feb 28, 2012 at 08:40:06PM -0800, John Fastabend wrote:
Also if there are embedded switches with learning capabilities they
might want to trigger events to user space. In this case having
a protocol type makes user space a bit easier to manage. I've
added Lennert so maybe he can
On Thu, Mar 01, 2012 at 08:36:20AM -0500, Jamal Hadi Salim wrote:
I want to see a unified API so that user space control applications
(RSTP, TRILL?)
can use one set of netlink calls for both software bridge and hardware
offloaded
bridges. Does this proposal meet that
On Mon, 5 Mar 2012 13:39:43 -0300, Marcelo Tosatti wrote:
On Tue, Feb 14, 2012 at 04:17:20PM -0500, Eric B Munson wrote:
On Tue, 14 Feb 2012, Marcelo Tosatti wrote:
On Tue, Feb 14, 2012 at 10:50:13AM -0500, Eric B Munson wrote:
On Tue, 14 Feb 2012, Marcelo Tosatti wrote:
On Tue, Feb
On 03/05/2012 05:50 PM, Peter Maydell wrote:
On 5 March 2012 15:43, Andreas Färber afaer...@suse.de wrote:
Mid-term also depends on how me want to proceed with LPAE softmmu-wise
(bump arm to 64-bit target_phys_addr_t, or do LPAE and AArch64 in a
new arm64).
For LPAE I would have thought
On 03/05/2012 06:14 PM, Paolo Bonzini wrote:
Il 05/03/2012 16:14, Avi Kivity ha scritto:
Hmm, I don't think so. It would need to protect execution of the
iohandlers too, and pretty much everything can happen there including a
nested loop. Of course recursive mutexes exist, but it
On 03/05/2012 04:30 PM, Jan Kiszka wrote:
On 2012-03-05 15:24, Avi Kivity wrote:
Long-term, I'd like to cut out certain file descriptors from the main
loop and process them completely in separate threads (for separate
locking, prioritization etc.). Dunno how NBD works, but maybe it should
Hi Simon,
you are using a 100Mbits nic and you try to send with 600M, try a
1000Mbits on the sending site as well.
-martin
Am 05.03.2012 00:57, schrieb Simon Chen:
For the two VMs, one is using 100M VNIC, the other is using 1000M one.
The vnet interfaces for the two VMs are put on two
On 2012-03-05 18:39, Avi Kivity wrote:
On 03/05/2012 04:30 PM, Jan Kiszka wrote:
On 2012-03-05 15:24, Avi Kivity wrote:
Long-term, I'd like to cut out certain file descriptors from the main
loop and process them completely in separate threads (for separate
locking, prioritization etc.). Dunno
On Mon, Mar 5, 2012 at 3:00 AM, Tadeusz Struk tadeusz.st...@intel.com wrote:
---
drivers/pci/pci.h | 1 +
drivers/pci/quirks.c | 33 +++--
include/linux/pci.h | 1 +
3 files changed, 29 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/pci.h
On Mon, Mar 5, 2012 at 15:17, Avi Kivity a...@redhat.com wrote:
On 03/05/2012 05:15 PM, Anthony Liguori wrote:
The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory
API. I think 32-on-32 is quite rare these days, so it wouldn't be much
of a performance issue.
I think
On Mon, 5 Mar 2012, Blue Swirl wrote:
On Mon, Mar 5, 2012 at 15:17, Avi Kivity a...@redhat.com wrote:
On 03/05/2012 05:15 PM, Anthony Liguori wrote:
The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory
API. I think 32-on-32 is quite rare these days, so it wouldn't be
On 03/05/2012 10:02 AM, Alexander Graf wrote:
@@ -442,6 +444,7 @@ heavyweight_exit:
/* Return to kvm_vcpu_run(). */
mtlrr5
+ mtcrr6
addir1, r1, HOST_STACK_SIZE
/* r3 still contains the return code from kvmppc_handle_exit(). */
blr
@@ -459,6
https://bugzilla.kernel.org/show_bug.cgi?id=42829
Steve stefan.bo...@gmail.com changed:
What|Removed |Added
Kernel Version|v3.0-rc5|v3.0-rc1
--
Configure
https://bugzilla.kernel.org/show_bug.cgi?id=42829
Steve stefan.bo...@gmail.com changed:
What|Removed |Added
Kernel Version|v3.0-rc1|v3.0-rc1+
https://bugzilla.kernel.org/show_bug.cgi?id=42829
Jason Wang jasow...@redhat.com changed:
What|Removed |Added
CC||jasow...@redhat.com
On 3/5/2012 8:53 AM, Lennert Buytenhek wrote:
On Tue, Feb 28, 2012 at 08:40:06PM -0800, John Fastabend wrote:
Also if there are embedded switches with learning capabilities they
might want to trigger events to user space. In this case having
a protocol type makes user space a bit easier to
Avi,
Any comments?
Thanks,
Jinsong
Liu, Jinsong wrote:
From ecd8be962f69393c183f941bfdbd7a7d3876d442 Mon Sep 17 00:00:00 2001
From: Liu, Jinsong jinsong@intel.com
Date: Mon, 27 Feb 2012 05:19:32 +0800
Subject: [PATCH] KVM: expose Intel cpu new features to guest
Intel recently release
On Mon, 2012-03-05 at 14:29 +0200, Avi Kivity wrote:
If some vcpus are created before KVM_CREATE_IRQCHIP, then
irqchip_in_kernel() and vcpu-arch.apic will be inconsistent, leading
to potential NULL pointer dereferences.
Fix by:
- ensuring that no vcpus are installed when KVM_CREATE_IRQCHIP
https://bugzilla.kernel.org/show_bug.cgi?id=42829
--- Comment #13 from Steve stefan.bo...@gmail.com 2012-03-06 07:28:59 ---
Hello.
I start testing from latest master branch v3.3-rc6+ on both: host, guest.
During all test host has the same kernel other stuff, on guest
i changed only kernel
Commits 2f5cdd5487 (KVM: PPC: Book3S HV: Make secondary threads more
robust against stray IPIs) and 1c2066b0f7 (KVM: PPC: Book3S HV: Make
virtual processor area registration more robust) added fields to
struct kvm_vcpu_arch inside #ifdef CONFIG_KVM_BOOK3S_64_HV regions,
and added lines to
Jan,
Any comments? I feel some confused about your point 'disable cpuid feature for
older machine types by default': are you planning a common approach for this
common issue, or, you just ask me a specific solution for the tsc deadline
timer case?
Thanks,
Jinsong
Liu, Jinsong wrote:
My
+/*
+ * Host interrupt handlers may have clobbered these guest-readable
+ * SPRGs, so we need to reload them here with the guest's values.
+ */
+lwz r3, VCPU_VRSAVE(r4)
+lwz r5, VCPU_SHARED_SPRG4(r11)
+mtspr SPRN_VRSAVE, r3
+lwz r6,
No instruction which can change Condition Register (CR) should be executed
after Guest CR is loaded. So the guest CR is restored after the Exit Timing in
lightweight_exit executes cmpw, which can clobber CR.
Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com
---
This patch is against
On PPC, CR2-CR4 are nonvolatile, thus have to be saved across function calls.
We didn't respect that for any architecture until Paul spotted it in his
patch for Book3S-HV. This patch saves/restores CR for all KVM capable PPC hosts.
Signed-off-by: Alexander Graf ag...@suse.de
---
On 02/21/2012 05:30 AM, Ben Collins wrote:
The result of kvmppc_core_vcpu_create() was being manipulated before it was
checked for IS_ERR(). Did not see the bug occur, but caught it when looking
through the code.
Nice catch, but this has already been fixed by Matt:
commit
On 02/03/2012 11:53 AM, Paul Mackerras wrote:
The ABI specifies that CR fields CR2--CR4 are nonvolatile across function
calls. Currently __kvmppc_vcore_entry doesn't save and restore the CR,
leading to CR2--CR4 getting corrupted with guest values, possibly leading
to incorrect behaviour in its
On 01/31/2012 07:25 AM, Matt Evans wrote:
SPAPR support includes various in-kernel hypercalls, improving performance
by cutting out the exit to userspace. H_BULK_REMOVE is implemented in this
patch.
Signed-off-by: Matt Evansm...@ozlabs.org
Thanks, applied to kvm-ppc-next.
Alex
--
To
Hi
I'm working on powerpc booke architecture and my project requires me to remove
read and write privileges on some pages. Due to this any instruction accessing
these pages traps and i'm trying to emulate the behavior of these instructions.
I've emulated lwarx and stwcx instruction but i think
On 03/05/2012 02:37 PM, Aashish Mittal wrote:
Hi
I'm working on powerpc booke architecture and my project requires me to remove
read and write privileges on some pages. Due to this any instruction accessing
these pages traps and i'm trying to emulate the behavior of these
instructions.
On 03/05/2012 10:02 AM, Alexander Graf wrote:
@@ -442,6 +444,7 @@ heavyweight_exit:
/* Return to kvm_vcpu_run(). */
mtlrr5
+ mtcrr6
addir1, r1, HOST_STACK_SIZE
/* r3 still contains the return code from kvmppc_handle_exit(). */
blr
@@ -459,6
89 matches
Mail list logo
