Re: [PATCH] virtio/s390: use dev_to_virtio

On Wed, 30 Dec 2015 22:05:25 +0800 Geliang Tang wrote: > Use dev_to_virtio() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/s390/virtio/virtio_ccw.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, added

Re: [PATCH 0/1] virtio/s390: one fix

On Thu, 3 Dec 2015 17:23:59 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > Michael, > > here's one fix for the virtio-ccw driver. > > Patch is against master, as your git branches on mst/vhost.git seem > to be quite old. Is there some branch I can base my ow

[PATCH 0/1] virtio/s390: one fix

Michael, here's one fix for the virtio-ccw driver. Patch is against master, as your git branches on mst/vhost.git seem to be quite old. Is there some branch I can base my own branch on, or do you prefer to take patches directly anyway? Cornelia Huck (1): virtio/s390: handle error values

[PATCH 1/1] virtio/s390: handle error values in irb

indications. Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> Reviewed-by: Guenther Hutzl <hu...@linux.vnet.ibm.com> Reviewed-by: Pierre Morel <pmo...@linux.vnet.ibm.com> --- drivers/s390/virtio/virtio_ccw.c | 62 1 file changed, 37

Re: [PATCH v5 2/2] KVM: Make KVM_CAP_IRQFD dependent on KVM_CAP_IRQCHIP

On Mon, 30 Nov 2015 14:56:38 +0300 Pavel Fedin wrote: > Hello! > > > > case KVM_CAP_INTERNAL_ERROR_DATA: > > > #ifdef CONFIG_HAVE_KVM_MSI > > > case KVM_CAP_SIGNAL_MSI: > > > + /* Fallthrough */ > > > #endif > > > + case KVM_CAP_CHECK_EXTENSION_VM: > > > +

Re: [PATCH v5 2/2] KVM: Make KVM_CAP_IRQFD dependent on KVM_CAP_IRQCHIP

On Mon, 30 Nov 2015 12:40:45 +0300 Pavel Fedin wrote: > Now at least ARM is able to determine whether the machine has > virtualization support for irqchip or not at runtime. Obviously, > irqfd requires irqchip. > > Signed-off-by: Pavel Fedin > --- >

Re: [PATCH v5 2/2] KVM: Make KVM_CAP_IRQFD dependent on KVM_CAP_IRQCHIP

On Mon, 30 Nov 2015 15:41:20 +0300 Pavel Fedin wrote: > Hello! > > > > Thank you for the note, i didn't know about irqchip-specific capability > > > codes. There's the > > > same issue with PowerPC, now i > > > understand why there's no KVM_CAP_IRQCHIP for them. Because

Re: [PATCH] vhost: move is_le setup to the backend

net.c |6 ++ > drivers/vhost/scsi.c |3 +++ > drivers/vhost/test.c |2 ++ > drivers/vhost/vhost.c | 12 +++----- > drivers/vhost/vhost.h |1 + > 5 files changed, 19 insertions(+), 5 deletions(-) Makes sense. Reviewed-by: Cornelia Huck <

Re: [PATCH/RFC 0/4] dma ops and virtio

On Thu, 5 Nov 2015 09:11:06 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > On Wed, 4 Nov 2015 10:14:11 -0800 > Andy Lutomirski <l...@amacapital.net> wrote: > > > On Wed, Nov 4, 2015 at 9:52 AM, Cornelia Huck <cornelia.h...@de.ibm.com> > > wrote:

Re: [GIT PULL v4 3/3] s390/dma: Allow per device dma ops

-- > arch/s390/pci/pci.c | 1 + > arch/s390/pci/pci_dma.c | 4 ++-- > 5 files changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the

Re: [PATCH/RFC 0/4] dma ops and virtio

On Wed, 4 Nov 2015 10:14:11 -0800 Andy Lutomirski <l...@amacapital.net> wrote: > On Wed, Nov 4, 2015 at 9:52 AM, Cornelia Huck <cornelia.h...@de.ibm.com> > wrote: > > On Wed, 4 Nov 2015 15:29:23 +0100 > > Cornelia Huck <cornelia.h...@de.ibm.com> wrote: &g

Re: [PATCH/RFC 0/4] dma ops and virtio

On Tue, 3 Nov 2015 10:45:12 -0800 Andy Lutomirski <l...@amacapital.net> wrote: > On Tue, Nov 3, 2015 at 9:59 AM, Cornelia Huck <cornelia.h...@de.ibm.com> > wrote: > > It's just failing very early in the setup phase. As it works for me > > with a kvm setup, I'm s

Re: [PATCH/RFC 0/4] dma ops and virtio

On Wed, 4 Nov 2015 15:29:23 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > I'm currently suspecting some endianness issues, probably with the ecw > accesses, which is why I'd be interested in your trace information (as > I currently don't have a LE test setup at hand.) I

Re: [PATCH 3/3] s390/dma: Allow per device dma ops

On Tue, 3 Nov 2015 12:54:39 +0100 Christian Borntraeger wrote: > As virtio-ccw now has dma ops, we can no longer default to the PCI ones. > Make use of dev_archdata to keep the dma_ops per device. The pci devices > now use that to override the default, and the default is

Re: [PATCH/RFC 0/4] dma ops and virtio

On Mon, 2 Nov 2015 12:23:25 -0800 Andy Lutomirski wrote: > No change. I'm stumped :( Here's what I see: (...) > CH DBG: css_interpret_ccw: cmd_code=e4 > CH DBG: css_interpret_ccw: ret=0 sense id -> works (...) > CH DBG: css_interpret_ccw: cmd_code=3 > CH DBG:

Re: [PATCH/RFC 0/4] dma ops and virtio

On Fri, 30 Oct 2015 13:33:07 -0700 Andy Lutomirski <l...@amacapital.net> wrote: > On Fri, Oct 30, 2015 at 1:25 AM, Cornelia Huck <cornelia.h...@de.ibm.com> > wrote: > > On Thu, 29 Oct 2015 15:50:38 -0700 > > Andy Lutomirski <l...@amacapital.net> wrote: > &g

Re: [PATCH/RFC 0/4] dma ops and virtio

On Thu, 29 Oct 2015 15:50:38 -0700 Andy Lutomirski wrote: > Progress! After getting that sort-of-working, I figured out what was > wrong with my earlier command, and I got that working, too. Now I > get: > > qemu-system-s390x -fsdev >

Re: [PATCH v4 2/6] virtio_ring: Support DMA APIs

On Thu, 29 Oct 2015 18:09:47 -0700 Andy Lutomirski wrote: > virtio_ring currently sends the device (usually a hypervisor) > physical addresses of its I/O buffers. This is okay when DMA > addresses and physical addresses are the same thing, but this isn't > always the case. For

Re: [PATCH 4/4] s390/virtio: use noop dma ops

On Fri, 30 Oct 2015 13:26:09 +0100 Christian Borntraeger wrote: > I am currently reworking this to > > static inline struct dma_map_ops *get_dma_ops(struct device *dev) > { > if (dev && dev->archdata.dma_ops) > return dev->archdata.dma_ops; >

Re: [PATCH 4/4] s390/virtio: use noop dma ops

On Tue, 27 Oct 2015 23:48:51 +0100 Christian Borntraeger wrote: > With all infrastructure in place, lets provide dma_ops for virtio > devices on s390. > > Signed-off-by: Christian Borntraeger > --- > drivers/s390/virtio/kvm_virtio.c | 2 ++ >

Re: [PATCH 4/4] s390/virtio: use noop dma ops

On Wed, 28 Oct 2015 09:43:34 +0900 Joerg Roedel wrote: > On Tue, Oct 27, 2015 at 11:48:51PM +0100, Christian Borntraeger wrote: > > @@ -1093,6 +1094,7 @@ static void virtio_ccw_auto_online(void *data, > > async_cookie_t cookie) > > struct ccw_device *cdev = data; > >

Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)

_vcpu *vcpu) > { > - atomic_or(PROG_REQUEST, >arch.sie_block->prog20); > + atomic_andnot(PROG_REQUEST, >arch.sie_block->prog20); > } > > /* Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> -- To unsubscribe from this list: send the line "uns

Re: [PATCH V6 1/6] kvm: don't try to register to KVM_FAST_MMIO_BUS for non mmio eventfd

apov <g...@kernel.org> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> > --- > virt/kvm/eventfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [PATCH V6 3/6] kvm: fix double free for fast mmio eventfd

89 10 48 b8 00 > 01 10 00 00 > RIP [] ioeventfd_release+0x28/0x60 [kvm] > RSP > > Cc: sta...@vger.kernel.org > Cc: Gleb Natapov <g...@kernel.org> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> > --- &g

Re: [PATCH V6 2/6] kvm: factor out core eventfd assign/deassign logic

org> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> > --- > virt/kvm/eventfd.c | 85 > -- > 1 file changed, 50 insertions(+), 35 deletions(-) Reviewed-by: Corneli

Re: [PATCH V6 4/6] kvm: fix zero length mmio searching

> Signed-off-by: Jason Wang <jasow...@redhat.com> > --- > virt/kvm/kvm_main.c | 19 +-- > 1 file changed, 17 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe k

Re: [PATCH V6 6/6] kvm: add fast mmio capabilitiy

On Tue, 15 Sep 2015 17:07:55 +0200 Paolo Bonzini wrote: > On 15/09/2015 08:41, Jason Wang wrote: > > +With KVM_CAP_FAST_MMIO, a zero length mmio eventfd is allowed for > > +kernel to ignore the length of guest write and get a possible faster > > +response. Note the speedup

Re: [PATCH V6 6/6] kvm: add fast mmio capabilitiy

On Tue, 15 Sep 2015 18:29:49 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote: > On 15/09/2015 18:13, Cornelia Huck wrote: > > On Tue, 15 Sep 2015 17:07:55 +0200 > > Paolo Bonzini <pbonz...@redhat.com> wrote: > > > >> On 15/09/2015 08:41, Jason Wang wr

Re: [PATCH V4 3/4] kvm: fix zero length mmio searching

On Fri, 11 Sep 2015 10:26:41 +0200 Paolo Bonzini wrote: > On 11/09/2015 05:17, Jason Wang wrote: > > + int len = r2->len ? r1->len : 0; > > + > > if (r1->addr < r2->addr) > > return -1; > > - if (r1->addr + r1->len > r2->addr + r2->len) > > + if

Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic

On Fri, 11 Sep 2015 11:17:34 +0800 Jason Wang wrote: > This patch factors out core eventfd assign/deassign logic and leave > the argument checking and bus index selection to callers. > > Cc: Gleb Natapov > Cc: Paolo Bonzini >

Re: [PATCH V4 2/4] kvm: fix double free for fast mmio eventfd

On Fri, 11 Sep 2015 11:17:35 +0800 Jason Wang wrote: > We register wildcard mmio eventfd on two buses, one for KVM_MMIO_BUS > and another is KVM_FAST_MMIO_BUS but with a single iodev > instance. This will lead an issue: kvm_io_bus_destroy() knows nothing > about the devices

Re: [PATCH V4 2/4] kvm: fix double free for fast mmio eventfd

On Fri, 11 Sep 2015 17:25:45 +0800 Jason Wang <jasow...@redhat.com> wrote: > On 09/11/2015 03:46 PM, Cornelia Huck wrote: > > On Fri, 11 Sep 2015 11:17:35 +0800 > > Jason Wang <jasow...@redhat.com> wrote: > >> + > >> + /* When length i

[PATCH 0/1] virtio/s390: one bugfix

Michael, here's a bugfix for the virtio-ccw driver. Question: How would you like to get patches? This one is formatted against your current linux-next branch; I can prepare a branch for you to pull from as well. Pierre Morel (1): virtio/s390: handle failures of READ_VQ_CONF ccw

[PATCH 1/1] virtio/s390: handle failures of READ_VQ_CONF ccw

y fail. Signed-off-by: Pierre Morel <pmo...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- drivers/s390/virtio/virtio_ccw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/v

Re: [PATCH V2 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

my (minor) style suggestions, consider this patch Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

+-- virt/kvm/kvm_main.c | 16 ++-- 2 files changed, 23 insertions(+), 24 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

On Mon, 24 Aug 2015 11:29:29 +0800 Jason Wang jasow...@redhat.com wrote: On 08/21/2015 05:29 PM, Cornelia Huck wrote: On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang jasow...@redhat.com wrote: @@ -850,9 +845,15 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct kvm_ioeventfd *args

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang jasow...@redhat.com wrote: diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index 9ff4193..834a409 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -838,11 +838,6 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct kvm_ioeventfd

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

...@redhat.com --- arch/arm/kvm/Kconfig | 1 + arch/arm64/kvm/Kconfig | 1 + arch/powerpc/kvm/Kconfig | 1 + drivers/net/Kconfig | 1 + drivers/vhost/Kconfig| 1 + virt/kvm/Kconfig | 3 +++ 6 files changed, 8 insertions(+) Acked-by: Cornelia Huck cornelia.h

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

...@redhat.com --- arch/arm/kvm/Kconfig | 1 + arch/arm64/kvm/Kconfig | 1 + arch/powerpc/kvm/Kconfig | 1 + drivers/net/Kconfig | 1 + drivers/vhost/Kconfig| 1 + virt/kvm/Kconfig | 3 +++ 6 files changed, 8 insertions(+) Acked-by: Cornelia Huck cornelia.h

[PATCH] virtio/s390: rename drivers/s390/kvm - drivers/s390/virtio

This more accurately reflects what these drivers actually do. Suggested-by: Paolo Bonzini pbonz...@redhat.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- MAINTAINERS | 2 +- drivers/s390/Makefile

Re: [PATCH] MAINTAINERS: separate section for s390 virtio drivers

On Wed, 1 Jul 2015 17:17:41 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 01/07/2015 17:15, Cornelia Huck wrote: The s390-specific virtio drivers have probably more to do with virtio than with kvm today; let's move them out into a separate section to reflect this and to be able

[PATCH] MAINTAINERS: separate section for s390 virtio drivers

The s390-specific virtio drivers have probably more to do with virtio than with kvm today; let's move them out into a separate section to reflect this and to be able to add relevant mailing lists. CC: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Cornelia Huck cornelia.h

Re: [PATCH v6 4/8] vringh: introduce vringh_is_little_endian() helper

On Fri, 24 Apr 2015 14:24:58 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- include/linux/vringh.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [PATCH v6 3/8] macvtap: introduce macvtap_is_little_endian() helper

On Fri, 24 Apr 2015 14:24:48 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- drivers/net/macvtap.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe

Re: [PATCH v6 7/8] vhost: cross-endian support for legacy devices

+++- drivers/vhost/vhost.h | 11 +- include/uapi/linux/vhost.h | 14 +++ 4 files changed, 122 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH v6 6/8] virtio: add explicit big-endian support to memory accessors

/vhost/vhost.h|3 ++- include/linux/virtio_byteorder.h | 24 ++-- include/linux/virtio_config.h|3 ++- include/linux/vringh.h |3 ++- 6 files changed, 24 insertions(+), 15 deletions(-) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [PATCH v6 5/8] vhost: introduce vhost_is_little_endian() helper

On Fri, 24 Apr 2015 14:25:12 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- drivers/vhost/vhost.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [PATCH v6 1/8] virtio: introduce virtio_is_little_endian() helper

*vdev) +{ + return virtio_has_feature(vdev, VIRTIO_F_VERSION_1); +} + While this reads a bit funny in this patch, it will end up correctly at the end of the series, so Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH v6 2/8] tun: add tun_is_little_endian() helper

On Fri, 24 Apr 2015 14:24:38 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- drivers/net/tun.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

On Mon, 27 Apr 2015 13:07:58 +0200 Michael Mueller m...@linux.vnet.ibm.com wrote: On Mon, 27 Apr 2015 12:52:54 +0200 Christian Borntraeger borntrae...@de.ibm.com wrote: Am 27.04.2015 um 11:43 schrieb Michael Mueller: On Mon, 27 Apr 2015 10:15:47 +0200 Christian Borntraeger

Re: [PATCH v5 6/8] virtio: add explicit big-endian support to memory accessors

On Thu, 23 Apr 2015 21:27:19 +0200 Thomas Huth th...@redhat.com wrote: On Thu, 23 Apr 2015 17:29:06 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: The current memory accessors logic is: - little endian if little_endian - native endian (i.e. no byteswap) if !little_endian If we

Re: [PATCH v5 7/8] vhost: cross-endian support for legacy devices

On Fri, 24 Apr 2015 10:06:19 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Fri, 24 Apr 2015 09:19:26 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 23 Apr 2015 17:29:42 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: diff --git a/include/uapi/linux/vhost.h b/include

Re: [PATCH v5 7/8] vhost: cross-endian support for legacy devices

On Thu, 23 Apr 2015 17:29:42 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: This patch brings cross-endian support to vhost when used to implement legacy virtio devices. Since it is a relatively rare situation, the feature availability is controlled by a kernel config option (not set by

Re: [PATCH v4 7/8] vhost: feature to set the vring endianness

On Tue, 14 Apr 2015 17:13:52 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Tue, 14 Apr 2015 16:20:23 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 10 Apr 2015 12:19:16 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: +#ifdef CONFIG_VHOST_SET_ENDIAN_LEGACY

Re: [PATCH v4 7/8] vhost: feature to set the vring endianness

On Fri, 10 Apr 2015 12:19:16 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: This patch brings cross-endian support to vhost when used to implement legacy virtio devices. Since it is a relatively rare situation, the feature availability is controlled by a kernel config option (not set by

Re: [PATCH v3 7/7] vhost: feature to set the vring endianness

On Tue, 07 Apr 2015 14:19:31 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: This patch brings cross-endian support to vhost when used to implement legacy virtio devices. Since it is a relatively rare situation, the feature availability is controlled by a kernel config option (not set by

Re: [PATCH/RFC 6/9] KVM: s390: Guest's memory access functions get access registers

, 93 insertions(+), 58 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC 7/9] KVM: s390: Optimize paths where get_vcpu_asce() is invoked

borntrae...@de.ibm.com --- arch/s390/kvm/gaccess.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord

Re: [PATCH/RFC 4/9] KVM: s390: Add MEMOP ioctls for reading/writing guest memory

On Mon, 16 Mar 2015 09:51:40 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: From: Thomas Huth th...@linux.vnet.ibm.com On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading and writing logical memory to provide

Re: [PATCH/RFC 2/9] KVM: s390: cleanup jump lables in kvm_arch_init_vm

...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH/RFC 9/9] KVM: s390: Create ioctl for Getting/Setting guest storage keys

On Mon, 16 Mar 2015 09:51:45 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: From: Jason J. Herne jjhe...@linux.vnet.ibm.com Provide the KVM_S390_GET_SKEYS and KVM_S390_SET_SKEYS ioctl which can be used to get/set guest storage keys. This functionality is needed for live migration

Re: [PATCH/RFC 3/9] KVM: s390: Fix low-address protection for real addresses

...@de.ibm.com --- arch/s390/kvm/gaccess.c | 11 ++- arch/s390/kvm/gaccess.h | 2 +- arch/s390/kvm/priv.c| 4 ++-- 3 files changed, 9 insertions(+), 8 deletions(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm

Re: virtio fixes pull for 4.0?

On Mon, 09 Mar 2015 17:43:19 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Michael S. Tsirkin m...@redhat.com writes: virtio-balloon: do not call blocking ops when !TASK_RUNNING Rusty, it seems you prefer a different fix for this issue, while Cornelia prefers mine. Maybe both me

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Mon, 2 Mar 2015 21:44:10 +0100 Michael S. Tsirkin m...@redhat.com wrote: Normally, hotunplug requires guest cooperation. IOW unplug request should send guest interrupt, then block until guest confirms it's not using the device anymore. virtio pci already handles that fine,

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Wed, 4 Mar 2015 11:25:56 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 04, 2015 at 04:44:54PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Mon, 2 Mar 2015 12:46:57 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 02, 2015 at 12:31:06PM +0100, Cornelia Huck wrote: On Mon, 2 Mar 2015 12:13:58 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote

Re: Qemu and virtio 1.0

On Mon, 2 Mar 2015 12:43:43 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Feb 25, 2015 at 02:50:22PM +1030, Rusty Russell wrote: OK, I am trying to experiment with virtio 1.0 support using the latest kernel and MST's qemu tree:

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Mon, 2 Mar 2015 13:19:43 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 02, 2015 at 01:11:02PM +0100, Cornelia Huck wrote: On Mon, 2 Mar 2015 12:46:57 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 02, 2015 at 12:31:06PM +0100, Cornelia Huck wrote

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Mon, 2 Mar 2015 12:13:58 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com writes: On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Thomas Huth

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Thomas Huth th...@linux.vnet.ibm.com writes: Hi all, with the recent kernel 3.19, I get a kernel warning when I start my KVM guest on s390 with virtio balloon enabled: The deeper problem is that

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Thu, 26 Feb 2015 09:45:29 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Feb 26, 2015 at 11:50:42AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com writes: Hi all, with the recent kernel 3.19, I get a kernel warning when I start my KVM guest on s390

Re: [PATCH] virtio-balloon: do not call blocking ops when !TASK_RUNNING

On Wed, 25 Feb 2015 15:14:36 +0100 Michael S. Tsirkin m...@redhat.com wrote: virtio balloon has this code: wait_event_interruptible(vb-config_change, (diff = towards_target(vb)) != 0 || vb-need_stats_update

Re: [PATCH v2] virtio-balloon: do not call blocking ops when !TASK_RUNNING

...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- changes from v1: remove wait_event_interruptible noticed by Cornelia Huck cornelia.h...@de.ibm.com drivers/virtio/virtio_balloon.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) I was able

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

On Wed, 25 Feb 2015 11:13:18 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: Hi all, with the recent kernel 3.19, I get a kernel warning when I start my KVM guest on s390 with virtio balloon enabled: [0.839687] do not call blocking ops when !TASK_RUNNING; state=1 set at

Re: Qemu and virtio 1.0

On Wed, 25 Feb 2015 14:50:22 +1030 Rusty Russell ru...@rustcorp.com.au wrote: OK, I am trying to experiment with virtio 1.0 support using the latest kernel and MST's qemu tree: https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/?h=virtio-1.0 The first issue is that the device

Re: [PATCH] KVM: s390: Add MEMOP ioctls for reading/writing guest memory

On Mon, 16 Feb 2015 13:16:41 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading and writing logical memory to provide this feature for userspace, too. Signed-off-by: Thomas

Re: [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

On Wed, 04 Feb 2015 09:26:11 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: the classic channel I/O does set the storage key change/reference and also triggers errors in the storage key protection value mismatches. Just a bit of background for the benefit of innocent bystanders:

Re: [Qemu-devel] [PATCH RFC v5 05/19] virtio: support more feature bits

On Tue, 2 Dec 2014 14:00:13 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h index 070006c..23d713b 100644 --- a/include/hw/qdev-properties.h +++ b/include/hw/qdev-properties.h @@ -51,6 +51,17 @@ extern

Re: [Qemu-devel] [PATCH RFC v5 18/19] virtio: support revision-specific features

On Tue, 2 Dec 2014 14:00:26 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Devices may support different sets of feature bits depending on which revision they're operating at. Let's give the transport a way to re-query the device about its features when the revision has been changed

Re: [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0

On Tue, 9 Dec 2014 15:46:46 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote: virtio-ccw should now have everything in place to operate virtio 1.0 devices, so let's enable revision 1. Signed-off-by: Cornelia Huck cornelia.h

Re: [PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call

On Thu, 4 Dec 2014 18:20:05 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Dec 02, 2014 at 02:00:18PM +0100, Cornelia Huck wrote: From: Thomas Huth th...@linux.vnet.ibm.com Handle the virtio-ccw revision according to what the guest sets. When revision 1 is selected, we have

Re: [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Tue, 2 Dec 2014 21:03:45 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) { +/* + * For virtio-1 devices, the number of buffers may only

Re: [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, 3 Dec 2014 10:27:36 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 2 Dec 2014 21:03:45 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: void virtio_queue_set_num(VirtIODevice *vdev, int n, int num

Re: [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, 3 Dec 2014 12:52:51 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 43b7e02..1e2a720 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio

Re: [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, 3 Dec 2014 13:19:17 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: On Wed, 3 Dec 2014 12:52:51 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote

[PATCH RFC v5 00/19] qemu: towards virtio-1 host support

instead of 32 bit arrays - infrastructure to allow devices to offer different sets of feature bits for legacy and standard devices - several fixes (mainly regarding, you guessed it, feature bits) Cornelia Huck (16): virtio: cull virtio_bus_set_vdev_features virtio: feature bit manipulation

[PATCH RFC v5 16/19] virtio-net: support longer header

virtio-1 devices always use num_buffers in the header, even if mergeable rx buffers have not been negotiated. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/net/virtio-net.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/net/virtio

[PATCH RFC v5 17/19] virtio-net: enable virtio 1.0

. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/net/virtio-net.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 7ee2bd6..b5dd356 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -473,6 +473,7 @@ static uint64_t

[PATCH RFC v5 19/19] virtio-blk: revision specific feature bits

Wire up virtio-blk to provide different feature bit sets depending on whether legacy or v1.0 has been requested. Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/block/virtio-blk.c | 19 +++ 1

[PATCH RFC v5 18/19] virtio: support revision-specific features

Devices may support different sets of feature bits depending on which revision they're operating at. Let's give the transport a way to re-query the device about its features when the revision has been changed. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/virtio-ccw.c

[PATCH RFC v5 06/19] virtio: endianness checks for virtio 1.0 devices

Add code that checks for the VERSION_1 feature bit in order to make decisions about the device's endianness. This allows us to support transitional devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/virtio/virtio.c|6 +- include/hw/virtio/virtio

[PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

For virtio-1 devices, we allow a more complex queue layout that doesn't require descriptor table and rings on a physically-contigous memory area: add virtio_queue_set_rings() to allow transports to set this up. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/virtio/virtio.c

[PATCH RFC v5 12/19] virtio: disallow late feature changes for virtio-1

For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/virtio/virtio.c | 16 ++-- include/hw/virtio/virtio.h |2

[PATCH RFC v5 09/19] s390x/css: Add a callback for when subchannel gets disabled

From: Thomas Huth th...@linux.vnet.ibm.com We need a possibility to run code when a subchannel gets disabled. This patch adds the necessary infrastructure. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/css.c | 12

[PATCH RFC v5 13/19] virtio: allow to fail setting status

virtio-1 allow setting of the FEATURES_OK status bit to fail if the negotiated feature bits are inconsistent: let's fail virtio_set_status() in that case and update virtio-ccw to post an error to the guest. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/virtio-ccw.c

[PATCH RFC v5 01/19] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1

From: Thomas Huth th...@linux.vnet.ibm.com Add the new VIRTIO_F_VERSION_1 definition to the virtio_config.h linux header. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- linux-headers/linux/virtio_config.h |3 +++ 1 file changed

[PATCH RFC v5 15/19] virtio-net: no writeable mac for virtio-1

Devices operating as virtio 1.0 may not allow writes to the mac address in config space. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/net/virtio-net.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index d6d1b98..ebbea60 100644

[PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call

the next user of the device does not negotiate the revision 1 anymore (e.g. the boot firmware uses revision 1, but the operating system only uses the legacy mode). Note that revisions 0 are still disabled. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h

[PATCH RFC v5 11/19] s390x/virtio-ccw: support virtio-1 set_vq format

Support the new CCW_CMD_SET_VQ format for virtio-1 devices. While we're at it, refactor the code a bit and enforce big endian fields (which had always been required, even for legacy). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw

  1   2   3   4   5   6   7   >