Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Avi Kivity
On 10/10/2010 05:46 PM, Gleb Natapov wrote: We should log both errno and exit_reason. If we want to be clever, we can display strerror(errno) if it's nonzero, and exit_reason otherwise (easy to do in a trace-cmd plugin). For starters we should remove KVM_EXIT_INTR exit reason. Looking

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Gleb Natapov
On Thu, Oct 14, 2010 at 12:27:15PM +0200, Avi Kivity wrote: On 10/10/2010 05:46 PM, Gleb Natapov wrote: We should log both errno and exit_reason. If we want to be clever, we can display strerror(errno) if it's nonzero, and exit_reason otherwise (easy to do in a trace-cmd plugin).

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Avi Kivity
On 10/14/2010 12:29 PM, Gleb Natapov wrote: On Thu, Oct 14, 2010 at 12:27:15PM +0200, Avi Kivity wrote: On 10/10/2010 05:46 PM, Gleb Natapov wrote: We should log both errno and exit_reason. If we want to be clever, we can display strerror(errno) if it's nonzero, and exit_reason

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Gleb Natapov
On Thu, Oct 14, 2010 at 01:11:20PM +0200, Avi Kivity wrote: On 10/14/2010 12:29 PM, Gleb Natapov wrote: On Thu, Oct 14, 2010 at 12:27:15PM +0200, Avi Kivity wrote: On 10/10/2010 05:46 PM, Gleb Natapov wrote: We should log both errno and exit_reason. If we want to be clever,

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Avi Kivity
On 10/14/2010 01:28 PM, Gleb Natapov wrote: On Thu, Oct 14, 2010 at 01:11:20PM +0200, Avi Kivity wrote: On 10/14/2010 12:29 PM, Gleb Natapov wrote: On Thu, Oct 14, 2010 at 12:27:15PM +0200, Avi Kivity wrote: On 10/10/2010 05:46 PM, Gleb Natapov wrote: We should log

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Gleb Natapov
On Thu, Oct 14, 2010 at 01:32:14PM +0200, Avi Kivity wrote: On 10/14/2010 01:28 PM, Gleb Natapov wrote: On Thu, Oct 14, 2010 at 01:11:20PM +0200, Avi Kivity wrote: On 10/14/2010 12:29 PM, Gleb Natapov wrote: On Thu, Oct 14, 2010 at 12:27:15PM +0200, Avi Kivity wrote: On 10/10/2010

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Gleb Natapov
On Thu, Oct 14, 2010 at 01:43:52PM +0200, Avi Kivity wrote: On 10/14/2010 01:41 PM, Gleb Natapov wrote: So what do you propose? I see no issue with my original patch. Record both errno and exit_reason. While they're never both valid at the same time, they're both

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Avi Kivity
On 10/14/2010 01:47 PM, Gleb Natapov wrote: You can always filter excess information away. If you're looking for exits to userspace (a major performance issue) then you want to see both normal exits and signal exits. How do I do it via /debug file system? Now I just echo name of the

Re: [PATCH] trace exit to userspace event

2010-10-14 Thread Avi Kivity
On 10/14/2010 02:09 PM, Avi Kivity wrote: On 10/14/2010 01:47 PM, Gleb Natapov wrote: You can always filter excess information away. If you're looking for exits to userspace (a major performance issue) then you want to see both normal exits and signal exits. How do I do it via /debug

Re: [PATCH] trace exit to userspace event

2010-10-10 Thread Avi Kivity
On 10/08/2010 06:44 PM, Gleb Natapov wrote: On Thu, Oct 07, 2010 at 09:49:17PM -0300, Marcelo Tosatti wrote: On Thu, Oct 07, 2010 at 07:56:55PM +0200, Gleb Natapov wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b8499f5..8800713 100644 ---

Re: [PATCH] trace exit to userspace event

2010-10-10 Thread Gleb Natapov
On Sun, Oct 10, 2010 at 10:45:45AM +0200, Avi Kivity wrote: On 10/08/2010 06:44 PM, Gleb Natapov wrote: On Thu, Oct 07, 2010 at 09:49:17PM -0300, Marcelo Tosatti wrote: On Thu, Oct 07, 2010 at 07:56:55PM +0200, Gleb Natapov wrote: diff --git a/virt/kvm/kvm_main.c

Re: [PATCH] trace exit to userspace event

2010-10-08 Thread Marcelo Tosatti
On Thu, Oct 07, 2010 at 07:56:55PM +0200, Gleb Natapov wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b8499f5..8800713 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1458,6 +1458,8 @@ static long kvm_vcpu_ioctl(struct file *filp, if

Re: [PATCH] trace exit to userspace event

2010-10-08 Thread Gleb Natapov
On Thu, Oct 07, 2010 at 09:49:17PM -0300, Marcelo Tosatti wrote: On Thu, Oct 07, 2010 at 07:56:55PM +0200, Gleb Natapov wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b8499f5..8800713 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1458,6

Re: [PATCH] trace exit to userspace event

2010-10-07 Thread Marcelo Tosatti
On Tue, Oct 05, 2010 at 03:14:32PM +0200, Gleb Natapov wrote: Add tracepoint for userspace exit. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h index 6dd3a51..fb44da0 100644 --- a/include/trace/events/kvm.h +++

Re: [PATCH] trace exit to userspace event

2010-10-07 Thread Gleb Natapov
On Thu, Oct 07, 2010 at 01:18:39PM -0300, Marcelo Tosatti wrote: On Tue, Oct 05, 2010 at 03:14:32PM +0200, Gleb Natapov wrote: Add tracepoint for userspace exit. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h index

[PATCH] trace exit to userspace event

2010-10-05 Thread Gleb Natapov
Add tracepoint for userspace exit. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h index 6dd3a51..fb44da0 100644 --- a/include/trace/events/kvm.h +++ b/include/trace/events/kvm.h @@ -6,6 +6,31 @@ #undef TRACE_SYSTEM #define