Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-20 Thread Ingo Molnar
* Pekka Enberg penb...@kernel.org wrote: Sorry for the bikeshedding but wouldn't it be better to follow Git's lead and have something like kvm config MyInstance-1 --set debug.io.delay.ms 100 and kvm config MyInstance-1 --list Yeah, agreed - 'kvm config' is intuitive. I tried to

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Pekka Enberg
On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within virtio-blk. This feature allows to verify and debug the threading within virtio-blk. Signed-off-by: Sasha Levin

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Sasha Levin
On Tue, 2011-04-19 at 19:52 +0300, Pekka Enberg wrote: On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within virtio-blk. This feature allows to verify and debug the

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Ingo Molnar
* Sasha Levin levinsasha...@gmail.com wrote: On Tue, 2011-04-19 at 19:52 +0300, Pekka Enberg wrote: On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Asias He
On 04/20/2011 01:11 AM, Ingo Molnar wrote: * Sasha Levin levinsasha...@gmail.com wrote: On Tue, 2011-04-19 at 19:52 +0300, Pekka Enberg wrote: On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Pekka Enberg
On Wed, Apr 20, 2011 at 2:10 AM, Asias He asias.he...@gmail.com wrote: This came up during our testing. Ingo suggested a large delay so we could easily see the results of threading. The problem we encountered was that having a delay right from the beginning will make the guest kernel take a

[PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-18 Thread Sasha Levin
Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within virtio-blk. This feature allows to verify and debug the threading within virtio-blk. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/kvm/virtio-blk.h |6 +-