Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > Hi Avi, > > Andrew, please see the comments on the need for a atomic get_user_pages() > below. > > On Sat, Dec 22, 2007 at 09:42:27PM +0200, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> In preparation for a mmu spinlock, avoid schedules in mmu_set_spte() >>

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-22 Thread Marcelo Tosatti
Hi Avi, Andrew, please see the comments on the need for a atomic get_user_pages() below. On Sat, Dec 22, 2007 at 09:42:27PM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > > In preparation for a mmu spinlock, avoid schedules in mmu_set_spte() > > by using follow_page() instead of get_user_pa

Re: [kvm-devel] [PATCH] kvm/qemu: Fix ia64 build broken.

2007-12-22 Thread Avi Kivity
Amit Shah wrote: > On Friday 21 December 2007 20:28:23 Zhang, Xiantao wrote: > >> Hi, Avi >> Due to last merge with Qemu upstream, some interfaces are changed, and >> leads to build fail >> , this patch fixed them. >> Xiantao >> > > I've not checked the patch yet; but a curiosity question:

Re: [kvm-devel] external module sched_in event

2007-12-22 Thread Avi Kivity
Izik Eidus wrote: >> This fixes my longstanding KVM instability and "-smp 2" now works >> flawlessy with svm too! -smp 2 -snapshot crashes in qemu userland but >> that's not kernel related, must be some thread mutex lock recursion or >> lock inversion in the qcow cow code. Removing -snapshot make -

Re: [kvm-devel] [PATCH] external module: remove tmp directory once done with sync

2007-12-22 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > This patch complements 684c6426c5d58f01f45cd45420df96c837d0feb4 by > deleting the tmp directory once the merge is completed so that it > doesn't get included by mistake in the release package > Applied, thanks. -- Do not meddle in the internals of kernels,

Re: [kvm-devel] mailman setup for kvm-devel (was Re: external module sched_in event)

2007-12-22 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > On Fri, Dec 21, 2007 at 07:22:57PM +0100, Andrea Arcangeli wrote: > >> On Fri, Dec 21, 2007 at 07:52:52PM +0200, Izik Eidus wrote: >> >>> oh, it was sent to the list, dont trust (in case you did) the source forge >>> site for the mails >>> >> But

Re: [kvm-devel] [PATCH] kvm/qemu: Fix ia64 build broken.

2007-12-22 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi, Avi > Due to last merge with Qemu upstream, some interfaces are changed, and > leads to build fail > , this patch fixed them. > Xiantao > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 22:47:52 +0800 > Subject: [PATCH] kvm: qemu : Fix ia64 build on late

Re: [kvm-devel] Oops on 2.6.23.11 with KVM 57

2007-12-22 Thread Avi Kivity
Guido Guenther wrote: > Hi, > I got the Oops below on an Dual CPU Dual-Core AMD Opteron(tm) Processor > 2220 running a 32bit kernel. Kernel is 2.6.23.11, kvm version 57. > Doesn't happen all the time but usually right at VM startup. Seems to be > easier to trigger when starting up several VMs in ro

Re: [kvm-devel] [PATCH 0/9] qemu: missing definitions from qemu-cvs merge

2007-12-22 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch series fixes compilation warnings from kvm 57 triggered > by 25a2e04e5689af63d104de2dea755f30bf643afd : > > PATCH 1/9 : fix definition for vmchannel_init in qemu/vl.c > PATCH 2/9 : fix definition for migrate_incoming in qemu/vl.c > PATCH

Re: [kvm-devel] [patch 0/5] KVM shadow scalability enhancements

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > The following patchset increases KVM shadow scalability by allowing concurrent > guest walking, allocation and instruction emulation. > Thanks; the split patchset it _much_ easier to review, and hopefully to bisect in case the review misses something. I believe we can

Re: [kvm-devel] [patch 4/5] KVM: export follow_page()

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > follow_page() is required by KVM to find the struct page which maps > to a given address in spinlock protected code. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> > > Index: kvm.quilt/mm/memory.c > ===

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > In preparation for a mmu spinlock, avoid schedules in mmu_set_spte() > by using follow_page() instead of get_user_pages(). > > The fault handling work by get_user_pages() now happens outside the lock. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> > > Index: kvm.qui

Re: [kvm-devel] external module sched_in event

2007-12-22 Thread Avi Kivity
Andrea Arcangeli wrote: [snip] > So in short with the below fix applied, after a write_tsc(0,0), the > UP guest never return any error anymore. Previously it would return > frequent errors because sched_in wasn't properly invoked by svm.c and > it would crash at boot every single time after a writ

[kvm-devel] [PATCH] external module: remove tmp directory once done with sync

2007-12-22 Thread Carlo Marcelo Arenas Belon
This patch complements 684c6426c5d58f01f45cd45420df96c837d0feb4 by deleting the tmp directory once the merge is completed so that it doesn't get included by mistake in the release package Signed-off-by: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> --- kernel/Makefile |1 + 1 files changed,