Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Avi Kivity wrote: Exactly. But it is better to be explicit about it and pass the page directly like you did before. I hate to make you go back-and-fourth, but I did not understand the issue completely before. btw, the call to gfn_to_page() can happen in page_fault() instead of walk_addr();

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Avi Kivity wrote: Avi Kivity wrote: Exactly. But it is better to be explicit about it and pass the page directly like you did before. I hate to make you go back-and-fourth, but I did not understand the issue completely before. btw, the call to gfn_to_page() can happen in

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Andrew Morton wrote: On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Avi Kivity wrote: Avi Kivity wrote: Exactly. But it is better to be explicit about it and pass the page directly like you did before. I hate to make you go back-and-fourth,

Re: [kvm-devel] [Virtio-for-kvm] [PATCH 0/7] userspace virtio

2007-12-23 Thread Avi Kivity
Dor Laor wrote: This patchset updates kvm repository with Anthony's virtio implementation along with rx performance improvements and guest reset handling. The original code was sent to qemu devel list 2 weeks ago. It contains support for network block devices. Using the performance

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Andrew Morton
On Sun, 23 Dec 2007 12:35:30 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Avi Kivity wrote: Avi Kivity wrote: Exactly. But it is better to be explicit about it and pass

Re: [kvm-devel] [Virtio-for-kvm] [PATCH 7/7] userspace virtio

2007-12-23 Thread Avi Kivity
Dor Laor wrote: From f244bcad756c4f761627557bb7f315b1d8f22fb2 Mon Sep 17 00:00:00 2001 From: Dor Laor [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 13:26:30 +0200 Subject: [PATCH] [VIRTIO-NET] Rx performance improvement The current performance are not good enough, the problem lies in qemu tap

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Andrew Morton wrote: On Sun, 23 Dec 2007 12:35:30 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Avi Kivity wrote: Avi Kivity wrote: Exactly.

[kvm-devel] [PATCH 01/50] KVM: x86 emulator: Add vmmcall/vmcall to x86_emulate (v3)

2007-12-23 Thread Avi Kivity
From: Anthony Liguori [EMAIL PROTECTED] Add vmmcall/vmcall to x86_emulate. Future patch will implement functionality for these instructions. Signed-off-by: Anthony Liguori [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 23 +--

[kvm-devel] [PATCH 00/50] KVM patch queue review for 2.6.25 merge window (part I)

2007-12-23 Thread Avi Kivity
Following is the first part of the 2.6.25 merge window submission. Since there are 238 patches in the queue (and a few more expected), they'll be sent in five batches of around 50 each. - This SF.net email is sponsored by:

[kvm-devel] [PATCH 02/50] KVM: Refactor hypercall infrastructure (v3)

2007-12-23 Thread Avi Kivity
From: Anthony Liguori [EMAIL PROTECTED] This patch refactors the current hypercall infrastructure to better support live migration and SMP. It eliminates the hypercall page by trapping the UD exception that would occur if you used the wrong hypercall instruction for the underlying architecture

[kvm-devel] [PATCH 06/50] KVM: emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn()

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn(). x86_emulate_insn() is x86_emulate_memop() without the decoding part. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] ---

[kvm-devel] [PATCH 11/50] KVM: MMU: Ignore reserved bits in cr3 in non-pae mode

2007-12-23 Thread Avi Kivity
From: Ryan Harper [EMAIL PROTECTED] This patch removes the fault injected when the guest attempts to set reserved bits in cr3. X86 hardware doesn't generate a fault when setting reserved bits. The result of this patch is that vmware-server, running within a kvm guest, boots and runs memtest from

[kvm-devel] [PATCH 10/50] KVM: MMU: Make flooding detection work when guest page faults are bypassed

2007-12-23 Thread Avi Kivity
When we allow guest page faults to reach the guests directly, we lose the fault tracking which allows us to detect demand paging. So we provide an alternate mechnism by clearing the accessed bit when we set a pte, and checking it later to see if the guest actually used it. Signed-off-by: Avi

[kvm-devel] [PATCH 07/50] KVM: Call x86_decode_insn() only when needed

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] Move emulate_ctxt to kvm_vcpu to keep emulate context when we exit from kvm module. Call x86_decode_insn() only when needed. Modify x86_emulate_insn() to not modify the context if it must be re-entered. Signed-off-by: Laurent Vivier [EMAIL PROTECTED]

[kvm-devel] [PATCH 08/50] KVM: VMX: Further reduce efer reloads

2007-12-23 Thread Avi Kivity
KVM avoids reloading the efer msr when the difference between the guest and host values consist of the long mode bits (which are switched by hardware) and the NX bit (which is emulated by the KVM MMU). This patch also allows KVM to ignore SCE (syscall enable) when the guest is running in 32-bit

[kvm-devel] [PATCH 09/50] KVM: Allow not-present guest page faults to bypass kvm

2007-12-23 Thread Avi Kivity
There are two classes of page faults trapped by kvm: - host page faults, where the fault is needed to allow kvm to install the shadow pte or update the guest accessed and dirty bits - guest page faults, where the guest has faulted and kvm simply injects the fault back into the guest to

[kvm-devel] [PATCH 05/50] KVM: x86 emulator: move all decoding process to function x86_decode_insn()

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] Split the decoding process into a new function x86_decode_insn(). Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 77 +++-- 1 files

[kvm-devel] [PATCH 15/50] KVM: x86_emulator: no writeback for bt

2007-12-23 Thread Avi Kivity
From: Qing He [EMAIL PROTECTED] Signed-off-by: Qing He [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index 8b0186f..fe50317

[kvm-devel] [PATCH 17/50] KVM: x86 emulator: Any legacy prefix after a REX prefix nullifies its effect

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] This patch modifies the management of REX prefix according behavior I saw in Xen 3.1. In Xen, this modification has been introduced by Jan Beulich. http://lists.xensource.com/archives/html/xen-changelog/2007-01/msg00081.html Signed-off-by: Laurent Vivier

[kvm-devel] [PATCH 21/50] KVM: Add general accessors to read and write guest memory

2007-12-23 Thread Avi Kivity
From: Izik Eidus [EMAIL PROTECTED](none) Signed-off-by: Izik Eidus [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h |9 +++ drivers/kvm/kvm_main.c | 160 +++- drivers/kvm/vmx.c | 43 ++--- 3

[kvm-devel] [PATCH 16/50] KVM: Purify x86_decode_insn() error case management

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] The only valid case is on protected page access, other cases are errors. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm_main.c | 10 +++--- 1 files changed, 7 insertions(+), 3

[kvm-devel] [PATCH 13/50] KVM: x86 emulator: remove _eflags and use directly ctxt-eflags.

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] Remove _eflags and use directly ctxt-eflags. Caching eflags is not needed as it is restored to vcpu by kvm_main.c:emulate_instruction() from ctxt-eflags only if emulation doesn't fail. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi

[kvm-devel] [PATCH 19/50] KVM: VMX: Simplify vcpu_clear()

2007-12-23 Thread Avi Kivity
Now that smp_call_function_single() knows how to call a function on the current cpu, there's no need to check explicitly. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/vmx.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/kvm/vmx.c

[kvm-devel] [PATCH 04/50] KVM: x86 emulator: move all x86_emulate_memop() to a structure

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] Move all x86_emulate_memop() common variables between decode and execute to a structure decode_cache. This will help in later separating decode and emulate. struct decode_cache { u8 twobyte; u8 b;

[kvm-devel] [PATCH 14/50] KVM: x86 emulator: Remove no_wb, use dst.type = OP_NONE instead

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] Remove no_wb, use dst.type = OP_NONE instead, idea stollen from xen-3.1 Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 76 ++--

[kvm-devel] [PATCH 12/50] KVM: x86 emulator: split some decoding into functions for readability

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] To improve readability, move push, writeback, and grp 1a/2/3/4/5/9 emulation parts into functions. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 451

[kvm-devel] [PATCH 25/50] KVM: Remove gratuitous casts from lapic.c

2007-12-23 Thread Avi Kivity
From: Rusty Russell [EMAIL PROTECTED] Since vcpu-apic is of the correct type, there's not need to cast. Signed-off-by: Rusty Russell [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/lapic.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff

[kvm-devel] [PATCH 31/50] KVM: Move guest pte dirty bit management to the guest pagetable walker

2007-12-23 Thread Avi Kivity
This is more consistent with the accessed bit management, and makes the dirty bit available earlier for other purposes. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/mmu.c |5 + drivers/kvm/paging_tmpl.h | 31 --- 2 files changed, 13

[kvm-devel] [PATCH 23/50] KVM: Add kvm_free_lapic() to pair with kvm_create_lapic()

2007-12-23 Thread Avi Kivity
From: Rusty Russell [EMAIL PROTECTED] Instead of the asymetry of kvm_free_apic, implement kvm_free_lapic(). And guess what? I found a minor bug: we don't need to hrtimer_cancel() from kvm_main.c, because we do that in kvm_free_apic(). Also: 1) kvm_vcpu_uninit should be the reverse order from

[kvm-devel] [PATCH 24/50] KVM: Hoist kvm_create_lapic() into kvm_vcpu_init()

2007-12-23 Thread Avi Kivity
From: Rusty Russell [EMAIL PROTECTED] Move kvm_create_lapic() into kvm_vcpu_init(), rather than having svm and vmx do it. And make it return the error rather than a fairly random -ENOMEM. This also solves the problem that neither svm.c nor vmx.c actually handles the error path properly.

[kvm-devel] [PATCH 38/50] KVM: apic round robin cleanup

2007-12-23 Thread Avi Kivity
From: Qing He [EMAIL PROTECTED] If no apic is enabled in the bitmap of an interrupt delivery with delivery mode of lowest priority, a warning should be reported rather than select a fallback vcpu Signed-off-by: Qing He [EMAIL PROTECTED] Signed-off-by: Eddie (Yaozu) Dong [EMAIL PROTECTED]

[kvm-devel] [PATCH 40/50] KVM: Move apic timer interrupt backlog processing to common code

2007-12-23 Thread Avi Kivity
Beside the obvious goodness of making code more common, this prevents a livelock with the next patch which moves interrupt injection out of the critical section. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm_main.c |2 ++ drivers/kvm/svm.c |1 - drivers/kvm/vmx.c

[kvm-devel] [PATCH 29/50] KVM: MMU: Clean up MMU functions to take struct kvm when appropriate

2007-12-23 Thread Avi Kivity
From: Anthony Liguori [EMAIL PROTECTED] Some of the MMU functions take a struct kvm_vcpu even though they affect all VCPUs. This patch cleans up some of them to instead take a struct kvm. This makes things a bit more clear. The main thing that was confusing me was whether certain functions

[kvm-devel] [PATCH 36/50] KVM: MMU: When updating the dirty bit, inform the mmu about it

2007-12-23 Thread Avi Kivity
Since the mmu uses different shadow pages for dirty large pages and clean large pages, this allows the mmu to drop ptes that are now invalid. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/paging_tmpl.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[kvm-devel] [PATCH 35/50] KVM: MMU: Move dirty bit updates to a separate function

2007-12-23 Thread Avi Kivity
Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/paging_tmpl.h | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h index 4538b15..a0f84a5 100644 --- a/drivers/kvm/paging_tmpl.h +++

[kvm-devel] [PATCH 33/50] KVM: MMU: Disable write access on clean large pages

2007-12-23 Thread Avi Kivity
By forcing clean huge pages to be read-only, we have separate roles for the shadow of a clean large page and the shadow of a dirty large page. This is necessary because different ptes will be instantiated for the two cases, even for read faults. Signed-off-by: Avi Kivity [EMAIL PROTECTED] ---

[kvm-devel] [PATCH 32/50] KVM: MMU: Fix nx access bit for huge pages

2007-12-23 Thread Avi Kivity
We must set the bit before the shift, otherwise the wrong bit gets set. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/paging_tmpl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h index da36e48..e07cb2e

[kvm-devel] [PATCH 34/50] KVM: MMU: Instantiate real-mode shadows as user writable shadows

2007-12-23 Thread Avi Kivity
This is consistent with real-mode permissions. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/mmu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index e6616a6..f52604a 100644 --- a/drivers/kvm/mmu.c +++

[kvm-devel] [PATCH 41/50] KVM: Rename KVM_TLB_FLUSH to KVM_REQ_TLB_FLUSH

2007-12-23 Thread Avi Kivity
We now have a new namespace, KVM_REQ_*, for bits in vcpu-requests. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h |2 +- drivers/kvm/kvm_main.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index

[kvm-devel] [PATCH 42/50] KVM: x86 emulator: Implement emulation of instruction: inc dec

2007-12-23 Thread Avi Kivity
From: Nitin A Kamble [EMAIL PROTECTED] Instructions: inc r16/r32 (opcode 0x40-0x47) dec r16/r32 (opcode 0x48-0x4f) Signed-off-by: Nitin A Kamble [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 20 ++-- 1 files

[kvm-devel] [PATCH 39/50] KVM: Add some \n in ioapic_debug()

2007-12-23 Thread Avi Kivity
From: Laurent Vivier [EMAIL PROTECTED] Add new-line at end of debug strings. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/ioapic.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git

[kvm-devel] [PATCH 22/50] KVM: Allow dynamic allocation of the mmu shadow cache size

2007-12-23 Thread Avi Kivity
From: Izik Eidus [EMAIL PROTECTED] The user is now able to set how many mmu pages will be allocated to the guest. Signed-off-by: Izik Eidus [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h |7 ++- drivers/kvm/kvm_main.c | 47

[kvm-devel] [PATCH 20/50] KVM: Remove the usage of page-private field by rmap

2007-12-23 Thread Avi Kivity
From: Izik Eidus [EMAIL PROTECTED] When kvm uses user-allocated pages in the future for the guest, we won't be able to use page-private for rmap, since page-rmap is reserved for the filesystem. So we move the rmap base pointers to the memory slot. A side effect of this is that we need to store

[kvm-devel] [PATCH 37/50] KVM: Portability: split kvm_vcpu_ioctl

2007-12-23 Thread Avi Kivity
From: Carsten Otte [EMAIL PROTECTED] This patch splits kvm_vcpu_ioctl into archtecture independent parts, and x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. Common ioctls for all architectures are: KVM_RUN, KVM_GET/SET_(S-)REGS, KVM_TRANSLATE, KVM_INTERRUPT, KVM_DEBUG_GUEST,

[kvm-devel] [PATCH 26/50] KVM: CodingStyle cleanup

2007-12-23 Thread Avi Kivity
From: Mike Day [EMAIL PROTECTED] Signed-off-by: Mike D. Day [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h | 32 +- drivers/kvm/kvm_main.c| 58 ++ drivers/kvm/lapic.c |3 +-

Re: [kvm-devel] external module sched_in event

2007-12-23 Thread Andrea Arcangeli
On Sat, Dec 22, 2007 at 09:13:44PM +0200, Avi Kivity wrote: Unfortunately, this fails badly on Intel i386: Hmm ok there's a definitive bug that I forgot a int1 kernel-kernel switch on x86 has no special debug stack like on x86-64. This will have a better chance to work, hope I got all offsets

Re: [kvm-devel] external module sched_in event

2007-12-23 Thread Avi Kivity
Andrea Arcangeli wrote: On Sat, Dec 22, 2007 at 09:13:44PM +0200, Avi Kivity wrote: Unfortunately, this fails badly on Intel i386: Hmm ok there's a definitive bug that I forgot a int1 kernel-kernel switch on x86 has no special debug stack like on x86-64. This will have a better

Re: [kvm-devel] [PATCH 27/50] KVM: Support assigning userspace memory to the guest

2007-12-23 Thread Avi Kivity
Avi Kivity wrote: From: Izik Eidus [EMAIL PROTECTED] Instead of having the kernel allocate memory to the guest, let userspace allocate it and pass the address to the kernel. This is required for s390 support, but also enables features like memory sharing and using hugetlbfs backed memory.

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Marcelo Tosatti
On Sun, Dec 23, 2007 at 10:41:07AM +0200, Avi Kivity wrote: Avi Kivity wrote: Exactly. But it is better to be explicit about it and pass the page directly like you did before. I hate to make you go back-and-fourth, but I did not understand the issue completely before. btw, the call

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Marcelo Tosatti
On Sun, Dec 23, 2007 at 01:01:25PM +0200, Avi Kivity wrote: Andrew Morton wrote: On Sun, 23 Dec 2007 12:35:30 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Avi Kivity wrote:

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Andrew Morton
On Sun, 23 Dec 2007 15:15:25 -0500 Marcelo Tosatti [EMAIL PROTECTED] wrote: Are you guys OK with this ? Modular KVM needs walk_page_range(), and also vm_normal_page() to be used on pagewalk callback. I am. - This

Re: [kvm-devel] virtio_net and SMP guests

2007-12-23 Thread Dor Laor
Rusty Russell wrote: On Friday 14 December 2007 23:12:05 Christian Borntraeger wrote: Rusty, Anthony, Dor, I need your brain power :-) On smp guests I have seen a problem with virtio (the version in curent Avi's git) which do not occur on single processor guests: kernel BUG at

Re: [kvm-devel] virtio_net and SMP guests

2007-12-23 Thread Rusty Russell
On Monday 24 December 2007 10:19:19 Dor Laor wrote: Rusty Russell wrote: Looks good to me. The only thing is the naming.. Maybe one can find better name than [dis|en]able_cb since it is more like disable interrupts than disable_cb and enable_cb is more like run_callbacks (and enable

[kvm-devel] Find timing info between two VM exits

2007-12-23 Thread avadh patel
Hi All, I was looking into the source code of kvm and modified qemu and trying to find the time spent between two VM-exit in kvm. Is there a way to find this from user-space qemu, without modifying the kernel module or libkvm? Thanks, Avadh

[kvm-devel] [PATCH] Add support 3G memory for ia64 guests.

2007-12-23 Thread Zhang, Xiantao
From: Zhang Xiantao [EMAIL PROTECTED] Date: Mon, 24 Dec 2007 14:06:31 +0800 Subject: [PATCH] kvm: qemu/ia64: guest with 3G memory fix. This patch fix boot issue with 3G memory. Currently, set TARGET_PHYS_ADDR_SPACE_BITS to 36 bits, and safely support 64G memory for guests. Signed-off-by: Zhang

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Marcelo Tosatti wrote: On Sun, Dec 23, 2007 at 10:41:07AM +0200, Avi Kivity wrote: Avi Kivity wrote: Exactly. But it is better to be explicit about it and pass the page directly like you did before. I hate to make you go back-and-fourth, but I did not understand the issue

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Marcelo Tosatti wrote: It can acquire the pagetablelock in the callback handler. But then, vm_normal_page() must also be exported. Are you guys OK with this ? Seems to me that requires fairly detailed mucking in mm details, just to get at a page. I believe that a new

Re: [kvm-devel] Find timing info between two VM exits

2007-12-23 Thread Avi Kivity
avadh patel wrote: Hi All, I was looking into the source code of kvm and modified qemu and trying to find the time spent between two VM-exit in kvm. Is there a way to find this from user-space qemu, without modifying the kernel module or libkvm? What do you mean exactly? Average time