Hi Laurent,
Fair enough. I think the patch can go in.
Thanks & Regards,
Nitin
Linux Open Source Technology Center, Intel Corporation
The Mind is like a parachute; it works much better when it's open.
-Origin
Kamble, Nitin A wrote:
> Hi Laurent,
> This patch looks much cleaner to me.
>
> I see you are saving the regs like this in the patch.
> memcpy(c->regs, ctxt->vcpu->regs, sizeof c->regs);
>
> But I don't see any place in the patch these regs getting restored after
> failure.
>
> Is it taken car
Hi Laurent,
This patch looks much cleaner to me.
I see you are saving the regs like this in the patch.
memcpy(c->regs, ctxt->vcpu->regs, sizeof c->regs);
But I don't see any place in the patch these regs getting restored after
failure.
Is it taken care of the code outside of the patch?
Thank
Laurent Vivier wrote:
> Avi Kivity wrote:
>
>> Laurent Vivier wrote:
>>
>>> This patch corrects some errors appearing when we have an emulation
>>> failure
>>> on an operation using REP prefix.
>>>
>>> When x86_emulate_insn() fails, saving EIP and ECX is not enough as
>>> emulation
>>> shou
Laurent Vivier wrote:
> This patch corrects some errors appearing when we have an emulation failure
> on an operation using REP prefix.
>
> When x86_emulate_insn() fails, saving EIP and ECX is not enough as emulation
> should have modified other registers like RSI or RDI. Moreover, the emulation
>
This patch corrects some errors appearing when we have an emulation failure
on an operation using REP prefix.
When x86_emulate_insn() fails, saving EIP and ECX is not enough as emulation
should have modified other registers like RSI or RDI. Moreover, the emulation
can fail on the writeback, and in
Avi Kivity wrote:
> Laurent Vivier wrote:
>> This patch corrects some errors appearing when we have an emulation
>> failure
>> on an operation using REP prefix.
>>
>> When x86_emulate_insn() fails, saving EIP and ECX is not enough as
>> emulation
>> should have modified other registers like RSI or
Laurent Vivier wrote:
> This patch corrects some errors appearing when we have an emulation failure
> on an operation using REP prefix.
>
> When x86_emulate_insn() fails, saving EIP and ECX is not enough as emulation
> should have modified other registers like RSI or RDI. Moreover, the emulation
>
This patch corrects some errors appearing when we have an emulation failure
on an operation using REP prefix.
When x86_emulate_insn() fails, saving EIP and ECX is not enough as emulation
should have modified other registers like RSI or RDI. Moreover, the emulation
can fail on the writeback, and in
