[kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Guillaume Thouvenin
Hello, CMPS and SCAS instructions accept repeat prefixes F3 and F2. So in order to emulate those prefixed instructions we need to be able to know if prefixes are REP/REPE/REPZ or REPNE/REPNZ. Currently kvm doesn't make this distinction. This patch introduces this distinction. Signed-off-by: Gui

Re: [kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Avi Kivity
Guillaume Thouvenin wrote: > Hello, > > CMPS and SCAS instructions accept repeat prefixes F3 and F2. So in > order to emulate those prefixed instructions we need to be able to know > if prefixes are REP/REPE/REPZ or REPNE/REPNZ. Currently kvm doesn't make > this distinction. This patch introduces

Re: [kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Amit Shah
* Guillaume Thouvenin wrote: > Hello, > > CMPS and SCAS instructions accept repeat prefixes F3 and F2. So in > order to emulate those prefixed instructions we need to be able to know > if prefixes are REP/REPE/REPZ or REPNE/REPNZ. Currently kvm doesn't make > this distinction. This patch introduc

Re: [kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Guillaume Thouvenin
On Thu, 22 Nov 2007 17:27:55 +0530 Amit Shah <[EMAIL PROTECTED]> wrote: > Can you just rename this to REP and REPNE? Yes I can. I send the new patch. > Does this fix the problems you saw with openbsd? No not yet. It will help to make the difference between REPE prefix and REPNE prefix because

Re: [kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Guillaume Thouvenin
CMPS and SCAS instructions accept repeat prefixes REPE and REPNE. So in order to emulate those prefixed instructions we need to be able to know if prefixes are REP/REPE/REPZ or REPNE/REPNZ. Currently kvm doesn't make this distinction. This patch introduces this distinction. Signed-off-by: Guillaum

Re: [kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Amit Shah
* Guillaume Thouvenin wrote: > On Thu, 22 Nov 2007 17:27:55 +0530 > > Amit Shah <[EMAIL PROTECTED]> wrote: > > Can you just rename this to REP and REPNE? > > Yes I can. I send the new patch. > > > Does this fix the problems you saw with openbsd? > > No not yet. It will help to make the difference b

Re: [kvm-devel] [PATCH] make distinction between repeat prefixes F3 and F2

2007-11-22 Thread Avi Kivity
Guillaume Thouvenin wrote: > On Thu, 22 Nov 2007 17:27:55 +0530 > Amit Shah <[EMAIL PROTECTED]> wrote: > > >> Can you just rename this to REP and REPNE? >> > > Yes I can. I send the new patch. > Too late, merged it already. > > >> Does this fix the problems you saw with openbsd?