Yang, Sheng wrote:
Sorry for not explain clearly.
This patch replaces vmcs_write32_fixedbits() with adjust_vmx_controls(),
It still doesn't say why, but I can now see it: this is code from Xen. I
have no objection to copying Xen code, but it needs to be documented in
the changelog, and there
This patch replaces vmcs_write32_fixedbits() with
adjust_vmx_controls(),
It still doesn't say why, but I can now see it: this is code
from Xen. I have no objection to copying Xen code, but it needs to be
documented in
the changelog, and there needs to be a good reason as to why you're
Li, Xin B wrote:
-static struct vmcs_descriptor {
+static struct vmcs_config {
Why the name change? Just for Xen compatibility? If that's the only
reason, it's insufficent.
If you agree the above, this becomes reasonable.
-Xin
I'm not a English native speaker,
-static struct vmcs_descriptor {
+static struct vmcs_config {
Why the name change? Just for Xen compatibility? If that's the only
reason, it's insufficent.
If you agree the above, this becomes reasonable.
-Xin
I'm not a English native speaker, maybe descriptor is a good name too.
-xin
Li, Xin B wrote:
This patch replaces vmcs_write32_fixedbits() with
adjust_vmx_controls(),
It still doesn't say why, but I can now see it: this is code
from Xen. I have no objection to copying Xen code, but it needs to be
documented in
the changelog, and there needs to be
().
I attached modified patch. If you need more information, please let me know.
Thanks
Yang, Sheng
-Original Message-
From: Avi Kivity [mailto:[EMAIL PROTECTED]
Sent: 2007年7月26日 13:20
To: Yang, Sheng
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [kvm-devel] [PATCH]Abstract vmcs
Do you mean the description of patch?
Thanks
Yang, Sheng
-Original Message-
From: Avi Kivity [mailto:[EMAIL PROTECTED]
Sent: 2007年7月26日 17:50
To: Li, Xin B
Cc: Yang, Sheng; kvm-devel@lists.sourceforge.net
Subject: Re: [kvm-devel] [PATCH]Abstract vmcs feature detect part
Sure. Please
Yang, Sheng wrote:
This patch changes a method to check cpu capability, so we can set vmcs
more conveniently.
Please explain the motivation for the change. What is more convenient?
-static __init void setup_vmcs_descriptor(void)
+static __init u32 adjust_vmx_controls(u32 ctl_min,
