Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Avi Kivity
Rusty Russell wrote: Two versions, size *and* ret? This seems like overkill... I think we ought to move away from version numbers and use feature availability flags instead. + if (rc) { + printk(KERN_INFO paravirt KVM unavailable\n); Double-printk when KVM

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Andi Kleen
On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote: * Andi Kleen [EMAIL PROTECTED] wrote: + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) { + printk(KERN_INFO KVM guest: WRMSR probe failed.\n); + return -ENOENT; + }

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Anthony Liguori
Rusty Russell wrote: On Thu, 2007-05-31 at 12:40 +0200, Andi Kleen wrote: On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote: * Andi Kleen [EMAIL PROTECTED] wrote: + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) { + printk(KERN_INFO KVM guest:

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Anthony Liguori
Andi Kleen wrote: On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote: yeah. I suspect printing that it's executing in native mode is OK. But only a single printk for that please This will be taken care of in the next round of patches. Regards, Anthony Liguori -Andi

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Anthony Liguori
Nakajima, Jun wrote: Anthony Liguori wrote: Nakajima, Jun wrote: Anthony Liguori wrote: Regards, Anthony Liguori I think we should use the CPUID instruction (leaf 0x4000) to detect the hypervosor as we are doing in Xen. Is that leaf

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-31 Thread Nakajima, Jun
Anthony Liguori wrote: Nakajima, Jun wrote: What I can say is that we (including the H/W teams) reviewed it internally. I've switched to using CPUID. I noticed that Xen also uses 0x40001 so I'm presuming that that is okay too? Yes. Regards, Anthony Liguori Jun --- Intel

[kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-30 Thread Anthony Liguori
Regards, Anthony Liguori Subject: [PATCH] Add KVM paravirt_ops implementation From: Anthony Liguori [EMAIL PROTECTED] This patch adds the basic infrastructure for paravirtualizing a KVM guest. Discovery of running under KVM is done by sharing a page of memory between the guest and host

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-30 Thread Nakajima, Jun
Anthony Liguori wrote: Regards, Anthony Liguori I think we should use the CPUID instruction (leaf 0x4000) to detect the hypervosor as we are doing in Xen. Jun --- Intel Open Source Technology Center - This SF.net

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-30 Thread Rusty Russell
On Wed, 2007-05-30 at 09:52 -0500, Anthony Liguori wrote: This patch adds the basic infrastructure for paravirtualizing a KVM guest. Hi Anthony! Nice patch, comments below. Discovery of running under KVM is done by sharing a page of memory between the guest and host (initially

Re: [kvm-devel] [PATCH 1/3] KVM paravirt_ops infrastructure

2007-05-30 Thread Anthony Liguori
Rusty Russell wrote: On Wed, 2007-05-30 at 09:52 -0500, Anthony Liguori wrote: This patch adds the basic infrastructure for paravirtualizing a KVM guest. Hi Anthony! Nice patch, comments below. Discovery of running under KVM is done by sharing a page of memory between